pi-harness-runtime 1.1.423 → 1.1.425

package/scripts/verify-package-contents.ts

@@ -35,7 +35,13 @@ const ROOT = resolve(dirname(fileURLToPath(import.meta.url)), "..");
 const verifyTarball = process.argv.includes("--pack");
 
 interface Problem {
-	kind: "missing-dist" | "missing-import" | "missing-tarball" | "missing-package";
+	kind:
+		| "missing-dist"
+		| "missing-import"
+		| "missing-tarball"
+		| "missing-package"
+		| "forbidden-path"
+		| "missing-plugin";
 	detail: string;
 }
 
@@ -53,6 +59,63 @@ const SHIPPED_ROOT_FILES = [
 	"windows.ts",
 ];
 
+/**
+ * Paths that must never reach the published package.
+ *
+ * `.pi/` holds per-machine extension state and the user's private skills.
+ * `.pi-lens/` holds a local tool policy directory. The skill payload
+ * directories hold skill content: skills live in the user's own Qdrant
+ * collection and in the installation-local skill store, never in the
+ * published repository.
+ *
+ * `packages/skills/` is NOT in this list: that package is the runtime
+ * implementation that loads, queries and indexes skills.
+ */
+const FORBIDDEN_PACKAGE_PREFIXES = [
+	".pi/",
+	".pi-lens/",
+	".agents/skills/",
+	".claude/skills/",
+];
+
+/**
+ * The one skill directory the package owns and publishes.
+ *
+ * `skills/harness-runtime/` is the skill of the package itself: it tells an
+ * installed agent what the harness is. It is public content, written for
+ * every user of the package, so it ships.
+ *
+ * Every other directory under `skills/` belongs to a user. Such a skill
+ * lives in that user's own Qdrant collection and in their installation-local
+ * skill store, and it must never reach the published tarball.
+ */
+const PACKAGE_SKILL_DIR = "skills/harness-runtime/";
+
+/** The files the published skill directory must contain. */
+const REQUIRED_SKILL_FILES = ["skills/harness-runtime/SKILL.md"];
+
+/**
+ * Whether a path is a skill payload that the package must not publish.
+ *
+ * A path under `skills/` is forbidden unless it belongs to the package's
+ * own skill directory.
+ */
+function isForbiddenSkillPath(path: string): boolean {
+	if (!path.startsWith("skills/")) return false;
+	return !path.startsWith(PACKAGE_SKILL_DIR);
+}
+
+/** The plugin directory that ships with the package. */
+const PLUGIN_DIR = "plugins";
+
+/** The files a shipped herdr plugin must contain. */
+const REQUIRED_PLUGIN_FILES = [
+	"plugins/herdr-clipboard/herdr-plugin.toml",
+	"plugins/herdr-clipboard/paste.sh",
+	"plugins/herdr-clipboard/start-bridge.sh",
+	"plugins/herdr-clipboard/tmux-watch.sh",
+];
+
 function listFiles(dir: string, filter: (file: string) => boolean): string[] {
 	if (!existsSync(dir)) return [];
 	const out: string[] = [];
@@ -98,6 +161,83 @@ const STATIC_IMPORT = /import\s+(type\s+)?[^;]*?from\s*["']([^"']+)["']/g;
 const DYNAMIC_IMPORT = /import\s*\(\s*["']([^"']+)["']\s*\)/g;
 const SIDE_EFFECT_IMPORT = /(?:^|\n)\s*import\s*["']([^"']+)["']/g;
 
+/**
+ * The published package must not carry a skill payload or a local state
+ * directory, and it must carry the plugin that the postinstall copies.
+ *
+ * The check runs on the git index, because that is what the release commits
+ * and what npm packs from.
+ */
+function checkPackageLayout(): void {
+	const tracked = spawnSync("git", ["ls-files"], {
+		cwd: ROOT,
+		encoding: "utf8",
+	});
+	const files =
+		tracked.status === 0 ? tracked.stdout.split("\n").filter(Boolean) : [];
+
+	for (const file of files) {
+		const posix = file.split("\\").join("/");
+		for (const prefix of FORBIDDEN_PACKAGE_PREFIXES) {
+			if (posix.startsWith(prefix)) {
+				problems.push({
+					kind: "forbidden-path",
+					detail: `${posix} is tracked - ${prefix} must not be committed`,
+				});
+				break;
+			}
+		}
+		if (isForbiddenSkillPath(posix)) {
+			problems.push({
+				kind: "forbidden-path",
+				detail: `${posix} is tracked - only ${PACKAGE_SKILL_DIR} may be committed`,
+			});
+		}
+	}
+
+	for (const required of REQUIRED_PLUGIN_FILES) {
+		if (!files.includes(required)) {
+			problems.push({
+				kind: "missing-plugin",
+				detail: `${required} is not tracked - the plugin would not ship`,
+			});
+		}
+	}
+
+	for (const required of REQUIRED_SKILL_FILES) {
+		if (!files.includes(required)) {
+			problems.push({
+				kind: "missing-plugin",
+				detail: `${required} is not tracked - the package would ship no skill`,
+			});
+		}
+	}
+}
+
+/**
+ * The postinstall copies the plugin from the package root.
+ *
+ * When the source directory moved to `plugins/` the copy script kept its
+ * old path, and the plugin silently stopped being installed.
+ */
+function checkPluginCopySource(): void {
+	const script = join(ROOT, "scripts", "copy-plugins.js");
+	if (!existsSync(script)) {
+		problems.push({
+			kind: "missing-plugin",
+			detail: "scripts/copy-plugins.js is missing - the plugin would not be installed",
+		});
+		return;
+	}
+	const source = readFileSync(script, "utf8");
+	if (!source.includes(`"${PLUGIN_DIR}"`)) {
+		problems.push({
+			kind: "missing-plugin",
+			detail: `scripts/copy-plugins.js does not read from the ${PLUGIN_DIR}/ directory`,
+		});
+	}
+}
+
 function checkImports(): void {
 	for (const file of shippedSourceFiles()) {
 		const content = readFileSync(file, "utf8");
@@ -306,6 +446,43 @@ async function inspectTarball(): Promise<void> {
 		return;
 	}
 
+	for (const file of files) {
+		const posix = file.split("\\").join("/");
+		for (const prefix of FORBIDDEN_PACKAGE_PREFIXES) {
+			if (posix.startsWith(prefix)) {
+				problems.push({
+					kind: "forbidden-path",
+					detail: `${posix} is in the tarball - ${prefix} must not be published`,
+				});
+				break;
+			}
+		}
+		if (isForbiddenSkillPath(posix)) {
+			problems.push({
+				kind: "forbidden-path",
+				detail: `${posix} is in the tarball - only ${PACKAGE_SKILL_DIR} may be published`,
+			});
+		}
+	}
+
+	for (const required of REQUIRED_PLUGIN_FILES) {
+		if (!files.includes(required)) {
+			problems.push({
+				kind: "missing-plugin",
+				detail: `${required} is not in the tarball`,
+			});
+		}
+	}
+
+	for (const required of REQUIRED_SKILL_FILES) {
+		if (!files.includes(required)) {
+			problems.push({
+				kind: "missing-plugin",
+				detail: `${required} is not in the tarball`,
+			});
+		}
+	}
+
 	const inTarball = new Set(files);
 	for (const { file, specifier, target } of runtimeImports.values()) {
 		const relativeTarget = relative(ROOT, target).split("\\").join("/");
@@ -321,6 +498,8 @@ async function inspectTarball(): Promise<void> {
 	}
 }
 
+checkPackageLayout();
+checkPluginCopySource();
 checkImports();
 checkPackageEntries();
 checkStaleOutputs();