pi-harness-runtime 1.1.415 → 1.1.417

package/packages/skills/dist/vector-schema.js

@@ -36,6 +36,34 @@ export const LEGACY_SKILL_COLLECTION = "pi-harness-skills";
 export const LEGACY_SKILL_COLLECTION_MODEL = "sentence-transformers/all-MiniLM-L6-v2";
 /** The vector size of the legacy collection. */
 export const LEGACY_SKILL_COLLECTION_DIMENSIONS = 384;
+/**
+ * The score below which a hit of the runtime collection is not a hit.
+ *
+ * The score of a vector search is a cosine between two vectors, and its
+ * scale belongs to the model that produced them. Measured against the
+ * runtime collection (123 skills, `text-embedding-3-small`):
+ *
+ *   - a query that names a skill scores 0.31 to 0.56,
+ *   - a query about something else scores 0.10 to 0.23, and the wrong
+ *     skill that it matched tops out at 0.2305.
+ *
+ * The threshold sits between the two (0.27). The old value of 0.5 belonged
+ * to the MiniLM collection, whose vectors are not comparable, and it
+ * threw away even a clear match (0.47) - so a search of the runtime
+ * collection returned nothing at all.
+ *
+ * It lives here, next to the model and the collection, so that the two
+ * cannot drift apart.
+ */
+export const SKILL_MIN_SCORE = 0.27;
+/**
+ * The score below which a hit of the legacy collection is not a hit.
+ *
+ * The legacy collection holds MiniLM vectors. Their scale was never
+ * measured against a query, so the old value is kept. It is named here
+ * so it is not mistaken for the threshold of the runtime.
+ */
+export const LEGACY_SKILL_MIN_SCORE = 0.5;
 /**
  * The body of a payload is truncated.
  *

package/packages/skills/dist/vector-schema.js.map

@@ -1 +1 @@
-{"version":3,"file":"vector-schema.js","sourceRoot":"","sources":["../src/vector-schema.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAEH,OAAO,EAAE,YAAY,EAAE,cAAc,EAAE,MAAM,eAAe,CAAC;AAE7D;;;;;GAKG;AACH,MAAM,CAAC,MAAM,gBAAgB,GAAG,6BAA6B,CAAC;AAE9D;;;;;;;GAOG;AACH,MAAM,CAAC,MAAM,uBAAuB,GAAG,mBAAmB,CAAC;AAE3D,0CAA0C;AAC1C,MAAM,CAAC,MAAM,6BAA6B,GAAG,wCAAwC,CAAC;AAEtF,gDAAgD;AAChD,MAAM,CAAC,MAAM,kCAAkC,GAAG,GAAG,CAAC;AAiCtD;;;;;GAKG;AACH,MAAM,CAAC,MAAM,wBAAwB,GAAG,IAAI,CAAC;AAE7C,kDAAkD;AAClD,MAAM,CAAC,MAAM,wBAAwB,GAAG,IAAI,CAAC;AAE7C;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,UAAU,CAAC,KAAa;IACtC,IAAI,IAAI,GAAG,CAAC,CAAC;IACb,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACtC,IAAI,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,EAAE,IAAI,CAAC,GAAG,KAAK,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC;IACzD,CAAC;IACD,OAAO,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;AACxB,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,cAAc,CAAC,KAS9B;IACC,MAAM,KAAK,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAC3B,IAAI,KAAK,CAAC,KAAK,IAAI,KAAK,CAAC,KAAK,KAAK,KAAK,CAAC,IAAI;QAAE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;IACvE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC;IAC9B,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,wBAAwB,CAAC,CAAC,CAAC;IAC1D,OAAO,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;AACzB,CAAC;AAcD;;;;;;;;GAQG;AACH,MAAM,UAAU,gBAAgB,CAAC,OAA0B;IACzD,OAAO,EAAE,EAAE,EAAE,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,OAAO,EAAE,CAAC;AACnD,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,iBAAiB,CAAC,KASjC;IACC,MAAM,IAAI,GAAG,cAAc,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACxC,MAAM,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,cAAc,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IACpE,MAAM,WAAW,GAAG,YAAY,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC;IACpD,MAAM,IAAI,GAAG,YAAY,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,wBAAwB,CAAC,CAAC;IACzE,OAAO;QACL,IAAI;QACJ,WAAW;QACX,IAAI;QACJ,IAAI,EAAE,cAAc,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC;KACzD,CAAC;AACJ,CAAC;AACD,MAAM,UAAU,2BAA2B,CAC1C,MAAkD,EAClD,QAA2B;IAE3B,IAAI,MAAM,CAAC,UAAU,KAAK,SAAS,IAAI,MAAM,CAAC,UAAU,KAAK,QAAQ,CAAC,UAAU,EAAE,CAAC;QAClF,MAAM,KAAK,GAAG,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,QAAQ,CAAC,KAAK,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;QAC3D,OAAO,wBAAwB,MAAM,CAAC,UAAU,iDAAiD,QAAQ,CAAC,UAAU,GAAG,KAAK,EAAE,CAAC;IAChI,CAAC;IACD,IAAI,MAAM,CAAC,QAAQ,KAAK,SAAS,IAAI,MAAM,CAAC,QAAQ,KAAK,QAAQ,CAAC,QAAQ,EAAE,CAAC;QAC5E,OAAO,2BAA2B,MAAM,CAAC,QAAQ,kCAAkC,QAAQ,CAAC,QAAQ,EAAE,CAAC;IACxG,CAAC;IACD,OAAO,IAAI,CAAC;AACb,CAAC"}
+{"version":3,"file":"vector-schema.js","sourceRoot":"","sources":["../src/vector-schema.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAEH,OAAO,EAAE,YAAY,EAAE,cAAc,EAAE,MAAM,eAAe,CAAC;AAE7D;;;;;GAKG;AACH,MAAM,CAAC,MAAM,gBAAgB,GAAG,6BAA6B,CAAC;AAE9D;;;;;;;GAOG;AACH,MAAM,CAAC,MAAM,uBAAuB,GAAG,mBAAmB,CAAC;AAE3D,0CAA0C;AAC1C,MAAM,CAAC,MAAM,6BAA6B,GAAG,wCAAwC,CAAC;AAEtF,gDAAgD;AAChD,MAAM,CAAC,MAAM,kCAAkC,GAAG,GAAG,CAAC;AAEtD;;;;;;;;;;;;;;;;;;GAkBG;AACH,MAAM,CAAC,MAAM,eAAe,GAAG,IAAI,CAAC;AAEpC;;;;;;GAMG;AACH,MAAM,CAAC,MAAM,sBAAsB,GAAG,GAAG,CAAC;AAiC1C;;;;;GAKG;AACH,MAAM,CAAC,MAAM,wBAAwB,GAAG,IAAI,CAAC;AAE7C,kDAAkD;AAClD,MAAM,CAAC,MAAM,wBAAwB,GAAG,IAAI,CAAC;AAE7C;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,UAAU,CAAC,KAAa;IACtC,IAAI,IAAI,GAAG,CAAC,CAAC;IACb,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACtC,IAAI,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,EAAE,IAAI,CAAC,GAAG,KAAK,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC;IACzD,CAAC;IACD,OAAO,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;AACxB,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,cAAc,CAAC,KAS9B;IACC,MAAM,KAAK,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAC3B,IAAI,KAAK,CAAC,KAAK,IAAI,KAAK,CAAC,KAAK,KAAK,KAAK,CAAC,IAAI;QAAE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;IACvE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC;IAC9B,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,wBAAwB,CAAC,CAAC,CAAC;IAC1D,OAAO,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;AACzB,CAAC;AAcD;;;;;;;;GAQG;AACH,MAAM,UAAU,gBAAgB,CAAC,OAA0B;IACzD,OAAO,EAAE,EAAE,EAAE,UAAU,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,OAAO,EAAE,CAAC;AACnD,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,iBAAiB,CAAC,KASjC;IACC,MAAM,IAAI,GAAG,cAAc,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IACxC,MAAM,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,cAAc,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;IACpE,MAAM,WAAW,GAAG,YAAY,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC;IACpD,MAAM,IAAI,GAAG,YAAY,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,wBAAwB,CAAC,CAAC;IACzE,OAAO;QACL,IAAI;QACJ,WAAW;QACX,IAAI;QACJ,IAAI,EAAE,cAAc,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC;KACzD,CAAC;AACJ,CAAC;AACD,MAAM,UAAU,2BAA2B,CAC1C,MAAkD,EAClD,QAA2B;IAE3B,IAAI,MAAM,CAAC,UAAU,KAAK,SAAS,IAAI,MAAM,CAAC,UAAU,KAAK,QAAQ,CAAC,UAAU,EAAE,CAAC;QAClF,MAAM,KAAK,GAAG,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,QAAQ,CAAC,KAAK,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;QAC3D,OAAO,wBAAwB,MAAM,CAAC,UAAU,iDAAiD,QAAQ,CAAC,UAAU,GAAG,KAAK,EAAE,CAAC;IAChI,CAAC;IACD,IAAI,MAAM,CAAC,QAAQ,KAAK,SAAS,IAAI,MAAM,CAAC,QAAQ,KAAK,QAAQ,CAAC,QAAQ,EAAE,CAAC;QAC5E,OAAO,2BAA2B,MAAM,CAAC,QAAQ,kCAAkC,QAAQ,CAAC,QAAQ,EAAE,CAAC;IACxG,CAAC;IACD,OAAO,IAAI,CAAC;AACb,CAAC"}

package/packages/skills/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/skills",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "File-based skill system with pi.dev compatibility and Hermes self-improvement",
   "type": "module",
   "main": "src/index.ts",

package/packages/skills/src/loader.ts

@@ -21,6 +21,7 @@ import {
   LEGACY_SKILL_COLLECTION_DIMENSIONS,
   LEGACY_SKILL_COLLECTION_MODEL,
   SKILL_COLLECTION,
+  SKILL_MIN_SCORE,
   describeSkillSchemaMismatch,
   skillPointPayload,
   skillQdrantPoint,
@@ -1051,12 +1052,13 @@ export class SkillRegistry {
    *
    * @param query Natural-language query
    * @param limit Max results (default 5)
-   * @param threshold Minimum cosine score (default 0.5)
+   * @param threshold Minimum cosine score (default: the score of the model
+   *   of the runtime collection - see SKILL_MIN_SCORE)
    */
   async findVector(
     query: string,
     limit = 5,
-    threshold = 0.5,
+    threshold = SKILL_MIN_SCORE,
   ): Promise<Array<{ skill: Skill; score: number; source: "local" | "remote" }>> {
     await this._ensureQdrant();
     if (!this._qdrant?.ready) return [];

package/packages/skills/src/sanitize.ts

@@ -22,22 +22,26 @@ interface SanitizationRule {
  *
  * The list is about the names of the clients and the projects of the
  * users of the harness - not about the skills themselves.
+ *
+ * The patterns match a plain fragment, without a word boundary. A client
+ * name rarely stands alone: it appears inside a directory name
+ * (`th_digisoft_erp_chart.json`), inside a Python module (`inpac_pharma`)
+ * or in a sentence ("integrated with Paperclip"). A word boundary would
+ * miss all of them - and `_` is a word character, so a boundary never
+ * follows an underscore.
  */
 const SANITIZATION_RULES: SanitizationRule[] = [
   // Client company names (case-insensitive)
-  { pattern: /\binpac\b/gi, replacement: "[Client A]" },
-  { pattern: /\bm-capital\b/gi, replacement: "[Client A]" },
-  { pattern: /\bmcapital\b/gi, replacement: "[Client A]" },
-  { pattern: /\bdigisoft\b/gi, replacement: "[Client B]" },
+  { pattern: /inpac/gi, replacement: "[Client A]" },
+  { pattern: /m-capital/gi, replacement: "[Client A]" },
+  { pattern: /mcapital/gi, replacement: "[Client A]" },
+  { pattern: /digisoft/gi, replacement: "[Client B]" },
 
   // Project/app specific names
-  { pattern: /\bgse-insurance\b/gi, replacement: "[Insurance Project]" },
-  { pattern: /\btbs-import\b/gi, replacement: "[Import Project]" },
-  { pattern: /\bdigisoft_erp\b/gi, replacement: "[Client B Erp]" },
-  { pattern: /\bm_capital\b/gi, replacement: "[Client A]" },
-  { pattern: /\binpac_\b/gi, replacement: "[Client A]_" },
-  { pattern: /\bpaperclip_\b/gi, replacement: "[Client D]_" },
-  { pattern: /\bopenclaw_\b/gi, replacement: "[Client F]_" },
+  { pattern: /gse-insurance/gi, replacement: "[Insurance Project]" },
+  { pattern: /tbs-import/gi, replacement: "[Import Project]" },
+  { pattern: /paperclip/gi, replacement: "[Client D]" },
+  { pattern: /openclaw/gi, replacement: "[Client F]" },
 
   // Generic replacements
   { pattern: /Company Name/gi, replacement: "[Client Name]" },
@@ -80,7 +84,28 @@ export function sanitizeText(text: string): string {
  *
  * The name is the identity of the point, so it has to be the same for
  * every writer: the map first, then the pattern rules.
+ *
+ * The result is a skill name - lower case, words separated by a dash -
+ * because the name of a point is also the id of the skill that a search
+ * returns. The replacements of the rules carry a space and brackets,
+ * which no skill name may hold.
  */
 export function skillPointName(name: string): string {
-	return SKILL_NAME_MAP[name] || sanitizeText(name);
+	const mapped = SKILL_NAME_MAP[name];
+	if (mapped) return mapped;
+	return kebabName(sanitizeText(name));
+}
+
+/**
+ * Bring a name into the shape of a skill name.
+ *
+ * The name of a skill is lower case and its words are separated by a
+ * dash: `^[a-z0-9]+(-[a-z0-9]+)*$`.
+ */
+function kebabName(name: string): string {
+	return name
+		.toLowerCase()
+		.replace(/[^a-z0-9]+/g, "-")
+		.replace(/-{2,}/g, "-")
+		.replace(/^-+|-+$/g, "");
 }

package/packages/skills/src/skill-commands.ts

@@ -10,6 +10,7 @@ import { resolve } from "node:path";
 import type { ExtensionAPI, ExtensionContext, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
 import { getGlobalSkillRegistry } from "./loader.js";
 import { scanForSkillsSync } from "./scanner.js";
+import { SKILL_MIN_SCORE } from "./vector-schema.js";
 
 /**
  * Skill command configuration
@@ -244,7 +245,7 @@ async function handleSkillSearch(
 
   // Try vector search if requested and available
   if (useVector && registry.isQdrantReady) {
-    const vectorResults = await registry.findVector(query, 5, 0.5);
+    const vectorResults = await registry.findVector(query, 5, SKILL_MIN_SCORE);
     if (vectorResults.length > 0) {
       backend = "vector";
       results = vectorResults.map(r => ({ skill: r.skill, score: r.score }));

package/packages/skills/src/vector-schema.ts

@@ -42,6 +42,36 @@ export const LEGACY_SKILL_COLLECTION_MODEL = "sentence-transformers/all-MiniLM-L
 /** The vector size of the legacy collection. */
 export const LEGACY_SKILL_COLLECTION_DIMENSIONS = 384;
 
+/**
+ * The score below which a hit of the runtime collection is not a hit.
+ *
+ * The score of a vector search is a cosine between two vectors, and its
+ * scale belongs to the model that produced them. Measured against the
+ * runtime collection (123 skills, `text-embedding-3-small`):
+ *
+ *   - a query that names a skill scores 0.31 to 0.56,
+ *   - a query about something else scores 0.10 to 0.23, and the wrong
+ *     skill that it matched tops out at 0.2305.
+ *
+ * The threshold sits between the two (0.27). The old value of 0.5 belonged
+ * to the MiniLM collection, whose vectors are not comparable, and it
+ * threw away even a clear match (0.47) - so a search of the runtime
+ * collection returned nothing at all.
+ *
+ * It lives here, next to the model and the collection, so that the two
+ * cannot drift apart.
+ */
+export const SKILL_MIN_SCORE = 0.27;
+
+/**
+ * The score below which a hit of the legacy collection is not a hit.
+ *
+ * The legacy collection holds MiniLM vectors. Their scale was never
+ * measured against a query, so the old value is kept. It is named here
+ * so it is not mistaken for the threshold of the runtime.
+ */
+export const LEGACY_SKILL_MIN_SCORE = 0.5;
+
 /** The schema a skill collection is expected to have. */
 export interface SkillVectorSchema {
 	/** The vector size. */

package/packages/skills/test/sanitize.test.ts

@@ -32,6 +32,26 @@ describe("the sanitization of a text", () => {
 		expect(sanitizeText("your company")).toBe("[Client]");
 		expect(sanitizeText("our client")).toBe("[Client]");
 	});
+
+	test("a client name inside an identifier is replaced", () => {
+		// The name of a client rarely stands alone. A word boundary would
+		// miss every one of these - and an underscore is a word character,
+		// so a boundary never follows one.
+		expect(sanitizeText("inpac_pharma")).toBe("[Client A]_pharma");
+		expect(sanitizeText("th_digisoft_erp_chart.json")).toBe(
+			"th_[Client B]_erp_chart.json",
+		);
+		expect(sanitizeText("apps/inpac_pharma/setup")).toBe(
+			"apps/[Client A]_pharma/setup",
+		);
+	});
+
+	test("a client name in a sentence is replaced", () => {
+		expect(sanitizeText("integrated with Paperclip")).toBe(
+			"integrated with [Client D]",
+		);
+		expect(sanitizeText("OpenClaw secrets")).toBe("[Client F] secrets");
+	});
 });
 
 describe("the name of a skill in the shared collection", () => {
@@ -59,6 +79,29 @@ describe("the name of a skill in the shared collection", () => {
 			expect(skillPointName(name)).not.toMatch(/inpac|gse-insurance|tbs-import/i);
 		}
 	});
+
+	test("the name is a valid skill name", () => {
+		// The name of a point is the id of the skill that a search returns,
+		// so it has to be a name that a skill may carry.
+		const NAME = /^[a-z0-9]+(-[a-z0-9]+)*$/;
+		for (const name of [
+			"inpac-pe-approval-workflow",
+			"openclaw-channel",
+			"gse-insurance-step5-slot-filter",
+			"tbs-import-clearance-lcv",
+			"whispertool",
+			"code-review",
+		]) {
+			expect(skillPointName(name)).toMatch(NAME);
+		}
+	});
+
+	test("a name that needs no sanitization stays the same", () => {
+		expect(skillPointName("code-review")).toBe("code-review");
+		expect(skillPointName("frappe-doctype-field-order")).toBe(
+			"frappe-doctype-field-order",
+		);
+	});
 });
 
 describe("the payload of a point is sanitized", () => {

package/packages/skills/test/vector-schema.test.ts

@@ -138,8 +138,21 @@ describe("the identity of a skill point", () => {
 			body: "b",
 		});
 
-		expect(withTitle.text).toContain("A Human Title");
-		expect(withoutTitle.text).not.toContain("A Human Title");
+		// The title is treated like the name: it is sanitized and it is
+		// brought into the shape of a skill name.
+		expect(withTitle.text).toContain("a-human-title");
+		expect(withoutTitle.text).not.toContain("a-human-title");
+	});
+
+	test("a title that is the name is not repeated in the text", () => {
+		const payload = skillPointPayload({
+			name: "a-skill",
+			title: "a-skill",
+			description: "d",
+			body: "b",
+		});
+
+		expect(payload.text.match(/a-skill/g)?.length).toBe(1);
 	});
 });
 

package/packages/skills/test/vector-threshold.test.ts

@@ -0,0 +1,108 @@
+/**
+ * The score that decides whether a hit of the vector store is a hit.
+ *
+ * The score of a vector search is a cosine between two vectors, and its
+ * scale belongs to the model that produced them. The runtime embeds with
+ * `text-embedding-3-small`, whose cosines for a query that names a skill
+ * land between 0.31 and 0.56 - while a query about something else reaches
+ * 0.23 at most.
+ *
+ * The threshold used to be 0.5, a value of the MiniLM collection, whose
+ * vectors are not comparable. Against the runtime collection it threw away
+ * every clear match (0.47) - a search of a filled collection returned
+ * nothing at all, and the skill was invisible.
+ *
+ * The threshold therefore lives next to the model, and the tests below
+ * hold it there.
+ */
+
+import { describe, expect, it } from "bun:test";
+import { readFileSync } from "node:fs";
+import { fileURLToPath } from "node:url";
+
+import {
+	createSkillRegistry,
+	type QdrantClientLike,
+	type QdrantEmbedderLike,
+} from "../src/loader.js";
+import { SKILL_MIN_SCORE } from "../src/vector-schema.js";
+
+/** A client that answers a query with the given points. */
+function fakeClient(points: Array<{ id: number; score: number }>): QdrantClientLike {
+	return {
+		async upsert(): Promise<void> {},
+		async query(): Promise<unknown> {
+			return { points };
+		},
+		async getCollection(): Promise<unknown> {
+			return { config: { params: { vectors: { size: 1536, distance: "Cosine" } } } };
+		},
+	};
+}
+
+/** An embedder that returns a fixed vector. */
+const fakeEmbedder: QdrantEmbedderLike = {
+	async createEmbedding() {
+		return { embedding: [0.1, 0.2, 0.3], tokens: 3 };
+	},
+};
+
+const registryWith = (scores: number[]) =>
+	createSkillRegistry({
+		qdrantClient: fakeClient(
+			scores.map((score, index) => ({
+				id: index + 1,
+				score,
+				payload: { name: `skill-${index}`, description: "d", body: "b" },
+			})),
+		),
+		embedder: fakeEmbedder,
+		collection: "pi-harness-skills-test",
+	});
+
+describe("the score that decides whether a hit is a hit", () => {
+	it("belongs to the model of the collection", () => {
+		// The measured values: a query that names a skill scores 0.31 to
+		// 0.56, a query about something else 0.10 to 0.23.
+		expect(SKILL_MIN_SCORE).toBeGreaterThan(0.23);
+		expect(SKILL_MIN_SCORE).toBeLessThan(0.31);
+	});
+
+	it("keeps a clear match that the old threshold of 0.5 threw away", async () => {
+		// 0.47 is a clear match of the runtime model - and below 0.5.
+		const registry = registryWith([0.47]);
+
+		const results = await registry.findVector("approve a purchase order");
+
+		expect(results).toHaveLength(1);
+		expect(results[0].score).toBe(0.47);
+	});
+
+	it("drops a hit that is noise", async () => {
+		const registry = registryWith([0.23]);
+
+		const results = await registry.findVector("cook a risotto");
+
+		expect(results).toHaveLength(0);
+	});
+
+	it("keeps the hits above it and drops the hits below it", async () => {
+		const registry = registryWith([0.55, 0.12, 0.4, 0.2]);
+
+		const results = await registry.findVector("a query");
+
+		expect(results.map((r) => r.score)).toEqual([0.55, 0.4]);
+	});
+
+	it("is the threshold of the skill command too", () => {
+		// The command passed 0.5 itself, so the fix of the default would
+		// not have reached the search of the user.
+		const source = readFileSync(
+			fileURLToPath(new URL("../src/skill-commands.ts", import.meta.url)),
+			"utf8",
+		);
+
+		expect(source).toContain("SKILL_MIN_SCORE");
+		expect(source).not.toMatch(/findVector\([^)]*,\s*5,\s*0\.5/);
+	});
+});

package/packages/sprint-planner/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/sprint-planner",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "type": "module",
   "description": "Sprint planning engine for pi-harness",
   "main": "dist/index.js",

package/packages/subscription-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/subscription-engine",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/task-compiler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/task-compiler",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "Task Compiler for pi-harness-runtime — produces deterministic task DAG from CompiledRequirement",
   "type": "module",
   "main": "./dist/index.js",

package/packages/telegram/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/telegram",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "pi-harness-runtime — Telegram inbound/outbound",
   "type": "module",
   "main": "./src/index.js",

package/packages/tencentdb-memory/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@moocoding/tencentdb-memory",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "TencentDB Agent Memory client - sync skills to centralized knowledge base",
   "type": "module",
   "main": "src/index.ts",

package/packages/tencentdb-sync/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/tencentdb-sync",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "Sync SKILL.md skills to TencentDB-Agent-Memory server (RFC-0105/0106)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/test-data-generator/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/test-data-generator",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "Test data generation for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/test-generator/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/test-generator",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "Auto-Test Generator — generate unit and E2E tests from source code (RFC-0013)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/todo-bd-sync/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@moocoding/todo-bd-sync",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "Two-way sync between rpiv-todo overlay and bd issue tracker",
   "type": "module",
   "main": "src/index.ts",

package/packages/token-estimation/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/token-estimation",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "pi-harness-runtime — token-estimation",
   "type": "module",
   "main": "./dist/index.js",

package/packages/token-optimizer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/token-optimizer",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "Token Budget Optimizer — maximize prompt value within token limits (RFC-0011)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/tooling-preference/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/tooling-preference",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "pi-harness-runtime — JS/TS tooling preference (Biome vs ESLint/Prettier) proposal",
   "type": "module",
   "main": "./dist/index.js",

package/packages/trajectory/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/trajectory",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "Trajectory capture for the write-review loop — persists cycle records for learning",
   "type": "module",
   "main": "./dist/src/index.js",

package/packages/tui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/tui",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "pi-harness-runtime — tui",
   "type": "module",
   "main": "./dist/index.js",

package/packages/two-phase-review/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/two-phase-review",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "pi-harness-runtime — two-phase implementation and review workflow (queue review signals, gate the phase, scope the diff)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/types/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/types",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "Shared TypeScript types for pi-harness-runtime packages",
   "type": "module",
   "main": "./dist/index.js",

package/packages/voice-api/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/voice-api",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "type": "module",
   "description": "Voice-to-text API using Whisper for Telegram and LINE integration",
   "main": "./dist/index.js",

package/packages/webmcp-tester/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/webmcp-tester",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "WebMCP-powered E2E testing for pi-harness - natural language test scenarios",
   "type": "module",
   "main": "./dist/index.js",

package/packages/wiki/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/wiki",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "LLM Wiki integration for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/workflow-events/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/workflow-events",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/workspace-scanner/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/workspace-scanner",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/worktree/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/worktree",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "pi-harness-runtime — worktree",
   "type": "module",
   "main": "./dist/index.js",

package/packages/write-review/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@moocoding/write-review",
-  "version": "1.1.415",
+  "version": "1.1.417",
   "description": "Two-agent write-review loop with blackboard coordination",
   "type": "module",
   "main": "src/index.ts",