pi-harness-runtime 1.1.411 → 1.1.413

package/packages/skills/test/remote-source.test.ts

@@ -0,0 +1,248 @@
+/**
+ * The skills that live on the server.
+ *
+ * The vector store is an index - it says WHICH skill fits a question. The
+ * service holds the authoritative files, so a machine without a local copy
+ * can still use a skill.
+ *
+ * The states must stay apart: a service that refused the call needs a
+ * different fix than a service that could not be reached, and both differ
+ * from a service that holds nothing.
+ *
+ * The source is injected, so the test neither reaches the network nor
+ * replaces a process-global module.
+ */
+
+import { describe, expect, it } from "bun:test";
+
+import { createSkillRegistry } from "../src/loader.js";
+import type { RemoteSkill, RemoteSkillSource } from "../src/remote-source.js";
+
+/** A source that holds the given skills. */
+class FakeSource implements RemoteSkillSource {
+	/** The skills the source holds. */
+	readonly skills: RemoteSkill[];
+	/** The ids that were asked for. */
+	readonly requested: string[] = [];
+	/** The error the next call raises. */
+	failure: { message: string; code: "denied" | "unavailable" } | null = null;
+
+	constructor(skills: RemoteSkill[] = []) {
+		this.skills = skills;
+	}
+
+	async list(): Promise<RemoteSkill[]> {
+		if (this.failure) {
+			const error = new Error(this.failure.message) as Error & {
+				code: string;
+			};
+			error.code = this.failure.code;
+			throw error;
+		}
+		return this.skills;
+	}
+
+	async get(id: string): Promise<RemoteSkill | null> {
+		this.requested.push(id);
+		if (this.failure) {
+			const error = new Error(this.failure.message) as Error & {
+				code: string;
+			};
+			error.code = this.failure.code;
+			throw error;
+		}
+		return this.skills.find((skill) => skill.id === id) ?? null;
+	}
+}
+
+describe("the skills of the server", () => {
+	it("are listed by the registry", async () => {
+		const source = new FakeSource([
+			{
+				id: "shared-skill",
+				name: "shared-skill",
+				description: "the shared skill",
+				version: "1.2.0",
+			},
+		]);
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+
+		const stats = await registry.refreshRemoteSkills();
+
+		expect(stats.state).toBe("populated");
+		expect(stats.count).toBe(1);
+		expect(registry.listRemote().map((skill) => skill.id)).toEqual(["shared-skill"]);
+		// The local count stays local.
+		expect(registry.list()).toHaveLength(0);
+	});
+
+	it("are not local skills", async () => {
+		const source = new FakeSource([
+			{ id: "shared-skill", name: "shared-skill", description: "d", version: "1.0.0" },
+		]);
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+		await registry.refreshRemoteSkills();
+
+		expect(registry.list()).toHaveLength(0);
+		expect(registry.listRemote()).toHaveLength(1);
+	});
+
+	it("replace the cached skill when the version changed", async () => {
+		const source = new FakeSource([
+			{ id: "shared-skill", name: "shared-skill", description: "old", version: "1.0.0" },
+		]);
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+		await registry.refreshRemoteSkills();
+		expect(registry.listRemote()[0].frontmatter.description).toBe("old");
+
+		// The server publishes a new version.
+		source.skills[0] = {
+			id: "shared-skill",
+			name: "shared-skill",
+			description: "new",
+			version: "1.1.0",
+		};
+		await registry.refreshRemoteSkills();
+
+		expect(registry.listRemote()[0].frontmatter.description).toBe("new");
+		expect(registry.listRemote()[0].frontmatter.version).toBe("1.1.0");
+	});
+
+	it("stay when the version is unknown", async () => {
+		const source = new FakeSource([
+			{ id: "shared-skill", name: "shared-skill", description: "known", version: "1.0.0" },
+		]);
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+		await registry.refreshRemoteSkills();
+
+		// A record without a version is not evidence of a change.
+		source.skills[0] = {
+			id: "shared-skill",
+			name: "shared-skill",
+			description: "changed without a version",
+		};
+		await registry.refreshRemoteSkills();
+
+		expect(registry.listRemote()[0].frontmatter.description).toBe("known");
+	});
+
+	it("are loaded completely from the service", async () => {
+		const source = new FakeSource([
+			{
+				id: "shared-skill",
+				name: "shared-skill",
+				description: "the shared skill",
+				version: "1.0.0",
+				content: "the complete body of the skill",
+				contentComplete: true,
+			},
+		]);
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+
+		const loaded = await registry.load("shared-skill");
+
+		expect(loaded).not.toBeNull();
+		expect(loaded?.body).toBe("the complete body of the skill");
+		expect(source.requested).toContain("shared-skill");
+	});
+
+	it("are not asked for again once the content is complete", async () => {
+		const source = new FakeSource([
+			{
+				id: "shared-skill",
+				name: "shared-skill",
+				description: "d",
+				version: "1.0.0",
+				content: "the body",
+				contentComplete: true,
+			},
+		]);
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+
+		await registry.load("shared-skill");
+		const afterFirst = source.requested.length;
+		await registry.load("shared-skill");
+
+		expect(source.requested.length).toBe(afterFirst);
+	});
+
+	it("are reported as empty when the service holds nothing", async () => {
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(new FakeSource([]));
+
+		const stats = await registry.refreshRemoteSkills();
+
+		expect(stats.state).toBe("empty");
+		expect(stats.count).toBe(0);
+	});
+
+	it("are reported as not configured without a service", async () => {
+		const registry = createSkillRegistry();
+
+		const stats = await registry.getRemoteStats();
+
+		expect(stats.state).toBe("not-configured");
+	});
+});
+
+describe("a service that does not answer", () => {
+	it("reports a refusal as denied", async () => {
+		const source = new FakeSource();
+		source.failure = { message: "unauthorized", code: "denied" };
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+
+		const stats = await registry.refreshRemoteSkills();
+
+		expect(stats.state).toBe("denied");
+		expect(stats.error).toContain("unauthorized");
+	});
+
+	it("reports an unreachable service as unavailable", async () => {
+		const source = new FakeSource();
+		source.failure = { message: "connection refused", code: "unavailable" };
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+
+		const stats = await registry.refreshRemoteSkills();
+
+		expect(stats.state).toBe("unavailable");
+		expect(stats.error).toContain("connection refused");
+	});
+
+	it("keeps the cached skills after a failed refresh", async () => {
+		const source = new FakeSource([
+			{ id: "shared-skill", name: "shared-skill", description: "d", version: "1.0.0" },
+		]);
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+		await registry.refreshRemoteSkills();
+
+		source.failure = { message: "connection refused", code: "unavailable" };
+		const stats = await registry.refreshRemoteSkills();
+
+		expect(stats.state).toBe("unavailable");
+		// A failed refresh must not throw the cached skills away.
+		expect(registry.listRemote()).toHaveLength(1);
+	});
+
+	it("does not put a credential into the message", async () => {
+		const source = new FakeSource();
+		source.failure = {
+			message: "Bearer sk-abcdefghijklmnopqrstuvwxyz0123456789 refused",
+			code: "denied",
+		};
+		const registry = createSkillRegistry();
+		registry.setRemoteSource(source);
+
+		const stats = await registry.refreshRemoteSkills();
+
+		expect(stats.error).not.toContain("sk-abcdefghijklmnopqrstuvwxyz0123456789");
+	});
+});

package/packages/sprint-planner/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/sprint-planner",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "type": "module",
   "description": "Sprint planning engine for pi-harness",
   "main": "dist/index.js",

package/packages/subscription-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/subscription-engine",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/task-compiler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/task-compiler",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "Task Compiler for pi-harness-runtime — produces deterministic task DAG from CompiledRequirement",
   "type": "module",
   "main": "./dist/index.js",

package/packages/telegram/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/telegram",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "pi-harness-runtime — Telegram inbound/outbound",
   "type": "module",
   "main": "./src/index.js",

package/packages/tencentdb-memory/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@moocoding/tencentdb-memory",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "TencentDB Agent Memory client - sync skills to centralized knowledge base",
   "type": "module",
   "main": "src/index.ts",

package/packages/tencentdb-sync/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/tencentdb-sync",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "Sync SKILL.md skills to TencentDB-Agent-Memory server (RFC-0105/0106)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/test-data-generator/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/test-data-generator",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "Test data generation for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/test-generator/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/test-generator",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "Auto-Test Generator — generate unit and E2E tests from source code (RFC-0013)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/todo-bd-sync/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@moocoding/todo-bd-sync",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "Two-way sync between rpiv-todo overlay and bd issue tracker",
   "type": "module",
   "main": "src/index.ts",

package/packages/token-estimation/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/token-estimation",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "pi-harness-runtime — token-estimation",
   "type": "module",
   "main": "./dist/index.js",

package/packages/token-optimizer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/token-optimizer",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "Token Budget Optimizer — maximize prompt value within token limits (RFC-0011)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/tooling-preference/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/tooling-preference",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "pi-harness-runtime — JS/TS tooling preference (Biome vs ESLint/Prettier) proposal",
   "type": "module",
   "main": "./dist/index.js",

package/packages/trajectory/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/trajectory",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "Trajectory capture for the write-review loop — persists cycle records for learning",
   "type": "module",
   "main": "./dist/src/index.js",

package/packages/tui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/tui",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "pi-harness-runtime — tui",
   "type": "module",
   "main": "./dist/index.js",

package/packages/two-phase-review/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/two-phase-review",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "pi-harness-runtime — two-phase implementation and review workflow (queue review signals, gate the phase, scope the diff)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/types/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/types",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "Shared TypeScript types for pi-harness-runtime packages",
   "type": "module",
   "main": "./dist/index.js",

package/packages/voice-api/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/voice-api",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "type": "module",
   "description": "Voice-to-text API using Whisper for Telegram and LINE integration",
   "main": "./dist/index.js",

package/packages/webmcp-tester/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/webmcp-tester",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "WebMCP-powered E2E testing for pi-harness - natural language test scenarios",
   "type": "module",
   "main": "./dist/index.js",

package/packages/wiki/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/wiki",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "LLM Wiki integration for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/workflow-events/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/workflow-events",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/workspace-scanner/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/workspace-scanner",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/worktree/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/worktree",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "pi-harness-runtime — worktree",
   "type": "module",
   "main": "./dist/index.js",

package/packages/write-review/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@moocoding/write-review",
-  "version": "1.1.411",
+  "version": "1.1.413",
   "description": "Two-agent write-review loop with blackboard coordination",
   "type": "module",
   "main": "src/index.ts",

package/scripts/sync-to-qdrant.ts

@@ -14,6 +14,21 @@
 import { existsSync, readdirSync, readFileSync, statSync } from "node:fs";
 import { join, basename } from "node:path";
 import { QdrantClient } from "@qdrant/js-client-rest";
+// The runtime and this script must write into the SAME collection with the
+// SAME vectors: a collection holds vectors of exactly one size, and a vector
+// of a different size cannot be searched with the vectors of the other one.
+// The embedder and the collection name are therefore imported from the
+// packages that own them - they are not repeated here.
+import {
+  EMBEDDING_DIMENSIONS,
+  EMBEDDING_MODEL,
+  createEmbedding,
+  createEmbeddingsBatch,
+} from "../packages/qdrant-skills/dist/index.js";
+import {
+  LEGACY_SKILL_COLLECTION,
+  SKILL_COLLECTION,
+} from "../packages/skills/dist/vector-schema.js";
 
 // =============================================================================
 // SANITIZATION: Replace client-specific names with placeholders
@@ -81,17 +96,17 @@ interface QdrantConfig {
 function getQdrantConfig(): QdrantConfig | null {
   let apiKey = process.env.QDRANT_API_KEY;
   const url = process.env.QDRANT_CLUSTER_ENDPOINT || "https://api.qdrant.tech";
-  const collection = process.env.QDRANT_COLLECTION || "pi-harness-skills";
-  
+  const collection = process.env.QDRANT_COLLECTION || SKILL_COLLECTION;
+
   if (!apiKey) {
     const keyPath = `${process.env.HOME}/.pi-harness-runtime/keys/qdrant-api-key.txt`;
     if (existsSync(keyPath)) {
       apiKey = readFileSync(keyPath, "utf-8").trim();
     }
   }
-  
+
   if (!apiKey) return null;
-  
+
   return { url, apiKey, collection };
 }
 
@@ -180,15 +195,58 @@ function findSkillDirs(dir: string): string[] {
 // =============================================================================
 
 async function ensureCollection(client: QdrantClient, name: string): Promise<void> {
+  const existing = await collectionSchema(client, name);
+  if (existing?.dimensions !== undefined && existing.dimensions !== EMBEDDING_DIMENSIONS) {
+    // The collection holds vectors of another size. Writing into it would
+    // fail, and recreating it would destroy the skills of the other model.
+    // The name says so the user can act.
+    console.error(
+      `[Sync] The collection ${name} holds ${existing.dimensions}-dimensional vectors,` +
+        ` but the runtime embeds with ${EMBEDDING_DIMENSIONS} (${EMBEDDING_MODEL}).`,
+    );
+    if (name === LEGACY_SKILL_COLLECTION) {
+      console.error(
+        `[Sync] ${LEGACY_SKILL_COLLECTION} is the legacy collection of the MiniLM model.`,
+      );
+    }
+    console.error(
+      `[Sync] Use a different collection (QDRANT_COLLECTION) or re-create this one.`,
+    );
+    process.exit(1);
+  }
   try {
     await client.createCollection(name, {
-      vectors: { size: 384, distance: "Cosine" }
+      vectors: { size: EMBEDDING_DIMENSIONS, distance: "Cosine" }
     });
   } catch {
     // Already exists - OK
   }
 }
 
+/**
+ * The vector size and the distance of a collection.
+ *
+ * `null` means the collection does not exist (or cannot be read).
+ */
+async function collectionSchema(
+  client: QdrantClient,
+  name: string,
+): Promise<{ dimensions?: number; distance?: string } | null> {
+  try {
+    // SAFETY: the Qdrant client answers with the collection description;
+    // the shape below is the one field this function reads. The cast is
+    // needed because the generated client types the response as `unknown`.
+    const info = (await client.getCollection(name)) as unknown as {
+      config?: { params?: { vectors?: { size?: number; distance?: string } } };
+    };
+    const vectors = info?.config?.params?.vectors;
+    if (!vectors) return { };
+    return { dimensions: vectors.size, distance: vectors.distance };
+  } catch {
+    return null;
+  }
+}
+
 async function clearCollection(client: QdrantClient, name: string): Promise<void> {
   try {
     await client.deleteCollection(name);
@@ -203,6 +261,17 @@ async function upsertSkills(
   collectionName: string,
   skills: SkillDoc[]
 ): Promise<void> {
+  // The vectors are produced by the same embedder the runtime uses, so the
+  // two can search each other's points. The embedding happens in batches:
+  // one request per 64 skills instead of one per skill.
+  const { embeddings } = await createEmbeddingsBatch(skills.map((skill) => skill.text));
+  if (embeddings.length !== skills.length) {
+    console.error(
+      `[Sync] The embedder returned ${embeddings.length} vectors for ${skills.length} skills.`,
+    );
+    process.exit(1);
+  }
+
   const points = skills.map((skill, idx) => ({
     id: idx + 1,
     payload: {
@@ -210,12 +279,9 @@ async function upsertSkills(
       description: skill.description,
       body: skill.body,
     },
-    vector: {
-      text: skill.text,
-      model: "sentence-transformers/all-MiniLM-L6-v2"
-    }
+    vector: embeddings[idx],
   }));
-  
+
   await client.upsert(collectionName, { wait: true, points });
 }
 
@@ -224,11 +290,10 @@ async function searchSkills(
   collectionName: string,
   query: string
 ): Promise<void> {
+  // The query is embedded with the same model as the stored vectors.
+  const { embedding } = await createEmbedding(query);
   const results = await client.query(collectionName, {
-    query: {
-      text: query,
-      model: "sentence-transformers/all-MiniLM-L6-v2"
-    },
+    query: embedding,
     limit: 10,
     with_payload: true,
   } as Parameters<typeof client.query>[1]);