pi-harness-runtime 1.1.407 → 1.1.408

package/packages/two-phase-review/dist/signals.d.ts

@@ -0,0 +1,74 @@
+/**
+ * Review signals.
+ *
+ * A "review now" signal is any attempt to start a comprehensive review while
+ * the implementation is still running. The workflow records the signal and
+ * defers the review instead of letting it interrupt the implementation.
+ */
+import type { ReviewSignal } from "./types.js";
+/**
+ * Tool names that start a comprehensive review of the change.
+ *
+ * Task-level checks (a type error of the file that is edited right now, a
+ * failing test of that file) are deliberately absent: they belong to the
+ * implementation and stay actionable.
+ */
+export declare const DEFAULT_REVIEW_TOOL_PATTERNS: string[];
+/**
+ * Command patterns that start a dedicated review runner from a shell.
+ *
+ * The list is narrow on purpose: a shell command is only a review signal when
+ * it runs a review runner, never when it merely mentions one.
+ */
+export declare const DEFAULT_REVIEW_COMMAND_PATTERNS: string[];
+/** Read the extra patterns a deployment configured. */
+export declare function parseExtraPatterns(env?: NodeJS.ProcessEnv): string[];
+/**
+ * Does the tool name name a comprehensive review?
+ *
+ * The name is matched exactly: a tool that only contains the name of a
+ * review ("read_audit_log") is ordinary work.
+ */
+export declare function isComprehensiveReviewTool(toolName: string, extraPatterns?: string[]): boolean;
+/** Does the shell command run a dedicated review runner? */
+export declare function isReviewCommand(command: string): boolean;
+/** The agent name of a generic dispatch tool, when it has one. */
+export declare function dispatchAgentName(toolName: string, input: unknown): string;
+/** A review request that the harness recognized. */
+export interface ReviewInvocation {
+    /** The source of the request (tool name, agent name or command). */
+    source: string;
+    /** The files the request points at (best effort). */
+    files: string[];
+    /** One short line describing the request. */
+    reason: string;
+}
+/** Pull file names out of a tool input (best effort). */
+export declare function extractFiles(toolName: string, input: unknown): string[];
+/**
+ * Recognize a request to start a comprehensive review.
+ *
+ * Returns `null` when the call is an ordinary task-level check.
+ */
+export declare function detectReviewInvocation(toolName: string, input: unknown, extraPatterns?: string[]): ReviewInvocation | null;
+/**
+ * Did the human ask for a review explicitly?
+ *
+ * The phase order never overrides the intent of the user: an explicit request
+ * runs the review now. A sentence that talks about a review without asking
+ * for one is not a request.
+ */
+export declare function explicitReviewRequest(message: string): boolean;
+/** The identity of a signal: the same signal is never recorded twice. */
+export declare function signalKey(signal: ReviewSignal): string;
+/** Add a signal, ignoring an identical one. */
+export declare function mergeSignals(signals: ReviewSignal[], signal: ReviewSignal, limit?: number): ReviewSignal[];
+/** The merged view of every recorded signal. */
+export interface SignalSummary {
+    sources: string[];
+    files: string[];
+    reason: string;
+}
+/** Merge the recorded signals into one scope. */
+export declare function summarizeSignals(signals: ReviewSignal[]): SignalSummary;
+//# sourceMappingURL=signals.d.ts.map

package/packages/two-phase-review/dist/signals.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"signals.d.ts","sourceRoot":"","sources":["../src/signals.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAEH,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,YAAY,CAAC;AAE/C;;;;;;GAMG;AACH,eAAO,MAAM,4BAA4B,EAAE,MAAM,EAwBhD,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,+BAA+B,EAAE,MAAM,EAWnD,CAAC;AA+EF,uDAAuD;AACvD,wBAAgB,kBAAkB,CAAC,GAAG,GAAE,MAAM,CAAC,UAAwB,GAAG,MAAM,EAAE,CAOjF;AAED;;;;;GAKG;AACH,wBAAgB,yBAAyB,CACxC,QAAQ,EAAE,MAAM,EAChB,aAAa,GAAE,MAAM,EAAO,GAC1B,OAAO,CAKT;AAED,4DAA4D;AAC5D,wBAAgB,eAAe,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CASxD;AAED,kEAAkE;AAClE,wBAAgB,iBAAiB,CAAC,QAAQ,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,GAAG,MAAM,CAQ1E;AAED,oDAAoD;AACpD,MAAM,WAAW,gBAAgB;IAChC,oEAAoE;IACpE,MAAM,EAAE,MAAM,CAAC;IACf,qDAAqD;IACrD,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,6CAA6C;IAC7C,MAAM,EAAE,MAAM,CAAC;CACf;AAKD,yDAAyD;AACzD,wBAAgB,YAAY,CAAC,QAAQ,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,GAAG,MAAM,EAAE,CA2BvE;AAED;;;;GAIG;AACH,wBAAgB,sBAAsB,CACrC,QAAQ,EAAE,MAAM,EAChB,KAAK,EAAE,OAAO,EACd,aAAa,GAAE,MAAM,EAAO,GAC1B,gBAAgB,GAAG,IAAI,CA8BzB;AAoBD;;;;;;GAMG;AACH,wBAAgB,qBAAqB,CAAC,OAAO,EAAE,MAAM,GAAG,OAAO,CAO9D;AAED,yEAAyE;AACzE,wBAAgB,SAAS,CAAC,MAAM,EAAE,YAAY,GAAG,MAAM,CAGtD;AAED,+CAA+C;AAC/C,wBAAgB,YAAY,CAC3B,OAAO,EAAE,YAAY,EAAE,EACvB,MAAM,EAAE,YAAY,EACpB,KAAK,SAAK,GACR,YAAY,EAAE,CAKhB;AAED,gDAAgD;AAChD,MAAM,WAAW,aAAa;IAC7B,OAAO,EAAE,MAAM,EAAE,CAAC;IAClB,KAAK,EAAE,MAAM,EAAE,CAAC;IAChB,MAAM,EAAE,MAAM,CAAC;CACf;AAED,iDAAiD;AACjD,wBAAgB,gBAAgB,CAAC,OAAO,EAAE,YAAY,EAAE,GAAG,aAAa,CAOvE"}

package/packages/two-phase-review/dist/signals.js

@@ -0,0 +1,297 @@
+/**
+ * Review signals.
+ *
+ * A "review now" signal is any attempt to start a comprehensive review while
+ * the implementation is still running. The workflow records the signal and
+ * defers the review instead of letting it interrupt the implementation.
+ */
+/**
+ * Tool names that start a comprehensive review of the change.
+ *
+ * Task-level checks (a type error of the file that is edited right now, a
+ * failing test of that file) are deliberately absent: they belong to the
+ * implementation and stay actionable.
+ */
+export const DEFAULT_REVIEW_TOOL_PATTERNS = [
+    "code-review",
+    "code_review",
+    "code-reviewer",
+    "code_reviewer",
+    "differential-review",
+    "differential_review",
+    "variant-analysis",
+    "variant_analysis",
+    "fp-check",
+    "fp_check",
+    "semgrep",
+    "codeql",
+    "durable-review",
+    "durable_review",
+    "spec-to-code-compliance",
+    "spec_to_code_compliance",
+    "security-threat-model",
+    "security_threat_model",
+    "supply-chain",
+    "insecure-defaults",
+    "sharp-edges",
+    "agentic-actions",
+    "audit",
+];
+/**
+ * Command patterns that start a dedicated review runner from a shell.
+ *
+ * The list is narrow on purpose: a shell command is only a review signal when
+ * it runs a review runner, never when it merely mentions one.
+ */
+export const DEFAULT_REVIEW_COMMAND_PATTERNS = [
+    "code-review",
+    "code-reviewer",
+    "differential-review",
+    "variant-analysis",
+    "fp-check",
+    "semgrep",
+    "codeql",
+    "durable-review",
+    "security-review",
+    "security-reviewer",
+];
+/** The programs that run another program. */
+const LAUNCHERS = new Set([
+    "npx",
+    "bunx",
+    "bun",
+    "pnpm",
+    "pnpx",
+    "yarn",
+    "dlx",
+    "uvx",
+    "pipx",
+    "deno",
+    "node",
+    "python",
+    "python3",
+]);
+/** The words a launcher uses to name the program it runs. */
+const LAUNCHER_SUBCOMMANDS = new Set(["run", "x", "dlx", "exec"]);
+/** Normalize a name: lower case, spaces and underscores become dashes. */
+function normalizeName(name) {
+    return (name ?? "")
+        .trim()
+        .toLowerCase()
+        .replace(/[\s_]+/g, "-");
+}
+/**
+ * The candidates of a tool name.
+ *
+ * A tool is identified by its full name and by the name behind its
+ * namespace ("mcp__pi__code-review" is "code-review").
+ */
+function toolNameCandidates(name) {
+    const raw = (name ?? "").trim();
+    if (!raw)
+        return [];
+    const candidates = new Set();
+    const add = (value) => {
+        const normalized = normalizeName(value);
+        if (normalized)
+            candidates.add(normalized);
+    };
+    add(raw);
+    const segments = raw.split(/__|[:/]/).filter(Boolean);
+    if (segments.length > 1)
+        add(segments[segments.length - 1]);
+    return [...candidates];
+}
+/**
+ * The program a shell segment runs.
+ *
+ * Only the program matters: a command that mentions a review runner as an
+ * argument ("echo code-review") does not run one.
+ */
+function commandExecutable(segment) {
+    const tokens = segment.trim().split(/\s+/).filter(Boolean);
+    let index = 0;
+    while (index < tokens.length && /^[A-Za-z_][A-Za-z0-9_]*=/.test(tokens[index]))
+        index += 1;
+    while (index < tokens.length &&
+        ["sudo", "env", "command", "time", "nohup"].includes(tokens[index].toLowerCase())) {
+        index += 1;
+    }
+    while (index < tokens.length && tokens[index].startsWith("-"))
+        index += 1;
+    let executable = tokens[index] ?? "";
+    if (!executable)
+        return "";
+    if (LAUNCHERS.has(executable.toLowerCase())) {
+        index += 1;
+        while (index < tokens.length && tokens[index].startsWith("-"))
+            index += 1;
+        if (LAUNCHER_SUBCOMMANDS.has((tokens[index] ?? "").toLowerCase()))
+            index += 1;
+        executable = tokens[index] ?? "";
+    }
+    const name = executable.split("/").pop() ?? "";
+    return normalizeName(name.replace(/\.(js|mjs|cjs|ts|sh)$/, ""));
+}
+/** Read the extra patterns a deployment configured. */
+export function parseExtraPatterns(env = process.env) {
+    const raw = env.PI_TWO_PHASE_REVIEW_TOOLS;
+    if (!raw)
+        return [];
+    return raw
+        .split(",")
+        .map((entry) => entry.trim().toLowerCase())
+        .filter(Boolean);
+}
+/**
+ * Does the tool name name a comprehensive review?
+ *
+ * The name is matched exactly: a tool that only contains the name of a
+ * review ("read_audit_log") is ordinary work.
+ */
+export function isComprehensiveReviewTool(toolName, extraPatterns = []) {
+    const candidates = toolNameCandidates(toolName);
+    if (candidates.length === 0)
+        return false;
+    const patterns = [...DEFAULT_REVIEW_TOOL_PATTERNS, ...extraPatterns].map(normalizeName);
+    return candidates.some((candidate) => patterns.includes(candidate));
+}
+/** Does the shell command run a dedicated review runner? */
+export function isReviewCommand(command) {
+    const text = (command ?? "").toLowerCase();
+    if (!text)
+        return false;
+    const runners = new Set(DEFAULT_REVIEW_COMMAND_PATTERNS.map(normalizeName));
+    const segments = text.split(/(?:\|\||&&|[;\n|])/);
+    return segments.some((segment) => {
+        const executable = commandExecutable(segment);
+        return executable !== "" && runners.has(executable);
+    });
+}
+/** The agent name of a generic dispatch tool, when it has one. */
+export function dispatchAgentName(toolName, input) {
+    if (!["subagent", "task", "dispatch_agent"].includes(toolName))
+        return "";
+    const args = (input ?? {});
+    const candidates = [args.agent, args.subagent_type, args.agentName, args.role];
+    for (const candidate of candidates) {
+        if (typeof candidate === "string" && candidate.trim())
+            return candidate.trim();
+    }
+    return "";
+}
+const SOURCE_FILE_PATTERN = /(?:^|[\s"'`(=])((?:\.{0,2}\/)?(?:[\w.@+-]+\/)*[\w.@+-]+\.(?:ts|tsx|mts|cts|js|jsx|mjs|cjs))/g;
+/** Pull file names out of a tool input (best effort). */
+export function extractFiles(toolName, input) {
+    const args = (input ?? {});
+    const files = new Set();
+    const add = (value) => {
+        if (typeof value === "string" && value.trim())
+            files.add(value.trim());
+    };
+    const addList = (value) => {
+        if (Array.isArray(value)) {
+            for (const entry of value)
+                add(entry);
+            return;
+        }
+        add(value);
+    };
+    for (const key of ["files", "paths", "path", "file", "target", "targets", "scope"]) {
+        addList(args[key]);
+    }
+    if (toolName === "bash" && typeof args.command === "string") {
+        const matches = args.command.matchAll(SOURCE_FILE_PATTERN);
+        for (const match of matches) {
+            if (match[1])
+                files.add(match[1]);
+        }
+    }
+    return [...files].slice(0, 200);
+}
+/**
+ * Recognize a request to start a comprehensive review.
+ *
+ * Returns `null` when the call is an ordinary task-level check.
+ */
+export function detectReviewInvocation(toolName, input, extraPatterns = []) {
+    if (isComprehensiveReviewTool(toolName, extraPatterns)) {
+        return {
+            source: toolName,
+            files: extractFiles(toolName, input),
+            reason: `a comprehensive review was requested with ${toolName}`,
+        };
+    }
+    const agent = dispatchAgentName(toolName, input);
+    if (agent && isComprehensiveReviewTool(agent, extraPatterns)) {
+        return {
+            source: agent,
+            files: extractFiles(toolName, input),
+            reason: `a comprehensive review was requested with the ${agent} reviewer`,
+        };
+    }
+    if (toolName === "bash") {
+        const command = input?.command;
+        if (typeof command === "string" && isReviewCommand(command)) {
+            return {
+                source: "bash",
+                files: extractFiles(toolName, input),
+                reason: `a review runner was started: ${command.trim().slice(0, 160)}`,
+            };
+        }
+    }
+    return null;
+}
+/**
+ * A negation of a review request.
+ *
+ * The negation is read per sentence, so "do not review yet" does not silence
+ * a later "please review the diff".
+ */
+const NEGATED_REVIEW = /\b(?:do not|don'?t|does not|doesn'?t|no|without|skip|avoid|postpone|defer|later|not yet|never)\b[^.!?\n]{0,40}\b(?:review|audit)\b/i;
+/** The ways a human asks for a review. */
+const AFFIRMATIVE_REVIEW = [
+    /\b(?:please\s+)?(?:run|do|perform|start|begin|execute|launch|carry out|give)\s+(?:a\s+|an\s+|the\s+)?(?:comprehensive\s+|full\s+|complete\s+|code\s+|security\s+)?(?:review|audit)\b/i,
+    /\b(?:can|could|would|will|shall)\s+you\s+(?:please\s+)?(?:review|audit)\b/i,
+    /\b(?:review|audit)\s+(?:the|this|that|my|our|it|everything|all|each)\b/i,
+    /^\s*(?:please\s+)?(?:review|audit)\b/i,
+    /\b(?:review|audit)\s+(?:now|again)\b/i,
+];
+/**
+ * Did the human ask for a review explicitly?
+ *
+ * The phase order never overrides the intent of the user: an explicit request
+ * runs the review now. A sentence that talks about a review without asking
+ * for one is not a request.
+ */
+export function explicitReviewRequest(message) {
+    if (!message)
+        return false;
+    const sentences = message.split(/(?<=[.!?])\s+/);
+    return sentences.some((sentence) => {
+        if (NEGATED_REVIEW.test(sentence))
+            return false;
+        return AFFIRMATIVE_REVIEW.some((pattern) => pattern.test(sentence));
+    });
+}
+/** The identity of a signal: the same signal is never recorded twice. */
+export function signalKey(signal) {
+    const files = [...signal.files].sort().join(",");
+    return `${signal.source}::${files}::${signal.reason.trim().toLowerCase()}`;
+}
+/** Add a signal, ignoring an identical one. */
+export function mergeSignals(signals, signal, limit = 50) {
+    const key = signalKey(signal);
+    if (signals.some((entry) => signalKey(entry) === key))
+        return signals;
+    const next = [...signals, signal];
+    return next.length > limit ? next.slice(next.length - limit) : next;
+}
+/** Merge the recorded signals into one scope. */
+export function summarizeSignals(signals) {
+    const sources = [...new Set(signals.map((signal) => signal.source))];
+    const files = [...new Set(signals.flatMap((signal) => signal.files))];
+    const reason = [...new Set(signals.map((signal) => signal.reason.trim()).filter(Boolean))].join("; ");
+    return { sources, files, reason };
+}
+//# sourceMappingURL=signals.js.map

package/packages/two-phase-review/dist/signals.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"signals.js","sourceRoot":"","sources":["../src/signals.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAIH;;;;;;GAMG;AACH,MAAM,CAAC,MAAM,4BAA4B,GAAa;IACrD,aAAa;IACb,aAAa;IACb,eAAe;IACf,eAAe;IACf,qBAAqB;IACrB,qBAAqB;IACrB,kBAAkB;IAClB,kBAAkB;IAClB,UAAU;IACV,UAAU;IACV,SAAS;IACT,QAAQ;IACR,gBAAgB;IAChB,gBAAgB;IAChB,yBAAyB;IACzB,yBAAyB;IACzB,uBAAuB;IACvB,uBAAuB;IACvB,cAAc;IACd,mBAAmB;IACnB,aAAa;IACb,iBAAiB;IACjB,OAAO;CACP,CAAC;AAEF;;;;;GAKG;AACH,MAAM,CAAC,MAAM,+BAA+B,GAAa;IACxD,aAAa;IACb,eAAe;IACf,qBAAqB;IACrB,kBAAkB;IAClB,UAAU;IACV,SAAS;IACT,QAAQ;IACR,gBAAgB;IAChB,iBAAiB;IACjB,mBAAmB;CACnB,CAAC;AAEF,6CAA6C;AAC7C,MAAM,SAAS,GAAG,IAAI,GAAG,CAAC;IACzB,KAAK;IACL,MAAM;IACN,KAAK;IACL,MAAM;IACN,MAAM;IACN,MAAM;IACN,KAAK;IACL,KAAK;IACL,MAAM;IACN,MAAM;IACN,MAAM;IACN,QAAQ;IACR,SAAS;CACT,CAAC,CAAC;AAEH,6DAA6D;AAC7D,MAAM,oBAAoB,GAAG,IAAI,GAAG,CAAC,CAAC,KAAK,EAAE,GAAG,EAAE,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC;AAElE,0EAA0E;AAC1E,SAAS,aAAa,CAAC,IAAY;IAClC,OAAO,CAAC,IAAI,IAAI,EAAE,CAAC;SACjB,IAAI,EAAE;SACN,WAAW,EAAE;SACb,OAAO,CAAC,SAAS,EAAE,GAAG,CAAC,CAAC;AAC3B,CAAC;AAED;;;;;GAKG;AACH,SAAS,kBAAkB,CAAC,IAAY;IACvC,MAAM,GAAG,GAAG,CAAC,IAAI,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC;IAChC,IAAI,CAAC,GAAG;QAAE,OAAO,EAAE,CAAC;IACpB,MAAM,UAAU,GAAG,IAAI,GAAG,EAAU,CAAC;IACrC,MAAM,GAAG,GAAG,CAAC,KAAa,EAAQ,EAAE;QACnC,MAAM,UAAU,GAAG,aAAa,CAAC,KAAK,CAAC,CAAC;QACxC,IAAI,UAAU;YAAE,UAAU,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IAC5C,CAAC,CAAC;IACF,GAAG,CAAC,GAAG,CAAC,CAAC;IACT,MAAM,QAAQ,GAAG,GAAG,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;IACtD,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC;QAAE,GAAG,CAAC,QAAQ,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC;IAC5D,OAAO,CAAC,GAAG,UAAU,CAAC,CAAC;AACxB,CAAC;AAED;;;;;GAKG;AACH,SAAS,iBAAiB,CAAC,OAAe;IACzC,MAAM,MAAM,GAAG,OAAO,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC;IAC3D,IAAI,KAAK,GAAG,CAAC,CAAC;IACd,OAAO,KAAK,GAAG,MAAM,CAAC,MAAM,IAAI,0BAA0B,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC;QAAE,KAAK,IAAI,CAAC,CAAC;IAC3F,OACC,KAAK,GAAG,MAAM,CAAC,MAAM;QACrB,CAAC,MAAM,EAAE,KAAK,EAAE,SAAS,EAAE,MAAM,EAAE,OAAO,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,WAAW,EAAE,CAAC,EAChF,CAAC;QACF,KAAK,IAAI,CAAC,CAAC;IACZ,CAAC;IACD,OAAO,KAAK,GAAG,MAAM,CAAC,MAAM,IAAI,MAAM,CAAC,KAAK,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC;QAAE,KAAK,IAAI,CAAC,CAAC;IAC1E,IAAI,UAAU,GAAG,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;IACrC,IAAI,CAAC,UAAU;QAAE,OAAO,EAAE,CAAC;IAC3B,IAAI,SAAS,CAAC,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC,EAAE,CAAC;QAC7C,KAAK,IAAI,CAAC,CAAC;QACX,OAAO,KAAK,GAAG,MAAM,CAAC,MAAM,IAAI,MAAM,CAAC,KAAK,CAAC,CAAC,UAAU,CAAC,GAAG,CAAC;YAAE,KAAK,IAAI,CAAC,CAAC;QAC1E,IAAI,oBAAoB,CAAC,GAAG,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;YAAE,KAAK,IAAI,CAAC,CAAC;QAC9E,UAAU,GAAG,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;IAClC,CAAC;IACD,MAAM,IAAI,GAAG,UAAU,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE,CAAC;IAC/C,OAAO,aAAa,CAAC,IAAI,CAAC,OAAO,CAAC,uBAAuB,EAAE,EAAE,CAAC,CAAC,CAAC;AACjE,CAAC;AAED,uDAAuD;AACvD,MAAM,UAAU,kBAAkB,CAAC,GAAG,GAAsB,OAAO,CAAC,GAAG;IACtE,MAAM,GAAG,GAAG,GAAG,CAAC,yBAAyB,CAAC;IAC1C,IAAI,CAAC,GAAG;QAAE,OAAO,EAAE,CAAC;IACpB,OAAO,GAAG;SACR,KAAK,CAAC,GAAG,CAAC;SACV,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;SAC1C,MAAM,CAAC,OAAO,CAAC,CAAC;AACnB,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,yBAAyB,CACxC,QAAgB,EAChB,aAAa,GAAa,EAAE;IAE5B,MAAM,UAAU,GAAG,kBAAkB,CAAC,QAAQ,CAAC,CAAC;IAChD,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IAC1C,MAAM,QAAQ,GAAG,CAAC,GAAG,4BAA4B,EAAE,GAAG,aAAa,CAAC,CAAC,GAAG,CAAC,aAAa,CAAC,CAAC;IACxF,OAAO,UAAU,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,QAAQ,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC;AACrE,CAAC;AAED,4DAA4D;AAC5D,MAAM,UAAU,eAAe,CAAC,OAAe;IAC9C,MAAM,IAAI,GAAG,CAAC,OAAO,IAAI,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;IAC3C,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,MAAM,OAAO,GAAG,IAAI,GAAG,CAAC,+BAA+B,CAAC,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC;IAC5E,MAAM,QAAQ,GAAG,IAAI,CAAC,KAAK,CAAC,oBAAoB,CAAC,CAAC;IAClD,OAAO,QAAQ,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE;QAChC,MAAM,UAAU,GAAG,iBAAiB,CAAC,OAAO,CAAC,CAAC;QAC9C,OAAO,UAAU,KAAK,EAAE,IAAI,OAAO,CAAC,GAAG,CAAC,UAAU,CAAC,CAAC;IACrD,CAAC,CAAC,CAAC;AACJ,CAAC;AAED,kEAAkE;AAClE,MAAM,UAAU,iBAAiB,CAAC,QAAgB,EAAE,KAAc;IACjE,IAAI,CAAC,CAAC,UAAU,EAAE,MAAM,EAAE,gBAAgB,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAC1E,MAAM,IAAI,GAAG,CAAC,KAAK,IAAI,EAAE,CAA4B,CAAC;IACtD,MAAM,UAAU,GAAG,CAAC,IAAI,CAAC,KAAK,EAAE,IAAI,CAAC,aAAa,EAAE,IAAI,CAAC,SAAS,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/E,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE,CAAC;QACpC,IAAI,OAAO,SAAS,KAAK,QAAQ,IAAI,SAAS,CAAC,IAAI,EAAE;YAAE,OAAO,SAAS,CAAC,IAAI,EAAE,CAAC;IAChF,CAAC;IACD,OAAO,EAAE,CAAC;AACX,CAAC;AAYD,MAAM,mBAAmB,GACxB,8FAA8F,CAAC;AAEhG,yDAAyD;AACzD,MAAM,UAAU,YAAY,CAAC,QAAgB,EAAE,KAAc;IAC5D,MAAM,IAAI,GAAG,CAAC,KAAK,IAAI,EAAE,CAA4B,CAAC;IACtD,MAAM,KAAK,GAAG,IAAI,GAAG,EAAU,CAAC;IAEhC,MAAM,GAAG,GAAG,CAAC,KAAc,EAAQ,EAAE;QACpC,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,CAAC,IAAI,EAAE;YAAE,KAAK,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC;IACxE,CAAC,CAAC;IACF,MAAM,OAAO,GAAG,CAAC,KAAc,EAAQ,EAAE;QACxC,IAAI,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC;YAC1B,KAAK,MAAM,KAAK,IAAI,KAAK;gBAAE,GAAG,CAAC,KAAK,CAAC,CAAC;YACtC,OAAO;QACR,CAAC;QACD,GAAG,CAAC,KAAK,CAAC,CAAC;IACZ,CAAC,CAAC;IAEF,KAAK,MAAM,GAAG,IAAI,CAAC,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,SAAS,EAAE,OAAO,CAAC,EAAE,CAAC;QACpF,OAAO,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;IACpB,CAAC;IAED,IAAI,QAAQ,KAAK,MAAM,IAAI,OAAO,IAAI,CAAC,OAAO,KAAK,QAAQ,EAAE,CAAC;QAC7D,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAAC,CAAC;QAC3D,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;YAC7B,IAAI,KAAK,CAAC,CAAC,CAAC;gBAAE,KAAK,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;QACnC,CAAC;IACF,CAAC;IAED,OAAO,CAAC,GAAG,KAAK,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;AACjC,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,sBAAsB,CACrC,QAAgB,EAChB,KAAc,EACd,aAAa,GAAa,EAAE;IAE5B,IAAI,yBAAyB,CAAC,QAAQ,EAAE,aAAa,CAAC,EAAE,CAAC;QACxD,OAAO;YACN,MAAM,EAAE,QAAQ;YAChB,KAAK,EAAE,YAAY,CAAC,QAAQ,EAAE,KAAK,CAAC;YACpC,MAAM,EAAE,6CAA6C,QAAQ,EAAE;SAC/D,CAAC;IACH,CAAC;IAED,MAAM,KAAK,GAAG,iBAAiB,CAAC,QAAQ,EAAE,KAAK,CAAC,CAAC;IACjD,IAAI,KAAK,IAAI,yBAAyB,CAAC,KAAK,EAAE,aAAa,CAAC,EAAE,CAAC;QAC9D,OAAO;YACN,MAAM,EAAE,KAAK;YACb,KAAK,EAAE,YAAY,CAAC,QAAQ,EAAE,KAAK,CAAC;YACpC,MAAM,EAAE,iDAAiD,KAAK,WAAW;SACzE,CAAC;IACH,CAAC;IAED,IAAI,QAAQ,KAAK,MAAM,EAAE,CAAC;QACzB,MAAM,OAAO,GAAI,KAAwC,EAAE,OAAO,CAAC;QACnE,IAAI,OAAO,OAAO,KAAK,QAAQ,IAAI,eAAe,CAAC,OAAO,CAAC,EAAE,CAAC;YAC7D,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,KAAK,EAAE,YAAY,CAAC,QAAQ,EAAE,KAAK,CAAC;gBACpC,MAAM,EAAE,gCAAgC,OAAO,CAAC,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,EAAE;aACtE,CAAC;QACH,CAAC;IACF,CAAC;IAED,OAAO,IAAI,CAAC;AACb,CAAC;AAED;;;;;GAKG;AACH,MAAM,cAAc,GACnB,qIAAqI,CAAC;AAEvI,0CAA0C;AAC1C,MAAM,kBAAkB,GAAa;IACpC,uLAAuL;IACvL,4EAA4E;IAC5E,yEAAyE;IACzE,uCAAuC;IACvC,uCAAuC;CACvC,CAAC;AAEF;;;;;;GAMG;AACH,MAAM,UAAU,qBAAqB,CAAC,OAAe;IACpD,IAAI,CAAC,OAAO;QAAE,OAAO,KAAK,CAAC;IAC3B,MAAM,SAAS,GAAG,OAAO,CAAC,KAAK,CAAC,eAAe,CAAC,CAAC;IACjD,OAAO,SAAS,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE;QAClC,IAAI,cAAc,CAAC,IAAI,CAAC,QAAQ,CAAC;YAAE,OAAO,KAAK,CAAC;QAChD,OAAO,kBAAkB,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC;IACrE,CAAC,CAAC,CAAC;AACJ,CAAC;AAED,yEAAyE;AACzE,MAAM,UAAU,SAAS,CAAC,MAAoB;IAC7C,MAAM,KAAK,GAAG,CAAC,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IACjD,OAAO,GAAG,MAAM,CAAC,MAAM,KAAK,KAAK,KAAK,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,CAAC;AAC5E,CAAC;AAED,+CAA+C;AAC/C,MAAM,UAAU,YAAY,CAC3B,OAAuB,EACvB,MAAoB,EACpB,KAAK,GAAG,EAAE;IAEV,MAAM,GAAG,GAAG,SAAS,CAAC,MAAM,CAAC,CAAC;IAC9B,IAAI,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,SAAS,CAAC,KAAK,CAAC,KAAK,GAAG,CAAC;QAAE,OAAO,OAAO,CAAC;IACtE,MAAM,IAAI,GAAG,CAAC,GAAG,OAAO,EAAE,MAAM,CAAC,CAAC;IAClC,OAAO,IAAI,CAAC,MAAM,GAAG,KAAK,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,MAAM,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AACrE,CAAC;AASD,iDAAiD;AACjD,MAAM,UAAU,gBAAgB,CAAC,OAAuB;IACvD,MAAM,OAAO,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;IACrE,MAAM,KAAK,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;IACtE,MAAM,MAAM,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,CAC9F,IAAI,CACJ,CAAC;IACF,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;AACnC,CAAC"}

package/packages/two-phase-review/dist/state.d.ts

@@ -0,0 +1,72 @@
+/**
+ * The persisted state of the two-phase workflow.
+ *
+ * The state survives a restart and a compaction, so the phase, the task start
+ * revision, the review scope, the finished chunks and the open findings are
+ * never lost.
+ */
+import type { ReviewChunk, ReviewFinding, ReviewSignal, TwoPhasePhase, TwoPhaseState } from "./types.js";
+/** The directory the state files live in. */
+export declare const TWO_PHASE_STATE_DIR: string;
+/** A fresh state for a task. */
+export declare function createState(taskId: string, startRevision?: string | null): TwoPhaseState;
+/** Make a file name safe for the file system. */
+export declare function safeFileName(taskId: string): string;
+/** Repair a state that was read from disk. */
+export declare function normalizeState(value: unknown, taskId: string): TwoPhaseState;
+/** The state of one task on disk. */
+export declare class TwoPhaseStateStore {
+    private readonly dir;
+    constructor(dir?: string);
+    /** The file the state of the task lives in. */
+    path(taskId: string): string;
+    /**
+     * Read the state of the task.
+     *
+     * `null` means that there is no state. A state that exists but cannot be
+     * read is an error: it must not be mistaken for a fresh task, because that
+     * would lose the revision the task started at and the progress of the
+     * review.
+     */
+    read(taskId: string): TwoPhaseState | null;
+    /**
+     * Write the state of the task.
+     *
+     * A failing write is reported to the caller: the runtime decides whether
+     * the session may continue without the state, the test sees the reason.
+     */
+    write(state: TwoPhaseState): TwoPhaseState;
+    /** Remove the state of the task. */
+    clear(taskId: string): void;
+}
+/** Move to a phase, never backwards. */
+export declare function moveToPhase(state: TwoPhaseState, phase: TwoPhasePhase): TwoPhaseState;
+/** Record a review signal. The phase does not change. */
+export declare function recordSignal(state: TwoPhaseState, signal: ReviewSignal): TwoPhaseState;
+/** The implementation is done: the review waits for its scope. */
+export declare function transitionToReviewPending(state: TwoPhaseState, scopeFiles: string[]): TwoPhaseState;
+/** The review starts with the given chunks. */
+export declare function startReview(state: TwoPhaseState, chunks: ReviewChunk[]): TwoPhaseState;
+/** Mark a review chunk as finished. */
+export declare function markChunkDone(state: TwoPhaseState, chunkId: string): TwoPhaseState;
+/** Record a confirmed finding. */
+export declare function recordFinding(state: TwoPhaseState, finding: ReviewFinding): TwoPhaseState;
+/**
+ * The review found something: the fixes are now the work.
+ *
+ * The fixes start when the review is finished: a fix phase before the review
+ * ran would hide the work that is still open.
+ */
+export declare function transitionToReviewFixes(state: TwoPhaseState): TwoPhaseState;
+/** Every chunk is finished. */
+export declare function allChunksDone(state: TwoPhaseState): boolean;
+/**
+ * The work is finished.
+ *
+ * The task is only complete when the review ran over every chunk. The
+ * implementation phase never completes the task on its own.
+ */
+export declare function markComplete(state: TwoPhaseState): TwoPhaseState;
+/** Is a review queued? */
+export declare function hasQueuedReview(state: TwoPhaseState): boolean;
+//# sourceMappingURL=state.d.ts.map

package/packages/two-phase-review/dist/state.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"state.d.ts","sourceRoot":"","sources":["../src/state.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAKH,OAAO,KAAK,EACX,WAAW,EACX,aAAa,EACb,YAAY,EACZ,aAAa,EACb,aAAa,EACb,MAAM,YAAY,CAAC;AAEpB,6CAA6C;AAC7C,eAAO,MAAM,mBAAmB,QAI/B,CAAC;AAaF,gCAAgC;AAChC,wBAAgB,WAAW,CAAC,MAAM,EAAE,MAAM,EAAE,aAAa,GAAE,MAAM,GAAG,IAAW,GAAG,aAAa,CAW9F;AAED,iDAAiD;AACjD,wBAAgB,YAAY,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,CAEnD;AAkBD,8CAA8C;AAC9C,wBAAgB,cAAc,CAAC,KAAK,EAAE,OAAO,EAAE,MAAM,EAAE,MAAM,GAAG,aAAa,CAgB5E;AAkCD,qCAAqC;AACrC,qBAAa,kBAAkB;IAClB,OAAO,CAAC,QAAQ,CAAC,GAAG;IAAhC,YAA6B,GAAG,GAAE,MAA4B,EAAI;IAElE,+CAA+C;IAC/C,IAAI,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,CAE3B;IAED;;;;;;;OAOG;IACH,IAAI,CAAC,MAAM,EAAE,MAAM,GAAG,aAAa,GAAG,IAAI,CAyBzC;IAED;;;;;OAKG;IACH,KAAK,CAAC,KAAK,EAAE,aAAa,GAAG,aAAa,CAiBzC;IAED,oCAAoC;IACpC,KAAK,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI,CAM1B;CACD;AAED,wCAAwC;AACxC,wBAAgB,WAAW,CAAC,KAAK,EAAE,aAAa,EAAE,KAAK,EAAE,aAAa,GAAG,aAAa,CAGrF;AAED,yDAAyD;AACzD,wBAAgB,YAAY,CAAC,KAAK,EAAE,aAAa,EAAE,MAAM,EAAE,YAAY,GAAG,aAAa,CAUtF;AAED,kEAAkE;AAClE,wBAAgB,yBAAyB,CACxC,KAAK,EAAE,aAAa,EACpB,UAAU,EAAE,MAAM,EAAE,GAClB,aAAa,CAEf;AAED,+CAA+C;AAC/C,wBAAgB,WAAW,CAAC,KAAK,EAAE,aAAa,EAAE,MAAM,EAAE,WAAW,EAAE,GAAG,aAAa,CAEtF;AAED,uCAAuC;AACvC,wBAAgB,aAAa,CAAC,KAAK,EAAE,aAAa,EAAE,OAAO,EAAE,MAAM,GAAG,aAAa,CAKlF;AAED,kCAAkC;AAClC,wBAAgB,aAAa,CAAC,KAAK,EAAE,aAAa,EAAE,OAAO,EAAE,aAAa,GAAG,aAAa,CAEzF;AAED;;;;;GAKG;AACH,wBAAgB,uBAAuB,CAAC,KAAK,EAAE,aAAa,GAAG,aAAa,CAI3E;AAED,+BAA+B;AAC/B,wBAAgB,aAAa,CAAC,KAAK,EAAE,aAAa,GAAG,OAAO,CAE3D;AAED;;;;;GAKG;AACH,wBAAgB,YAAY,CAAC,KAAK,EAAE,aAAa,GAAG,aAAa,CAIhE;AAED,0BAA0B;AAC1B,wBAAgB,eAAe,CAAC,KAAK,EAAE,aAAa,GAAG,OAAO,CAE7D"}