pi-harness-runtime 1.1.38 → 1.1.41

package/harness/langchain/daemon.ts

@@ -48,6 +48,7 @@ import {
 import { NotificationCenter } from "../../packages/notification/dist/notification-center.js";
 
 import { invokeWithSurgeRetry, type SurgePolicy } from "./surge.js";
+import type { LoopWidget } from "./widget.js";
 import { createLoopCheckpointer } from "./checkpointer.js";
 
 import {
@@ -111,6 +112,12 @@ export interface DaemonConfig {
 	 * Default: none (no tunnel management)
 	 */
 	tunnelCommand?: string;
+	/**
+	 * Optional widget for TUI / status-line display.
+	 * When set, the daemon updates the widget at each loop transition
+	 * (mirrors pi-lens footer style: !NW ●ME).
+	 */
+	widget?: LoopWidget;
 }
 
 // ─── TriggeredTask ──────────────────────────────────────────────────────────
@@ -668,6 +675,7 @@ export class LoopDaemon {
 	private readonly busWatcher: BusWatcher;
 	private readonly bdWatcher: BdTasksWatcher;
 	private readonly tunnelMonitor: TunnelMonitor | null;
+	private readonly widget: LoopWidget | null;
 
 	/** Currently running tasks (taskId → RunningTask) */
 	private readonly running = new Map<string, RunningTask>();
@@ -691,6 +699,7 @@ export class LoopDaemon {
 			workspace: config.workspace ?? getHerdrWorkspace(),
 			notificationConfig: config.notificationConfig ?? undefined,
 			tunnelCommand: config.tunnelCommand,
+			widget: config.widget,
 		} as Required<DaemonConfig>;
 
 		this.agentId = this.config.agentId;
@@ -718,6 +727,7 @@ export class LoopDaemon {
 		}
 
 		this.inboxWatcher = new InboxWatcher(this.inboxDir, this.config.pollMs);
+		this.widget = this.config.widget ?? null;
 		this.busWatcher = new BusWatcher(this.bus, this.config.pollMs);
 		this.bdWatcher = new BdTasksWatcher(this.config.pollMs);
 
@@ -879,11 +889,12 @@ export class LoopDaemon {
 							maxIterations: this.config.maxIterations,
 						}));
 
-			// Inject transition publishing into onStep
+			// Inject transition publishing into onStep (also drives the widget)
 			const originalOnStep = deps.onStep;
 			deps.onStep = (step, state) => {
 				originalOnStep?.(step, state);
 				this._publishTransition(loopId, step, state);
+				this._updateWidget(step, state);
 			};
 
 			// ── Run the graph (surge-aware: 529/overloaded pauses auto-resume) ──
@@ -952,6 +963,17 @@ export class LoopDaemon {
 
 			log(`Loop finished: ${verdict} after ${iterations} iteration(s)`);
 
+			// Update widget on loop completion
+			if (this.widget) {
+				this.widget.setComplete(
+					verdict === "approved"
+						? "approved"
+						: verdict === "blocked"
+							? "rejected"
+							: "max_iterations",
+				);
+			}
+
 			// ── Gate check after blocked verdict ────────────────────────────────
 			if (
 				verdict === "blocked" &&
@@ -1034,6 +1056,57 @@ export class LoopDaemon {
 		}
 	}
 
+	/**
+	 * Drive the TUI widget through loop transitions.
+	 * Called from onStep within _runTask.
+	 */
+	private _updateWidget(step: string, state: LoopState): void {
+		const w = this.widget;
+		if (!w) return;
+
+		switch (step) {
+			case "plan": {
+				w.setPhase("planning", "GPT planning");
+				break;
+			}
+			case "write": {
+				w.setPhase("writing", "MiniMax coding");
+				// After a write step, bump the iteration counter
+				w.startIteration(state.iteration, this.config.maxIterations);
+				break;
+			}
+			case "review": {
+				w.setPhase("reviewing", "GPT reviewing");
+				// Process review comments — one record per file
+				const comments = state.review?.comments ?? [];
+				if (comments.length === 0) break;
+
+				// Group blocking comments by file (severity: "critical" = blocking)
+				const byFile = new Map<string, number>();
+				for (const c of comments) {
+					if (c.severity === "critical") {
+						const prev = byFile.get(c.file ?? "") ?? 0;
+						byFile.set(c.file ?? "", prev + 1);
+					}
+				}
+				for (const [file, count] of byFile) {
+					if (count > 0) {
+						w.recordBlockers(file, count);
+					}
+				}
+				// Files with no blocking comments pass
+				const blockingFiles = new Set(byFile.keys());
+				for (const c of comments) {
+					const f = c.file ?? "";
+					if (!blockingFiles.has(f) && f) {
+						w.recordReviewPass(f);
+					}
+				}
+				break;
+			}
+		}
+	}
+
 	private _reviewReportPath(loopId: string, iteration: number): string {
 		return `${ensureHerdrWorkspace().reviews}/${loopId}-review-${iteration}.md`;
 	}

package/harness/langchain/graph.ts

@@ -24,6 +24,7 @@ import {
 	type ReviewVerdict,
 	ReviewVerdictSchema,
 } from "./agents.js";
+import type { LoopWidget } from "./widget.js";
 
 // ─── State ──────────────────────────────────────────────────────────────────
 
@@ -58,6 +59,8 @@ export interface LoopDeps {
 	review: (plan: string, code: string) => Promise<ReviewVerdict>;
 	maxIterations: number;
 	onStep?: (step: string, state: LoopState) => void;
+	/** Optional widget for TUI / status-line display (mirrors pi-lens footer style). */
+	widget?: LoopWidget;
 }
 
 // ─── Node implementations ───────────────────────────────────────────────────

package/harness/langchain/widget.test.ts

@@ -0,0 +1,251 @@
+/**
+ * LoopWidget tests — T14
+ *
+ * Run:
+ *   bun test harness/langchain/widget.test.ts
+ */
+
+import { describe, it, beforeEach } from "node:test";
+import assert from "node:assert";
+import { LoopWidget } from "./widget.js";
+
+// ─── Fixtures ────────────────────────────────────────────────────────────────
+
+const stubTheme = {
+	fg: (color: string, s: string): string => {
+		const codes: Record<string, string> = {
+			dim: `\x1b[2m${s}\x1b[0m`,
+			error: `\x1b[31m${s}\x1b[0m`,
+			warning: `\x1b[33m${s}\x1b[0m`,
+			success: `\x1b[32m${s}\x1b[0m`,
+			accent: `\x1b[36m${s}\x1b[0m`,
+		};
+		return codes[color] ?? s;
+	},
+};
+
+describe("T14 — LoopWidget", () => {
+	let widget: LoopWidget;
+
+	beforeEach(() => {
+		widget = new LoopWidget();
+	});
+
+	// ─── Idle state ────────────────────────────────────────────────────────
+
+	it("starts in idle phase", () => {
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.match(lines[0], /idle/);
+		assert.match(lines[0], /harness/);
+	});
+
+	// ─── Phase transitions ──────────────────────────────────────────────────
+
+	it("setPhase changes the phase label", () => {
+		widget.setPhase("writing");
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.match(lines[0], /coding/);
+	});
+
+	it("setPhase with custom label uses the label", () => {
+		widget.setPhase("planning", "GPT planning");
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.match(lines[0], /GPT planning/);
+	});
+
+	it("surge-pause shows detail line", () => {
+		widget.setSurgePause(new Date(Date.now() + 30 * 60_000)); // 30 min
+		const lines = widget.renderWidget(80, stubTheme);
+		// Label is "surge (in 30m)"
+		assert.ok(lines.some((l) => l.includes("surge") && l.includes("in 30m")));
+	});
+
+	it("setError shows error detail", () => {
+		widget.setError("model timeout");
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.ok(lines.some((l) => l.includes("error")));
+		assert.ok(lines.some((l) => l.includes("model timeout")));
+	});
+
+	it("setComplete approved shows ✓ loop complete", () => {
+		widget.setComplete("approved");
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.match(lines[0], /loop complete/);
+	});
+
+	it("setComplete rejected shows ✗ loop rejected", () => {
+		widget.setComplete("rejected");
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.match(lines[0], /loop rejected/);
+	});
+
+	it("setComplete max_iterations shows iteration count", () => {
+		widget.setComplete("max_iterations");
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.match(lines[0], /max iterations/);
+	});
+
+	// ─── Iteration tracking ────────────────────────────────────────────────
+
+	it("startIteration sets iteration and max", () => {
+		widget.startIteration(3, 5);
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.match(lines[0], /iter 3\/5/);
+	});
+
+	it("startIteration resets per-file counters but keeps file records", () => {
+		widget.recordWrite("src/a.ts");
+		widget.recordBlockers("src/a.ts", 2);
+		widget.startIteration(2, 5);
+		// Files accumulate across iterations (same codebase); only counters reset.
+		// After reset, a.ts shows with 0 write steps and 0 blockers.
+		const lines = widget.renderWidget(80, stubTheme);
+		const fileLines = lines.filter((l) => l.includes("a.ts"));
+		assert.ok(fileLines.length > 0, "file should still appear");
+		// No blocker count in the file row (reset to 0)
+		assert.ok(
+			!fileLines.some((l) => l.includes("!2")),
+			"blocker count should be reset",
+		);
+	});
+
+	// ─── File record tracking ──────────────────────────────────────────────
+
+	it("recordWrite shows file in widget", () => {
+		widget.recordWrite("src/foo.ts");
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.ok(lines.some((l) => l.includes("foo.ts")));
+	});
+
+	it("recordWrite accumulates across calls", () => {
+		widget.recordWrite("src/bar.ts");
+		widget.recordWrite("src/bar.ts");
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.ok(lines.some((l) => l.includes("bar.ts") && l.includes("✍2")));
+	});
+
+	it("recordBlockers shows blocker count", () => {
+		widget.recordBlockers("src/bad.ts", 2);
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.ok(lines.some((l) => l.includes("bad.ts") && l.includes("!2")));
+	});
+
+	it("recordReviewPass clears blockers and increments passes", () => {
+		widget.recordBlockers("src/ok.ts", 1);
+		widget.recordReviewPass("src/ok.ts");
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.ok(lines.some((l) => l.includes("ok.ts") && l.includes("🔍1")));
+		// No blocker count
+		assert.ok(
+			!lines.some(
+				(l) => l.includes("ok.ts") && l.includes("!") && !l.includes("🔍"),
+			),
+		);
+	});
+
+	// ─── Summary counts ────────────────────────────────────────────────────
+
+	it("no errors/warnings shows ✓", () => {
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.ok(lines[0].includes("✓") || lines[0].includes("harness"));
+	});
+
+	it("errors shown as ●NE", () => {
+		widget.recordBlockers("src/err.ts", 3);
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.ok(lines.some((l) => l.includes("●3E")));
+	});
+
+	// ─── Surge pause ──────────────────────────────────────────────────────
+
+	it("setSurgePause shows reset time in minutes/hours", () => {
+		const resetAt = new Date(Date.now() + 90 * 60_000); // 90 minutes → "in 1h 30m"
+		widget.setSurgePause(resetAt);
+		const lines = widget.renderWidget(80, stubTheme);
+		const surgeLine = lines.find((l) => l.includes("surge"));
+		assert.ok(surgeLine !== undefined);
+		assert.match(surgeLine, /\(in \d+h/); // "in 1h 30m" matches
+	});
+
+	it("setSurgePause shows 'now' for past dates", () => {
+		const resetAt = new Date(Date.now() - 1000);
+		widget.setSurgePause(resetAt);
+		const lines = widget.renderWidget(80, stubTheme);
+		// Label format: "surge (now)"
+		assert.ok(lines.some((l) => l.includes("surge") && l.includes("(now)")));
+	});
+
+	// ─── Console fallback ─────────────────────────────────────────────────
+
+	it("toConsoleString returns human-readable output", () => {
+		widget.startIteration(2, 5);
+		widget.setPhase("writing", "coding");
+		widget.recordWrite("src/test.ts");
+		const output = widget.toConsoleString();
+		assert.match(output, /harness/);
+		assert.match(output, /iter 2\/5/);
+		assert.match(output, /coding/);
+		assert.match(output, /test\.ts/);
+	});
+
+	// ─── Width / truncation ───────────────────────────────────────────────
+
+	it("truncates long file names with …", () => {
+		widget.recordWrite(
+			"/very/long/path/to/a/very/long/file/name/that/exceeds/width.ts",
+		);
+		const lines = widget.renderWidget(40, stubTheme);
+		for (const line of lines) {
+			const stripped = line.replace(/\x1b\[[0-9;]*m/g, "");
+			assert.ok(stripped.length <= 41, `line too long: ${stripped}`);
+		}
+	});
+
+	// ─── reset() ─────────────────────────────────────────────────────────
+
+	it("reset() clears all state", () => {
+		widget.startIteration(2, 5);
+		widget.setPhase("writing");
+		widget.recordWrite("src/a.ts");
+		widget.reset();
+		const lines = widget.renderWidget(80, stubTheme);
+		assert.match(lines[0], /idle/);
+		assert.ok(!lines.some((l) => l.includes("a.ts")));
+	});
+
+	// ─── makeRenderer ─────────────────────────────────────────────────────
+
+	it("makeRenderer returns factory and invalidate", () => {
+		const { factory, invalidate } = widget.makeRenderer();
+		assert.equal(typeof factory, "function");
+		assert.equal(typeof invalidate, "function");
+	});
+
+	it("factory returns render + invalidate + dispose", () => {
+		const { factory } = widget.makeRenderer();
+		const comp = factory({} as any, stubTheme as any);
+		assert.equal(typeof comp.render, "function");
+		assert.equal(typeof comp.invalidate, "function");
+		assert.equal(typeof comp.dispose, "function");
+	});
+
+	it("factory render() returns widget lines", () => {
+		widget.setPhase("planning");
+		const { factory } = widget.makeRenderer();
+		const comp = factory({} as any, stubTheme as any);
+		const lines = comp.render(80);
+		assert.ok(Array.isArray(lines));
+		assert.ok(lines.length > 0);
+	});
+
+	// ─── getLoopWidget singleton ────────────────────────────────────────────
+
+	it("getLoopWidget returns the same instance", () => {
+		// Dynamic import to avoid module caching issues
+		import("./widget.js").then((m) => {
+			const a = m.getLoopWidget();
+			const b = m.getLoopWidget();
+			assert.strictEqual(a, b);
+		});
+	});
+});