pi-harness-runtime 1.1.346 → 1.1.348

package/packages/notification/test/pending-question.test.ts

@@ -0,0 +1,331 @@
+/**
+ * Pending Question Controller Tests
+ * 
+ * Tests for the pending question detection, state management,
+ * and channel delivery logic.
+ */
+
+import { describe, it, expect, beforeEach } from "bun:test";
+import { 
+  PendingQuestionController,
+  createPendingQuestionController,
+  type QuestionKind,
+} from "../src/pending-question.js";
+
+describe("PendingQuestionController", () => {
+  let controller: PendingQuestionController;
+
+  beforeEach(() => {
+    controller = createPendingQuestionController({
+      evaluationDelayMs: 5 * 60 * 1000,
+      jevEnabled: false,
+    });
+  });
+
+  describe("detectQuestion", () => {
+    it("should detect 'Want me to implement X?' pattern", () => {
+      const result = controller.detectQuestion(
+        "I've finished the toggle implementation. Want me to implement the toggle buttons now?"
+      );
+      expect(result.detected).toBe(true);
+      expect(result.questionText).toContain("Want me to implement");
+      expect(result.kind).toBe("approval");
+      expect(result.isRoutine).toBe(false);
+    });
+
+    it("should detect 'Would you like me to add X?' pattern", () => {
+      const result = controller.detectQuestion(
+        "Would you like me to add the persistence layer next?"
+      );
+      expect(result.detected).toBe(true);
+      expect(result.questionText).toContain("Would you like me to add");
+      expect(result.kind).toBe("approval");
+    });
+
+    it("should detect 'Shall I start X?' pattern", () => {
+      const result = controller.detectQuestion(
+        "Shall I start with the database schema?"
+      );
+      expect(result.detected).toBe(true);
+      expect(result.kind).toBe("approval");
+    });
+
+    it("should detect 'Should I implement X?' pattern", () => {
+      const result = controller.detectQuestion(
+        "Should I implement the SQLite persistence now?"
+      );
+      expect(result.detected).toBe(true);
+      expect(result.kind).toBe("approval");
+    });
+
+    it("should detect question ending with ? with request + intent words", () => {
+      const result = controller.detectQuestion(
+        "Should I continue with the next task?"
+      );
+      expect(result.detected).toBe(true);
+      expect(result.kind).toBe("routine");
+      expect(result.isRoutine).toBe(true);
+    });
+
+    it("should detect 'Should I continue?' as routine", () => {
+      const result = controller.detectQuestion("Should I continue?");
+      expect(result.detected).toBe(true);
+      expect(result.isRoutine).toBe(true);
+    });
+
+    it("should NOT detect quoted questions", () => {
+      const result = controller.detectQuestion(
+        `Here's an example: "Want me to implement this?" - that's what I might ask.`
+      );
+      // The quoted question should not be detected
+      expect(result.detected).toBe(false);
+    });
+
+    it("should NOT detect rhetorical questions in code blocks", () => {
+      const result = controller.detectQuestion(
+        `\`\`\`\n// Want me to implement this?\n\`\`\`\nThe code above shows what we need.`
+      );
+      expect(result.detected).toBe(false);
+    });
+
+    it("should detect clarification questions", () => {
+      const result = controller.detectQuestion(
+        "Do you mean the SQLite or the file-based approach?"
+      );
+      expect(result.detected).toBe(true);
+      expect(result.kind).toBe("clarification");
+    });
+
+    it("should NOT detect plain progress statements", () => {
+      const result = controller.detectQuestion(
+        "I've implemented the toggle buttons and they work correctly."
+      );
+      expect(result.detected).toBe(false);
+    });
+
+    it("should detect 'Can I proceed?' as routine", () => {
+      const result = controller.detectQuestion("Can I proceed with the next step?");
+      expect(result.detected).toBe(true);
+      expect(result.isRoutine).toBe(true);
+    });
+  });
+
+  describe("question lifecycle", () => {
+    it("should create and track a pending question", () => {
+      const question = controller.createQuestion({
+        text: "Want me to implement the toggle buttons now?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      expect(question.requestId).toBeDefined();
+      expect(question.state).toBe("pending");
+      expect(question.kind).toBe("approval");
+      expect(controller.hasPendingQuestion()).toBe(true);
+      expect(controller.getCurrentQuestion()).toEqual(question);
+    });
+
+    it("should resolve a question with 'yes'", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.resolve({ resolution: "yes", by: "user" });
+
+      expect(controller.isResolved()).toBe(true);
+      expect(controller.getResolution()).toBe("yes");
+      expect(controller.getCurrentQuestion()?.state).toBe("resolved");
+      expect(controller.getCurrentQuestion()?.resolvedBy).toBe("user");
+    });
+
+    it("should resolve a question with 'no'", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.resolve({ resolution: "no", by: "user" });
+
+      expect(controller.getResolution()).toBe("no");
+    });
+
+    it("should cancel a question", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.cancel("Session switched");
+
+      expect(controller.hasPendingQuestion()).toBe(false);
+      expect(controller.getCurrentQuestion()).toBe(null);
+    });
+
+    it("should start evaluation", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.startEvaluation();
+
+      expect(controller.getCurrentQuestion()?.state).toBe("evaluating");
+    });
+  });
+
+  describe("channel delivery state", () => {
+    it("should update Telegram delivery state", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.updateDeliveryState("telegram", true);
+      
+      const question = controller.getCurrentQuestion();
+      expect(question?.deliveryState.telegram?.delivered).toBe(true);
+      expect(question?.deliveryState.telegram?.deliveredAt).toBeDefined();
+      expect(question?.userNotified).toBe(true);
+    });
+
+    it("should update LINE delivery state", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.updateDeliveryState("line", true);
+      
+      const question = controller.getCurrentQuestion();
+      expect(question?.deliveryState.line?.delivered).toBe(true);
+    });
+
+    it("should track delivery errors", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.updateDeliveryState("telegram", false, "Network error");
+      
+      const question = controller.getCurrentQuestion();
+      expect(question?.deliveryState.telegram?.delivered).toBe(false);
+      expect(question?.deliveryState.telegram?.error).toBe("Network error");
+    });
+  });
+
+  describe("suppress completion", () => {
+    it("should suppress completion when pending question exists", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      expect(controller.shouldSuppressCompletion()).toBe(true);
+    });
+
+    it("should NOT suppress completion when no pending question", () => {
+      expect(controller.shouldSuppressCompletion()).toBe(false);
+    });
+
+    it("should NOT suppress completion when question is resolved", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.resolve({ resolution: "yes", by: "user" });
+
+      expect(controller.shouldSuppressCompletion()).toBe(false);
+    });
+  });
+
+  describe("callbacks", () => {
+    it("should call user answer callback on resolution", () => {
+      let callbackCalled = false;
+      let callbackResolution = "";
+      
+      controller.onUserAnswer((question, answer) => {
+        callbackCalled = true;
+        callbackResolution = answer;
+      });
+
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.resolve({ resolution: "yes", by: "user" });
+
+      expect(callbackCalled).toBe(true);
+      expect(callbackResolution).toBe("yes");
+    });
+  });
+
+  describe("cleanup", () => {
+    it("should clean up old resolved questions", () => {
+      controller.createQuestion({
+        text: "Want me to implement X?",
+        sessionId: "test-session",
+        workspacePath: "/test",
+        kind: "approval",
+      });
+
+      controller.resolve({ resolution: "yes", by: "user" });
+
+      // Wait a tiny bit then cleanup with 0ms max age
+      setTimeout(() => {
+        controller.cleanup(0);
+        const questions = controller.getAllQuestions();
+        expect(questions.length).toBe(0);
+      }, 10);
+    });
+  });
+});
+
+describe("Question detection edge cases", () => {
+  let controller: PendingQuestionController;
+
+  beforeEach(() => {
+    controller = createPendingQuestionController();
+  });
+
+  it("should handle multiple questions in one message", () => {
+    const result = controller.detectQuestion(
+      "I've finished task 1. Want me to implement the toggle buttons now? Should I continue with the next task?"
+    );
+    // Should detect the approval question, not the routine continuation
+    expect(result.detected).toBe(true);
+    expect(result.kind).toBe("approval");
+  });
+
+  it("should handle mixed content with questions", () => {
+    const result = controller.detectQuestion(
+      `Here's what I did:\n1. Implemented toggle state\n2. Added persistence\n\nWant me to continue with the UI?`
+    );
+    expect(result.detected).toBe(true);
+    expect(result.kind).toBe("approval");
+  });
+});

package/packages/observability/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/observability",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Comprehensive observability system with structured logging, tracing, metrics, and alerting",
   "type": "module",
   "main": "./dist/index.js",

package/packages/okf-indexer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/okf-indexer",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "OKF document indexer for SKILL.md files (RFC-0106)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/paperclip-integration/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/paperclip-integration",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Paperclip API integration: poll agent inbox, route tasks to pi.dev, Telegram alerts",
   "type": "module",
   "main": "./dist/index.js",

package/packages/performance-optimizer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/performance-optimizer",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Performance optimization analyzer for pi-harness runtime (RFC-0056)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/permission-mode/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/permission-mode",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "description": "Runtime permission modes for pi-harness - Supervised/Auto/Full-access",
   "main": "./dist/index.js",

package/packages/privilege-broker/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/privilege-broker",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Privilege Broker — capability registry and command executor for autonomous runtime (RFC-0101 §7)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/project-analyzer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/project-analyzer",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Project analysis system for pi-harness-runtime - detects frameworks, rules, and project structure",
   "type": "module",
   "main": "./dist/index.js",

package/packages/project-bootstrap/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/project-bootstrap",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Project scaffolding from typed ProjectSpec",
   "type": "module",
   "main": "./dist/index.js",

package/packages/projection-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/projection-engine",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/prompt-compiler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/prompt-compiler",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Deterministic prompt compiler for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/prompt-versioning/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/prompt-versioning",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "description": "Version control for prompts with rollback support (RFC-0019)",
   "main": "dist/index.js",

package/packages/provider-adapter-sdk/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/provider-adapter-sdk",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "SDK for building, testing, and registering AI provider adapters",
   "type": "module",
   "main": "./dist/index.js",

package/packages/provider-router/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/provider-router",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Enhanced Provider Router for pi-harness-runtime — intelligent routing with capabilities, costs, and quotas",
   "type": "module",
   "main": "./dist/provider-router.js",

package/packages/provider-selector/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/provider-selector",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Multi-Provider Selector — route requests by cost, quality, and latency (RFC-0012)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/providers/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/providers",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "pi-harness-runtime — providers",
   "type": "module",
   "main": "./dist/index.js",

package/packages/qdrant-skills/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/qdrant-skills",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Qdrant vector search integration for Hermes-style skill system",
   "type": "module",
   "main": "./dist/index.js",

package/packages/quota-manager/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/quota-manager",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "pi-harness-runtime — quota-manager",
   "type": "module",
   "main": "./dist/index.js",

package/packages/rate-limiter/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/rate-limiter",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "description": "Rate limiting with token bucket algorithm (RFC-0023)",
   "main": "dist/index.js",

package/packages/react-vite-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/react-vite-plugin",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "React/Vite framework analysis — components, config, TypeScript setup",
   "type": "module",
   "main": "./dist/index.js",

package/packages/relay/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/relay",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "description": "Cloud relay for remote access - T3 Connect style for pi-harness",
   "main": "./dist/index.js",

package/packages/release-manager/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/release-manager",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "description": "Release management for pi-harness",
   "main": "dist/index.js",

package/packages/requirement-compiler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/requirement-compiler",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Compiles raw requirements into validated CompiledRequirement with ambiguity detection and risk tagging",
   "type": "module",
   "main": "./dist/index.js",

package/packages/runtime/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/runtime",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "pi-harness-runtime — runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/scheduler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/scheduler",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "pi-harness-runtime — scheduler",
   "type": "module",
   "main": "./dist/index.js",

package/packages/scheduler-adapter/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/scheduler-adapter",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Scheduler Adapter — cron, systemd, launchd, internal adapters for autonomous runtime (RFC-0101 §6)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/session/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/session",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Session management system for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/session-api/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/session-api",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/session-export/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/session-export",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/shared-context/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/shared-context",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "pi-harness-runtime — shared-context",
   "type": "module",
   "main": "./dist/index.js",

package/packages/skill-mcp-client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/skill-mcp-client",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "MCP client for Skills SaaS backend",
   "type": "module",
   "main": "./dist/index.js",

package/packages/skill-registry/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/skill-registry",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Skill Registry for pi-harness-runtime — dynamic skill discovery and invocation",
   "type": "module",
   "main": "./dist/index.js",

package/packages/skills/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/skills",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "File-based skill system with pi.dev compatibility and Hermes self-improvement",
   "type": "module",
   "main": "src/index.ts",

package/packages/sprint-planner/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/sprint-planner",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "description": "Sprint planning engine for pi-harness",
   "main": "dist/index.js",

package/packages/subscription-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/subscription-engine",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/task-compiler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/task-compiler",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "Task Compiler for pi-harness-runtime — produces deterministic task DAG from CompiledRequirement",
   "type": "module",
   "main": "./dist/index.js",

package/packages/telegram/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/telegram",
-  "version": "1.1.346",
+  "version": "1.1.348",
   "description": "pi-harness-runtime — Telegram inbound/outbound",
   "type": "module",
   "main": "./src/index.js",