pi-harness-runtime 1.1.319 → 1.1.321

package/packages/durable-review/test/acceptance.test.ts

@@ -0,0 +1,335 @@
+/**
+ * Durable Review Acceptance Tests
+ *
+ * Tests per wiki/pi-durable-reviewer-minimax-plan.md acceptance criteria.
+ */
+
+import { describe, it, before, after, mock } from "node:test";
+import assert from "node:assert";
+import { randomUUID } from "node:crypto";
+import { existsSync, mkdirSync, unlinkSync, rmdirSync, writeFileSync, readFileSync } from "node:fs";
+import { join } from "node:path";
+import { validateAndHashRequest, hashWorkspaceKey, getWorkspaceDir } from "../dist/service.js";
+import { validateReviewRequest } from "../dist/types.js";
+import {
+  tryAcquireOwnership,
+  releaseOwnership,
+  startWorker,
+  stopWorker,
+  checkWorkerReady,
+} from "../dist/worker.js";
+import { handleReviewRequest, cancelJob, getJobStatus } from "../dist/worker.js";
+
+// Test workspace path
+const TEST_WORKSPACE = "/tmp/durable-review-test-" + Date.now();
+const TEST_DB_DIR = join(process.env.HOME || "/tmp", ".pi-harness-runtime", "durable");
+
+describe("Acceptance Tests", () => {
+  // Setup
+  before(() => {
+    mkdirSync(TEST_WORKSPACE, { recursive: true });
+  });
+
+  after(() => {
+    // Cleanup test workspace
+    try {
+      const workspaceKey = hashWorkspaceKey(TEST_WORKSPACE);
+      const testDir = getWorkspaceDir(workspaceKey);
+      const lockPath = join(testDir, ".worker.lock");
+      if (existsSync(lockPath)) unlinkSync(lockPath);
+    } catch {
+      // ignore cleanup errors
+    }
+  });
+
+  // --- Feature Disabled ---
+  describe("Feature disabled", () => {
+    it("validateReviewRequest works without HARNESS_DURABLE_REVIEW flag", () => {
+      const request = {
+        requestId: "test-1",
+        input: { workspacePath: TEST_WORKSPACE },
+      };
+      const validation = validateReviewRequest(request);
+      assert.strictEqual(validation.valid, true);
+    });
+  });
+
+  // --- Duplicate Admission ---
+  describe("Duplicate admission", () => {
+    it("same request returns same input hash", () => {
+      const request1 = {
+        requestId: "test-dup",
+        input: { workspacePath: TEST_WORKSPACE, diff: "test diff" },
+      };
+      const request2 = {
+        requestId: "test-dup",
+        input: { workspacePath: TEST_WORKSPACE, diff: "test diff" },
+      };
+
+      const val1 = validateAndHashRequest(request1);
+      const val2 = validateAndHashRequest(request2);
+
+      assert.strictEqual(val1.valid, true);
+      assert.strictEqual(val2.valid, true);
+      assert.strictEqual(val1.inputHash, val2.inputHash);
+    });
+
+    it("different input returns different hash", () => {
+      const request1 = {
+        requestId: "test-1",
+        input: { workspacePath: TEST_WORKSPACE, diff: "diff 1" },
+      };
+      const request2 = {
+        requestId: "test-2",
+        input: { workspacePath: TEST_WORKSPACE, diff: "diff 2" },
+      };
+
+      const val1 = validateAndHashRequest(request1);
+      const val2 = validateAndHashRequest(request2);
+
+      assert.strictEqual(val1.valid, true);
+      assert.strictEqual(val2.valid, true);
+      assert.notStrictEqual(val1.inputHash, val2.inputHash);
+    });
+  });
+
+  // --- Ownership ---
+  describe("Ownership race", () => {
+    it("first worker acquires ownership", async () => {
+      const workspaceKey = hashWorkspaceKey(TEST_WORKSPACE);
+      const workerId1 = "worker-1-" + randomUUID().slice(0, 8);
+
+      const result = await tryAcquireOwnership(workspaceKey, workerId1);
+      assert.strictEqual(result.acquired, true);
+
+      // Cleanup
+      await releaseOwnership(workspaceKey, workerId1);
+    });
+
+    it("second worker cannot acquire if first holds lock", async () => {
+      const workspaceKey = hashWorkspaceKey(TEST_WORKSPACE);
+      const workerId1 = "worker-1-" + randomUUID().slice(0, 8);
+      const workerId2 = "worker-2-" + randomUUID().slice(0, 8);
+
+      // First acquires
+      const result1 = await tryAcquireOwnership(workspaceKey, workerId1);
+      assert.strictEqual(result1.acquired, true);
+
+      // Second should fail
+      const result2 = await tryAcquireOwnership(workspaceKey, workerId2);
+      assert.strictEqual(result2.acquired, false);
+      assert.ok(result2.existingOwner);
+
+      // Cleanup
+      await releaseOwnership(workspaceKey, workerId1);
+    });
+
+    it("stale owner is recoverable", async () => {
+      const workspaceKey = hashWorkspaceKey(TEST_WORKSPACE);
+      const workerId1 = "stale-worker-" + randomUUID().slice(0, 8);
+      const workerId2 = "new-worker-" + randomUUID().slice(0, 8);
+
+      // First acquires
+      const result1 = await tryAcquireOwnership(workspaceKey, workerId1);
+      assert.strictEqual(result1.acquired, true);
+
+      // Simulate stale lock by directly writing old timestamp
+      const lockPath = join(getWorkspaceDir(workspaceKey), ".worker.lock");
+      const staleLock = {
+        workerId: workerId1,
+        pid: 99999,
+        startedAt: Date.now() - 120_000, // 2 minutes ago
+      };
+      writeFileSync(lockPath, JSON.stringify(staleLock));
+
+      // New worker should be able to acquire
+      const result2 = await tryAcquireOwnership(workspaceKey, workerId2);
+      assert.strictEqual(result2.acquired, true);
+
+      // Cleanup
+      await releaseOwnership(workspaceKey, workerId2);
+    });
+  });
+
+  // --- Worker Lifecycle ---
+  describe("Worker lifecycle", () => {
+    it("startWorker succeeds", async () => {
+      const result = await startWorker(TEST_WORKSPACE);
+      assert.strictEqual(result.success, true);
+      assert.ok(result.workerId);
+      assert.ok(result.workspaceKey);
+    });
+
+    it("checkWorkerReady returns ready", async () => {
+      const ready = await checkWorkerReady();
+      assert.strictEqual(ready.ready, true);
+      assert.ok(ready.workerId);
+    });
+
+    it("stopWorker succeeds", async () => {
+      await stopWorker();
+      const ready = await checkWorkerReady();
+      assert.strictEqual(ready.ready, false);
+    });
+  });
+
+  // --- Request Handling ---
+  describe("Request handling", () => {
+    before(async () => {
+      await startWorker(TEST_WORKSPACE);
+    });
+
+    after(async () => {
+      await stopWorker();
+    });
+
+    it("handleReviewRequest creates job", async () => {
+      const request = {
+        requestId: "test-review-" + randomUUID().slice(0, 8),
+        input: { workspacePath: TEST_WORKSPACE },
+      };
+
+      const result = await handleReviewRequest(request);
+      assert.ok(result.jobId);
+      assert.strictEqual(result.status.status, "queued");
+    });
+
+    it("handleReviewRequest rejects invalid request", async () => {
+      const invalidRequest = {
+        requestId: "",
+        input: { workspacePath: TEST_WORKSPACE },
+      };
+
+      await assert.rejects(
+        async () => handleReviewRequest(invalidRequest as any),
+        /requestId is required/
+      );
+    });
+
+    it("getJobStatus returns null for unknown job", async () => {
+      const status = await getJobStatus("unknown-job-id");
+      assert.strictEqual(status, null);
+    });
+
+    it("cancelJob returns false for unknown job", async () => {
+      const cancelled = await cancelJob("unknown-job-id");
+      assert.strictEqual(cancelled, false);
+    });
+  });
+
+  // --- Input Stability ---
+  describe("Input stability", () => {
+    it("validateAndHashRequest produces stable hash", () => {
+      const request = {
+        requestId: "test-hash",
+        input: { workspacePath: TEST_WORKSPACE, diff: "stable diff content" },
+      };
+
+      const result1 = validateAndHashRequest(request);
+      const result2 = validateAndHashRequest(request);
+
+      assert.strictEqual(result1.inputHash, result2.inputHash);
+    });
+
+    it("different content produces different hash", () => {
+      const request1 = {
+        requestId: "test",
+        input: { workspacePath: TEST_WORKSPACE, diff: "content A" },
+      };
+      const request2 = {
+        requestId: "test",
+        input: { workspacePath: TEST_WORKSPACE, diff: "content B" },
+      };
+
+      const result1 = validateAndHashRequest(request1);
+      const result2 = validateAndHashRequest(request2);
+
+      assert.notStrictEqual(result1.inputHash, result2.inputHash);
+    });
+  });
+
+  // --- Workspace Path ---
+  describe("Workspace path handling", () => {
+    it("hashWorkspaceKey produces consistent hash", () => {
+      const hash1 = hashWorkspaceKey("/some/path");
+      const hash2 = hashWorkspaceKey("/some/path");
+      assert.strictEqual(hash1, hash2);
+    });
+
+    it("different paths produce different hashes", () => {
+      const hash1 = hashWorkspaceKey("/path/a");
+      const hash2 = hashWorkspaceKey("/path/b");
+      assert.notStrictEqual(hash1, hash2);
+    });
+
+    it("getWorkspaceDir creates directory", () => {
+      const workspaceKey = hashWorkspaceKey(TEST_WORKSPACE);
+      const dir = getWorkspaceDir(workspaceKey);
+      assert.ok(existsSync(dir));
+    });
+  });
+
+  // --- Validation ---
+  describe("Request validation", () => {
+    it("rejects missing requestId", () => {
+      const result = validateReviewRequest({
+        requestId: "",
+        input: { workspacePath: TEST_WORKSPACE },
+      });
+      assert.strictEqual(result.valid, false);
+      assert.ok(result.error?.includes("requestId"));
+    });
+
+    it("rejects missing workspacePath", () => {
+      const result = validateReviewRequest({
+        requestId: "test",
+        input: { workspacePath: "" },
+      });
+      assert.strictEqual(result.valid, false);
+      assert.ok(result.error?.includes("workspacePath"));
+    });
+
+    it("accepts valid request", () => {
+      const result = validateReviewRequest({
+        requestId: "test",
+        input: { workspacePath: TEST_WORKSPACE },
+      });
+      assert.strictEqual(result.valid, true);
+      assert.ok(result.request);
+    });
+
+    it("applies default maxPasses and maxToolCalls", () => {
+      const result = validateReviewRequest({
+        requestId: "test",
+        input: { workspacePath: TEST_WORKSPACE },
+      });
+      assert.strictEqual(result.valid, true);
+      assert.strictEqual(result.request?.maxPasses, 5);
+      assert.strictEqual(result.request?.maxToolCalls, 100);
+    });
+
+    it("respects provided maxPasses and maxToolCalls", () => {
+      const result = validateReviewRequest({
+        requestId: "test",
+        input: { workspacePath: TEST_WORKSPACE },
+        maxPasses: 10,
+        maxToolCalls: 200,
+      });
+      assert.strictEqual(result.valid, true);
+      assert.strictEqual(result.request?.maxPasses, 10);
+      assert.strictEqual(result.request?.maxToolCalls, 200);
+    });
+  });
+
+  // --- Storage Failure ---
+  describe("Storage failure handling", () => {
+    it("validateAndHashRequest handles missing workspace path gracefully", () => {
+      const result = validateAndHashRequest({
+        requestId: "test",
+        input: { workspacePath: "/nonexistent/path/that/cannot/exist" },
+      });
+      assert.strictEqual(result.valid, true); // Validation passes, hash is computed
+      assert.ok(result.workspaceKey);
+    });
+  });
+});

package/packages/e2e-tester/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/e2e-tester",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "WebMCP-powered E2E testing for pi-harness - natural language test scenarios",
   "type": "module",
   "main": "./dist/index.js",

package/packages/evaluation-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/evaluation-engine",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Evaluation engine for pi-harness runtime (RFC-0057)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/evaluation-runner/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/evaluation-runner",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "type": "module",
   "description": "Framework-agnostic evaluation framework for AI outputs (RFC-0020)",
   "main": "dist/index.js",

package/packages/event-bus/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/event-bus",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/event-store/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/event-store",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/experience-replay/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/experience-replay",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Experience replay for debugging and reproducibility (RFC-0059)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/feedback-collector/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/feedback-collector",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "type": "module",
   "description": "Collect and aggregate human/automated feedback (RFC-0021)",
   "main": "dist/index.js",

package/packages/file-copy-helper/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@moocoding/file-copy-helper",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Injects cp/sudo cp rule when user asks to mimic/copy files",
   "type": "module",
   "main": "dist/index.js",

package/packages/framework-detector/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/framework-detector",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Framework detection system for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/framework-plugin-sdk/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/framework-plugin-sdk",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Framework plugin SDK for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/frappe-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/frappe-plugin",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Frappe/ERPNext framework analysis — DocTypes, hooks, bench sites, site config",
   "type": "module",
   "main": "./dist/index.js",

package/packages/generic-web-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/generic-web-plugin",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Generic web framework analysis — REST/GraphQL endpoints, OpenAPI, auth",
   "type": "module",
   "main": "./dist/index.js",

package/packages/health-monitor/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/health-monitor",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "type": "module",
   "description": "Health monitoring and auto-healing",
   "main": "dist/index.js",

package/packages/intent-analyzer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/intent-analyzer",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/jev-judge/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/jev-judge",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Jev Judge - Structured decision model for agent routing, E2E testing, and automated decisions",
   "type": "module",
   "main": "./dist/index.js",

package/packages/knowledge-graph/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/knowledge-graph",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Knowledge Graph extraction and provenance linking for SKILL.md files",
   "type": "module",
   "main": "./dist/index.js",

package/packages/knowledge-retrieval/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/knowledge-retrieval",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Knowledge retrieval via TencentDB-Agent-Memory MCP (RFC-0105)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/laravel-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/laravel-plugin",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Laravel framework analysis — artisan commands, Eloquent models, Blade",
   "type": "module",
   "main": "./dist/index.js",

package/packages/learning-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/learning-engine",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Learning engine for extracting lessons from runtime execution (RFC-0058)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/mcp-adapter/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/mcp-adapter",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "type": "module",
   "description": "MCP server adapter for pi-harness — exposes harness capabilities as MCP tools/resources/prompts (RFC-0068)",
   "main": "dist/index.js",

package/packages/memory-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/memory-engine",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Memory engine with OKF integration for durable knowledge management (RFC-0060)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/milestone-manager/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/milestone-manager",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Track milestones and alerts when items are at risk",
   "type": "module",
   "main": "./dist/index.js",

package/packages/model-registry/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/model-registry",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Model Registry for pi-harness-runtime — centralized model metadata with pricing",
   "type": "module",
   "main": "./dist/index.js",

package/packages/nextjs-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/nextjs-plugin",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Next.js framework detection and analysis for pi-harness-runtime (RFC-0062)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/notification/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/notification",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "pi-harness-runtime — notification",
   "type": "module",
   "main": "./dist/index.js",

package/packages/observability/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/observability",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Comprehensive observability system with structured logging, tracing, metrics, and alerting",
   "type": "module",
   "main": "./dist/index.js",

package/packages/okf-indexer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/okf-indexer",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "OKF document indexer for SKILL.md files (RFC-0106)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/paperclip-integration/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/paperclip-integration",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Paperclip API integration: poll agent inbox, route tasks to pi.dev, Telegram alerts",
   "type": "module",
   "main": "./dist/index.js",

package/packages/performance-optimizer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/performance-optimizer",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Performance optimization analyzer for pi-harness runtime (RFC-0056)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/privilege-broker/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/privilege-broker",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Privilege Broker — capability registry and command executor for autonomous runtime (RFC-0101 §7)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/project-analyzer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/project-analyzer",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Project analysis system for pi-harness-runtime - detects frameworks, rules, and project structure",
   "type": "module",
   "main": "./dist/index.js",

package/packages/project-bootstrap/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/project-bootstrap",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Project scaffolding from typed ProjectSpec",
   "type": "module",
   "main": "./dist/index.js",

package/packages/projection-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/projection-engine",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/prompt-compiler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/prompt-compiler",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "description": "Deterministic prompt compiler for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/prompt-versioning/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/prompt-versioning",
-  "version": "1.1.319",
+  "version": "1.1.321",
   "type": "module",
   "description": "Version control for prompts with rollback support (RFC-0019)",
   "main": "dist/index.js",