pi-harness-runtime 1.1.232 → 1.1.233

package/packages/jev-judge/src/continuation-controller.ts

@@ -1,5 +1,4 @@
-import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-import type { TodoItem } from "./todo-provider.js";
+import type { TodoItem, TodoContext } from "./todo-provider.js";
 import { createTodoProvider } from "./todo-provider.js";
 
 /**
@@ -45,7 +44,8 @@ export interface ContinuationState {
 	continuationQueued: boolean;
 	userPaused: boolean;
 	lastSteerMessage: string | null;
-	steerAttempts: number;
+	steerAttemptsForCurrentItem: number;
+	lastItemContinued: number | null;
 	lastEvaluationResult: string | null;
 }
 
@@ -65,7 +65,7 @@ export interface ContinuationResult {
  * Evaluates todo state on agent_settled and determines next action.
  */
 export class TodoContinuationController {
-	private pi: ExtensionAPI;
+	private ctx: TodoContext;
 	private config: Required<ContinuationConfig>;
 	private todoProvider: ReturnType<typeof createTodoProvider>;
 
@@ -79,13 +79,14 @@ export class TodoContinuationController {
 		continuationQueued: false,
 		userPaused: false,
 		lastSteerMessage: null,
-		steerAttempts: 0,
+		steerAttemptsForCurrentItem: 0,
+		lastItemContinued: null,
 		lastEvaluationResult: null,
 	};
 
-	constructor(pi: ExtensionAPI, config?: ContinuationConfig) {
-		this.pi = pi;
-		this.todoProvider = createTodoProvider(pi);
+	constructor(ctx: TodoContext, config?: ContinuationConfig) {
+		this.ctx = ctx;
+		this.todoProvider = createTodoProvider(ctx);
 		this.config = {
 			jevFallbackMinWaitMs: 5 * 60 * 1000, // 5 minutes
 			routineThreshold: 0.7,
@@ -96,78 +97,99 @@ export class TodoContinuationController {
 	}
 
 	/**
-	 * Register lifecycle hooks
+	 * Check if continuation is allowed (not paused, session idle)
 	 */
-	register(): void {
-		debugLog("TodoContinuation", "Registering hooks");
-
-		// Session start - reset state
-		this.pi.on("session_start", () => {
-			this.reset();
-			debugLog("TodoContinuation", "Session started");
-		});
-
-		// Agent settled - evaluate continuation
-		this.pi.on("agent_settled", () => {
-			this.evaluateContinuation().catch(() => {
-				// Silently handle errors
-			});
-		});
-
-		// User input - reset pause state
-		this.pi.on("message_start", (event) => {
-			const msg = event.message as { role?: string };
-			if (msg?.role === "user") {
-				this.state.userPaused = false;
-				this.state.lastSteerMessage = null;
-			}
-		});
-
-		// Session shutdown - cleanup
-		this.pi.on("session_shutdown", () => {
-			this.cleanup();
-		});
-
-		// Tool call - track mutations that might invalidate state
-		this.pi.on("tool_call", (event) => {
-			// Increment generation on edits
-			if (["write", "edit", "bash"].includes(event.toolName)) {
-				this.state.generation++;
-				this.state.continuationQueued = false;
-			}
-		});
-
-		debugLog("TodoContinuation", "Lifecycle hooks registered");
+	private canContinue(): boolean {
+		if (this.state.userPaused) {
+			debugLog("TodoContinuation", "User paused, not continuing");
+			return false;
+		}
+		if (this.ctx.isIdle?.() === false) {
+			debugLog("TodoContinuation", "Session not idle, not continuing");
+			return false;
+		}
+		if (this.ctx.hasPendingMessages?.()) {
+			debugLog("TodoContinuation", "Pending messages, not continuing");
+			return false;
+		}
+		return true;
 	}
 
 	/**
 	 * Public method to evaluate and execute continuation
 	 * Called by external handlers (e.g., agent_settled)
+	 * Checks blockers and pause BEFORE selecting a task
 	 */
 	async decide(): Promise<ContinuationResult> {
+		// 1. Check if continuation is allowed
+		if (!this.canContinue()) {
+			return { action: "stop", reason: "paused or session not idle" };
+		}
+
+		// 2. Check provider availability
 		const availability = await this.todoProvider.availability();
 		if (!availability.available) {
 			debugLog("TodoContinuation", "Provider unavailable:", availability.error);
-			return { action: "stop", reason: availability.error };
+			return { action: "stop", reason: availability.error ?? "provider unavailable" };
 		}
 
-		const inProgress = await this.todoProvider.getInProgress();
-		const pending = await this.todoProvider.getPending();
+		// 3. Get todo state (throws on branch read failure)
+		let inProgress: TodoItem[];
+		let pending: TodoItem[];
+		let blocked: TodoItem[];
+		try {
+			inProgress = await this.todoProvider.getInProgress();
+			pending = await this.todoProvider.getPending();
+			blocked = await this.todoProvider.getBlocked();
+		} catch (err) {
+			const msg = err instanceof Error ? err.message : String(err);
+			debugLog("TodoContinuation", "Failed to read todos:", msg);
+			return { action: "stop", reason: `todo read failed: ${msg}` };
+		}
 
-		if (inProgress.length > 0) {
-			return { action: "continue", nextItemId: inProgress[0].id };
+		// 4. Check for blocked items FIRST (before selecting any task)
+		if (blocked.length > 0) {
+			debugLog("TodoContinuation", "Tasks blocked:", blocked.length);
+			return { action: "blocked", question: `${blocked.length} task(s) blocked` };
 		}
 
-		if (pending.length > 0) {
-			return { action: "continue", nextItemId: pending[0].id };
+		// 5. Continue in-progress work if any
+		if (inProgress.length > 0) {
+			const item = inProgress[0];
+			
+			// Reset counter if switching to a different task
+			if (this.state.lastItemContinued !== item.id) {
+				this.state.steerAttemptsForCurrentItem = 0;
+				this.state.lastItemContinued = item.id;
+			}
+			
+			// Check per-task attempt limit
+			if (this.state.steerAttemptsForCurrentItem >= this.config.maxSteerAttempts) {
+				return { action: "stop", reason: `max attempts (${this.config.maxSteerAttempts}) reached for task ${item.id}` };
+			}
+			
+			return { action: "continue", nextItemId: item.id };
 		}
 
-		// No work remaining - but check for blocked items
-		const blocked = await this.todoProvider.getBlocked();
-		if (blocked.length > 0) {
-			return { action: "blocked", question: `${blocked.length} task(s) blocked` };
+		// 6. Continue pending work if any
+		if (pending.length > 0) {
+			const item = pending[0];
+			
+			// Reset counter if switching to a different task
+			if (this.state.lastItemContinued !== item.id) {
+				this.state.steerAttemptsForCurrentItem = 0;
+				this.state.lastItemContinued = item.id;
+			}
+			
+			// Check per-task attempt limit
+			if (this.state.steerAttemptsForCurrentItem >= this.config.maxSteerAttempts) {
+				return { action: "stop", reason: `max attempts (${this.config.maxSteerAttempts}) reached for task ${item.id}` };
+			}
+			
+			return { action: "continue", nextItemId: item.id };
 		}
 
+		// 7. No work remaining
 		return { action: "stop", reason: "No pending tasks" };
 	}
 
@@ -239,13 +261,19 @@ export class TodoContinuationController {
 	/**
 	 * Continue a specific todo item
 	 */
-	private async continueItem(item: TodoItem): Promise<void> {
-		if (this.state.steerAttempts >= this.config.maxSteerAttempts) {
-			debugLog("TodoContinuation", "Max steer attempts reached");
+	async continueItem(item: TodoItem): Promise<void> {
+		// Increment attempts for this specific item
+		if (this.state.lastItemContinued !== item.id) {
+			this.state.steerAttemptsForCurrentItem = 0;
+			this.state.lastItemContinued = item.id;
+		}
+
+		if (this.state.steerAttemptsForCurrentItem >= this.config.maxSteerAttempts) {
+			debugLog("TodoContinuation", "Max steer attempts reached for item", item.id);
 			return;
 		}
 
-		this.state.steerAttempts++;
+		this.state.steerAttemptsForCurrentItem++;
 		this.state.continuationQueued = true;
 
 		// Build continuation message
@@ -258,7 +286,7 @@ export class TodoContinuationController {
 
 		// Send continuation message via Pi API
 		try {
-			await (this.pi as ExtensionAPI & { sendUserMessage: (content: string, opts?: { deliverAs?: string }) => Promise<void> }).sendUserMessage(message, { deliverAs: "steer" });
+			await this.ctx.sendUserMessage?.(message, { deliverAs: "steer" });
 		} catch (err) {
 			debugLog("TodoContinuation", "Failed to send continuation:", String(err));
 			this.state.continuationQueued = false;
@@ -269,12 +297,18 @@ export class TodoContinuationController {
 	 * Steer to continue a todo item
 	 */
 	async steerToContinue(itemId: number): Promise<void> {
-		if (this.state.steerAttempts >= this.config.maxSteerAttempts) {
-			debugLog("TodoContinuation", "Max steer attempts reached");
+		// Increment attempts for this specific item
+		if (this.state.lastItemContinued !== itemId) {
+			this.state.steerAttemptsForCurrentItem = 0;
+			this.state.lastItemContinued = itemId;
+		}
+
+		if (this.state.steerAttemptsForCurrentItem >= this.config.maxSteerAttempts) {
+			debugLog("TodoContinuation", "Max steer attempts reached for item", itemId);
 			return;
 		}
 
-		this.state.steerAttempts++;
+		this.state.steerAttemptsForCurrentItem++;
 		this.state.continuationQueued = true;
 
 		const snapshot = await this.todoProvider.getSnapshot();
@@ -290,7 +324,7 @@ export class TodoContinuationController {
 
 		// Send continuation message via Pi API
 		try {
-			await (this.pi as ExtensionAPI & { sendUserMessage: (content: string, opts?: { deliverAs?: string }) => Promise<void> }).sendUserMessage(message, { deliverAs: "steer" });
+			await this.ctx.sendUserMessage?.(message, { deliverAs: "steer" });
 		} catch (err) {
 			debugLog("TodoContinuation", "Failed to send steer:", String(err));
 			this.state.continuationQueued = false;
@@ -318,7 +352,7 @@ export class TodoContinuationController {
 	/**
 	 * Reset state for new session
 	 */
-	private reset(): void {
+	_reset(): void {
 		this.state = {
 			sessionId: `session-${Date.now()}`,
 			generation: 0,
@@ -329,7 +363,8 @@ export class TodoContinuationController {
 			continuationQueued: false,
 			userPaused: false,
 			lastSteerMessage: null,
-			steerAttempts: 0,
+			steerAttemptsForCurrentItem: 0,
+			lastItemContinued: null,
 			lastEvaluationResult: null,
 		};
 	}
@@ -337,7 +372,7 @@ export class TodoContinuationController {
 	/**
 	 * Cleanup on shutdown
 	 */
-	private cleanup(): void {
+	_cleanup(): void {
 		debugLog("TodoContinuation", "Cleaning up");
 		this.state.continuationQueued = false;
 		this.state.generation++;
@@ -356,13 +391,12 @@ export class TodoContinuationController {
 }
 
 /**
- * Create and register a todo continuation controller
+ * Create a todo continuation controller
+ * Note: Caller is responsible for registering event handlers with the proper context
  */
 export function createTodoContinuation(
-	pi: ExtensionAPI,
+	ctx: TodoContext,
 	config?: ContinuationConfig
 ): TodoContinuationController {
-	const controller = new TodoContinuationController(pi, config);
-	controller.register();
-	return controller;
+	return new TodoContinuationController(ctx, config);
 }

package/packages/jev-judge/src/todo-provider.ts

@@ -7,6 +7,20 @@
 
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 
+/**
+ * Minimal context interface for todo provider
+ * Contains only the properties needed to read session branch and send messages
+ */
+export interface TodoContext {
+	sessionManager: {
+		getSessionId(): string;
+		getBranch(): Iterable<unknown>;
+	};
+	isIdle?: () => boolean;
+	hasPendingMessages?: () => boolean;
+	sendUserMessage?: (content: string, opts?: { deliverAs?: string }) => Promise<void>;
+}
+
 /**
  * Todo item status
  */
@@ -175,22 +189,15 @@ export class MockTodoProvider implements TodoProvider {
 	}
 }
 
-/**
- * Extended ExtensionAPI type with sessionManager (not in base type but available at runtime)
- */
-interface PiExtensionAPI extends ExtensionAPI {
-	sessionManager: {
-		getSessionId(): string;
-		getBranch(): Iterable<unknown>;
-	};
-}
+
 
 /**
  * Create a todo provider that reads from rpiv-todo state via session branch
  */
-export function createTodoProvider(pi?: ExtensionAPI): TodoProvider {
-	if (pi && "sessionManager" in pi) {
-		return new PiTodoProvider(pi as PiExtensionAPI);
+export function createTodoProvider(ctx?: TodoContext | ExtensionAPI): TodoProvider {
+	// Accept either TodoContext or ExtensionAPI with sessionManager
+	if (ctx && "sessionManager" in ctx) {
+		return new PiTodoProvider(ctx as TodoContext);
 	}
 	return new PiUnavailableTodoProvider();
 }
@@ -200,15 +207,16 @@ export function createTodoProvider(pi?: ExtensionAPI): TodoProvider {
  * Replicates rpiv-todo's replayFromBranch logic to access todo state
  */
 class PiTodoProvider implements TodoProvider {
-	private pi: PiExtensionAPI;
+	private ctx: TodoContext;
 	private _revision = 0;
+	private _lastError: string | null = null;
 
-	constructor(pi: PiExtensionAPI) {
-		this.pi = pi;
+	constructor(ctx: TodoContext) {
+		this.ctx = ctx;
 	}
 
 	async availability(): Promise<TodoAvailability> {
-		if (!this.pi.sessionManager) {
+		if (!this.ctx.sessionManager) {
 			return {
 				available: false,
 				error: "Session manager not available",
@@ -229,13 +237,15 @@ class PiTodoProvider implements TodoProvider {
 
 	/**
 	 * Get todo state from session branch (replicates rpiv-todo's replayFromBranch)
+	 * Returns null if branch read fails (don't silently return empty state)
 	 */
-	private getTodoState(): { tasks: TodoItem[]; nextId: number } {
+	private getTodoState(): { tasks: TodoItem[]; nextId: number } | null {
 		let fromEntries: { tasks: TodoItem[]; nextId: number } | undefined;
 		let fromToolResults: { tasks: TodoItem[]; nextId: number } | undefined;
 
 		try {
-			for (const entry of this.pi.sessionManager.getBranch()) {
+			const branch = this.ctx.sessionManager.getBranch();
+			for (const entry of branch) {
 				const e = entry as {
 					type?: string;
 					customType?: string;
@@ -259,19 +269,28 @@ class PiTodoProvider implements TodoProvider {
 				fromToolResults = { tasks: (msg.details as { tasks: TodoItem[] }).tasks.map(t => ({ ...t })), nextId: (msg.details as { nextId: number }).nextId };
 			}
 		} catch (err) {
-			// Fall through to EMPTY_STATE on error
+			// Return null on error - don't silently return empty state
+			this._lastError = err instanceof Error ? err.message : String(err);
+			return null;
 		}
 
 		// Prefer custom entries (more authoritative), fall back to tool results
-		return fromEntries ?? fromToolResults ?? { tasks: [], nextId: 1 };
+		this._lastError = null;
+		return fromEntries ?? fromToolResults ?? null;
 	}
 
 	async getSnapshot(): Promise<TodoSnapshot> {
 		this._revision++;
 		const state = this.getTodoState();
+		
+		// If branch read failed, throw to indicate unavailable state
+		if (state === null) {
+			throw new Error(`Todo state unavailable: ${this._lastError ?? "branch read failed"}`);
+		}
+		
 		return {
 			items: state.tasks,
-			sessionId: this.pi.sessionManager.getSessionId() ?? "unknown",
+			sessionId: this.ctx.sessionManager.getSessionId() ?? "unknown",
 			revision: this._revision,
 			createdAt: new Date(),
 		};

package/packages/jev-judge/src/typesafe-provider.ts

@@ -258,12 +258,21 @@ export class TypeSafeJudge {
 
     switch (answer.type) {
       case "noul":
-        // FIX: Use answer.noul (not probability) per TypeSafe API spec
+        // FIX: Validate noul value is present and in range [0, 1]
+        if (answer.noul === undefined || answer.noul === null) {
+          throw new Error(`TypeSafe API: missing noul value for question "${questionId}"`);
+        }
+        if (typeof answer.noul !== "number" || isNaN(answer.noul)) {
+          throw new Error(`TypeSafe API: invalid noul value for question "${questionId}": ${JSON.stringify(answer.noul)}`);
+        }
+        if (answer.noul < 0 || answer.noul > 1) {
+          throw new Error(`TypeSafe API: noul value out of range [0,1] for question "${questionId}": ${answer.noul}`);
+        }
         response = {
           type: "noul",
-          noul: answer.noul ?? 0.5,
+          noul: answer.noul,
         };
-        probability = answer.noul ?? 0.5;
+        probability = answer.noul;
         break;
 
       case "choice":

package/packages/knowledge-graph/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/knowledge-graph",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Knowledge Graph extraction and provenance linking for SKILL.md files",
   "type": "module",
   "main": "./dist/index.js",

package/packages/knowledge-retrieval/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/knowledge-retrieval",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Knowledge retrieval via TencentDB-Agent-Memory MCP (RFC-0105)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/laravel-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/laravel-plugin",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Laravel framework analysis — artisan commands, Eloquent models, Blade",
   "type": "module",
   "main": "./dist/index.js",

package/packages/learning-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/learning-engine",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Learning engine for extracting lessons from runtime execution (RFC-0058)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/mcp-adapter/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/mcp-adapter",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "type": "module",
   "description": "MCP server adapter for pi-harness — exposes harness capabilities as MCP tools/resources/prompts (RFC-0068)",
   "main": "dist/index.js",

package/packages/memory-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/memory-engine",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Memory engine with OKF integration for durable knowledge management (RFC-0060)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/milestone-manager/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/milestone-manager",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Track milestones and alerts when items are at risk",
   "type": "module",
   "main": "./dist/index.js",

package/packages/model-registry/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/model-registry",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Model Registry for pi-harness-runtime — centralized model metadata with pricing",
   "type": "module",
   "main": "./dist/index.js",

package/packages/nextjs-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/nextjs-plugin",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Next.js framework detection and analysis for pi-harness-runtime (RFC-0062)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/notification/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/notification",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "pi-harness-runtime — notification",
   "type": "module",
   "main": "./dist/index.js",

package/packages/observability/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/observability",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Comprehensive observability system with structured logging, tracing, metrics, and alerting",
   "type": "module",
   "main": "./dist/index.js",

package/packages/okf-indexer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/okf-indexer",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "OKF document indexer for SKILL.md files (RFC-0106)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/paperclip-integration/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/paperclip-integration",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Paperclip API integration: poll agent inbox, route tasks to pi.dev, Telegram alerts",
   "type": "module",
   "main": "./dist/index.js",

package/packages/performance-optimizer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/performance-optimizer",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Performance optimization analyzer for pi-harness runtime (RFC-0056)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/privilege-broker/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/privilege-broker",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Privilege Broker — capability registry and command executor for autonomous runtime (RFC-0101 §7)",
   "type": "module",
   "main": "./dist/index.js",

package/packages/project-analyzer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/project-analyzer",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Project analysis system for pi-harness-runtime - detects frameworks, rules, and project structure",
   "type": "module",
   "main": "./dist/index.js",

package/packages/project-bootstrap/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/project-bootstrap",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Project scaffolding from typed ProjectSpec",
   "type": "module",
   "main": "./dist/index.js",

package/packages/projection-engine/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/projection-engine",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "type": "module",
   "main": "src/index.ts",
   "exports": {

package/packages/prompt-compiler/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/prompt-compiler",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Deterministic prompt compiler for pi-harness-runtime",
   "type": "module",
   "main": "./dist/index.js",

package/packages/prompt-versioning/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/prompt-versioning",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "type": "module",
   "description": "Version control for prompts with rollback support (RFC-0019)",
   "main": "dist/index.js",

package/packages/provider-adapter-sdk/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi/provider-adapter-sdk",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "SDK for building, testing, and registering AI provider adapters",
   "type": "module",
   "main": "./dist/index.js",

package/packages/provider-router/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-harness/provider-router",
-  "version": "1.1.232",
+  "version": "1.1.233",
   "description": "Enhanced Provider Router for pi-harness-runtime — intelligent routing with capabilities, costs, and quotas",
   "type": "module",
   "main": "./dist/provider-router.js",