pi-harness-runtime 0.10.7 → 0.10.12

package/packages/write-review/src/gate.ts

@@ -11,157 +11,159 @@ import type { WriteReviewStatus } from "./types.js";
  * Commands that trigger build gate
  */
 const BUILD_COMMANDS = [
-  "bench build",
-  "npm run build",
-  "yarn build",
-  "pnpm build",
-  "bun run build",
-  "npm run dev",
-  "yarn dev",
-  "pnpm dev",
-  "./build",
-  "make build",
-  "gradle build",
-  "mvn package",
-  "dotnet build",
-  "cargo build",
-  "go build",
-  "python manage.py migrate",
-  "bench migrate",
-  "bench --site",
+	"bench build",
+	"npm run build",
+	"yarn build",
+	"pnpm build",
+	"bun run build",
+	"npm run dev",
+	"yarn dev",
+	"pnpm dev",
+	"./build",
+	"make build",
+	"gradle build",
+	"mvn package",
+	"dotnet build",
+	"cargo build",
+	"go build",
+	"python manage.py migrate",
+	"bench migrate",
+	"bench --site",
 ];
 
 /**
  * Check if a command is a build command
  */
 export function isBuildCommand(command: string): boolean {
-  const lower = command.toLowerCase().trim();
-  return BUILD_COMMANDS.some((cmd) => lower.includes(cmd.toLowerCase()));
+	const lower = command.toLowerCase().trim();
+	return BUILD_COMMANDS.some((cmd) => lower.includes(cmd.toLowerCase()));
 }
 
 /**
  * Gate result
  */
 export interface GateResult {
-  allowed: boolean;
-  reason?: string;
-  currentPhase?: string;
-  message?: string;
+	allowed: boolean;
+	reason?: string;
+	currentPhase?: string;
+	message?: string;
 }
 
 /**
  * Check if build is allowed
  */
 export function checkBuildGate(
-  command: string,
-  blackboard: WriteReviewBlackboard
+	command: string,
+	blackboard: WriteReviewBlackboard,
 ): GateResult {
-  if (!isBuildCommand(command)) {
-    return { allowed: true };
-  }
-
-  const status = blackboard.load();
-  if (!status) {
-    // No review session - allow build
-    return { allowed: true };
-  }
-
-  if (status.phase === "approved") {
-    return {
-      allowed: true,
-      currentPhase: status.phase,
-      message: "Build allowed - review approved.",
-    };
-  }
-
-  return {
-    allowed: false,
-    reason: "REVIEW_NOT_APPROVED",
-    currentPhase: status.phase,
-    message: `Build blocked. Current review phase: ${status.phase}. Wait for "APPROVED" verdict.`,
-  };
+	if (!isBuildCommand(command)) {
+		return { allowed: true };
+	}
+
+	const status = blackboard.load();
+	if (!status) {
+		// No review session - allow build
+		return { allowed: true };
+	}
+
+	if (status.phase === "approved") {
+		return {
+			allowed: true,
+			currentPhase: status.phase,
+			message: "Build allowed - review approved.",
+		};
+	}
+
+	return {
+		allowed: false,
+		reason: "REVIEW_NOT_APPROVED",
+		currentPhase: status.phase,
+		message: `Build blocked. Current review phase: ${status.phase}. Wait for "APPROVED" verdict.`,
+	};
 }
 
 /**
  * Format gate rejection message
  */
 export function formatGateRejection(result: GateResult): string {
-  if (result.allowed) {
-    return "";
-  }
-
-  const lines = [
-    "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━",
-    "⚠️  BUILD BLOCKED",
-    "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━",
-    "",
-    `Current Phase: ${result.currentPhase}`,
-    "",
-    "The code is under review. Build is only allowed after APPROVED verdict.",
-    "",
-    "To check status:",
-    `  cat {project}/.write-review/status.json`,
-    "",
-    "To wait for approval, do nothing. The reviewer will post the verdict.",
-    "",
-  ];
-
-  if (result.currentPhase === "changes_requested") {
-    lines.push("Reviewer requested changes. Writer agent should update the code.");
-  } else if (result.currentPhase === "reviewing") {
-    lines.push("Review is in progress. Please wait...");
-  } else if (result.currentPhase === "pending_review") {
-    lines.push("Review not started yet. Waiting for reviewer...");
-  }
-
-  return lines.join("\n");
+	if (result.allowed) {
+		return "";
+	}
+
+	const lines = [
+		"━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━",
+		"⚠️  BUILD BLOCKED",
+		"━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━",
+		"",
+		`Current Phase: ${result.currentPhase}`,
+		"",
+		"The code is under review. Build is only allowed after APPROVED verdict.",
+		"",
+		"To check status:",
+		`  cat {project}/.write-review/status.json`,
+		"",
+		"To wait for approval, do nothing. The reviewer will post the verdict.",
+		"",
+	];
+
+	if (result.currentPhase === "changes_requested") {
+		lines.push(
+			"Reviewer requested changes. Writer agent should update the code.",
+		);
+	} else if (result.currentPhase === "reviewing") {
+		lines.push("Review is in progress. Please wait...");
+	} else if (result.currentPhase === "pending_review") {
+		lines.push("Review not started yet. Waiting for reviewer...");
+	}
+
+	return lines.join("\n");
 }
 
 /**
  * Get phase emoji
  */
 export function getPhaseEmoji(phase: string): string {
-  const emojis: Record<string, string> = {
-    idle: "💤",
-    writing: "✍️",
-    pending_review: "⏳",
-    reviewing: "🔍",
-    approved: "✅",
-    blocked: "🚫",
-    changes_requested: "🔄",
-  };
-  return emojis[phase] ?? "❓";
+	const emojis: Record<string, string> = {
+		idle: "💤",
+		writing: "✍️",
+		pending_review: "⏳",
+		reviewing: "🔍",
+		approved: "✅",
+		blocked: "🚫",
+		changes_requested: "🔄",
+	};
+	return emojis[phase] ?? "❓";
 }
 
 /**
  * Format status for display
  */
 export function formatStatusDisplay(status: WriteReviewStatus): string {
-  const emoji = getPhaseEmoji(status.phase);
-  const lines = [
-    `${emoji} Write-Review Status`,
-    "",
-    `Phase: ${status.phase}`,
-    `Iteration: ${status.iteration}`,
-  ];
-
-  if (status.verdict) {
-    lines.push(`Verdict: ${status.verdict}`);
-  }
-
-  if (status.verdictMessage) {
-    lines.push("");
-    lines.push("Message:");
-    lines.push(status.verdictMessage);
-  }
-
-  if (status.codeFiles && status.codeFiles.length > 0) {
-    lines.push("");
-    lines.push("Code Files:");
-    for (const file of status.codeFiles) {
-      lines.push(`  - ${file}`);
-    }
-  }
-
-  return lines.join("\n");
+	const emoji = getPhaseEmoji(status.phase);
+	const lines = [
+		`${emoji} Write-Review Status`,
+		"",
+		`Phase: ${status.phase}`,
+		`Iteration: ${status.iteration}`,
+	];
+
+	if (status.verdict) {
+		lines.push(`Verdict: ${status.verdict}`);
+	}
+
+	if (status.verdictMessage) {
+		lines.push("");
+		lines.push("Message:");
+		lines.push(status.verdictMessage);
+	}
+
+	if (status.codeFiles && status.codeFiles.length > 0) {
+		lines.push("");
+		lines.push("Code Files:");
+		for (const file of status.codeFiles) {
+			lines.push(`  - ${file}`);
+		}
+	}
+
+	return lines.join("\n");
 }

package/packages/write-review/src/injection.ts

@@ -63,27 +63,30 @@ Only build/commit if the status shows "approved" or "phase": "approved".
  * Format hint with project path
  */
 export function formatWriteReviewHint(projectPath: string): string {
-  return WRITE_REVIEW_HINT.replace("{project}", projectPath).replace("{p}", projectPath);
+	return WRITE_REVIEW_HINT.replace("{project}", projectPath).replace(
+		"{p}",
+		projectPath,
+	);
 }
 
 /**
  * Format review reminder with project path
  */
 export function formatReviewReminder(projectPath: string): string {
-  return REVIEW_REMINDER_HINT.replace("{project}", projectPath);
+	return REVIEW_REMINDER_HINT.replace("{project}", projectPath);
 }
 
 /**
  * Get all hints to inject
  */
 export function getWriteReviewHints(projectPath: string): {
-  writeHint: string;
-  reminderHint: string;
+	writeHint: string;
+	reminderHint: string;
 } {
-  return {
-    writeHint: formatWriteReviewHint(projectPath),
-    reminderHint: formatReviewReminder(projectPath),
-  };
+	return {
+		writeHint: formatWriteReviewHint(projectPath),
+		reminderHint: formatReviewReminder(projectPath),
+	};
 }
 
 /**
@@ -93,65 +96,75 @@ import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { createBlackboard } from "./blackboard.js";
 
 export function injectWriterInstructions(
-  pi: ExtensionAPI,
-  config?: { debug?: boolean }
+	pi: ExtensionAPI,
+	config?: { debug?: boolean },
 ): void {
-  let currentProject: string | null = null;
-  let blackboard: ReturnType<typeof createBlackboard> | null = null;
-  let hintsInjected = false;
-
-  // System prompt injection
-  pi.on("before_agent_start", async (event) => {
-    const cwd = process.cwd?.() ?? "/";
-    if (cwd !== currentProject) {
-      currentProject = cwd;
-      blackboard = createBlackboard(cwd);
-      hintsInjected = false;
-    }
-
-    if (!hintsInjected && blackboard) {
-      const status = blackboard.load();
-      if (status && status.phase !== "idle") {
-        event.systemPrompt += formatWriteReviewHint(cwd);
-        if (status.phase !== "approved") {
-          event.systemPrompt += formatReviewReminder(cwd);
-        }
-        hintsInjected = true;
-        if (config?.debug) {
-          console.log(`[write-review] Hints injected for ${cwd}, phase: ${status.phase}`);
-        }
-      }
-    }
-  });
-
-  // Build gate
-  pi.on("tool_execution_end", async (event) => {
-    const toolName = (event as { tool?: { name?: string } }).tool?.name ?? "";
-    if (toolName !== "bash") return;
-
-    const result = event as { result?: { content?: string } };
-    const content = result.result?.content ?? "";
-
-    // Check for build commands
-    const buildCommands = [
-      "bench build", "npm run build", "yarn build",
-      "pnpm build", "bun run build", "make build",
-      "gradle build", "dotnet build", "cargo build",
-    ];
-    const isBuild = buildCommands.some(cmd => content.includes(cmd));
-
-    if (isBuild && blackboard) {
-      const status = blackboard.load();
-      if (status && status.phase !== "approved") {
-        result.result!.content = content + "\n\n" +
-          "⚠️ BUILD BLOCKED - Review not approved yet.\n" +
-          `Current phase: ${status.phase}\n` +
-          "Wait for APPROVED verdict before building.";
-      }
-    }
-  });
-
-  if (config?.debug) {
-    console.log("[write-review] Extension registered");
-  }
+	let currentProject: string | null = null;
+	let blackboard: ReturnType<typeof createBlackboard> | null = null;
+	let hintsInjected = false;
+
+	// System prompt injection
+	pi.on("before_agent_start", async (event) => {
+		const cwd = process.cwd?.() ?? "/";
+		if (cwd !== currentProject) {
+			currentProject = cwd;
+			blackboard = createBlackboard(cwd);
+			hintsInjected = false;
+		}
+
+		if (!hintsInjected && blackboard) {
+			const status = blackboard.load();
+			if (status && status.phase !== "idle") {
+				event.systemPrompt += formatWriteReviewHint(cwd);
+				if (status.phase !== "approved") {
+					event.systemPrompt += formatReviewReminder(cwd);
+				}
+				hintsInjected = true;
+				if (config?.debug) {
+					console.log(
+						`[write-review] Hints injected for ${cwd}, phase: ${status.phase}`,
+					);
+				}
+			}
+		}
+	});
+
+	// Build gate
+	pi.on("tool_execution_end", async (event) => {
+		const toolName = (event as { tool?: { name?: string } }).tool?.name ?? "";
+		if (toolName !== "bash") return;
+
+		const result = event as { result?: { content?: string } };
+		const content = result.result?.content ?? "";
+
+		// Check for build commands
+		const buildCommands = [
+			"bench build",
+			"npm run build",
+			"yarn build",
+			"pnpm build",
+			"bun run build",
+			"make build",
+			"gradle build",
+			"dotnet build",
+			"cargo build",
+		];
+		const isBuild = buildCommands.some((cmd) => content.includes(cmd));
+
+		if (isBuild && blackboard) {
+			const status = blackboard.load();
+			if (status && status.phase !== "approved") {
+				result.result!.content =
+					content +
+					"\n\n" +
+					"⚠️ BUILD BLOCKED - Review not approved yet.\n" +
+					`Current phase: ${status.phase}\n` +
+					"Wait for APPROVED verdict before building.";
+			}
+		}
+	});
+
+	if (config?.debug) {
+		console.log("[write-review] Extension registered");
+	}
 }