pi-gsd 1.12.4 → 2.0.1

package/.gsd/extensions/pi-gsd-hooks.ts

@@ -18,18 +18,20 @@
 
 import { execSync } from "node:child_process";
 import {
+	copyFileSync,
 	existsSync,
 	lstatSync,
 	mkdirSync,
 	readFileSync,
-	rmSync,
-	statSync,
-	symlinkSync,
+	readdirSync,
 	writeFileSync,
 } from "node:fs";
 import { homedir } from "node:os";
-import { dirname, join } from "node:path";
+import { dirname, join, relative } from "node:path";
 import type { ContextUsage, ExtensionAPI } from "@mariozechner/pi-coding-agent";
+import { processWxpTrustedContent, WxpProcessingError, readWorkflowVersionTag } from "../../src/wxp/index.js";
+import { DEFAULT_SHELL_ALLOWLIST } from "../../src/wxp/security.js";
+import type { WxpSecurityConfig } from "../../src/schemas/wxp.zod.js";
 
 /**
  * Ensures .pi/gsd/ in the project is a symlink to the harness files
@@ -37,45 +39,92 @@ import type { ContextUsage, ExtensionAPI } from "@mariozechner/pi-coding-agent";
  * if already present. Never overwrites a real directory (user may have
  * customised it).
  */
-const ensureHarnessSymlink = (cwd: string): void => {
-	try {
-		const dest = join(cwd, ".pi", "gsd");
-		// If dest exists, verify it's a valid symlink with files inside.
-		// A stale real directory (from old build or worktree) must be replaced.
-		if (existsSync(dest)) {
-			try {
-				const stat = statSync(dest);
-				if (stat.isSymbolicLink?.() || lstatSync(dest).isSymbolicLink()) return; // valid symlink, done
-				// Real directory — check if it has the expected files
-				if (existsSync(join(dest, "workflows", "execute-phase.md"))) return; // looks complete
-				// Stale/incomplete directory — remove and replace with symlink
-				rmSync(dest, { recursive: true, force: true });
-			} catch {
-				return; // can't inspect, leave it
+
+/**
+ * Copy-on-first-run harness distribution (HRN-01, HRN-03).
+ * - Detects symlinks and replaces with real file copies.
+ * - Copies missing files; never overwrites existing real files.
+ * - Silent on any failure (non-blocking).
+ */
+function copyHarness(
+	src: string,
+	dest: string,
+): { symlinksReplaced: number; filesCopied: number } {
+	let symlinksReplaced = 0;
+	let filesCopied = 0;
+
+	const walk = (srcDir: string, destDir: string): void => {
+		mkdirSync(destDir, { recursive: true });
+		const entries = readdirSync(srcDir, { withFileTypes: true });
+		for (const entry of entries) {
+			const srcPath = join(srcDir, entry.name);
+			const destPath = join(destDir, entry.name);
+			if (entry.isDirectory()) {
+				walk(srcPath, destPath);
+				continue;
 			}
+			if (existsSync(destPath)) {
+				try {
+					const st = lstatSync(destPath);
+					if (st.isSymbolicLink()) {
+						// Replace symlink with real copy (HRN-03)
+						try {
+							// unlinkSync removes the symlink without following it
+							const { unlinkSync } = require("node:fs") as typeof import("node:fs");
+							unlinkSync(destPath);
+						} catch { /* ignore */ }
+						copyFileSync(srcPath, destPath);
+						symlinksReplaced++;
+					}
+					// Real file exists → skip (HRN-01: never overwrite)
+				} catch { /* ignore */ }
+				continue;
+			}
+			try {
+				copyFileSync(srcPath, destPath);
+				filesCopied++;
+			} catch { /* ignore */ }
 		}
+	};
 
-		// Walk up from this extension file to the package root:
-		// <pkg>/.gsd/extensions/pi-gsd-hooks.ts → <pkg>
-		const extFile = typeof __filename !== "undefined" ? __filename : "";
-		const pkgRoot = join(dirname(extFile), "..", "..");
-		const harnessSrc = join(
-			pkgRoot,
-			".gsd",
-			"harnesses",
-			"pi",
-			"get-shit-done",
-		);
+	walk(src, dest);
+	return { symlinksReplaced, filesCopied };
+}
 
-		if (!existsSync(harnessSrc)) return; // package incomplete — skip silently
+/**
+ * Extract the raw arguments string from a message that was produced by pi template expansion.
+ * Pi replaces $ARGUMENTS in prompt templates with the user's typed text.
+ * After <gsd-include> resolution, $ARGUMENTS text appears as trailing plain text
+ * at the end of the message — everything after the last WXP/include tag block.
+ *
+ * Example message after pi expansion + include resolution:
+ *   [workflow content with <gsd-execute> blocks...]
+ *   16 --auto
+ *
+ * Returns: "16 --auto"
+ */
+function extractRawArguments(content: string): string {
+	// Find the last <...> block (WXP tag or include) position
+	const lastTagEnd = (() => {
+		const tagPattern = /<\/(?:gsd-[a-zA-Z0-9_-]+|shell|if|then|else|condition|args|outs|string-op|settings)>/g;
+		let lastEnd = 0;
+		let m: RegExpExecArray | null;
+		while ((m = tagPattern.exec(content)) !== null) {
+			lastEnd = m.index + m[0].length;
+		}
+		return lastEnd;
+	})();
 
-		mkdirSync(join(cwd, ".pi"), { recursive: true });
-		symlinkSync(harnessSrc, dest, "dir");
-	} catch {
-		/* silent — never block session startup */
-	}
-};
+	// Everything after the last closing tag is the trailing plain text ($ARGUMENTS expansion)
+	const trailing = content.slice(lastTagEnd).trim();
 
+	// Only return if it looks like user arguments (not a full document block)
+	// Reject if it contains markdown headings or is very long (probably included file content)
+	if (trailing.length === 0 || trailing.length > 500 || trailing.includes("\n\n\n")) {
+		return "";
+	}
+	return trailing;
+}
 
 export default function (pi: ExtensionAPI) {
 /** Resolve a single <gsd-include> match: file lookup + selector extraction. */
@@ -227,15 +276,128 @@ function resolveGsdInclude(
 			return { messages: [] }; // block LLM call
 		}
 
+		// ── WXP post-processing: run after <gsd-include> resolution (WXP-14) ──
+		// Load global + project settings (HRN-06, HRN-07)
+		const extFile2 = typeof __filename !== "undefined" ? __filename : "";
+		const pkgRoot2 = join(dirname(extFile2), "..", "..");
+
+		type SettingsFile = {
+			shellAllowlist?: string[];
+			shellBanlist?: string[];
+			trustedPaths?: Array<{ position: "project" | "pkg" | "absolute"; path: string }>;
+			untrustedPaths?: Array<{ position: "project" | "pkg" | "absolute"; path: string }>;
+			shellTimeoutMs?: number;
+		};
+		const loadSettings = (settingsPath: string): SettingsFile => {
+			try {
+				if (existsSync(settingsPath)) {
+					return JSON.parse(readFileSync(settingsPath, "utf8")) as SettingsFile;
+				}
+			} catch { /* ignore */ }
+			return {};
+		};
+		const globalSettings = loadSettings(join(homedir(), ".gsd", "pi-gsd-settings.json"));
+		const projectSettings = loadSettings(join(ctx.cwd, ".pi", "gsd", "pi-gsd-settings.json"));
+		const mergedAllowlist = [
+			...DEFAULT_SHELL_ALLOWLIST,
+			...(globalSettings.shellAllowlist ?? []),
+			...(projectSettings.shellAllowlist ?? []),
+		];
+		const wxpSecurity: WxpSecurityConfig = {
+			trustedPaths: [
+				...(globalSettings.trustedPaths ?? []),
+				...(projectSettings.trustedPaths ?? []),
+				{ position: "pkg", path: ".gsd/harnesses/pi/get-shit-done" },
+				{ position: "project", path: ".pi/gsd" },
+			],
+			untrustedPaths: [
+				...(globalSettings.untrustedPaths ?? []),
+				...(projectSettings.untrustedPaths ?? []),
+			],
+			shellAllowlist: [...new Set(mergedAllowlist)],
+			shellBanlist: [
+				...(globalSettings.shellBanlist ?? []),
+				...(projectSettings.shellBanlist ?? []),
+			],
+			shellTimeoutMs: projectSettings.shellTimeoutMs ?? globalSettings.shellTimeoutMs ?? 30_000,
+		};
+
+		try {
+			for (const msg of messages) {
+				if (msg.role !== "user") continue;
+				if (typeof msg.content === "string") {
+					if (!msg.content.includes("<gsd-")) continue;
+					const virtualPath = join(ctx.cwd, ".pi", "gsd", "workflows", "_message.md");
+					const rawArgs = extractRawArguments(msg.content);
+					msg.content = processWxpTrustedContent(msg.content, virtualPath, wxpSecurity, ctx.cwd, pkgRoot2, rawArgs, (m, lv) => ctx.ui.notify(m, lv === "error" ? "error" : "info"));
+				} else if (Array.isArray(msg.content)) {
+					for (const block of msg.content) {
+						if (block.type !== "text" || !block.text) continue;
+						if (!block.text.includes("<gsd-")) continue;
+						const virtualPath = join(ctx.cwd, ".pi", "gsd", "workflows", "_message.md");
+						const rawArgs = extractRawArguments(block.text);
+						block.text = processWxpTrustedContent(block.text, virtualPath, wxpSecurity, ctx.cwd, pkgRoot2, rawArgs, (m, lv) => ctx.ui.notify(m, lv === "error" ? "error" : "info"));
+					}
+				}
+			}
+		} catch (wxpErr) {
+			if (wxpErr instanceof WxpProcessingError) {
+				ctx.ui.notify(wxpErr.message, "error");
+				return { messages: [] }; // WXP-09: no partial content reaches LLM
+			}
+			// Non-WXP error: log but don't block
+			const errMsg = wxpErr instanceof Error ? wxpErr.message : String(wxpErr);
+			ctx.ui.notify(`GSD WXP: unexpected context error: ${errMsg}`, "info");
+		}
+
 		return { messages };
 	});
 
 	// ── session_start: GSD update check ──────────────────────────────────────
 	pi.on("session_start", async (_event, ctx) => {
-		// Ensure harness files are reachable via .pi/gsd/ symlink
-		ensureHarnessSymlink(ctx.cwd);
-
+		// Copy-on-first-run harness distribution (HRN-01, HRN-03)
+		try {
+			const extFile = typeof __filename !== "undefined" ? __filename : "";
+			const pkgRoot = join(dirname(extFile), "..", "..");
+			const pkgHarness = join(pkgRoot, ".gsd", "harnesses", "pi", "get-shit-done");
+			const projectHarness = join(ctx.cwd, ".pi", "gsd");
+			if (existsSync(pkgHarness)) {
+				const { symlinksReplaced } = copyHarness(pkgHarness, projectHarness);
+				if (symlinksReplaced > 0) {
+					ctx.ui.notify(
+						`ℹ️ GSD: Replaced ${symlinksReplaced} symlink(s) in .pi/gsd/ with real file copies.`,
+						"info",
+					);
+				}
 
+				// Version-aware update detection (HRN-02)
+				try {
+					const pkgJsonPath = join(pkgRoot, "package.json");
+					if (existsSync(pkgJsonPath)) {
+						const pkgVersion = (JSON.parse(readFileSync(pkgJsonPath, "utf8")) as { version?: string }).version ?? "0.0.0";
+						const outdated: string[] = [];
+						// Check a sample of key workflow files for version drift
+						const sampleFiles = ["workflows/execute-phase.md", "workflows/plan-phase.md"];
+						for (const rel of sampleFiles) {
+							const projFile = join(projectHarness, rel);
+							if (!existsSync(projFile)) continue;
+							const content = readFileSync(projFile, "utf8");
+							const vtag = readWorkflowVersionTag(content);
+							if (!vtag || vtag.doNotUpdate) continue;
+							if (vtag.version !== pkgVersion) outdated.push(rel);
+						}
+						if (outdated.length > 0) {
+							ctx.ui.notify(
+								`ℹ️ GSD harness update available (package v${pkgVersion}).\n` +
+								`Outdated files: ${outdated.join(", ")}\n` +
+								`Run: pi-gsd-tools harness update [y|n|pick|diff]`,
+								"info",
+							);
+						}
+					}
+				} catch { /* silent */ }
+			}
+		} catch { /* silent */ }
 		try {
 			const cacheDir = join(homedir(), ".pi", "cache");
 			const cacheFile = join(cacheDir, "gsd-update-check.json");

package/.gsd/harnesses/pi/get-shit-done/workflows/add-phase.md

@@ -1,10 +1,68 @@
-<purpose>
-Add a new integer phase to the end of the current milestone in the roadmap. Automatically calculates next phase number, creates phase directory, and updates roadmap structure.
-</purpose>
-
-<required_reading>
-Read all files referenced by the invoking prompt's execution_context before starting.
-</required_reading>
+<gsd-version v="1.12.4" />
+
+<gsd-arguments>
+  <settings>
+    <keep-extra-args />
+  </settings>
+  <arg name="description" type="string" optional />
+</gsd-arguments>
+
+<gsd-execute>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="init" />
+      <arg string="phase-op" />
+      <arg string="0" />
+    </args>
+    <outs>
+      <out type="string" name="init" />
+    </outs>
+  </shell>
+  <if>
+    <condition>
+      <starts-with>
+        <left name="init" />
+        <right type="string" value="@file:" />
+      </starts-with>
+    </condition>
+    <then>
+      <string-op op="split">
+        <args>
+          <arg name="init" />
+          <arg type="string" value="@file:" />
+        </args>
+        <outs>
+          <out type="string" name="init-file" />
+        </outs>
+      </string-op>
+      <shell command="cat">
+        <args>
+          <arg name="init-file" wrap='"' />
+        </args>
+        <outs>
+          <out type="string" name="init" />
+        </outs>
+      </shell>
+    </then>
+  </if>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="state" />
+      <arg string="json" />
+      <arg string="--raw" />
+    </args>
+    <outs>
+      <out type="string" name="state" />
+    </outs>
+  </shell>
+</gsd-execute>
+
+## Context (pre-injected by WXP)
+
+**Description:** <gsd-paste name="description" />
+
+**Project State:**
+<gsd-paste name="state" />
 
 <process>
 
@@ -28,10 +86,7 @@ Exit.
 <step name="init_context">
 Load phase operation context:
 
-```bash
-INIT=$(pi-gsd-tools init phase-op "0")
-if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
-```
+<!-- Context pre-injected above via WXP — variables available via <gsd-paste name="..."> -->
 
 Check `roadmap_exists` from init JSON. If false:
 ```

package/.gsd/harnesses/pi/get-shit-done/workflows/add-tests.md

@@ -1,3 +1,71 @@
+<gsd-version v="1.12.4" />
+
+<gsd-arguments>
+  <settings><keep-extra-args /></settings>
+  <arg name="phase" type="number" />
+</gsd-arguments>
+
+<gsd-execute>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="pi-gsd-tools" />
+      <arg string="init" />
+      <arg string="phase-op" />
+    </args>
+    <outs>
+      <out type="string" name="init" />
+    </outs>
+  </shell>
+  <if>
+    <condition>
+      <starts-with>
+        <left name="init" />
+        <right type="string" value="@file:" />
+      </starts-with>
+    </condition>
+    <then>
+      <string-op op="split">
+        <args>
+          <arg name="init" />
+          <arg type="string" value="@file:" />
+        </args>
+        <outs>
+          <out type="string" name="init-file" />
+        </outs>
+      </string-op>
+      <shell command="cat">
+        <args>
+          <arg name="init-file" wrap='"' />
+        </args>
+        <outs>
+          <out type="string" name="init" />
+        </outs>
+      </shell>
+    </then>
+  </if>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="pi-gsd-tools" />
+      <arg string="state" />
+      <arg string="json" />
+      <arg string="--raw" />
+    </args>
+    <outs>
+      <out type="string" name="state" />
+    </outs>
+  </shell>
+</gsd-execute>
+
+## Context (pre-injected)
+
+**Phase:** <gsd-paste name="phase" />
+
+**Phase Data:**
+<gsd-paste name="init" />
+
+**State:**
+<gsd-paste name="state" />
+
 <purpose>
 Generate unit and E2E tests for a completed phase based on its SUMMARY.md, CONTEXT.md, and implementation. Classifies each changed file into TDD (unit), E2E (browser), or Skip categories, presents a test plan for user approval, then generates tests following RED-GREEN conventions.
 
@@ -32,10 +100,7 @@ Exit.
 <step name="init_context">
 Load phase operation context:
 
-```bash
-INIT=$(pi-gsd-tools init phase-op "${PHASE_ARG}")
-if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
-```
+<!-- Context pre-injected above via WXP — variables available via <gsd-paste name="..."> -->
 
 Extract from init JSON: `phase_dir`, `phase_number`, `phase_name`.
 

package/.gsd/harnesses/pi/get-shit-done/workflows/add-todo.md

@@ -1,3 +1,32 @@
+<gsd-version v="1.12.4" />
+
+<gsd-arguments>
+  <settings><keep-extra-args /></settings>
+  <arg name="text" type="string" optional />
+</gsd-arguments>
+
+<gsd-execute>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="pi-gsd-tools" />
+      <arg string="state" />
+      <arg string="json" />
+      <arg string="--raw" />
+    </args>
+    <outs>
+      <suppress-errors />
+      <out type="string" name="state" />
+    </outs>
+  </shell>
+</gsd-execute>
+
+## Context (pre-injected)
+
+**Todo text:** <gsd-paste name="text" />
+
+**State:**
+<gsd-paste name="state" />
+
 <purpose>
 Capture an idea, task, or issue that surfaces during a GSD session as a structured todo for later work. Enables "thought → capture → continue" flow without losing context.
 </purpose>
@@ -11,10 +40,7 @@ Read all files referenced by the invoking prompt's execution_context before star
 <step name="init_context">
 Load todo context:
 
-```bash
-INIT=$(pi-gsd-tools init todos)
-if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
-```
+<!-- Context pre-injected above via WXP — variables available via <gsd-paste name="..."> -->
 
 Extract from init JSON: `commit_docs`, `date`, `timestamp`, `todo_count`, `todos`, `pending_dir`, `todos_dir_exists`.
 

package/.gsd/harnesses/pi/get-shit-done/workflows/audit-milestone.md

@@ -1,25 +1,83 @@
-<purpose>
-Verify milestone achieved its definition of done by aggregating phase verifications, checking cross-phase integration, and assessing requirements coverage. Reads existing VERIFICATION.md files (phases already verified during execute-phase), aggregates tech debt and deferred gaps, then spawns integration checker for cross-phase wiring.
-</purpose>
-
-<required_reading>
-Read all files referenced by the invoking prompt's execution_context before starting.
-</required_reading>
-
-<available_agent_types>
-Valid GSD subagent types (use exact names - do not fall back to 'general-purpose'):
-- gsd-integration-checker - Checks cross-phase integration
-</available_agent_types>
+<gsd-version v="1.12.4" />
+
+<gsd-arguments>
+  <settings>
+    <keep-extra-args />
+  </settings>
+</gsd-arguments>
+
+<gsd-execute>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="init" />
+      <arg string="milestone-op" />
+    </args>
+    <outs>
+      <out type="string" name="init" />
+    </outs>
+  </shell>
+  <if>
+    <condition>
+      <starts-with>
+        <left name="init" />
+        <right type="string" value="@file:" />
+      </starts-with>
+    </condition>
+    <then>
+      <string-op op="split">
+        <args>
+          <arg name="init" />
+          <arg type="string" value="@file:" />
+        </args>
+        <outs>
+          <out type="string" name="init-file" />
+        </outs>
+      </string-op>
+      <shell command="cat">
+        <args>
+          <arg name="init-file" wrap='"' />
+        </args>
+        <outs>
+          <out type="string" name="init" />
+        </outs>
+      </shell>
+    </then>
+  </if>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="agent-skills" />
+      <arg string="gsd-integration-checker" />
+    </args>
+    <outs>
+      <suppress-errors />
+      <out type="string" name="agent-skills-checker" />
+    </outs>
+  </shell>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="resolve-model" />
+      <arg string="gsd-integration-checker" />
+      <arg string="--raw" />
+    </args>
+    <outs>
+      <suppress-errors />
+      <out type="string" name="integration-checker-model" />
+    </outs>
+  </shell>
+</gsd-execute>
+
+## Milestone Audit Context (pre-injected by WXP)
+
+**Milestone Init Data:**
+<gsd-paste name="init" />
+
+**Integration Checker Model:** <gsd-paste name="integration-checker-model" />
 
 <process>
 
 ## 0. Initialize Milestone Context
 
-```bash
-INIT=$(pi-gsd-tools init milestone-op)
-if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
-AGENT_SKILLS_CHECKER=$(pi-gsd-tools agent-skills gsd-integration-checker 2>/dev/null)
-```
+<!-- Context pre-injected above via WXP — variables available via <gsd-paste name="..."> -->
 
 Extract from init JSON: `milestone_version`, `milestone_name`, `phase_count`, `completed_phases`, `commit_docs`.
 

package/.gsd/harnesses/pi/get-shit-done/workflows/audit-uat.md

@@ -1,3 +1,41 @@
+<gsd-version v="1.12.4" />
+
+<gsd-arguments>
+  <settings><keep-extra-args /></settings>
+</gsd-arguments>
+
+<gsd-execute>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="pi-gsd-tools" />
+      <arg string="audit-uat" />
+      <arg string="--raw" />
+    </args>
+    <outs>
+      <out type="string" name="audit-data" />
+    </outs>
+  </shell>
+  <shell command="pi-gsd-tools">
+    <args>
+      <arg string="pi-gsd-tools" />
+      <arg string="state" />
+      <arg string="json" />
+      <arg string="--raw" />
+    </args>
+    <outs>
+      <out type="string" name="state" />
+    </outs>
+  </shell>
+</gsd-execute>
+
+## Audit Data (pre-injected)
+
+**UAT Audit:**
+<gsd-paste name="audit-data" />
+
+**State:**
+<gsd-paste name="state" />
+
 <purpose>
 Cross-phase audit of all UAT and verification files. Finds every outstanding item (pending, skipped, blocked, human_needed), optionally verifies against the codebase to detect stale docs, and produces a prioritized human test plan.
 </purpose>