pi-goosedump 0.9.2 → 0.9.3

package/index.ts

@@ -80,6 +80,9 @@ const DEFAULT_GOOSEDUMP_SETTINGS: GoosedumpSettings = {
   turnsBeforeCompact: 0,
 };
 
+const TURNS_BEFORE_COMPACT_MIN = 0;
+const TURNS_BEFORE_COMPACT_MAX = 255;
+
 function piAgentDir(): string {
   return process.env.PI_CODING_AGENT_DIR ?? join(homedir(), '.pi', 'agent');
 }
@@ -113,7 +116,12 @@ function readGoosedumpSettingsFrom(path: string): Partial<GoosedumpSettings> {
 
   const settings: Partial<GoosedumpSettings> = {};
   const value = raw.turnsBeforeCompact;
-  if (typeof value === 'number' && Number.isSafeInteger(value) && value >= 0 && value <= 255) {
+  if (
+    typeof value === 'number' &&
+    Number.isSafeInteger(value) &&
+    value >= TURNS_BEFORE_COMPACT_MIN &&
+    value <= TURNS_BEFORE_COMPACT_MAX
+  ) {
     settings.turnsBeforeCompact = value;
   }
   return settings;
@@ -248,6 +256,13 @@ function missingSessionId(tool: string, provider = 'pi'): AgentToolResult<void>
   return textResult(`session is required for ${tool} when no current session is available`);
 }
 
+const GOOSEDUMP_UNAVAILABLE_MESSAGE =
+  'goosedump is not available. Install with: npm install @jarkkojs/goosedump';
+
+function goosedumpUnavailableResult(): AgentToolResult<void> {
+  return textResult(GOOSEDUMP_UNAVAILABLE_MESSAGE);
+}
+
 function runGoosedump(args: string[]): string {
   try {
     return execFileSync('node', [resolveGoosedumpBinary(), ...args], {
@@ -552,20 +567,28 @@ function isControlChar(char: string): boolean {
 class NumberInputSubmenu implements Component {
   private readonly input = new Input();
   private readonly hint: (text: string) => string;
-  private readonly onSubmitValue: (value: string) => void;
+  private readonly onSubmitValue: (value: number) => void;
   private readonly onCancelEdit: () => void;
+  private readonly onInvalidValue: (message: string) => void;
   private readonly title: string;
+  private readonly currentValue: number;
+  private readonly min: number;
+  private readonly max: number;
 
   constructor(
     title: string,
-    initialValue: string,
-    onSubmit: (value: string) => void,
+    currentValue: number,
+    onSubmit: (value: number) => void,
     onCancel: () => void,
+    options?: { min?: number; max?: number; onInvalid?: (message: string) => void },
   ) {
     this.title = title;
+    this.currentValue = currentValue;
     this.onSubmitValue = onSubmit;
     this.onCancelEdit = onCancel;
-    this.input.setValue(initialValue);
+    this.onInvalidValue = options?.onInvalid ?? (() => {});
+    this.min = options?.min ?? 0;
+    this.max = options?.max ?? 255;
     this.hint = getSettingsListTheme().hint;
   }
 
@@ -573,8 +596,16 @@ class NumberInputSubmenu implements Component {
     const kb = getKeybindings();
     if (kb.matches(data, 'tui.select.confirm') || data === '\n') {
       const digits = this.input.getValue().replace(/\D/g, '');
+      if (digits === '') {
+        this.onCancelEdit();
+        return;
+      }
       const parsed = Number(digits);
-      this.onSubmitValue(digits !== '' && Number.isSafeInteger(parsed) ? String(parsed) : '0');
+      if (!Number.isSafeInteger(parsed) || parsed < this.min || parsed > this.max) {
+        this.onInvalidValue(`Enter a whole number between ${this.min} and ${this.max}`);
+        return;
+      }
+      this.onSubmitValue(parsed);
       return;
     }
     if (kb.matches(data, 'tui.select.cancel')) {
@@ -593,7 +624,7 @@ class NumberInputSubmenu implements Component {
 
   render(width: number): string[] {
     return [
-      this.hint(`  ${this.title}`),
+      this.hint(`  ${this.title} · current ${this.currentValue} · ${this.min}-${this.max}`),
       '',
       ...this.input.render(width),
       '',
@@ -637,9 +668,14 @@ async function runSettingsEditor(ctx: ExtensionContext): Promise<void> {
           submenu: (currentValue, subDone) =>
             new NumberInputSubmenu(
               settingLabel(scope, 'turnsBeforeCompact'),
-              currentValue,
-              (value) => subDone(value),
+              Number(currentValue),
+              (value) => subDone(String(value)),
               () => subDone(),
+              {
+                min: TURNS_BEFORE_COMPACT_MIN,
+                max: TURNS_BEFORE_COMPACT_MAX,
+                onInvalid: (message) => ctx.ui.notify(message, 'error'),
+              },
             ),
         }));
       }
@@ -652,7 +688,12 @@ async function runSettingsEditor(ctx: ExtensionContext): Promise<void> {
           (id, newValue) => {
             const [scope, key] = id.split(':') as [SettingsScope, GoosedumpSettingKey];
             const parsed = Number(newValue);
-            if (!Number.isSafeInteger(parsed) || parsed < 0 || parsed > 255) return;
+            if (
+              !Number.isSafeInteger(parsed) ||
+              parsed < TURNS_BEFORE_COMPACT_MIN ||
+              parsed > TURNS_BEFORE_COMPACT_MAX
+            )
+              return;
             writeScopedGoosedumpSetting(location, scope, key, parsed);
             settingsList.updateValue(id, newValue);
             ctx.ui.notify(`${settingLabel(scope, key)} = ${formatCompactSetting(parsed)}`, 'info');
@@ -1091,11 +1132,7 @@ export function createGoosedumpIntegration(
             ),
           }),
           async execute(_id, params, _signal, _onUpdate, ctx): Promise<AgentToolResult<void>> {
-            if (!goosedumpAvailable) {
-              return textResult(
-                'goosedump is not available. Install with: npm install @jarkkojs/goosedump',
-              );
-            }
+            if (!goosedumpAvailable) return goosedumpUnavailableResult();
 
             try {
               const provider = params.provider ?? 'pi';
@@ -1172,11 +1209,7 @@ export function createGoosedumpIntegration(
             ),
           }),
           async execute(_id, params, _signal, _onUpdate, ctx): Promise<AgentToolResult<void>> {
-            if (!goosedumpAvailable) {
-              return textResult(
-                'goosedump is not available. Install with: npm install @jarkkojs/goosedump',
-              );
-            }
+            if (!goosedumpAvailable) return goosedumpUnavailableResult();
 
             try {
               const provider = params.provider ?? 'pi';
@@ -1247,11 +1280,7 @@ export function createGoosedumpIntegration(
             ),
           }),
           async execute(_id, params, _signal, _onUpdate, ctx): Promise<AgentToolResult<void>> {
-            if (!goosedumpAvailable) {
-              return textResult(
-                'goosedump is not available. Install with: npm install @jarkkojs/goosedump',
-              );
-            }
+            if (!goosedumpAvailable) return goosedumpUnavailableResult();
 
             try {
               const provider = params.provider ?? 'pi';
@@ -1298,11 +1327,7 @@ export function createGoosedumpIntegration(
             ),
           }),
           async execute(_id, params, _signal, _onUpdate, ctx): Promise<AgentToolResult<void>> {
-            if (!goosedumpAvailable) {
-              return textResult(
-                'goosedump is not available. Install with: npm install @jarkkojs/goosedump',
-              );
-            }
+            if (!goosedumpAvailable) return goosedumpUnavailableResult();
 
             const keep = params.keep ?? null;
             requestCompaction(ctx, keep);
@@ -1390,15 +1415,13 @@ export function createGoosedumpIntegration(
       description: 'Edit goosedump compaction settings',
       handler: async (_args, ctx) => {
         if (!goosedumpAvailable) {
-          ctx.ui.notify(
-            'goosedump is not available. Install with: npm install @jarkkojs/goosedump',
-            'error',
-          );
+          ctx.ui.notify(GOOSEDUMP_UNAVAILABLE_MESSAGE, 'error');
           return;
         }
 
         try {
           await runSettingsEditor(ctx);
+          reloadCompactSettings(ctx.cwd);
           updateStatus(ctx);
         } catch (err) {
           const message = err instanceof Error ? err.message : String(err);
@@ -1411,10 +1434,7 @@ export function createGoosedumpIntegration(
       description: 'Compact now with goosedump; optionally keep the last N user turns',
       handler: async (args, ctx) => {
         if (!goosedumpAvailable) {
-          ctx.ui.notify(
-            'goosedump is not available. Install with: npm install @jarkkojs/goosedump',
-            'error',
-          );
+          ctx.ui.notify(GOOSEDUMP_UNAVAILABLE_MESSAGE, 'error');
           return;
         }
 
@@ -1439,10 +1459,7 @@ export function createGoosedumpIntegration(
       description: 'Search the current session history',
       handler: async (args, ctx) => {
         if (!goosedumpAvailable) {
-          ctx.ui.notify(
-            'goosedump is not available. Install with: npm install @jarkkojs/goosedump',
-            'error',
-          );
+          ctx.ui.notify(GOOSEDUMP_UNAVAILABLE_MESSAGE, 'error');
           return;
         }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goosedump",
-  "version": "0.9.2",
+  "version": "0.9.3",
   "description": "Pi extension for goosedump-backed session-history search, entry expansion, and compaction",
   "keywords": [
     "compaction",
@@ -31,7 +31,7 @@
   },
   "dependencies": {
     "@earendil-works/pi-tui": "^0.78.0",
-    "@jarkkojs/goosedump": "^0.9.3",
+    "@jarkkojs/goosedump": "^0.9.4",
     "@sinclair/typebox": "^0.34.49"
   },
   "devDependencies": {