pi-goosedump 0.8.0 → 0.8.1

package/README.md

@@ -86,13 +86,12 @@ current session to its goosedump id and runs `goosedump compact <id>` with Pi's
 compaction range (`--from`, `--until`, and `--scope`) so the generated summary
 matches the entries Pi is about to replace.
 
-Optional goosedump counters can also trigger compaction. `0` disables a counter;
-when either counter fires, both counters reset to their configured values.
+An optional goosedump counter can also trigger compaction. `0` disables the counter;
+when it fires, it resets to its configured value.
 
 ```json
 {
   "goosedump": {
-    "stepsBeforeCompact": 0,
     "turnsBeforeCompact": 0
   }
 }

package/index.ts

@@ -19,9 +19,13 @@ import { homedir } from 'node:os';
 import { basename, dirname, extname, isAbsolute, join, relative } from 'node:path';
 
 import {
+  type Component,
+  Input,
   Key,
   SettingsList,
   type SettingItem,
+  decodeKittyPrintable,
+  getKeybindings,
   matchesKey,
   truncateToWidth,
   visibleWidth,
@@ -31,7 +35,7 @@ import { Type } from '@sinclair/typebox';
 
 const require = createRequire(import.meta.url);
 
-const GOOSEDUMP_VERSION = [0, 8, 1] as const;
+const GOOSEDUMP_VERSION = [0, 8, 2] as const;
 
 // One element of goosedump 0.8's `list` JSON output.
 interface ListEntryJson {
@@ -119,7 +123,6 @@ interface CompactJson {
 }
 
 interface GoosedumpSettings {
-  stepsBeforeCompact: number;
   turnsBeforeCompact: number;
 }
 
@@ -127,12 +130,9 @@ type SettingsScope = 'global' | 'project';
 type GoosedumpSettingKey = keyof GoosedumpSettings;
 
 const DEFAULT_GOOSEDUMP_SETTINGS: GoosedumpSettings = {
-  stepsBeforeCompact: 0,
   turnsBeforeCompact: 0,
 };
 
-const COMPACT_SETTING_VALUES = ['0', '5', '10', '20', '50', '100'];
-
 function piAgentDir(): string {
   return process.env.PI_CODING_AGENT_DIR ?? join(homedir(), '.pi', 'agent');
 }
@@ -165,11 +165,9 @@ function readGoosedumpSettingsFrom(path: string): Partial<GoosedumpSettings> {
   if (!isRecord(raw)) return {};
 
   const settings: Partial<GoosedumpSettings> = {};
-  for (const key of ['stepsBeforeCompact', 'turnsBeforeCompact'] as const) {
-    const value = raw[key];
-    if (typeof value === 'number' && Number.isSafeInteger(value) && value >= 0) {
-      settings[key] = value;
-    }
+  const value = raw.turnsBeforeCompact;
+  if (typeof value === 'number' && Number.isSafeInteger(value) && value >= 0) {
+    settings.turnsBeforeCompact = value;
   }
   return settings;
 }
@@ -747,6 +745,64 @@ function buildGoosedumpCompaction(
   };
 }
 
+function isControlChar(char: string): boolean {
+  const code = char.charCodeAt(0);
+  return code < 32 || code === 0x7f || (code >= 0x80 && code <= 0x9f);
+}
+
+class NumberInputSubmenu implements Component {
+  private readonly input = new Input();
+  private readonly hint: (text: string) => string;
+  private readonly onSubmitValue: (value: string) => void;
+  private readonly onCancelEdit: () => void;
+  private readonly title: string;
+
+  constructor(
+    title: string,
+    initialValue: string,
+    onSubmit: (value: string) => void,
+    onCancel: () => void,
+  ) {
+    this.title = title;
+    this.onSubmitValue = onSubmit;
+    this.onCancelEdit = onCancel;
+    this.input.setValue(initialValue);
+    this.hint = getSettingsListTheme().hint;
+  }
+
+  handleInput(data: string): void {
+    const kb = getKeybindings();
+    if (kb.matches(data, 'tui.select.confirm') || data === '\n') {
+      const digits = this.input.getValue().replace(/\D/g, '');
+      const parsed = Number(digits);
+      this.onSubmitValue(digits !== '' && Number.isSafeInteger(parsed) ? String(parsed) : '0');
+      return;
+    }
+    if (kb.matches(data, 'tui.select.cancel')) {
+      this.onCancelEdit();
+      return;
+    }
+    const kittyChar = decodeKittyPrintable(data);
+    const printable = kittyChar ?? (data.length === 1 && !isControlChar(data) ? data : undefined);
+    if (printable !== undefined && !/^[0-9]$/.test(printable)) return;
+    this.input.handleInput(data);
+  }
+
+  invalidate(): void {
+    this.input.invalidate();
+  }
+
+  render(width: number): string[] {
+    return [
+      this.hint(`  ${this.title}`),
+      '',
+      ...this.input.render(width),
+      '',
+      this.hint('  enter submit  ·  esc cancel  ·  digits only'),
+    ];
+  }
+}
+
 async function runSessionBrowser(
   ctx: ExtensionContext,
   listings: GoosedumpListing[],
@@ -757,7 +813,6 @@ async function runSessionBrowser(
   const LIST_VIEWPORT = 18;
   const COMPACT_VIEWPORT = 18;
   const location = ctx.cwd;
-  const settingValues = COMPACT_SETTING_VALUES;
 
   function locationListings(): GoosedumpListing[] {
     return listings.filter((listing) => listing.cwd === location);
@@ -777,8 +832,7 @@ async function runSessionBrowser(
 
   function settingLabel(scope: SettingsScope, key: GoosedumpSettingKey): string {
     const scopeLabel = scope === 'global' ? 'Global' : 'Project';
-    const keyLabel = key === 'stepsBeforeCompact' ? 'stepsBeforeCompact' : 'turnsBeforeCompact';
-    return `${scopeLabel} ${keyLabel}`;
+    return `${scopeLabel} ${key}`;
   }
 
   function buildSettingItems(): SettingItem[] {
@@ -786,18 +840,19 @@ async function runSessionBrowser(
     const project = readScopedGoosedumpSettings(location, 'project');
     const settingsByScope = { global, project } satisfies Record<SettingsScope, GoosedumpSettings>;
 
-    return (['global', 'project'] as const).flatMap((scope) =>
-      (['stepsBeforeCompact', 'turnsBeforeCompact'] as const).map((key) => ({
-        id: `${scope}:${key}`,
-        label: settingLabel(scope, key),
-        description:
-          key === 'stepsBeforeCompact'
-            ? 'Tool steps before goosedump starts compaction; 0 disables this trigger.'
-            : 'LLM turns before goosedump starts compaction; 0 disables this trigger.',
-        currentValue: String(settingsByScope[scope][key]),
-        values: settingValues,
-      })),
-    );
+    return (['global', 'project'] as const).map((scope) => ({
+      id: `${scope}:turnsBeforeCompact`,
+      label: settingLabel(scope, 'turnsBeforeCompact'),
+      description: 'LLM turns before goosedump starts compaction; 0 disables this trigger.',
+      currentValue: String(settingsByScope[scope].turnsBeforeCompact),
+      submenu: (currentValue, done) =>
+        new NumberInputSubmenu(
+          settingLabel(scope, 'turnsBeforeCompact'),
+          currentValue,
+          (value) => done(value),
+          () => done(),
+        ),
+    }));
   }
 
   await ctx.ui.custom<void>(
@@ -835,8 +890,7 @@ async function runSessionBrowser(
             tui.requestRender();
           },
           () => {
-            tab = 'sessions';
-            tui.requestRender();
+            done(undefined);
           },
         );
       }
@@ -892,15 +946,13 @@ async function runSessionBrowser(
         const effective = resolveGoosedumpSettings(location);
         lines.push(
           makeRow(
-            dim(
-              `Effective: steps=${formatCompactSetting(effective.stepsBeforeCompact)} turns=${formatCompactSetting(effective.turnsBeforeCompact)}`,
-            ),
+            dim(`Effective: turns=${formatCompactSetting(effective.turnsBeforeCompact)}`),
             innerW,
             border,
           ),
         );
         lines.push(
-          makeRow(dim('tab switch  ↑↓ select  enter/space cycle  esc close'), innerW, border),
+          makeRow(dim('tab switch  ↑↓ select  enter/space edit  esc close'), innerW, border),
         );
         lines.push(`${borderFg('╰')}${borderFg('─'.repeat(width - 2))}${borderFg('╯')}`);
         return lines;
@@ -1051,10 +1103,6 @@ async function runSessionBrowser(
           }
 
           if (tab === 'settings') {
-            if (matchesKey(data, Key.escape) || matchesKey(data, Key.ctrl('c'))) {
-              done(undefined);
-              return;
-            }
             settingsList.handleInput(data);
             tui.requestRender();
             return;
@@ -1152,19 +1200,17 @@ export function createGoosedumpIntegration(
   let goosedumpAvailable = false;
   let compactSettings = DEFAULT_GOOSEDUMP_SETTINGS;
   let settingsSignature = '';
-  let stepsRemaining = 0;
   let turnsRemaining = 0;
   let counterTriggered = false;
   let compactionQueued = false;
 
   function compactSettingsSignature(settings: GoosedumpSettings): string {
-    return `${settings.stepsBeforeCompact}:${settings.turnsBeforeCompact}`;
+    return String(settings.turnsBeforeCompact);
   }
 
   function resetCompactCounters(cwd: string): void {
     compactSettings = resolveGoosedumpSettings(cwd);
     settingsSignature = compactSettingsSignature(compactSettings);
-    stepsRemaining = compactSettings.stepsBeforeCompact;
     turnsRemaining = compactSettings.turnsBeforeCompact;
     counterTriggered = false;
   }
@@ -1175,15 +1221,6 @@ export function createGoosedumpIntegration(
     if (nextSignature !== settingsSignature) resetCompactCounters(cwd);
   }
 
-  function noteCompletedStep(ctx: ExtensionContext): void {
-    if (!goosedumpAvailable || !shouldOverrideDefaultCompaction) return;
-    reloadCompactSettings(ctx.cwd);
-    if (compactSettings.stepsBeforeCompact === 0) return;
-
-    stepsRemaining -= 1;
-    if (stepsRemaining <= 0) counterTriggered = true;
-  }
-
   function noteCompletedTurn(ctx: ExtensionContext): void {
     if (!goosedumpAvailable || !shouldOverrideDefaultCompaction) return;
     reloadCompactSettings(ctx.cwd);
@@ -1193,6 +1230,9 @@ export function createGoosedumpIntegration(
     }
 
     if (!counterTriggered || compactionQueued) return;
+    // ctx.compact() uses manual compaction semantics and aborts the current run.
+    // Wait until no queued work remains before triggering plugin-driven compaction.
+    if (ctx.hasPendingMessages()) return;
 
     resetCompactCounters(ctx.cwd);
     compactionQueued = true;
@@ -1509,10 +1549,6 @@ export function createGoosedumpIntegration(
       }
     });
 
-    pi.on('tool_execution_end', async (_event, ctx) => {
-      noteCompletedStep(ctx);
-    });
-
     pi.on('turn_end', async (_event, ctx) => {
       noteCompletedTurn(ctx);
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goosedump",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Coding agent context data browser plugin for pi",
   "keywords": [
     "goosedump",
@@ -29,7 +29,7 @@
   },
   "dependencies": {
     "@earendil-works/pi-tui": "^0.78.0",
-    "@jarkkojs/goosedump": "^0.8.1",
+    "@jarkkojs/goosedump": "^0.8.2",
     "@sinclair/typebox": "^0.34.49"
   },
   "devDependencies": {