pi-goal-list-loop-audit 0.38.25 → 0.38.26

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.38.26 — approval-render store: spillway cap keeps undelivered renders (2026-09-08)
+
+### Fixed
+- Post-tag review of the v0.38.25 store: the sidecar cap could trim undelivered renders past 20 entries (non-positive slice budget). The cap now applies to delivered history only — undelivered renders are never dropped (self-draining: any user command replays them). Same 7 behavioral pins green; full gate 1986 pass / 0 fail.
+
 ## 0.38.25 — post-objective summary: canonical approval render, persist + replay, audit-goal counts (2026-09-07)
 
 ### Fixed

package/docs/INDEX.md

@@ -18,7 +18,7 @@ For shipped docs, the relevant entry points are:
   failback; v0.35.9 hardened cross-version npm tarball checks; v0.35.10
   handles multi-entry npm dry-run reports; v0.35.11 accepts both npm report
   shapes; v0.35.12 supports npm 12's keyed pack reports; v0.35.13 fixes stale-API recovery loops.
-  v0.35.14–v0.38.25 continue through the supervisor freeze (`/glla pause`),
+  v0.35.14–v0.38.26 continue through the supervisor freeze (`/glla pause`),
   load hold, auditor picker parity, Windows launch fix, zombie-watchdog
   subagent carve-out, due-wait backstop, the `/glla agents` visibility panel,
   durable state-root selection, blank-until-resume auditor context, frozen

package/extensions/approval-render-store.ts

@@ -47,7 +47,7 @@ function isValidRender(entry: unknown): entry is PendingApprovalRender {
     && (e.deliveredAt === undefined || typeof e.deliveredAt === "string");
 }
 
-function readRenders(cwd: string): PendingApprovalRender[] | undefined {
+function readRenders(cwd: string): PendingApprovalRender[] {
   let raw: string;
   try {
     raw = fs.readFileSync(approvalRenderStorePath(cwd), "utf-8");
@@ -91,7 +91,7 @@ export function persistApprovalRender(cwd: string, render: {
   delivered: boolean;
 }): boolean {
   const at = nowIso();
-  const existing = readRenders(cwd) ?? [];
+  const existing = readRenders(cwd);
   const entry: PendingApprovalRender = {
     goalId: render.goalId,
     objective: render.objective.slice(0, 300),
@@ -99,11 +99,14 @@ export function persistApprovalRender(cwd: string, render: {
     createdAt: at,
     ...(render.delivered ? { deliveredAt: at } : {}),
   };
+  // The cap trims DELIVERED history only: undelivered renders are never
+  // dropped (each is ~1KB and any user command replays them, so the
+  // undelivered tail is self-draining in practice).
   const undelivered = existing.filter((e) => !e.deliveredAt);
-  const delivered = [...existing.filter((e) => e.deliveredAt), ...(render.delivered ? [entry] : [])]
-    .slice(-(MAX_STORED_RENDERS - undelivered.length - (render.delivered ? 0 : 1)));
-  const next = [...undelivered, ...(render.delivered ? [] : [entry]), ...delivered];
-  if (!writeRenders(cwd, next.slice(-MAX_STORED_RENDERS))) return false;
+  const delivered = [...existing.filter((e) => e.deliveredAt), ...(render.delivered ? [entry] : [])];
+  const deliveredBudget = Math.max(0, MAX_STORED_RENDERS - undelivered.length - (render.delivered ? 0 : 1));
+  const next = [...undelivered, ...(render.delivered ? [] : [entry]), ...delivered.slice(-deliveredBudget)];
+  if (!writeRenders(cwd, next)) return false;
   appendLedger(cwd, "terminal_approval_render_persisted", {
     goalId: render.goalId,
     delivered: render.delivered,
@@ -118,7 +121,7 @@ export function persistApprovalRender(cwd: string, render: {
  * throws. */
 export function replayUndeliveredApprovalRenders(ctx: { cwd: string; ui: { notify: (message: string, type?: "info" | "warning" | "error") => void } }): number {
   const renders = readRenders(ctx.cwd);
-  if (!renders || renders.length === 0) return 0;
+  if (renders.length === 0) return 0;
   const pending = renders.filter((e) => !e.deliveredAt).slice(0, MAX_REPLAY_PER_CONTACT);
   if (pending.length === 0) return 0;
   const at = nowIso();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.38.25",
+  "version": "0.38.26",
   "description": "Mission control for autonomous pi: interview-drafted goals, an audited task queue, and forever-loops (metric, spec, project-audit) that run for hours. A detached extension-less auditor process re-verifies every completion with raw evidence without holding the main pi turn; confirmed drafts, decision pauses and consent gates keep you in charge.",
   "license": "AGPL-3.0-only",
   "author": "dracon",