pi-goal-list-loop-audit 0.33.0 → 0.33.1

package/extensions/goal-loop-auditor.ts

@@ -338,6 +338,7 @@ export async function runGoalCompletionAuditor(args: {
     } finally {
       clearInterval(stallTimer);
       unsub();
+      args.signal?.removeEventListener("abort", abort); // v0.33.1: don't retain the session via the signal
       // v0.32.0: dispose the auditor session — each complete_goal leaked one
       // session's subscriptions/stream resources for the parent's lifetime.
       (session as any).dispose?.();

package/extensions/goal-loop-display.ts

@@ -48,6 +48,12 @@ export function truncate(s: string, max: number): string {
   return s.length <= max ? s : s.slice(0, Math.max(0, max - 1)) + "…";
 }
 
+const ANSI_RE = /\x1b\[[0-9;]*m/g;
+/** v0.33.1: painted strings measure by their VISIBLE width. */
+function visibleLen(s: string): number {
+  return s.replace(ANSI_RE, "").length;
+}
+
 /** v0.33.0: 5-cell meter with a rounding guard (command-code's rule — never
  * shows empty or full unless the value truly is 0 or 1). */
 export function meter(frac: number, cells = 5): string {
@@ -296,7 +302,6 @@ function goalLines(g: Goal, state: State, audit: AuditDisplayProgress | null | u
       : g.status === "auditing"
         ? paint(theme, "accent", "⟡")
         : paint(theme, "success", "●");
-  const headBase = `${icon} ${truncate(g.objective.replace(/\s+/g, " "), budgetFor(width, 3, 48))}`;
   // v0.24.7: a list item is named as such and points at /list — before,
   // the widget called it "active" and hinted "/goal status", reading as if
   // queue work were a standalone goal.
@@ -325,7 +330,12 @@ function goalLines(g: Goal, state: State, audit: AuditDisplayProgress | null | u
   // ∞/↓/↑ loop, ⟡ auditing, ⏸ paused) + the type-named footer verbs.
   // Token segment only when a budget is set (v0.22.0): the guard is opt-in,
   // and "0/0 tok" carried no information when off.
-  const head = `${headBase} ${paint(theme, "dim", "·")} ${headSegs.join(` ${paint(theme, "dim", "·")} `)}`;
+  // v0.33.1: the head must FIT the terminal — the segments are fixed, so
+  // the objective absorbs whatever room is left (was: objective budgeted
+  // alone, segments appended unbudgeted → 140-col heads at width 100).
+  const segsText = headSegs.join(` ${paint(theme, "dim", "·")} `);
+  const objBudget = width && width > 0 ? Math.max(16, width - 1 - 2 - 3 - visibleLen(segsText)) : 48;
+  const head = `${icon} ${truncate(g.objective.replace(/\s+/g, " "), objBudget)} ${paint(theme, "dim", "·")} ${segsText}`;
   const lines = [head];
   if (g.status === "auditing") {
     lines.push(`├─ auditor: ${audit?.label ?? "running"}${audit?.currentTool ? ` · ${truncate(audit.currentTool, 30)}` : ""}`);
@@ -427,10 +437,13 @@ function loopLines(l: LoopState, now: number, theme?: DisplayTheme, width?: numb
   segs.push(fmtElapsed(now - Date.parse(l.startedAt)));
   if (l.measureCmd) {
     segs.push(`best ${paint(theme, "success", `${l.bestValue ?? "n/a"}`)}`);
+    segs.push(`last ${l.lastValue ?? "n/a"}`); // v0.33.1: a plateauing loop's current reading stays visible
     const stallText = `stall ${l.stallCount}/${l.plateauWindow}`;
     segs.push(l.stallCount >= l.plateauWindow - 1 ? paint(theme, "warning", stallText) : stallText);
   }
-  const lines = [`${icon} ${truncate(l.target, budgetFor(width, 3, 44))} ${paint(theme, "dim", "·")} ${segs.join(` ${paint(theme, "dim", "·")} `)}${stallNote}`];
+  const segsText = segs.join(` ${paint(theme, "dim", "·")} `);
+  const targetBudget = width && width > 0 ? Math.max(16, width - 1 - 2 - 3 - visibleLen(segsText) - visibleLen(stallNote)) : 44;
+  const lines = [`${icon} ${truncate(l.target, targetBudget)} ${paint(theme, "dim", "·")} ${segsText}${stallNote}`];
   const act = extras?.recent?.[extras.recent.length - 1];
   if (act) {
     lines.push(`├─ ${paint(theme, act.ok ? "success" : "error", act.ok ? "✓" : "✗")} ${act.name}${act.arg ? ` ${paint(theme, "dim", truncate(act.arg, 24))}` : ""}${act.ms > 0 ? ` ${paint(theme, "dim", `(${fmtElapsed(act.ms)})`)}` : ""}`);

package/extensions/goal-settings.ts

@@ -211,6 +211,7 @@ export const SETTINGS_KEYS: Array<keyof Settings> = [
   "stallSimilarityThreshold",
   "postaudit",
   "toolOverrides",
+  "reviewer", // v0.33.1: legacy alias — menu saves can write it; provenance must know it exists
 ];
 
 /** Where each effective setting comes from (for the /glla display). */

package/extensions/loops/goal.ts

@@ -639,13 +639,17 @@ function summarizeToolArg(name: string, input: any): string | undefined {
   if (!input || typeof input !== "object") return undefined;
   const v = input.file_path ?? input.path ?? input.command ?? input.pattern ?? input.query ?? input.url ?? input.title;
   if (typeof v !== "string" || v.length === 0) return undefined;
-  const base = name === "bash" ? v : v.split("/").pop() || v;
+  // v0.33.1: strip control chars BEFORE truncating — a raw \n breaks the
+  // widget card into un-prefixed lines (footer spoof), a raw ESC corrupts
+  // the TUI. The objective path was already whitespace-collapsed; this
+  // path was the gap.
+  const base = (name === "bash" ? v : v.split("/").pop() || v).replace(/[\x00-\x1f\x7f-\x9f]/g, " ").replace(/\s+/g, " ").trim();
   return base.length <= 24 ? base : base.slice(0, 23) + "…";
 }
 function noteToolCall(event: any): void {
   const name = String(event?.toolName ?? "?");
   const id = String(event?.toolCallId ?? event?.id ?? `anon-${Date.now()}`);
-  if (inFlightToolCalls.size > 20) inFlightToolCalls.delete(inFlightToolCalls.keys().next().value!);
+  if (inFlightToolCalls.size >= 20) inFlightToolCalls.delete(inFlightToolCalls.keys().next().value!); // v0.33.1: evict BEFORE the 21st
   inFlightToolCalls.set(id, { name, arg: summarizeToolArg(name, event?.input ?? event?.args), at: Date.now() });
 }
 function noteToolResult(event: any): void {
@@ -865,6 +869,14 @@ function heartbeatTick(): void {
     if (!absorbStaleIfSuperseded(ctx)) goStaleTerminal(ctx, "heartbeat probe");
     return;
   }
+  // v0.33.1: nothing supervised → the compact debt/resync belong to a dead
+  // goal/loop. Discharge here so a later goal can't inherit a bogus RESYNC
+  // block or a spurious forced refire (the old in-guard `else` was
+  // unreachable — isSupervising() ≡ isLoopActive() || isActionableGoal()).
+  if (!isSupervising() && (postCompactResumeOwed || postCompactResyncPending)) {
+    postCompactResumeOwed = false;
+    postCompactResyncPending = false;
+  }
   // v0.32.1: post-compaction resume debt — retry on every heartbeat tick
   // past grace until a turn actually starts. Fixed-offset settles alone
   // can both lose (pi busy at 2s AND at grace+2s = a dangling chain).
@@ -1104,7 +1116,10 @@ function sendContinuation(goalId: string): void {
   }
   if (!extensionApi || extensionApiStale) return;
   try {
-    const resync = postCompactResyncPending ? buildPostCompactResync() : "";
+    let resync = "";
+    // v0.33.1: a builder throw (corrupt restored state) must not masquerade
+    // as a transport failure — send without the block instead.
+    if (postCompactResyncPending) { try { resync = buildPostCompactResync(); } catch { resync = ""; } }
     extensionApi.sendMessage({
       customType: GOAL_EVENT_ENTRY,
       content: resync + continuationPrompt(state.goal!),
@@ -1279,6 +1294,14 @@ function notifyPersistenceState(ctx: ExtensionContext): void {
 }
 
 function setGoal(goal: Goal, ctx: ExtensionContext, via = "user"): void {
+  // v0.33.1: per-goal module state resets at activation — a new goal must
+  // not inherit the previous goal's compact debt/resync, quota streak,
+  // token-message dedupe set, or widget action feed.
+  postCompactResumeOwed = false;
+  postCompactResyncPending = false;
+  quotaRetryStreak = 0;
+  countedTokenMessages.clear();
+  recentActions.length = 0;
   // v0.28.14: never silently orphan a live goal — a paused/active goal
   // being replaced is archived honestly first (the old behavior left it in
   // goals/ but untracked: "older goals lying around leading to confusion").
@@ -1397,6 +1420,8 @@ async function fanOutListAuditFindings(ctx: ExtensionContext): Promise<void> {
 }
 
 function archiveCurrentGoal(ctx: ExtensionContext, status: Status, stopReason?: string): void {
+  postCompactResumeOwed = false; // v0.33.1: the dead goal's compact debt/resync dies with it
+  postCompactResyncPending = false;
   if (!state.goal) return;
   const goal = state.goal;
   ensureDirs(ctx.cwd);
@@ -2638,7 +2663,13 @@ function sendLoopTurn(): void {
   if (!isLoopActive() || !extensionApi) return;
   const ctx = freshCtx();
   if (!ctx || !ctx.isIdle() || ctx.hasPendingMessages()) {
-    if (ctx) accountSendRearm(ctx, "loop");
+    if (!ctx) {
+      // v0.33.1: mirror sendContinuation — probe the handle (terminal exit)
+      // and advance the streak so the cadence backs off instead of spinning
+      // a flat 50ms below every watchdog.
+      if (probeExtensionApiStale()) return;
+      loopRearmStreak++;
+    } else accountSendRearm(ctx, "loop");
     loopTimer = setTimeout(() => sendLoopTurn(), sendRearmDelayMs(loopRearmStreak)); // v0.28.29: backing-off cadence
     loopTimer.unref?.();
     return;
@@ -2694,7 +2725,8 @@ function sendLoopTurn(): void {
   // instruction (metricless loops; metric loops already vary via values).
   const variantNote = metricless ? continueVariant(loop.iteration) : "";
   try {
-    const loopResync = postCompactResyncPending ? buildPostCompactResync() : "";
+    let loopResync = "";
+    if (postCompactResyncPending) { try { loopResync = buildPostCompactResync(); } catch { loopResync = ""; } } // v0.33.1
     extensionApi.sendMessage({
       customType: GOAL_EVENT_ENTRY,
       content: loopResync + loopPrompt(loop, regressionNote, strategyNote, boundsNote, interventionNote, variantNote),
@@ -5920,6 +5952,9 @@ export default function (pi: ExtensionAPI): void {
     writeOwnerFile(ctx.cwd);
     sessionReplacementUntil = 0;
     zombieStoodDown = false;
+    staleTerminalDone = false; // v0.33.1: a rebound session must be able to go terminal AGAIN (was: one-shot for the process lifetime)
+    postCompactResumeOwed = false; // v0.33.1: a compact from a previous session must not resync THIS one
+    postCompactResyncPending = false;
     const startReason = typeof event?.reason === "string" ? event.reason : "unknown";
     appendLedger(ctx.cwd, "session_rebound", { reason: startReason });
     if (extensionApiStale) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.33.0",
+  "version": "0.33.1",
   "description": "Goal. Loop. Audit. Done. \u2014 a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor \u2014 only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",