pi-goal-list-loop-audit 0.29.3 → 0.29.5

package/extensions/goal-settings.ts

@@ -152,6 +152,21 @@ export function loadSettings(cwd: string): Settings {
   ) as unknown as Settings;
 }
 
+/**
+ * v0.29.5: autoResume is GLOBAL-only (user directive 2026-07-30: "we are
+ * not supporting project level setting for it now, just global"). Launch-
+ * time restore reads this, never the project file — a stale autoResume
+ * key in a project's settings.json is ignored (junk-runner field case: a
+ * project-local opt-in from the unattended-audit era kept auto-firing the
+ * list at every bare `pi` launch after the global default flipped off).
+ */
+export function loadGlobalSettings(): Settings {
+  return mergeSettings(
+    DEFAULT_SETTINGS as unknown as Record<string, unknown>,
+    readSettingsFile(globalSettingsPath()) as Record<string, unknown>,
+  ) as unknown as Settings;
+}
+
 /** Every provenance-tracked key (the /glla headless display + UI). */
 export const SETTINGS_KEYS: Array<keyof Settings> = [
   "auditorModel",

package/extensions/loops/goal.ts

@@ -106,6 +106,7 @@ import {
   DEFAULT_SETTINGS,
   SETTINGS_KEYS,
   globalSettingsPath,
+  loadGlobalSettings,
   loadSettings,
   projectSettingsPath,
   saveSettings,
@@ -706,6 +707,10 @@ function heartbeatTick(): void {
     ctx.ui.notify(msg, "warning");
     notifyExternal(ctx, msg);
   }
+  // v0.29.5: user-abort stand-down — the chain stays DOWN until the
+  // user resumes. Without this guard the 60s heartbeat re-fired the
+  // continuation and defeated the 0.29.4 stand-down within a minute.
+  if (abortedStandDown) return;
   if (!fire) return;
   // v0.26.6: the 0.25.0 "recent ship (<5m)" suppression was REMOVED. It fed
   // lastShippedAtMs, which read the state-file MTIME — and the heartbeat's
@@ -747,6 +752,10 @@ let consecutiveErrorIterations = 0;
 // v0.28.5 (E8): user aborts are NOT provider errors — separate counter,
 // separate brake message, and no auto-resume (aborting is user intent).
 let consecutiveAbortIterations = 0;
+// v0.29.5: set when a user abort stands the chain down (0.29.4) — the
+// heartbeat refire + post-compaction refire must NOT resurrect it; only
+// an explicit schedule (resume/activate/next turn) clears it.
+let abortedStandDown = false;
 let consecutiveNoToolIterations = 0;
 
 // =================================================================
@@ -779,6 +788,7 @@ function freshCtx(): ExtensionContext | null {
 }
 
 function scheduleContinuation(ctx: ExtensionContext, force = false, delayMs?: number): void {
+  abortedStandDown = false; // v0.29.5: any explicit schedule ends the stand-down
   if (!isActionableGoal()) return;
   rememberCtx(ctx);
   const goalId = state.goal!.id;
@@ -1223,7 +1233,7 @@ function fireReviewer(
       manual: opts.manual,
       ledgerEntries,
       sources,
-      enqueueListItems: (objectives) => enqueueItems(ctx, objectives, "reviewer", { autoActivate: loadSettings(ctx.cwd).autoResume === true }),
+      enqueueListItems: (objectives) => enqueueItems(ctx, objectives, "reviewer", { autoActivate: loadGlobalSettings().autoResume === true }),
       proposeGoal: (objective, reason) => {
         try {
           extensionApi?.sendUserMessage(
@@ -3383,13 +3393,11 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
         persistState(liveCtx);
         appendLedger(liveCtx.cwd, "list_added", { id: item.id, objective: item.objective, drafted: true });
         if (!state.goal || state.goal.status === "complete" || state.goal.status === "aborted") {
-          // v0.28.28: an AUTO-ACCEPTED draft does not auto-start unless
-          // autoResume is on — accepting a draft is not consent to start.
-          if (autoAccept && loadSettings(liveCtx.cwd).autoResume !== true) {
-            liveCtx.ui.notify(`Auto-accepted and QUEUED (autoResume off — not auto-started): ${extracted.objective.slice(0, 80)} — /list next when ready.`, "info");
-            appendLedger(liveCtx.cwd, "list_autoactivation_held", { source: "draft-autoaccepted", count: 1 });
-            return { content: [{ type: "text", text: "Draft accepted and added to the list, but NOT started (the user's autoResume setting is off — auto-accepted drafts queue, they don't auto-start). Do NOT begin work. Tell the user: /list next starts it." }], details: {} };
-          }
+          // v0.29.4: an auto-accepted draft STARTS — autoAcceptDrafts is the
+          // pre-consent (the user asked for the draft in-session). The
+          // 0.28.28 autoResume hold is lifted: that setting now gates ONLY
+          // launch-time restore. The 0.29.1 zombie-twin guard already
+          // refused duplicates of just-completed work upstream.
           activateNextListItem(liveCtx);
           return { content: [{ type: "text", text: "Confirmed and activated (list was empty). Begin work now." }], details: {} };
         }
@@ -3397,20 +3405,11 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
       }
       const goal = createGoal(full, liveCtx);
       setGoal(goal, liveCtx, autoAccept ? "draft-autoaccepted" : "draft-confirmed");
-      // v0.28.28: auto-accepted goal drafts are created HELD when autoResume
-      // is off — auto-accept delegates the Confirm click, not the decision
-      // to start. Explicit user-confirmed drafts still start immediately.
-      if (autoAccept && loadSettings(liveCtx.cwd).autoResume !== true) {
-        updateGoal({
-          status: "paused",
-          pauseKind: "blocked",
-          pauseReason: "auto-accepted draft — held for the user's go-ahead (autoResume off)",
-          pauseSuggestedAction: "/goal resume to start · /goal cancel to drop · /glla autoresume=on starts auto-accepted drafts automatically",
-        }, liveCtx);
-        appendLedger(liveCtx.cwd, "draft_held", { goalId: goal.id, reason: "autoaccept-autoresume-off" });
-        liveCtx.ui.notify(`Draft auto-accepted and HELD (autoResume off): ${goal.objective.slice(0, 80)} — /goal resume to start, /goal cancel to drop.`, "info");
-        return { content: [{ type: "text", text: "Goal accepted but HELD (the user's autoResume setting is off — auto-accepted drafts do not auto-start). Do NOT begin work. Tell the user: /goal resume starts it, /goal cancel drops it." }], details: {} };
-      }
+      // v0.29.4: auto-accepted drafts START (autoAcceptDrafts is the
+      // pre-consent — the user asked for the draft in-session). autoResume
+      // no longer gates draft starts; it gates ONLY launch-time restore of
+      // persisted state ("load it but not auto start it"). Zombie twins of
+      // just-completed work are refused upstream (0.29.1).
       iterationCounter = 0;
       consecutiveErrorIterations = 0;
       consecutiveAbortIterations = 0;
@@ -5071,7 +5070,7 @@ export default function (pi: ExtensionAPI): void {
       const c = freshCtx();
       if (!c) return;
       try {
-        if (c.isIdle() && !c.hasPendingMessages() && continuationTimer === null && loopTimer === null && isSupervising()) {
+        if (c.isIdle() && !c.hasPendingMessages() && continuationTimer === null && loopTimer === null && isSupervising() && !abortedStandDown) {
           appendLedger(c.cwd, "compaction_refire", {});
           if (isLoopActive()) scheduleLoopTick(c);
           else scheduleContinuation(c, true);
@@ -5196,12 +5195,13 @@ export default function (pi: ExtensionAPI): void {
     // Restore gate (v0.26.9 tri-state): a human LOADING a session
     // ("startup"/"new"/"resume", or no reason) HOLDS — the popup shows what
     // is waiting and nothing starts until they resume explicitly. In-session
-    // machinery ("reload"/"fork") auto-resumes. /glla autoresume=on opts a
-    // project into auto-resume everywhere (unattended rigs); autoresume=off
-    // never auto-resumes. Once running, the chain auto-continues forever
-    // unless a super-stuck brake (stall escalation / stale-api / latch)
-    // stops it loudly.
-    const autoResumeSetting = resolveEffectiveAggressiveSettings(loadSettings(ctx.cwd)).autoResume;
+    // machinery ("reload"/"fork") auto-resumes. /glla autoresume=on opts
+    // into auto-resume everywhere (unattended rigs); autoresume=off never
+    // auto-resumes. v0.29.5: the setting is GLOBAL-only — project-level
+    // autoResume keys are ignored. Once running, the chain auto-continues
+    // forever unless a super-stuck brake (stall escalation / stale-api /
+    // latch) stops it loudly.
+    const autoResumeSetting = resolveEffectiveAggressiveSettings(loadGlobalSettings()).autoResume;
     const autoResume = shouldAutoResumeOnSessionStart(event?.reason, autoResumeSetting);
     // v0.25.0 (contract item 6): aggressiveMode announces every auto-event.
     if (
@@ -5223,7 +5223,7 @@ export default function (pi: ExtensionAPI): void {
         state.loop = { ...l, active: false, stopReason: HELD_ON_RESTORE };
         persistState(ctx);
         ctx.ui.notify(
-          `Loop held on restore: ${l.target.slice(0, 60)} — /loop resume to continue, /glla autoresume=on to auto-resume on session load in this project.`,
+          `Loop held on restore: ${l.target.slice(0, 60)} — /loop resume to continue, /glla autoresume=on to auto-resume on session load (global setting).`,
           "info",
         );
       }
@@ -5250,7 +5250,7 @@ export default function (pi: ExtensionAPI): void {
         // v0.22.7: name WHAT is held — a list head resumes through /list.
         const isListItem = state.goal.policy === "list";
         const resumeCmd = isListItem ? "/list resume" : "/goal resume";
-        const resumeHint = `${resumeCmd} to continue${queued > 0 ? ` (+${queued} waiting in the list)` : ""} · /glla autoresume=on to auto-resume in this project`;
+        const resumeHint = `${resumeCmd} to continue${queued > 0 ? ` (+${queued} waiting in the list)` : ""} · /glla autoresume=on to auto-resume on load (global setting)`;
         updateGoal({
           status: "paused",
           pauseKind: "blocked",
@@ -5367,6 +5367,12 @@ export default function (pi: ExtensionAPI): void {
         // "unproductive turns" pause). pi's own retry owns the backoff;
         // the nudge counter neither increments nor resets on these turns.
         appendLedger(ctx.cwd, "stall_nudge_exempt_error", { nudgesSoFar: heartbeatNudges });
+      } else if (lastA?.stopReason === "aborted") {
+        // v0.29.4: user aborts are not model unproductivity either — the
+        // user pressed Esc. Counting the interrupt tripped the stall brake
+        // on the USER's action (pully field case: Esc-spam → STALL WARNING
+        // 1/3, 2/3 → a bogus "stalled" pause). Neither increment nor reset.
+        appendLedger(ctx.cwd, "stall_nudge_exempt_aborted", { nudgesSoFar: heartbeatNudges });
       } else {
       const s = loadSettings(ctx.cwd);
       const shortWordsThr = s.stallShortWords ?? DEFAULT_STALL_SHORT_WORDS;
@@ -5529,6 +5535,14 @@ export default function (pi: ExtensionAPI): void {
         appendLedger(ctx.cwd, "goal_paused", { reason: "5 consecutive aborts (user interrupted)" });
         return;
       }
+      // v0.29.4: an abort stands the chain DOWN — no auto re-fire. The old
+      // fall-through re-fired the continuation immediately, so every Esc
+      // was answered by another turn under the user's hands ("it auto
+      // triggered and I kept spamming esc on it" — pully, 2026-07-30).
+      ctx.ui.notify(`${goalNoun()} standing down — turn aborted by user (not counted toward stalls). /goal resume to continue, /goal cancel to stop.`, "info");
+      abortedStandDown = true; // v0.29.5: heartbeat/compaction refires must not resurrect the chain
+      appendLedger(ctx.cwd, "abort_stand_down", { consecutiveAborts: consecutiveAbortIterations });
+      return;
     } else {
       consecutiveErrorIterations = 0;
       consecutiveAbortIterations = 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.29.3",
+  "version": "0.29.5",
   "description": "Goal. Loop. Audit. Done. \u2014 a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor \u2014 only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",