pi-goal-list-loop-audit 0.28.9 → 0.28.11

package/README.md

@@ -27,7 +27,7 @@ Install:
 pi install npm:pi-goal-list-loop-audit
 ```
 
-Four top-level commands, that's all:
+Five top-level commands — `/goal`, `/list`, `/loop`, `/glla`, `/review`:
 
 ```
 /goal                              # drafting: agent grills, you Confirm
@@ -40,12 +40,13 @@ Four top-level commands, that's all:
 /goal cancel                       # abort
 /goal tweak "<new objective>"      # edit in place (Confirm dialog)
 /goal archive                      # archived goals, newest first
-/glla                               # open the settings UI (or /glla key=value)
+/glla                               # settings UI table · /glla key=value · /glla stats · /glla audits [N|full] · /glla postaudit · /glla autoaccept=on
 /list fix the login bug, add dark mode, write docs   # dump it — the agent shapes it into items, one Confirm
 /list plan.md                      # file detected → bulk import, one Confirm (sisyphus/Ralph style)
 /list <paste a checklist>          # multi-line paste → same batch flow
 /list "fix the flaky test. Done when: npm test green"   # explicit contract → added directly, no interview
 /list                              # show the list (add/import are optional no-op aliases — detection routes everything)
+```
 
 (Or just say it: "queue these 10 things…" — the agent manages the list too.)
 
@@ -53,6 +54,8 @@ Four top-level commands, that's all:
 `/list next <n>` or the agent's `list_activate` tool picks any item — with
 subagents, what gets worked next is a choice, not a position. Numbering always
 matches `/list show`.
+
+```
 /list                              # show active + waiting items
 /list next                         # skip current, activate next
 /list remove <n>                   # drop item n from the list
@@ -67,6 +70,7 @@ matches `/list show`.
 /loop start "keep improving SPEC.md" measure=none max=20   # metricless with an explicit cap (v0.23.0)
 /loop status                       # iteration, best, stall, recent values
 /loop stop                         # halt with summary
+/review <goal-id> [off|on|auto|aggressive]   # re-review an archived goal (bypasses the trigger gates)
 ```
 
 **Metricless loops** (`measure=none`): for genuinely endless work — an
@@ -311,7 +315,7 @@ prompts/
   goal-loop-forever-draft.md   # /loop drafting prompt
 scripts/
   smoke.sh                     # live integration harness (tmux + real models)
-tests/                         # 168 unit tests, no live pi required
+tests/                         # 545 tests across 58 files, no live pi required (mock-ctx harness drives the orchestrator)
 docs/DESIGN.md                 # architectural decisions
 PLAN.md                        # milestones, decisions, gates
 ```

package/extensions/goal-loop-display.ts

@@ -144,11 +144,11 @@ export function buildStatusText(state: State, audit?: AuditDisplayProgress | nul
       return `glla: ${g.policy} ${paint(theme, "error", "⚠ interrupted — stale handle · auto-resumes on pi restart")}`;
     }
     // v0.24.7: list policy gets its own wording — a queue item is not a goal.
-    // Before: "glla: list ● 3m 19s · list 29" (policy label AND queue counter
-    // both said "list"). After: "glla: list ● 3m 19s · 29 queued". Goal
-    // policy keeps the bare "list N" suffix (no duplication there).
+    // v0.28.11 (U10): goal policy joins it — "list 29" read as a command
+    // fragment; "29 queued" says what the number IS. Both policies now
+    // render "… · N queued".
     const n = state.list?.length ?? 0;
-    const queue = n === 0 ? "" : g.policy === "list" ? ` · ${n} queued` : ` · list ${n}`;
+    const queue = n === 0 ? "" : ` · ${n} queued`;
     const tasks = g.taskList ? ` ${countDone(g)}/${countTotal(g)} tasks ·` : "";
     return `glla: ${g.policy} ${paint(theme, "success", "●")}${tasks} ${fmtElapsed(now - Date.parse(g.createdAt))}${queue}`;
   }
@@ -275,7 +275,7 @@ function goalLines(g: Goal, state: State, audit: AuditDisplayProgress | null | u
   const queue = state.list?.length ?? 0;
   const footer = isList
     ? `${queue > 0 ? `${queue} queued · ` : ""}/list · /glla`
-    : `${queue > 0 ? `list ${queue} · ` : ""}/goal status · /glla`;
+    : `${queue > 0 ? `${queue} queued · ` : ""}/goal status · /glla`;
   lines.push(`└─ ${paint(theme, "dim", footer)}`);
   return lines;
 }

package/extensions/loops/goal.ts

@@ -758,6 +758,9 @@ function persistState(ctx: ExtensionContext): void {
 // once per recovery. The TUI flag (buildWidgetLines) carries the standing
 // state; these notifies are the LOUD part.
 let persistenceDegradedNotified = false;
+
+/** v0.28.11 (U9): objective-first notifies — truncate long objectives. */
+const shortObj = (s: string): string => (s.length > 90 ? `${s.slice(0, 87)}…` : s);
 function notifyPersistenceState(ctx: ExtensionContext): void {
   if (isPersistenceDegraded() && !persistenceDegradedNotified) {
     persistenceDegradedNotified = true;
@@ -885,7 +888,7 @@ function fireReviewer(
           // to still count as "proposed" in the report + notify. Now the
           // failure is LOUD and the proposal goes uncounted.
           ctx.ui.notify(
-            `Reviewer /goal proposal NOT delivered: ${err instanceof Error ? err.message : String(err)} — the follow-up never reached the session. Restart pi if the session was just replaced.`,
+            `Postaudit /goal proposal NOT delivered: ${err instanceof Error ? err.message : String(err)} — the follow-up never reached the session. Restart pi if the session was just replaced.`,
             "warning",
           );
           return false;
@@ -895,7 +898,7 @@ function fireReviewer(
       ledger: (type, value) => appendLedger(ctx.cwd, type, value),
     });
     if (!outcome.fired && outcome.suppressedReason && opts.manual) {
-      ctx.ui.notify(`Reviewer suppressed: ${outcome.suppressedReason}`, "info");
+      ctx.ui.notify(`Postaudit suppressed: ${outcome.suppressedReason}`, "info");
     }
     // v0.27.5: surface the silent review to interactive users. The internal
     // runReviewer notify fires DURING the goal-completion handler, easy to
@@ -911,7 +914,7 @@ function fireReviewer(
       );
     }
   } catch (err) {
-    ctx.ui.notify(`Reviewer failed (non-fatal): ${err instanceof Error ? err.message : String(err)}`, "warning");
+    ctx.ui.notify(`Postaudit failed (non-fatal): ${err instanceof Error ? err.message : String(err)}`, "warning");
   }
 }
 
@@ -1088,10 +1091,10 @@ async function cmdSet(args: string, ctx: ExtensionContext, skipDraft = false): P
     // v0.28.1 (S3): the goal is persisted — mark the interrupt so the next
     // fresh session auto-resumes, and tell the truth instead of "starting now".
     updateGoal({ interruptedAt: nowIso(), interruptedReason: "created in a stale session" }, ctx);
-    ctx.ui.notify(`Goal ${goal.id} created and safe in .pi-glla/ — this stale process can't send continuations. Restart pi and it auto-resumes.`, "warning");
+    ctx.ui.notify(`Goal saved: ${shortObj(goal.objective)} — safe in .pi-glla/, but this stale process can't send continuations. Restart pi and it auto-resumes. (id: ${goal.id})`, "warning");
     return;
   }
-  ctx.ui.notify(`Goal ${goal.id} created — starting now. Auditor will verify on completion.`, "info");
+  ctx.ui.notify(`Goal started: ${shortObj(goal.objective)} — the auditor will verify on completion. (id: ${goal.id})`, "info");
   scheduleContinuation(ctx, true);
 }
 
@@ -3453,17 +3456,17 @@ async function cmdToolOverride(args: string, ctx: ExtensionContext): Promise<voi
     if (action === "allow") {
       const allow = current.allow ?? [];
       if (!allow.includes(tool)) apply({ allow: [...allow, tool] });
-      ctx.ui.notify(`toolOverrides.allow += ${tool}`, "info");
+      ctx.ui.notify(`"${tool}" is now always visible to the agent (project override saved).`, "info");
     } else if (action === "hide") {
       const hide = current.hide ?? [];
       if (!hide.includes(tool)) apply({ hide: [...hide, tool] });
-      ctx.ui.notify(`toolOverrides.hide += ${tool}`, "info");
+      ctx.ui.notify(`"${tool}" is now always hidden from the agent (project override saved).`, "info");
     } else if (action === "unallow") {
       apply({ allow: (current.allow ?? []).filter((t) => t !== tool) });
-      ctx.ui.notify(`toolOverrides.allow -= ${tool}`, "info");
+      ctx.ui.notify(`"${tool}" visibility override removed — the session decides again.`, "info");
     } else {
       apply({ hide: (current.hide ?? []).filter((t) => t !== tool) });
-      ctx.ui.notify(`toolOverrides.hide -= ${tool}`, "info");
+      ctx.ui.notify(`"${tool}" hide override removed — the session decides again.`, "info");
     }
     return;
   }
@@ -3490,7 +3493,12 @@ async function cmdToolOverride(args: string, ctx: ExtensionContext): Promise<voi
     }
     cfg[tool] = toolCfg;
     apply({ perToolConfig: cfg });
-    ctx.ui.notify(`toolOverrides.perToolConfig.${tool} ${action === "set" ? "set" : "unset"}`, "info");
+    ctx.ui.notify(
+      action === "set"
+        ? `"${tool}" setting saved: ${kv.slice(0, kv.indexOf("="))} = ${JSON.stringify(toolCfg[kv.slice(0, kv.indexOf("="))])} (project override).`
+        : `"${tool}" setting "${kv}" removed — back to the built-in default.`,
+      "info",
+    );
     return;
   }
   ctx.ui.notify(`Unknown tooloverride action: ${action}. Use: list | allow | hide | unallow | unhide | set | unset.`, "warning");
@@ -3530,7 +3538,7 @@ async function cmdReviewerSettings(ctx: ExtensionContext): Promise<void> {
     const cfg = load();
     let choice: string | undefined;
     try {
-      choice = await ctx.ui.select("Reviewer — post-completion follow-up enqueuer (project settings)", reviewerMenuOptions(cfg));
+      choice = await ctx.ui.select("Postaudit — post-completion follow-up enqueuer (project settings)", reviewerMenuOptions(cfg));
     } catch {
       return;
     }
@@ -3557,8 +3565,10 @@ async function cmdReviewerSettings(ctx: ExtensionContext): Promise<void> {
         const n = Number(v?.trim());
         if (Number.isSafeInteger(n) && n >= 1 && n <= 100) save({ maxReviewsPerDay: n });
       }
-    } catch {
-      /* individual save failures are non-fatal */
+    } catch (err) {
+      // v0.28.11 (E7): a swallowed save failure made the user believe the
+      // toggle landed. Loud now.
+      ctx.ui.notify(`Postaudit setting NOT saved: ${err instanceof Error ? err.message : String(err)} — check .pi-glla/settings.json permissions.`, "warning");
     }
   }
 }
@@ -4041,7 +4051,7 @@ export default function (pi: ExtensionAPI): void {
     handler: settingsHandler,
   });
   pi.registerCommand("review", {
-    description: "Manually run the reviewer on an archived goal: /review <goal-id> [auto|report|default] — extracts findings, writes a report to .pi-glla/reviews/, cascades per the mode (auto = auto-loop, no Confirms). Bypasses the trigger gates (explicit user request).",
+    description: "Manually run the postaudit on an archived goal: /review <goal-id> [off|on|auto|aggressive] — extracts findings, writes a report to .pi-glla/reviews/, cascades per the mode (auto/aggressive = no Confirms). Bypasses the trigger gates (explicit user request).",
     handler: (args: string, ctx: ExtensionContext) => { rememberCtx(ctx); return cmdReview(args, ctx); },
   });
   pi.registerCommand("list", {

package/extensions/reviewer.ts

@@ -226,27 +226,27 @@ export function runReviewer(
   deps: ReviewerDeps,
 ): ReviewerOutcome {
   const none = (suppressedReason: string): ReviewerOutcome => ({ fired: false, suppressedReason, enqueued: 0, proposed: 0 });
-  if (!config.enabled && !deps.manual) return none("reviewer disabled");
+  if (!config.enabled && !deps.manual) return none("the postaudit is disabled (/glla postaudit → Enabled)");
   // v0.27.5: "off" mode is the user-friendly way to silence the postaudit
   // — equivalent to enabled=false but exposed via the postaudit menu.
-  if (config.mode === "off" && !deps.manual) return none("postaudit mode = off");
+  if (config.mode === "off" && !deps.manual) return none("postaudit mode is off (/glla postaudit → Mode)");
   const event = source.kind === "goal" ? `${source.terminal}` : "list-complete";
   if (!deps.manual) {
-    if (config.doNotFireOn.includes(event)) return none(`doNotFireOn: ${event}`);
-    if (source.kind === "goal" && source.terminal !== "goal-complete") return none(`not a completion: ${source.terminal}`);
-    if (!config.fireOn.includes(source.kind === "goal" ? "goal-complete" : "list-complete")) return none("fireOn excludes this event");
+    if (config.doNotFireOn.includes(event)) return none(`this event type (${event}) is excluded in /glla postaudit → fire-on`);
+    if (source.kind === "goal" && source.terminal !== "goal-complete") return none(`the goal ended as ${source.terminal}, not a completion — no follow-up fires`);
+    if (!config.fireOn.includes(source.kind === "goal" ? "goal-complete" : "list-complete")) return none("this event type is excluded in /glla postaudit → fire-on");
     // v0.26.2: in auto mode the queue emptying is the cascade's natural
     // rhythm, not a runaway — the refire window must not strangle it.
     // (The per-day cap below still bounds everything.)
     const refireWindowApplies = !(config.mode === "auto" && source.kind === "list");
     if (refireWindowApplies && reviewerFiredRecently(deps.ledgerEntries, REVIEWER_REFIRE_WINDOW_MS, deps.nowMs)) {
       deps.ledger("reviewer_suppressed", { reason: "refire-window", goalId: source.goalId });
-      return none("reviewer fired within the last 5 minutes (runaway prevention)");
+      return none("a postaudit ran within the last 5 minutes (runaway prevention)");
     }
     const today = reviewsToday(deps.ledgerEntries, deps.nowMs);
     if (today >= config.maxReviewsPerDay) {
       deps.ledger("reviewer_suppressed", { reason: "day-cap", count: today, cap: config.maxReviewsPerDay, goalId: source.goalId });
-      return none(`day cap reached (${today}/${config.maxReviewsPerDay})`);
+      return none(`daily postaudit cap reached (${today}/${config.maxReviewsPerDay}) — /glla postaudit → Max reviews`);
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.28.9",
+  "version": "0.28.11",
   "description": "Goal. Loop. Audit. Done. \u2014 a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor \u2014 only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",

package/prompts/goal-loop-continuation.md

@@ -93,21 +93,28 @@ Do NOT spawn more subagents of the failed type until quota resets — you will j
 
 ## DETACHED COMMIT DETECTION
 
-If your commits keep getting rewritten away (same content, new SHA — or worse, content reverted), check the auto-committer daemon BEFORE diagnosing yourself as stuck or broken:
+If your commits keep getting rewritten away (same content, new SHA — or worse, content reverted), check for an **auto-commit daemon** BEFORE diagnosing yourself as stuck or broken. **Skip this section entirely if your rig has no auto-committer** — most rigs don't. (The maintainer's rigs run one called `dracon-sync`; yours may run a different one, or none.)
+
+Generic forensics (safe everywhere):
 
 ```bash
 git reflog --date=iso | grep -E "filter-branch|filter-repo"
 git reflog --date=iso | grep -E ": reset:"
+```
+
+If those show rewrites you didn't make, find the daemon (example for the maintainer's rig — adapt the pattern to yours):
+
+```bash
 ps -fea | grep -E "dracon-sync|filter-repo" | grep -v grep
 ```
 
-The auto-committer (`dracon-sync daemon`) may be running `auto_rewrite_large_blobs` on your commits. The fix is NOT to keep re-committing — it is to:
+An auto-committer may be rewriting your commits (e.g. `dracon-sync daemon` running `auto_rewrite_large_blobs`). The fix is NOT to keep re-committing — it is to:
 
-1. Pause the daemon (`dracon-sync pause`, or write the `.pi-glla/.pause-auto-commit` sentinel via the goal tools).
-2. Investigate the rewrite trigger (daemon config `max_push_blob_bytes`, `auto_rewrite_large_blobs`).
+1. Pause the daemon if one exists (on the maintainer's rigs: `dracon-sync pause`, or write the `.pi-glla/.pause-auto-commit` sentinel via the goal tools).
+2. Investigate the rewrite trigger (for `dracon-sync`: daemon config `max_push_blob_bytes`, `auto_rewrite_large_blobs`).
 3. Add `.pi-glla/` to the daemon's exclude list.
 
-Do NOT conclude "the loop is too eager" or "I am broken" before checking what the daemon is doing — the daemon rewriting your commits makes YOUR loop look broken when it is not.
+Do NOT conclude "the loop is too eager" or "I am broken" before checking what a daemon is doing — a daemon rewriting your commits makes YOUR loop look broken when it is not.
 
 ## TASK WORKFLOW