pi-goal-list-loop-audit 0.28.19 → 0.28.21

package/README.md

@@ -203,7 +203,7 @@ No external watchdog plugin needed.
 /glla tokenlimit=10000000            # per-goal token budget (default: off) → GLOBAL
 /glla tokenlimit=0                   # explicitly no cap (the default)
 /glla wedgealert=30                  # hung-command alert minutes (default: 30, 0 = off)
-/glla autoresume=on                  # auto-resume goals/loops on session LOAD too (default: hold on load, auto-resume on reload/fork; off: never)
+/glla autoresume=on                  # auto-resume goals/loops on ANY session start (default: load HELD, never auto-start — explicit /goal resume, /list resume, or /loop; off: never)
 /glla auditcap=5                     # pause the goal after N consecutive auditor disapprovals (default 5, 0 = unlimited)
 /glla aggressivemode=on               # keep-going defaults: autoResume, cap 10, stuck 10, wedge off, quota auto-retry, cap→TODOs
 /glla quotaretryminutes=60            # minutes before auto-retrying a quota-exhausted auditor

package/extensions/goal-loop-core.ts

@@ -728,21 +728,21 @@ export function cloneGoal(goal: Goal): Goal {
  * setting for unattended restarts). One mechanical predicate; no heuristics.
  */
 export function shouldAutoResumeOnSessionStart(reason: string | undefined, autoResume: boolean | undefined): boolean {
-  // v0.26.9 tri-state:
-  //   true      → auto-resume on EVERY session start (unattended rigs).
+  // v0.28.21: the DEFAULT flipped to hold-everything (user directive:
+  // "load it on session load but not auto start it"). Tri-state:
+  //   true      → auto-resume on EVERY session start (unattended rigs;
+  //               /glla autoresume=on — this is the ONLY auto-resume path).
   //   false     → never auto-resume; always hold for an explicit resume.
-  //   undefined → DEFAULT: a human LOADING a session ("startup"/"new"/
-  //               "resume", or old pi reporting no reason) must not trigger
-  //               work — show the held popup, they resume explicitly.
-  //               In-session MACHINERY ("reload"/"fork") auto-resumes so an
-  //               extension reload or session fork never strands work.
+  //   undefined → DEFAULT: never auto-resume either — whatever the reason
+  //               ("startup"/"new"/"resume"/"reload"/"fork"/none), the
+  //               item is LOADED (visible, state intact) but HELD until an
+  //               explicit /goal resume, /list resume, or /loop.
   // Mid-session continuation (agent_end chains, heartbeat refires,
   // post-compaction, list/loop transitions) is not gated here at all — it
   // auto-continues forever unless a super-stuck brake (stall escalation,
   // stale-api terminal, pending-latch watchdog) stops it loudly.
-  if (autoResume === true) return true;
-  if (autoResume === false) return false;
-  return reason === "reload" || reason === "fork";
+  void reason; // retained for the signature; no reason auto-resumes by default anymore
+  return autoResume === true;
 }
 
 /**

package/extensions/loops/goal.ts

@@ -1194,9 +1194,9 @@ async function cmdSet(args: string, ctx: ExtensionContext, skipDraft = false): P
   consecutiveNoToolIterations = 0;
   if (staleEntry) {
     // v0.28.1 (S3): the goal is persisted — mark the interrupt so the next
-    // fresh session auto-resumes, and tell the truth instead of "starting now".
+    // fresh session LOADS it (held by default since v0.28.21), and tell the truth instead of "starting now".
     updateGoal({ interruptedAt: nowIso(), interruptedReason: "created in a stale session" }, ctx);
-    ctx.ui.notify(`Goal saved: ${shortObj(goal.objective)} — safe in .pi-glla/, but this stale process can't send continuations. Restart pi and it auto-resumes. (id: ${goal.id})`, "warning");
+    ctx.ui.notify(`Goal saved: ${shortObj(goal.objective)} — safe in .pi-glla/, but this stale process can't send continuations. Restart pi, then /goal resume (v0.28.21: session loads no longer auto-start by default). (id: ${goal.id})`, "warning");
     return;
   }
   ctx.ui.notify(`Goal started: ${shortObj(goal.objective)} — the auditor will verify on completion. (id: ${goal.id})`, "info");
@@ -1239,6 +1239,13 @@ async function cmdPause(ctx: ExtensionContext): Promise<void> {
 
 async function cmdResume(ctx: ExtensionContext): Promise<void> {
   if (!state.goal || state.goal.status !== "paused") return;
+  // v0.28.21: one-active-thing — the LAST unguarded activation path. A
+  // paused goal/list-item must not resume over a live loop (covers
+  // /goal resume AND /list resume, which routes here).
+  if (isLoopActive()) {
+    ctx.ui.notify("A loop is active — one active thing at a time. /loop stop it first, then resume the goal.", "warning");
+    return;
+  }
   // v0.28.1 (S1/S3): resuming in a stale session used to flip status to
   // active, claim "Resumed goal", then re-pause on the stale send failure
   // (or zombie — S1). Now: persist the resume (the next fresh session
@@ -4460,12 +4467,13 @@ export default function (pi: ExtensionAPI): void {
         );
       }
     } else if (state.goal && state.goal.status === "active" && state.goal.autoContinue) {
-      // v0.28.3 (S2 completed): an infra interrupt outranks the DEFAULT
-      // hold — the goal never chose to stop; pi killed its handle. With
-      // autoresume unset, an interrupted goal auto-resumes even on a human
-      // session load; explicit /glla autoresume=off still holds.
       const wasInterrupted = !!state.goal.interruptedAt;
-      if (autoResume || (wasInterrupted && autoResumeSetting !== false)) {
+      // v0.28.21: the 0.28.3 interrupted-goal exemption is SUPERSEDED —
+      // the default is now hold-everything on session load (user directive:
+      // "load it but not auto start it"). Interrupted goals hold like
+      // everything else; autoresume=on (unattended rigs) still auto-resumes
+      // them, and the marker is cleared only on that promised auto-resume.
+      if (autoResume) {
         // v0.28.1 (S2): clear the stale-handle interrupt marker — this IS
         // the auto-resume the marker promised.
         if (wasInterrupted) updateGoal({ interruptedAt: undefined, interruptedReason: undefined }, ctx);
@@ -4506,6 +4514,22 @@ export default function (pi: ExtensionAPI): void {
         ctx.ui.notify(`List has ${listQueue().length} item(s) waiting — /list next to activate the head.`, "info");
       }
     }
+    // v0.28.21: enforce one-active-thing at the restore boundary for DIRTY
+    // legacy states — pre-guard versions could persist an active goal AND
+    // an active/held loop; the chain above handles the loop first, and the
+    // goal would otherwise stay active and fire on agent_end. Pause it:
+    // at most one thing owns the active slot, and nothing auto-starts.
+    if (state.loop && state.goal && state.goal.status === "active") {
+      updateGoal({
+        status: "paused",
+        pauseReason: "held on session load — the loop owns the active slot (one active thing at a time)",
+        pauseSuggestedAction: "/loop to work the loop, or /loop stop then /goal resume to work the goal",
+      }, ctx);
+      ctx.ui.notify(
+        `Goal [${state.goal.id}] held — a loop also exists; one active thing at a time. /loop to resume the loop, or /loop stop then /goal resume.`,
+        "info",
+      );
+    }
     // Always paint on session load (v0.22.1): the branches above only reach
     // refreshUI via persistState, so a goal that was ALREADY paused (or any
     // state that doesn't mutate on load) rendered nothing — "can't tell if

package/extensions/settings-menu.ts

@@ -70,7 +70,7 @@ export interface SettingsRow {
   label: string;
   /** VALUE column — current effective value, e.g. `true` / `(off)` / `60`. */
   valueText: string;
-  /** SOURCE column — provenance tag, one of `[project]` / `[global]` / `[default]`. */
+  /** SOURCE column — provenance tag: `project` / `global` / `default` / `runtime` (v0.28.20: bare — brackets were chrome). */
   sourceText: string;
   /** DESCRIPTION column — one-line explanation; truncated with ellipsis when narrow. */
   description: string;
@@ -116,7 +116,7 @@ export function buildSettingsRows(
     const p = provFor(k);
     return p.value === undefined ? fallback : String(p.value);
   };
-  const src = (k: keyof Settings): string => `[${provFor(k).source}]`;
+  const src = (k: keyof Settings): string => provFor(k).source;
 
   const rows: SettingsRow[] = [];
 
@@ -135,7 +135,7 @@ export function buildSettingsRows(
       id: "autoAcceptDrafts",
       section: "keep-going",
       label: "Auto-accept drafts",
-      valueText: show("autoAcceptDrafts", "(off)"),
+      valueText: show("autoAcceptDrafts", "off"),
       sourceText: src("autoAcceptDrafts"),
       description: "on: goal/loop drafts activate without the Confirm dialog (unattended rigs)",
     },
@@ -143,7 +143,7 @@ export function buildSettingsRows(
       id: "aggressiveMode",
       section: "keep-going",
       label: "Aggressive mode",
-      valueText: show("aggressiveMode", "(off)"),
+      valueText: show("aggressiveMode", "off"),
       sourceText: src("aggressiveMode"),
       description:
         "flips DEFAULTS toward keep-going (autoResume, cap 10, stuck 10, wedge off, quota auto-retry, cap→TODOs); explicit per-key settings still win",
@@ -156,7 +156,7 @@ export function buildSettingsRows(
       id: "auditorModel",
       section: "auditor",
       label: "Auditor model",
-      valueText: show("auditorModel", "(pi session model)"),
+      valueText: show("auditorModel", "pi session model"),
       sourceText: src("auditorModel"),
       description: "provider/model override for the isolated auditor",
     },
@@ -164,7 +164,7 @@ export function buildSettingsRows(
       id: "auditorThinkingLevel",
       section: "auditor",
       label: "Auditor thinking",
-      valueText: show("auditorThinkingLevel", "(session, floor high)"),
+      valueText: show("auditorThinkingLevel", "session, floor high"),
       sourceText: src("auditorThinkingLevel"),
       description: "thinking level for the auditor session",
     },
@@ -172,7 +172,7 @@ export function buildSettingsRows(
       id: "auditCap",
       section: "auditor",
       label: "Audit cap",
-      valueText: show("auditCap", `(${defaults.auditCap})`),
+      valueText: show("auditCap", `${defaults.auditCap}`),
       sourceText: src("auditCap"),
       description: "pause the goal after N consecutive disapprovals (0 = unlimited)",
     },
@@ -182,7 +182,7 @@ export function buildSettingsRows(
       label: "Audit feedback chars",
       valueText: show(
         "auditFeedbackChars",
-        DEFAULT_AUDIT_FEEDBACK_CHARS === 0 ? "(full report)" : `(${DEFAULT_AUDIT_FEEDBACK_CHARS})`,
+        DEFAULT_AUDIT_FEEDBACK_CHARS === 0 ? "full report" : `${DEFAULT_AUDIT_FEEDBACK_CHARS}`,
       ),
       sourceText: src("auditFeedbackChars"),
       description: "cap the executor-visible disapproval report (0 = full report)",
@@ -191,7 +191,7 @@ export function buildSettingsRows(
       id: "quotaRetryMinutes",
       section: "auditor",
       label: "Quota retry minutes",
-      valueText: show("quotaRetryMinutes", `(${DEFAULT_QUOTA_RETRY_MINUTES})`),
+      valueText: show("quotaRetryMinutes", `${DEFAULT_QUOTA_RETRY_MINUTES}`),
       sourceText: src("quotaRetryMinutes"),
       description: "auto-retry a quota-exhausted auditor after N minutes",
     },
@@ -203,7 +203,7 @@ export function buildSettingsRows(
       id: "wedgeAlertMinutes",
       section: "stall-brakes",
       label: "Wedge alert minutes",
-      valueText: show("wedgeAlertMinutes", `(${WEDGE_ALERT_DEFAULT_MINUTES})`),
+      valueText: show("wedgeAlertMinutes", `${WEDGE_ALERT_DEFAULT_MINUTES}`),
       sourceText: src("wedgeAlertMinutes"),
       description: "hung-command alert while the session is busy (0 = off)",
     },
@@ -211,7 +211,7 @@ export function buildSettingsRows(
       id: "stuckMaxInterventions",
       section: "stall-brakes",
       label: "Stuck max interventions",
-      valueText: show("stuckMaxInterventions", `(${defaults.stuckMaxInterventions})`),
+      valueText: show("stuckMaxInterventions", `${defaults.stuckMaxInterventions}`),
       sourceText: src("stuckMaxInterventions"),
       description: "consecutive stuck interventions before a loop stops",
     },
@@ -219,7 +219,7 @@ export function buildSettingsRows(
       id: "stallEscalationRefires",
       section: "stall-brakes",
       label: "Stall escalation refires",
-      valueText: show("stallEscalationRefires", `(${DEFAULT_STALL_ESCALATION_REFIRES})`),
+      valueText: show("stallEscalationRefires", `${DEFAULT_STALL_ESCALATION_REFIRES}`),
       sourceText: src("stallEscalationRefires"),
       description:
         "heartbeat refires with no turn before the goal pauses / loop stops (0 = never)",
@@ -228,7 +228,7 @@ export function buildSettingsRows(
       id: "stallShortWords",
       section: "stall-brakes",
       label: "Stall short words",
-      valueText: show("stallShortWords", `(${DEFAULT_STALL_SHORT_WORDS})`),
+      valueText: show("stallShortWords", `${DEFAULT_STALL_SHORT_WORDS}`),
       sourceText: src("stallShortWords"),
       description: "turns with no tools AND fewer words than this count as a nudge",
     },
@@ -236,7 +236,7 @@ export function buildSettingsRows(
       id: "stallSimilarityThreshold",
       section: "stall-brakes",
       label: "Stall similarity threshold",
-      valueText: show("stallSimilarityThreshold", `(${DEFAULT_STALL_SIM_THRESHOLD})`),
+      valueText: show("stallSimilarityThreshold", `${DEFAULT_STALL_SIM_THRESHOLD}`),
       sourceText: src("stallSimilarityThreshold"),
       description:
         "no-tool turns whose text is > this similar to the prior turn count as a nudge (0–1)",
@@ -249,7 +249,7 @@ export function buildSettingsRows(
       id: "subagentModelStrategy",
       section: "subagents",
       label: "Subagent model strategy",
-      valueText: show("subagentModelStrategy", "(inherit-parent)"),
+      valueText: show("subagentModelStrategy", "inherit-parent"),
       sourceText: src("subagentModelStrategy"),
       description:
         "inherit-parent shares your session model + quota pool; agent-default uses the upstream pi-subagents default agents",
@@ -258,45 +258,52 @@ export function buildSettingsRows(
       id: "subagentModelOverrides.Explore",
       section: "subagents",
       label: "Subagent Explore pin",
-      valueText: settings.subagentModelOverrides?.Explore ?? "(follows strategy)",
+      valueText: settings.subagentModelOverrides?.Explore ?? "follows strategy",
       sourceText:
         settings.subagentModelOverrides?.Explore !== undefined
           ? src("subagentModelOverrides")
-          : "[default]",
+          : "default",
       description: "provider/model pin; always wins over strategy",
     },
     {
       id: "subagentModelOverrides.Plan",
       section: "subagents",
       label: "Subagent Plan pin",
-      valueText: settings.subagentModelOverrides?.Plan ?? "(follows strategy)",
+      valueText: settings.subagentModelOverrides?.Plan ?? "follows strategy",
       sourceText:
         settings.subagentModelOverrides?.Plan !== undefined
           ? src("subagentModelOverrides")
-          : "[default]",
+          : "default",
       description: "provider/model pin; always wins over strategy",
     },
     {
       id: "subagentModelOverrides.general-purpose",
       section: "subagents",
       label: "Subagent general-purpose pin",
-      valueText: settings.subagentModelOverrides?.["general-purpose"] ?? "(follows strategy)",
+      valueText: settings.subagentModelOverrides?.["general-purpose"] ?? "follows strategy",
       sourceText:
         settings.subagentModelOverrides?.["general-purpose"] !== undefined
           ? src("subagentModelOverrides")
-          : "[default]",
+          : "default",
       description: "provider/model pin; always wins over strategy",
     },
     {
       id: "subagentResolved",
       section: "subagents",
       label: "Effective resolution",
-      valueText: [
-        resolveEffectiveSubagentModel("Explore", settings, subagent.sessionModel),
-        resolveEffectiveSubagentModel("Plan", settings, subagent.sessionModel),
-        resolveEffectiveSubagentModel("general-purpose", settings, subagent.sessionModel),
-      ].join(" · "),
-      sourceText: "[runtime]",
+      // v0.28.20: compact — strip the parenthesized qualifier (the
+      // DESCRIPTION column carries semantics) and dedupe identical
+      // resolutions; the old 3-part parenthesized composite never fit.
+      valueText: (() => {
+        const strip = (r: string) => r.replace(/ \([^)]*\)$/, "").replace(/^\((.*)\)$/, "$1");
+        const parts = [
+          resolveEffectiveSubagentModel("Explore", settings, subagent.sessionModel),
+          resolveEffectiveSubagentModel("Plan", settings, subagent.sessionModel),
+          resolveEffectiveSubagentModel("general-purpose", settings, subagent.sessionModel),
+        ].map(strip);
+        return parts.every((p) => p === parts[0]) ? parts[0]! : parts.join(" · ");
+      })(),
+      sourceText: "runtime",
       description: "effective Explore / Plan / general-purpose model given current settings",
     },
   );
@@ -307,7 +314,7 @@ export function buildSettingsRows(
       id: "notifyCmd",
       section: "other",
       label: "Notify command",
-      valueText: show("notifyCmd", "(off)"),
+      valueText: show("notifyCmd", "off"),
       sourceText: src("notifyCmd"),
       description: "desktop push command; the event message is passed as $1",
     },
@@ -315,16 +322,16 @@ export function buildSettingsRows(
       id: "tokenLimit",
       section: "other",
       label: "Token limit per goal",
-      valueText: show("tokenLimit", "(off)"),
+      valueText: show("tokenLimit", "off"),
       sourceText: src("tokenLimit"),
       description: "per-goal token budget; pause when exceeded (0 = off)",
     },
     {
       id: "postaudit",
       section: "other",
-      label: "Postaudit config…",
+      label: "Postaudit",
       valueText: "open sub-menu",
-      sourceText: "[—]",
+      sourceText: "—",
       description:
         "post-completion follow-up enqueuer: mode, triggers, cascade, caps (postaudit / reviewer)",
     },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.28.19",
+  "version": "0.28.21",
   "description": "Goal. Loop. Audit. Done. \u2014 a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor \u2014 only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",