pi-goal-list-loop-audit 0.28.16 → 0.28.18

package/extensions/goal-loop-display.ts

@@ -12,7 +12,17 @@
 
 import type { Goal, State } from "./goal-loop-core.js";
 import { isPersistenceDegraded, lastPersistenceFailure } from "./goal-loop-core.js";
-import type { LoopState } from "./goal-loop-forever.js";
+import { HELD_ON_RESTORE, type LoopState } from "./goal-loop-forever.js";
+
+/** v0.28.17: a loop parked by the session-restore gate (was active when the
+ * last session ended). Held loops must stay VISIBLE — before, only
+ * state.loop?.active rendered anything and a reload made the loop vanish
+ * from the always-on UI (user report 2026-07-29: "loops are the most
+ * immature"). Stopped loops (any other stopReason) stay invisible. */
+function heldLoop(state: State): LoopState | undefined {
+  const l = state.loop;
+  return l && !l.active && l.stopReason === HELD_ON_RESTORE ? l : undefined;
+}
 
 // ---- formatters ----
 
@@ -128,20 +138,26 @@ export function buildStatusText(state: State, audit?: AuditDisplayProgress | nul
     return `glla: loop ${arrow} iter ${l.iteration}/${l.maxIterations > 0 ? l.maxIterations : "∞"} · best ${l.bestValue ?? "n/a"} · ${stall}${stallSuffix}`;
   }
   const g = state.goal;
-  if (!g) return undefined;
+  const held = heldLoop(state);
+  // v0.28.17: a held loop rides every goal state as a compact suffix.
+  const heldSuffix = held ? paint(theme, "warning", " · loop⏸held") : "";
+  if (!g) {
+    if (held) return `glla: loop ${paint(theme, "warning", "⏸ held")} · iter ${held.iteration} — /loop to resume`;
+    return undefined;
+  }
   if (g.status === "auditing") {
     const tool = audit?.currentTool ? ` · ${audit.currentTool}` : "";
-    return `glla: ${paint(theme, "accent", "auditing…")}${tool}`;
+    return `glla: ${paint(theme, "accent", "auditing…")}${tool}${heldSuffix}`;
   }
   if (g.status === "paused") {
     const label = `${g.policy} paused ⏸ ${truncate(g.pauseReason ?? "", 40)}`;
-    return `glla: ${paint(theme, pauseIsError(g) ? "error" : "warning", label)}`;
+    return `glla: ${paint(theme, pauseIsError(g) ? "error" : "warning", label)}${heldSuffix}`;
   }
   if (g.status === "active") {
     // v0.28.1 (S1/S2): a stale-handle interrupt keeps the goal ACTIVE (the
     // next fresh session auto-resumes it) — say so instead of looking healthy.
     if (g.interruptedAt) {
-      return `glla: ${g.policy} ${paint(theme, "error", "⚠ interrupted — stale handle · auto-resumes on pi restart")}`;
+      return `glla: ${g.policy} ${paint(theme, "error", "⚠ interrupted — stale handle · auto-resumes on pi restart")}${heldSuffix}`;
     }
     // v0.24.7: list policy gets its own wording — a queue item is not a goal.
     // v0.28.11 (U10): goal policy joins it — "list 29" read as a command
@@ -150,9 +166,11 @@ export function buildStatusText(state: State, audit?: AuditDisplayProgress | nul
     const n = state.list?.length ?? 0;
     const queue = n === 0 ? "" : ` · ${n} queued`;
     const tasks = g.taskList ? ` ${countDone(g)}/${countTotal(g)} tasks ·` : "";
-    return `glla: ${g.policy} ${paint(theme, "success", "●")}${tasks} ${fmtElapsed(now - Date.parse(g.createdAt))}${queue}`;
+    return `glla: ${g.policy} ${paint(theme, "success", "●")}${tasks} ${fmtElapsed(now - Date.parse(g.createdAt))}${queue}${heldSuffix}`;
   }
-  return undefined; // complete/aborted → clear
+  // complete/aborted → clear — but a held loop still shows.
+  if (held) return `glla: loop ${paint(theme, "warning", "⏸ held")} · iter ${held.iteration} — /loop to resume`;
+  return undefined;
 }
 
 function countDone(g: Goal): number {
@@ -199,9 +217,27 @@ export function buildWidgetLines(state: State, audit?: AuditDisplayProgress | nu
 function buildWidgetLinesInner(state: State, audit?: AuditDisplayProgress | null, now = Date.now(), theme?: DisplayTheme, width?: number, extras?: { stalls?: number }): string[] | undefined {
   if (state.loop?.active) return loopLines(state.loop, now, theme, width, extras);
   const g = state.goal;
-  if (!g) return undefined;
-  if (g.status === "complete" || g.status === "aborted") return undefined;
-  return goalLines(g, state, audit, now, theme, width);
+  const held = heldLoop(state);
+  if (!g || g.status === "complete" || g.status === "aborted") {
+    // v0.28.17: no visible goal — the held loop gets its own card.
+    return held ? heldLoopLines(held, now, theme, width) : undefined;
+  }
+  const lines = goalLines(g, state, audit, now, theme, width);
+  // v0.28.17: a held loop rides the goal card as a trailing line.
+  if (held) {
+    lines.push(`${paint(theme, "warning", "⏸")} ${truncate(held.target, budgetFor(width, 3, 64))}`);
+    lines.push(`└─ ${paint(theme, "dim", `loop held · iter ${held.iteration} — /loop to resume`)}`);
+  }
+  return lines;
+}
+
+/** v0.28.17: standalone card for a restore-held loop (no goal visible). */
+function heldLoopLines(l: LoopState, now: number, theme?: DisplayTheme, width?: number): string[] {
+  return [
+    `${paint(theme, "warning", "⏸")} ${truncate(l.target, budgetFor(width, 3, 64))}`,
+    `├─ loop held · iter ${l.iteration} · ${fmtElapsed(now - Date.parse(l.startedAt))} so far`,
+    `└─ ${paint(theme, "dim", "held by the session-restore gate — /loop to resume, /loop stop to drop")}`,
+  ];
 }
 
 // Branch lines sit flush-left (pi-tasks convention): pi's widget renderer

package/extensions/goal-loop-forever.ts

@@ -31,6 +31,13 @@ export interface LoopRefinement {
   newMeasureCmd: string;
 }
 
+/** v0.28.17: stopReason marking a loop parked by the session-restore gate
+ * (it was active when the last session ended; the fresh session holds it
+ * until the user resumes with /loop). Exported so the display layer can
+ * recognize held loops — they must stay VISIBLE in the status/widget,
+ * unlike stopped loops which are genuinely gone. */
+export const HELD_ON_RESTORE = "held: restored in a fresh session";
+
 export interface LoopState {
   target: string;
   /** v0.23.0: optional — a metricless "spec loop" (measure=none) has no

package/extensions/goal-settings.ts

@@ -118,6 +118,11 @@ export const DEFAULT_SETTINGS: Settings = {
 };
 
 export function globalSettingsPath(): string {
+  // v0.28.18: test/embedding override — the suite must be hermetic from
+  // the developer's real global settings file (a user setting autoAccept
+  // globally once made draft-Confirm tests auto-accept and fail).
+  const override = process.env.GLLA_GLOBAL_SETTINGS_PATH;
+  if (override) return override;
   return path.join(os.homedir(), ".pi", "agent", "pi-goal-list-loop-audit.settings.json");
 }
 

package/extensions/loops/goal.ts

@@ -161,6 +161,7 @@ import {
   LOOP_DEFAULTS,
   resolveSpecFiles,
   respecTarget,
+  HELD_ON_RESTORE,
   type LoopState,
 } from "../goal-loop-forever.js";
 import {
@@ -184,8 +185,8 @@ import {
 // =================================================================
 
 const GOAL_EVENT_ENTRY = "goal-event";
-/** stopReason marker for a loop held (not stopped) by the fresh-session restore gate. */
-const HELD_ON_RESTORE = "held: restored in a fresh session";
+// HELD_ON_RESTORE (stopReason marker for a restore-held loop) lives in
+// goal-loop-forever.js since v0.28.17 — the display layer imports it too.
 
 // =================================================================
 // Module-level state (one per session)

package/extensions/settings-menu.ts

@@ -337,8 +337,10 @@ export function buildSettingsRows(
 // TUI table component
 // =================================================================
 
-/** Padding + gutter between columns. */
-const COL_GUTTER = 2;
+/** Column separator (v0.28.18: box-drawing — the menu reads as a table). */
+const COL_SEP = " │ ";
+/** Header-rule junction matching COL_SEP's visible width. */
+const COL_RULE_SEP = "─┼─";
 
 /** Maximum width for each fixed column before truncation kicks in. */
 const MAX_KEY_W = 32;
@@ -450,15 +452,20 @@ export class SettingsMenuComponent implements Component {
     let keyW = visibleWidth(this.theme.bold("KEY"));
     let valueW = visibleWidth(this.theme.bold("VALUE"));
     let sourceW = visibleWidth(this.theme.bold("SOURCE"));
-    for (const r of this.visibleRows()) {
-      if (visibleWidth(r.label) > keyW) keyW = visibleWidth(r.label);
+    // v0.28.18: widths are computed across ALL sections (not just the
+    // active one) so the grid does NOT reflow on tab switch — a table's
+    // columns stay put. The 2-char selection prefix ("▶ "/"  ") counts
+    // toward the KEY column (before, rows overflowed keyW by 2 and the
+    // whole VALUE column sat 2 chars right of the header's VALUE).
+    for (const r of this.rows) {
+      if (visibleWidth(r.label) + 2 > keyW) keyW = visibleWidth(r.label) + 2;
       if (visibleWidth(r.valueText) > valueW) valueW = visibleWidth(r.valueText);
       if (visibleWidth(r.sourceText) > sourceW) sourceW = visibleWidth(r.sourceText);
     }
     keyW = Math.min(keyW, MAX_KEY_W);
     valueW = Math.min(valueW, MAX_VALUE_W);
     sourceW = Math.min(sourceW, MAX_SOURCE_W);
-    const descW = Math.max(MIN_DESC_W, width - keyW - valueW - sourceW - 3 * COL_GUTTER);
+    const descW = Math.max(MIN_DESC_W, width - keyW - valueW - sourceW - 3 * visibleWidth(COL_SEP));
     return { keyW, valueW, sourceW, descW };
   }
 
@@ -469,17 +476,19 @@ export class SettingsMenuComponent implements Component {
 
   private renderBody(width: number): string[] {
     const { keyW, valueW, sourceW, descW } = this.widths(width);
-    const gutter = " ".repeat(COL_GUTTER);
+    const sep = this.theme.fg("dim", COL_SEP);
 
     const lines: string[] = [];
 
     lines.push(this.theme.fg("accent", this.theme.bold(this.title)));
 
+    // v0.28.18: EVERY tab is bracketed (active = accent, inactive = dim) —
+    // bare words read as floating text, not tabs.
     lines.push(
       SETTINGS_SECTIONS.map((s, i) =>
         i === this.activeSectionIdx
           ? this.theme.fg("accent", `[${s.label}]`)
-          : this.theme.fg("dim", s.label),
+          : this.theme.fg("dim", `[${s.label}]`),
       ).join("  "),
     );
 
@@ -489,7 +498,14 @@ export class SettingsMenuComponent implements Component {
         this.padEnd(this.theme.bold("VALUE"), valueW),
         this.padEnd(this.theme.bold("SOURCE"), sourceW),
         this.theme.bold("DESCRIPTION"),
-      ].join(gutter),
+      ].join(sep),
+    );
+    // Header rule — the grid line that makes it read as a table.
+    lines.push(
+      this.theme.fg(
+        "dim",
+        ["─".repeat(keyW), "─".repeat(valueW), "─".repeat(sourceW), "─".repeat(descW)].join(COL_RULE_SEP),
+      ),
     );
 
     const vs = this.visibleRows();
@@ -499,12 +515,18 @@ export class SettingsMenuComponent implements Component {
       vs.forEach((r, i) => {
         const selected = i === this.selectedIdx;
         const prefix = selected ? "▶ " : "  ";
+        // v0.28.18: KEY (incl. prefix) and VALUE are truncated to their
+        // column — before, an over-long VALUE (e.g. the subagent effective-
+        // resolution composite) overflowed and shoved SOURCE/DESCRIPTION
+        // right on that row only, breaking the grid.
         const row = [
-          this.padEnd(prefix + r.label, keyW),
-          this.padEnd(r.valueText, valueW),
-          this.padEnd(r.sourceText, sourceW),
+          this.padEnd(truncateToWidth(prefix + r.label, keyW, "…"), keyW),
+          this.padEnd(truncateToWidth(r.valueText, valueW, "…"), valueW),
+          this.padEnd(truncateToWidth(r.sourceText, sourceW, "…"), sourceW),
           truncateToWidth(r.description, descW, "…"),
-        ].join(gutter);
+        // Selected row: plain separators — the whole row gets one accent
+        // wrap; a nested dim separator's reset code would end it early.
+        ].join(selected ? COL_SEP : sep);
         lines.push(selected ? this.theme.fg("accent", row) : row);
       });
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.28.16",
+  "version": "0.28.18",
   "description": "Goal. Loop. Audit. Done. \u2014 a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor \u2014 only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",