pi-goal-list-loop-audit 0.28.14 → 0.28.16

package/extensions/loops/goal.ts

@@ -295,7 +295,7 @@ async function confirmDraft(ctx: ExtensionContext, title: string, body: string):
 // paused goal — honestly, with a ledger trail. resume: legacy silent
 // behavior. A new GOAL replacing a paused one archives it in every policy
 // (one-active-thing: state.goal holds exactly one goal).
-function resolveCarryover(ctx: ExtensionContext, trigger: "goal" | "loop"): void {
+function resolveCarryover(ctx: ExtensionContext, trigger: "goal" | "loop" | "list"): void {
   if (carryoverResolved || !carryoverSnapshot) return;
   carryoverResolved = true;
   const snap = carryoverSnapshot;
@@ -305,8 +305,9 @@ function resolveCarryover(ctx: ExtensionContext, trigger: "goal" | "loop"): void
   const done: string[] = [];
   const waiting: string[] = [];
   const pausedGoal = state.goal && state.goal.status === "paused" ? state.goal : null;
-  if (pausedGoal && (trigger === "goal" || policy === "clear")) {
-    archiveCurrentGoal(ctx, "aborted", trigger === "goal" ? "replaced by new goal (carryover)" : "carryover cleared");
+  // A new goal OR list item replaces the goal slot; a loop leaves it paused.
+  if (pausedGoal && (trigger === "goal" || trigger === "list" || policy === "clear")) {
+    archiveCurrentGoal(ctx, "aborted", trigger === "loop" ? "carryover cleared" : `replaced by new ${trigger} (carryover)`);
     done.push(`archived paused goal "${(snap.pausedGoal ?? pausedGoal.objective).slice(0, 60)}"`);
   } else if (snap.pausedGoal) {
     waiting.push(`paused goal "${snap.pausedGoal}" (/goal resume)`);
@@ -1025,6 +1026,10 @@ function activateNextListItem(ctx: ExtensionContext, n = 1): boolean {
     appendLedger(ctx.cwd, "list_activation_blocked_loop", {});
     return false;
   }
+  // v0.28.14: carryover resolution runs BEFORE the item is taken — under
+  // carryover=clear the stale queue is dropped first and there is nothing
+  // to activate; under pause the ONE summary precedes the activation.
+  resolveCarryover(ctx, "list");
   const queue = listQueue();
   const taken = takeAt(queue, n);
   if (!taken) return false;
@@ -4226,12 +4231,13 @@ export default function (pi: ExtensionAPI): void {
     handler: (args: string, ctx: ExtensionContext) => { rememberCtx(ctx); return cmdList(args, ctx); },
   });
   pi.registerCommand("loop", {
-    description: "Loop 3: metric-driven process — it never completes. /loop <target> drafts the metric with you · /loop start \"<target>\" = infinite metricless loop (no plateau, no cap; ends at time=/tokens= or /loop stop) · /loop respec = infinite metricless reconcile against the root SPEC.md · add measure=\"<cmd>\" direction=min|max [window=5] [max=50] [branch=1] for a metric loop · /loop status · /loop stop. 'Improve until X' is a /goal, not a loop.",
+    description: "Loop 3: metric-driven process — it never completes. /loop <target> drafts the metric with you · /loop start \"<target>\" = infinite metricless loop (no plateau, no cap; ends at time=/tokens= or /loop stop) · /loop respec = infinite metricless reconcile against the root SPEC.md · add measure=\"<cmd>\" direction=min|max [window=5] [max=50] [branch=1] for a metric loop · /loop status · /loop stop (alias /loop cancel). 'Improve until X' is a /goal, not a loop.",
     getArgumentCompletions: completions([
       ["start", "skip drafting: /loop start \"<target>\" measure=\"<cmd>\" direction=min|max [window=5] [max=50]"],
       ["respec", "infinite metricless loop reconciling the codebase against the root SPEC.md"],
       ["status", "show metric, iteration, best/last values, stall count"],
       ["stop", "end the loop (keeps the best state)"],
+      ["cancel", "alias of /loop stop — end the loop"],
       ["finish", "end the loop cleanly: /loop finish [reason] → stopReason 'completed: <reason>'"],
     ]),
     handler: (args: string, ctx: ExtensionContext) => { rememberCtx(ctx); return cmdLoop(args, ctx); },

package/extensions/reviewer.ts

@@ -213,12 +213,22 @@ export interface ReviewerOutcome {
   reportPath?: string;
   enqueued: number;
   proposed: number;
-  /** v0.27.5: the cascade step that actually fired (notify-and-idle | convert-findings-to-list | queue-leftovers | fire-audit-on-clean | propose-goal | aggressive-relaunch | report-only) — surfaces in /goal status and tests. */
+  /** v0.27.5: the cascade step that actually fired (notify-and-idle | convert-findings-to-list | queue-leftovers | fire-audit-on-clean | propose-goal | aggressive-relaunch | duplicate-suppressed) — surfaces in /goal status and tests. v0.28.16: "duplicate-suppressed" = the clean completion WAS a regression scan, so the follow-up scan was deduped. */
   cascadeStep?: string;
 }
 
 export const REVIEWER_REFIRE_WINDOW_MS = 5 * 60_000;
 
+/** v0.28.16: normalize an objective for duplicate-compare — lowercase,
+ * goal-ids (yyyyMMddHHmmss-xxxxxx) become <id>, whitespace collapses. */
+export function normalizeObjective(s: string): string {
+  return s
+    .toLowerCase()
+    .replace(/\b\d{14}-[a-z0-9]{6}\b/g, "<id>")
+    .replace(/\s+/g, " ")
+    .trim();
+}
+
 /** The reviewer lifecycle (contract item 1). */
 export function runReviewer(
   config: ReviewerConfig,
@@ -310,7 +320,16 @@ export function runReviewer(
   // aggressive mode → relaunch the audit goal directly (no Confirm).
   if (findings.length === 0 && config.cascade.includes("fire-audit-on-clean")) {
     const auditObjective = `Post-completion regression scan after ${source.goalId} (${config.auditScope})`;
-    if (aggressive) {
+    // v0.28.16: duplicate-scan dedupe — the reviewer fires ON completion,
+    // so source.objective IS the most recent completion. If the goal that
+    // just completed was itself this same scan (normalized: goal-ids
+    // stripped), the proposal would be a scan-of-a-scan — the cascade loop
+    // that fired twice on 2026-07-28. Suppress the proposal/enqueue (the
+    // report is still written; the ledger records the reason).
+    if (normalizeObjective(source.objective) === normalizeObjective(auditObjective)) {
+      deps.ledger("reviewer_suppressed", { reason: "duplicate-scan", goalId: source.goalId, objective: auditObjective });
+      cascadeStep = "duplicate-suppressed";
+    } else if (aggressive) {
       if (deps.proposeGoal(auditObjective, "aggressive postaudit: clean completion — relaunching the regression scan as /goal")) {
         proposed++;
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.28.14",
+  "version": "0.28.16",
   "description": "Goal. Loop. Audit. Done. \u2014 a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor \u2014 only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",