pi-goal-list-loop-audit 0.27.6 → 0.27.7

package/extensions/loops/goal.ts

@@ -679,7 +679,7 @@ function archiveCurrentGoal(ctx: ExtensionContext, status: Status, stopReason?:
 function fireReviewer(
   ctx: ExtensionContext,
   source: { kind: "goal" | "list"; goalId: string; objective: string; terminal: string },
-  opts: { manual?: boolean; mode?: "default" | "auto" | "report" } = {},
+  opts: { manual?: boolean; mode?: "off" | "default" | "auto" | "aggressive" | "report" } = {},
 ): void {
   try {
     const settings = loadSettings(ctx.cwd);
@@ -3068,13 +3068,16 @@ async function cmdReview(args: string, ctx: ExtensionContext): Promise<void> {
   const parts = args.trim().split(/\s+/).filter(Boolean);
   const id = parts[0] ?? "";
   const modeArg = parts[1];
-  const mode = modeArg === "auto" || modeArg === "report" || modeArg === "default" ? modeArg : undefined;
+  const validModes = ["off", "default", "auto", "aggressive", "report"] as const;
+  const mode = (validModes as readonly string[]).includes(modeArg ?? "")
+    ? (modeArg as typeof validModes[number])
+    : undefined;
   if (modeArg && !mode) {
-    ctx.ui.notify(`Unknown mode "${modeArg}" — use auto | report | default.`, "warning");
+    ctx.ui.notify(`Unknown mode "${modeArg}" — use off | default | auto | aggressive | report.`, "warning");
     return;
   }
   if (!id) {
-    ctx.ui.notify("Usage: /review <goal-id> [auto|report|default] — see /goal archive for ids.", "info");
+    ctx.ui.notify(`Usage: /review <goal-id> [${validModes.join("|")}] — see /goal archive for ids.`, "info");
     return;
   }
   // Resolve the id against the archive (suffix match allowed).
@@ -3098,15 +3101,22 @@ async function cmdReview(args: string, ctx: ExtensionContext): Promise<void> {
   fireReviewer(ctx, { kind: "goal", goalId, objective, terminal: "goal-complete" }, { manual: true, mode });
 }
 
-/** v0.26.0: /glla reviewer — the reviewer config menu (project-scoped). */
+/** v0.27.5: /glla reviewer | postaudit — the post-completion audit config menu
+ * (project-scoped). Reads the dual-write settings (postaudit wins over the
+ * legacy reviewer key), and writes back to whichever key was read first —
+ * so we don't drift two parallel config blocks. */
 async function cmdReviewerSettings(ctx: ExtensionContext): Promise<void> {
+  const settings = loadSettings(ctx.cwd);
+  const block = (settings.postaudit ?? settings.reviewer) as Partial<ReviewerConfig> | undefined;
+  const settingsKey: "postaudit" | "reviewer" = settings.postaudit !== undefined ? "postaudit" : "reviewer";
   if (!ctx.hasUI) {
-    const cfg = resolveReviewerConfig(loadSettings(ctx.cwd).reviewer as Partial<ReviewerConfig> | undefined);
-    ctx.ui.notify(`reviewer (project): ${JSON.stringify(cfg, null, 2)}`, "info");
+    const cfg = resolveReviewerConfig(block);
+    ctx.ui.notify(`${settingsKey} (project): ${JSON.stringify(cfg, null, 2)}`, "info");
     return;
   }
-  const load = () => resolveReviewerConfig(loadSettings(ctx.cwd).reviewer as Partial<ReviewerConfig> | undefined);
-  const save = (patch: Partial<ReviewerConfig>) => saveSettings("project", ctx.cwd, { reviewer: { ...load(), ...patch } as Record<string, unknown> });
+  const load = () => resolveReviewerConfig(loadSettings(ctx.cwd)[settingsKey] as Partial<ReviewerConfig> | undefined);
+  const save = (patch: Partial<ReviewerConfig>) =>
+    saveSettings("project", ctx.cwd, { [settingsKey]: { ...load(), ...patch } as Record<string, unknown> });
   for (;;) {
     const cfg = load();
     let choice: string | undefined;
@@ -3118,7 +3128,13 @@ async function cmdReviewerSettings(ctx: ExtensionContext): Promise<void> {
     if (!choice || choice === "Done") return;
     try {
       if (choice.startsWith("Enabled")) save({ enabled: !cfg.enabled });
-      else if (choice.startsWith("Mode")) save({ mode: cfg.mode === "default" ? "auto" : cfg.mode === "auto" ? "report" : "default" });
+      else if (choice.startsWith("Mode")) {
+        // v0.27.5: 5-state cycle off → default → auto → aggressive → report → off
+        const order: Array<"off" | "default" | "auto" | "aggressive" | "report"> = ["off", "default", "auto", "aggressive", "report"];
+        const i = order.indexOf(cfg.mode as typeof order[number]);
+        const next = order[(i + 1) % order.length]!;
+        save({ mode: next });
+      }
       else if (choice.startsWith("Leverage mode")) save({ leverageMode: cfg.leverageMode === "fix-without-confirm" ? "confirm-all" : "fix-without-confirm" });
       else if (choice.startsWith("Fire on goal-complete")) save({ fireOn: cfg.fireOn.includes("goal-complete") ? cfg.fireOn.filter((e) => e !== "goal-complete") : [...cfg.fireOn, "goal-complete"] });
       else if (choice.startsWith("Fire on list-complete")) save({ fireOn: cfg.fireOn.includes("list-complete") ? cfg.fireOn.filter((e) => e !== "list-complete") : [...cfg.fireOn, "list-complete"] });

package/extensions/reviewer.ts

@@ -15,7 +15,7 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 
-export type ReviewerMode = "default" | "auto" | "report";
+export type ReviewerMode = "off" | "default" | "auto" | "aggressive" | "report";
 
 export interface ReviewerConfig {
   enabled: boolean;
@@ -203,6 +203,8 @@ export interface ReviewerOutcome {
   reportPath?: string;
   enqueued: number;
   proposed: number;
+  /** v0.27.5: the cascade step that actually fired (notify-and-idle | convert-findings-to-list | queue-leftovers | fire-audit-on-clean | propose-goal | aggressive-relaunch | report-only) — surfaces in /goal status and tests. */
+  cascadeStep?: string;
 }
 
 export const REVIEWER_REFIRE_WINDOW_MS = 5 * 60_000;
@@ -215,6 +217,9 @@ export function runReviewer(
 ): ReviewerOutcome {
   const none = (suppressedReason: string): ReviewerOutcome => ({ fired: false, suppressedReason, enqueued: 0, proposed: 0 });
   if (!config.enabled && !deps.manual) return none("reviewer disabled");
+  // v0.27.5: "off" mode is the user-friendly way to silence the postaudit
+  // — equivalent to enabled=false but exposed via the postaudit menu.
+  if (config.mode === "off" && !deps.manual) return none("postaudit mode = off");
   const event = source.kind === "goal" ? `${source.terminal}` : "list-complete";
   if (!deps.manual) {
     if (config.doNotFireOn.includes(event)) return none(`doNotFireOn: ${event}`);
@@ -243,7 +248,8 @@ export function runReviewer(
   let enqueued = 0;
   let proposed = 0;
   let cascadeStep = "notify-and-idle";
-  const auto = config.mode === "auto";
+  const auto = config.mode === "auto" || config.mode === "aggressive";
+  const aggressive = config.mode === "aggressive";
   const reportOnly = config.mode === "report";
 
   // Cascade: findings → list items (leverage: fix-without-confirm).
@@ -255,8 +261,22 @@ export function runReviewer(
   }
   // Architectural findings: default mode → /goal proposal WITH Confirm;
   // auto mode → /list items (the auto-loop rolls straight into them).
+  // aggressive mode → enqueue AND relaunch as the next active goal
+  // (skips both Confirm and the queue — the unattended rig never stops).
   if (architectural.length > 0 && !reportOnly) {
-    if (auto) {
+    if (aggressive) {
+      deps.enqueueListItems(architectural.map((f) => f.text));
+      // v0.27.5 aggressive: also propose the FIRST architectural finding
+      // as a relaunch so the queue gets burned through even when the
+      // unattended rig can't Confirm.
+      deps.proposeGoal(
+        architectural[0]!.text,
+        `aggressive postaudit: relaunching as /goal without Confirm (${architectural.length} architectural findings total)`,
+      );
+      enqueued += architectural.length;
+      proposed += 1;
+      cascadeStep = "aggressive-relaunch";
+    } else if (auto) {
       deps.enqueueListItems(architectural.map((f) => f.text));
       enqueued += architectural.length;
       cascadeStep = convertStep;
@@ -272,16 +292,22 @@ export function runReviewer(
   // Clean completion → audit: default mode proposes a /goal (Confirm);
   // auto mode enqueues the audit as a /list item (no Confirm — the
   // cascade keeps rolling until the findings run dry).
+  // aggressive mode → relaunch the audit goal directly (no Confirm).
   if (findings.length === 0 && config.cascade.includes("fire-audit-on-clean") && !reportOnly) {
     const auditObjective = `Post-completion regression scan after ${source.goalId} (${config.auditScope})`;
-    if (auto) {
+    if (aggressive) {
+      deps.proposeGoal(auditObjective, "aggressive postaudit: clean completion — relaunching the regression scan as /goal");
+      proposed++;
+      cascadeStep = "aggressive-relaunch";
+    } else if (auto) {
       deps.enqueueListItems([auditObjective]);
       enqueued++;
+      cascadeStep = "fire-audit-on-clean";
     } else {
       deps.proposeGoal(auditObjective, "reviewer: completion looks clean — firing the audit step");
       proposed++;
+      cascadeStep = "fire-audit-on-clean";
     }
-    cascadeStep = "fire-audit-on-clean";
   }
   if (reportOnly) cascadeStep = "report-only";
 
@@ -311,7 +337,7 @@ export function runReviewer(
   if (strategic.length > 0) {
     deps.notify(`Reviewer: ${strategic.length} strategic finding(s) need YOUR call — see the report's Strategic section.`, "warning");
   }
-  return { fired: true, report, reportPath, enqueued, proposed };
+  return { fired: true, report, reportPath, enqueued, proposed, cascadeStep };
 }
 
 /** /glla reviewer menu options, derived from the config — extracted so
@@ -319,7 +345,7 @@ export function runReviewer(
 export function reviewerMenuOptions(cfg: ReviewerConfig): string[] {
   return [
     `Enabled — ${cfg.enabled ? "ON" : "OFF"}`,
-    `Mode — ${cfg.mode} (default = Confirm-gated · auto = auto-loop, no Confirms · report = report only)`,
+    `Mode — ${cfg.mode} (off = silenced · default = Confirm-gated · auto = auto-loop, no Confirms · aggressive = auto + relaunch · report = report only)`,
     `Leverage mode — ${cfg.leverageMode} (bug/refactor findings)`,
     `Fire on goal-complete — ${cfg.fireOn.includes("goal-complete") ? "ON" : "OFF"}`,
     `Fire on list-complete — ${cfg.fireOn.includes("list-complete") ? "ON" : "OFF"}`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.27.6",
+  "version": "0.27.7",
   "description": "Goal. Loop. Audit. Done. \u2014 a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor \u2014 only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",