pi-goal-list-loop-audit 0.26.5 → 0.26.6

package/extensions/goal-loop-core.ts

@@ -917,6 +917,8 @@ export function isAutoCommitPaused(cwd: string): boolean {
 /** Suppress the heartbeat when work shipped very recently — a session
  * that just committed is transitioning, not stalled. Pure; the tick
  * gathers the timestamps. */
+/** @deprecated v0.26.6: no longer called by the heartbeat (self-sustaining
+ * under ledger writes / auto-commit daemons). Kept for API compatibility. */
 export function shouldSuppressHeartbeatForRecentShip(args: {
   nowMs: number;
   lastShippedAtMs: number | null;
@@ -930,6 +932,10 @@ export function shouldSuppressHeartbeatForRecentShip(args: {
 /** Best-effort "when did work last ship" for a repo: newest of the HEAD
  * commit time and the .pi-glla state file mtime. Null when unknown. */
 export function lastShippedAtMs(cwd: string): number | null {
+  // v0.26.6: the .pi-glla/active.jsonl MTIME term was REMOVED — the
+  // heartbeat's own ledger writes refreshed it every 15s, which made the
+  // 0.25.0 ship-suppression self-sustaining (darklord: 9.1h / 2,184
+  // suppressed ticks). Only a real git commit counts as a ship now.
   let best: number | null = null;
   try {
     const out = execSync("git log -1 --format=%ct", { cwd, stdio: ["ignore", "pipe", "ignore"] })
@@ -940,12 +946,6 @@ export function lastShippedAtMs(cwd: string): number | null {
   } catch {
     /* not a git repo or no commits */
   }
-  try {
-    const mtime = fs.statSync(path.join(cwd, ".pi-glla", "active.jsonl")).mtimeMs;
-    if (best === null || mtime > best) best = mtime;
-  } catch {
-    /* no state file yet */
-  }
   return best;
 }
 

package/extensions/loops/goal.ts

@@ -38,7 +38,6 @@ import {
   classifyImpossibleReason,
   extractPendingTasks,
   isFullAuditObjective,
-  lastShippedAtMs,
   resolveEffectiveAggressiveSettings,
   appendAuditLog,
   computeListDepth,
@@ -52,7 +51,6 @@ import {
   crossRecommendMode,
   formatListDepth,
   shouldEscalateStall,
-  shouldSuppressHeartbeatForRecentShip,
   mergeSettings,
   parseListImport,
 
@@ -240,6 +238,10 @@ let heartbeatNudges = 0;
 // refire's own noteActivity, which is what made the hegemon zombie spin
 // self-sustaining (619 refires / 23.5h / zero turns).
 let consecutiveStalls = 0;
+// v0.26.6: precise replacement for the removed ship-recency suppression —
+// set while complete_goal's isolated audit runs, so the heartbeat never
+// refires into an in-flight completion.
+let completionAuditInFlight = false;
 let heartbeatTimer: NodeJS.Timeout | null = null;
 
 function noteActivity(real = false): void {
@@ -381,18 +383,16 @@ function heartbeatTick(): void {
     notifyExternal(ctx, msg);
   }
   if (!fire) return;
-  // v0.25.0 (contract item 27): a session that SHIPPED in the last 5
-  // minutes (commit or ledger write) is transitioning, not stalled —
-  // suppress the refire so rapid iteration isn't interrupted.
-  if (
-    shouldSuppressHeartbeatForRecentShip({
-      nowMs: Date.now(),
-      lastShippedAtMs: lastShippedAtMs(ctx.cwd),
-    })
-  ) {
-    appendLedger(ctx.cwd, "heartbeat_suppressed", { reason: "recent ship (<5m)" });
-    return;
-  }
+  // v0.26.6: the 0.25.0 "recent ship (<5m)" suppression was REMOVED. It fed
+  // lastShippedAtMs, which read the state-file MTIME — and the heartbeat's
+  // own suppressed-tick ledger writes refreshed that mtime every 15s,
+  // making the suppression self-sustaining forever (field-observed in
+  // darklord: 2,184 suppressed ticks over 9.1h after a post-compaction
+  // send failure; the completed list item never closed). Under an
+  // auto-committing daemon the git-head term self-sustains too. The legit
+  // windows are already covered precisely — busy mid-turn, pending
+  // messages, scheduled timers — plus the audit-in-flight flag below.
+  if (completionAuditInFlight) return;
   noteActivity();
   consecutiveStalls++;
   appendLedger(ctx.cwd, "heartbeat_refire", { nudgesSoFar: heartbeatNudges, consecutiveStalls });
@@ -1894,13 +1894,20 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
       // retry with backoff before we report "auditor infrastructure error
       // (retried once)". Neither attempt is a verdict on the work.
       const auditStartMs = Date.now();
-      const { result, retriedOnce } = await runWithInfraRetry(runAudit, {
-        onRetry: (err) => {
-          latestAuditProgress = { label: `infra error (${err.slice(0, 40)}) — retrying once`, lastEventAt: Date.now() };
-          refreshUI(ctx);
-          appendLedger(ctx.cwd, "audit_infra_retry", { goalId: state.goal?.id, error: err.slice(0, 200) });
-        },
-      });
+      completionAuditInFlight = true;
+      let result: Awaited<ReturnType<typeof runAudit>>;
+      let retriedOnce = false;
+      try {
+        ({ result, retriedOnce } = await runWithInfraRetry(runAudit, {
+          onRetry: (err) => {
+            latestAuditProgress = { label: `infra error (${err.slice(0, 40)}) — retrying once`, lastEventAt: Date.now() };
+            refreshUI(ctx);
+            appendLedger(ctx.cwd, "audit_infra_retry", { goalId: state.goal?.id, error: err.slice(0, 200) });
+          },
+        }));
+      } finally {
+        completionAuditInFlight = false;
+      }
       const auditDurationMs = Date.now() - auditStartMs;
       latestAuditProgress = null;
       // Audit history: record REAL verdicts only — a non-empty report is the

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.26.5",
+  "version": "0.26.6",
   "description": "Goal. Loop. Audit. Done. — a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor — only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",