pi-goal-list-loop-audit 0.26.2 → 0.26.4

package/extensions/loops/goal.ts

@@ -595,8 +595,12 @@ function fireReviewer(
     } catch {
       /* archive md may not exist for manual review of a live goal */
     }
+    // v0.26.4 source curation: an APPROVED audit report is the executor's
+    // own completion claims — meta-text with zero finding signal (the
+    // 0.26.2/0.26.3 misfires both mined it). Disapprovals/errors carry the
+    // independent auditor's required-fixes — the real findings.
     const auditTexts = readAuditLog(ctx.cwd)
-      .filter((e) => e.goalId === source.goalId)
+      .filter((e) => e.goalId === source.goalId && (e.verdict === "disapproved" || e.verdict === "error"))
       .map((e) => e.report);
     for (const t of auditTexts) sources.push({ name: "audit", text: t });
     let ledgerEntries: Array<{ type: string; at?: string; value?: any }> = [];

package/extensions/reviewer.ts

@@ -65,28 +65,51 @@ export interface Finding {
 /** Leverage classification (contract item 5). Order matters: strategic
  * and architectural win over bug/refactor — "should we rewrite this
  * broken schema" is a decision, not a fix. */
+// v0.26.3: the bare words "architectural"/"strategic" are REMOVED — they
+// self-matched the reviewer's own vocabulary ("architectural-class",
+// "architectural findings", the docs' mode matrix) and produced 3 junk
+// findings on the 0.26.2 completion, observed live.
 const CLASS_PATTERNS: Array<{ class: FindingClass; re: RegExp }> = [
-  { class: "strategic", re: /\bshould we\b|\bdeprecat|ship this\??|strategic/i },
-  { class: "architectural", re: /\brewrite\b|new dependency|schema change|architectural|redesign/i },
+  { class: "strategic", re: /\bshould we\b|\bdeprecat|ship this\??/i },
+  { class: "architectural", re: /\brewrite\b|new dependency|schema change|\bredesign\b/i },
   { class: "bug", re: /\bTODO\b|\bFIXME\b|\bbug\b|\bissue\b|regression|broken|\bfixme\b/i },
   { class: "refactor", re: /could be cleaner|consider refactoring|duplicat|refactor|left ?out|follow[\s-]?up|deferred|could be improved|improvement|enhancement|consider adding|would be nice|nice to have/i },
 ];
 
+/** v0.26.3: lines that never carry findings — code, markdown tables, and
+ * the reviewer's own report/config vocabulary. Observed false positives
+ * from the 0.26.2 completion: a test("…architectural…") name, the
+ * INSTALL.md mode-matrix row, and ship-doc prose. */
+const SKIP_LINE = /^\s*(test|it|describe|assert|expect)\s*\(|^\s*(const|let|var|function|import|export|require)\b|\{\s*\.\.\.\s*\}|,\s*\.\.\.$|^\s*\||^\s*[{\[\]}]|^\s*['"]/;
+const REVIEWER_VOCAB = /architectural-class|bug-class|refactor-class|strategic-class|reviewer found|cascade step|\*\*Mode\*\*|problems\s*\/\s*\(?(improvements|architectural)/i;
+
 export function classifyFindingText(line: string): FindingClass | undefined {
   const t = line.trim();
   if (t.length < 8) return undefined;
+  if (SKIP_LINE.test(t) || REVIEWER_VOCAB.test(t)) return undefined;
   for (const { class: cls, re } of CLASS_PATTERNS) {
     if (re.test(t)) return cls;
   }
   return undefined;
 }
 
-/** Scan source texts line-by-line for finding-shaped content. */
+/** v0.26.4: remove fenced code blocks and inline code spans. Quoted
+ * code is how completion summaries leak vocabulary into extraction —
+ * the 0.26.3 misfire matched a backticked reviewer.ts line containing
+ * four architectural patterns. */
+export function stripCodeSpans(text: string): string {
+  return text
+    .replace(/```[\s\S]*?```/g, " ")
+    .replace(/`[^`\n]*`/g, " ");
+}
+
+/** Scan source texts line-by-line for finding-shaped content. Code
+ * spans are stripped first (v0.26.4) — findings live in prose. */
 export function extractFindings(sources: Array<{ name: string; text: string }>, max: number): Finding[] {
   const out: Finding[] = [];
   const seen = new Set<string>();
   for (const { name, text } of sources) {
-    for (const line of text.split("\n")) {
+    for (const line of stripCodeSpans(text).split("\n")) {
       const cls = classifyFindingText(line);
       if (!cls) continue;
       const clean = line.trim().replace(/^[-*>\s\[\]x]+/, "").slice(0, 200);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.26.2",
+  "version": "0.26.4",
   "description": "Goal. Loop. Audit. Done. — a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor — only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",