pi-goal-list-loop-audit 0.26.1 → 0.26.3

package/extensions/loops/goal.ts

@@ -583,11 +583,12 @@ function archiveCurrentGoal(ctx: ExtensionContext, status: Status, stopReason?:
 function fireReviewer(
   ctx: ExtensionContext,
   source: { kind: "goal" | "list"; goalId: string; objective: string; terminal: string },
-  opts: { manual?: boolean } = {},
+  opts: { manual?: boolean; mode?: "default" | "auto" | "report" } = {},
 ): void {
   try {
     const settings = loadSettings(ctx.cwd);
     const config = resolveReviewerConfig(settings.reviewer as Partial<ReviewerConfig> | undefined);
+    if (opts.mode) config.mode = opts.mode;
     const sources: Array<{ name: string; text: string }> = [];
     try {
       sources.push({ name: "archive", text: fs.readFileSync(archivedGoalPath(ctx.cwd, source.goalId), "utf-8") });
@@ -2884,9 +2885,16 @@ async function openSettingsUI(ctx: ExtensionContext): Promise<void> {
 
 /** v0.26.0: /review <archived-goal-id> — manual reviewer invocation. */
 async function cmdReview(args: string, ctx: ExtensionContext): Promise<void> {
-  const id = args.trim();
+  const parts = args.trim().split(/\s+/).filter(Boolean);
+  const id = parts[0] ?? "";
+  const modeArg = parts[1];
+  const mode = modeArg === "auto" || modeArg === "report" || modeArg === "default" ? modeArg : undefined;
+  if (modeArg && !mode) {
+    ctx.ui.notify(`Unknown mode "${modeArg}" — use auto | report | default.`, "warning");
+    return;
+  }
   if (!id) {
-    ctx.ui.notify("Usage: /review <goal-id> — see /goal archive for ids.", "info");
+    ctx.ui.notify("Usage: /review <goal-id> [auto|report|default] — see /goal archive for ids.", "info");
     return;
   }
   // Resolve the id against the archive (suffix match allowed).
@@ -2907,7 +2915,7 @@ async function cmdReview(args: string, ctx: ExtensionContext): Promise<void> {
     ctx.ui.notify(`No archive found for ${id}.`, "warning");
     return;
   }
-  fireReviewer(ctx, { kind: "goal", goalId, objective, terminal: "goal-complete" }, { manual: true });
+  fireReviewer(ctx, { kind: "goal", goalId, objective, terminal: "goal-complete" }, { manual: true, mode });
 }
 
 /** v0.26.0: /glla reviewer — the reviewer config menu (project-scoped). */
@@ -2930,6 +2938,7 @@ async function cmdReviewerSettings(ctx: ExtensionContext): Promise<void> {
     if (!choice || choice === "Done") return;
     try {
       if (choice.startsWith("Enabled")) save({ enabled: !cfg.enabled });
+      else if (choice.startsWith("Mode")) save({ mode: cfg.mode === "default" ? "auto" : cfg.mode === "auto" ? "report" : "default" });
       else if (choice.startsWith("Leverage mode")) save({ leverageMode: cfg.leverageMode === "fix-without-confirm" ? "confirm-all" : "fix-without-confirm" });
       else if (choice.startsWith("Fire on goal-complete")) save({ fireOn: cfg.fireOn.includes("goal-complete") ? cfg.fireOn.filter((e) => e !== "goal-complete") : [...cfg.fireOn, "goal-complete"] });
       else if (choice.startsWith("Fire on list-complete")) save({ fireOn: cfg.fireOn.includes("list-complete") ? cfg.fireOn.filter((e) => e !== "list-complete") : [...cfg.fireOn, "list-complete"] });
@@ -3368,7 +3377,7 @@ export default function (pi: ExtensionAPI): void {
     handler: settingsHandler,
   });
   pi.registerCommand("review", {
-    description: "Manually run the reviewer on an archived goal: /review <goal-id> — extracts findings, writes a report to .pi-glla/reviews/, enqueues bug-class fixes to /list, proposes architectural items as /goal. Bypasses the trigger gates (explicit user request).",
+    description: "Manually run the reviewer on an archived goal: /review <goal-id> [auto|report|default] — extracts findings, writes a report to .pi-glla/reviews/, cascades per the mode (auto = auto-loop, no Confirms). Bypasses the trigger gates (explicit user request).",
     handler: (args: string, ctx: ExtensionContext) => { rememberCtx(ctx); return cmdReview(args, ctx); },
   });
   pi.registerCommand("list", {

package/extensions/reviewer.ts

@@ -15,8 +15,15 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 
+export type ReviewerMode = "default" | "auto" | "report";
+
 export interface ReviewerConfig {
   enabled: boolean;
+  /** v0.26.2: default = Confirm-gated cascade; auto = auto-loop — every
+   * finding class (incl. architectural) and the clean-completion audit
+   * become /list items with zero Confirms (strategic stays notify-only —
+   * decisions never auto-fire); report = write the report + notify only. */
+  mode: ReviewerMode;
   fireOn: Array<"goal-complete" | "list-complete">;
   doNotFireOn: string[];
   cascade: Array<"convert-findings-to-list" | "queue-leftovers" | "fire-audit-on-clean" | "notify-and-idle">;
@@ -30,6 +37,7 @@ export interface ReviewerConfig {
 
 export const DEFAULT_REVIEWER_CONFIG: ReviewerConfig = {
   enabled: true,
+  mode: "default",
   fireOn: ["goal-complete", "list-complete"],
   doNotFireOn: ["goal-aborted", "goal-paused"],
   cascade: ["convert-findings-to-list", "queue-leftovers", "fire-audit-on-clean", "notify-and-idle"],
@@ -57,16 +65,28 @@ export interface Finding {
 /** Leverage classification (contract item 5). Order matters: strategic
  * and architectural win over bug/refactor — "should we rewrite this
  * broken schema" is a decision, not a fix. */
+// v0.26.3: the bare words "architectural"/"strategic" are REMOVED — they
+// self-matched the reviewer's own vocabulary ("architectural-class",
+// "architectural findings", the docs' mode matrix) and produced 3 junk
+// findings on the 0.26.2 completion, observed live.
 const CLASS_PATTERNS: Array<{ class: FindingClass; re: RegExp }> = [
-  { class: "strategic", re: /\bshould we\b|\bdeprecat|ship this\??|strategic/i },
-  { class: "architectural", re: /\brewrite\b|new dependency|schema change|architectural|redesign/i },
+  { class: "strategic", re: /\bshould we\b|\bdeprecat|ship this\??/i },
+  { class: "architectural", re: /\brewrite\b|new dependency|schema change|\bredesign\b/i },
   { class: "bug", re: /\bTODO\b|\bFIXME\b|\bbug\b|\bissue\b|regression|broken|\bfixme\b/i },
-  { class: "refactor", re: /could be cleaner|consider refactoring|duplicat|refactor|left ?out|follow[\s-]?up|deferred/i },
+  { class: "refactor", re: /could be cleaner|consider refactoring|duplicat|refactor|left ?out|follow[\s-]?up|deferred|could be improved|improvement|enhancement|consider adding|would be nice|nice to have/i },
 ];
 
+/** v0.26.3: lines that never carry findings — code, markdown tables, and
+ * the reviewer's own report/config vocabulary. Observed false positives
+ * from the 0.26.2 completion: a test("…architectural…") name, the
+ * INSTALL.md mode-matrix row, and ship-doc prose. */
+const SKIP_LINE = /^\s*(test|it|describe|assert|expect)\s*\(|^\s*(const|let|var|function|import|export|require)\b|\{\s*\.\.\.\s*\}|,\s*\.\.\.$|^\s*\|/;
+const REVIEWER_VOCAB = /architectural-class|bug-class|refactor-class|strategic-class|reviewer found|cascade step|\*\*Mode\*\*|problems\s*\/\s*(improvements|architectural)/i;
+
 export function classifyFindingText(line: string): FindingClass | undefined {
   const t = line.trim();
   if (t.length < 8) return undefined;
+  if (SKIP_LINE.test(t) || REVIEWER_VOCAB.test(t)) return undefined;
   for (const { class: cls, re } of CLASS_PATTERNS) {
     if (re.test(t)) return cls;
   }
@@ -110,6 +130,7 @@ export interface ReviewReport {
   objective: string;
   findings: Finding[];
   cascadeStep: string;
+  mode: ReviewerMode;
   at: string;
 }
 
@@ -120,7 +141,7 @@ export function formatReviewReport(r: ReviewReport): string {
   return [
     `# Review — ${r.goalId}`,
     "",
-    `**Kind**: ${r.kind} · **At**: ${r.at}`,
+    `**Kind**: ${r.kind} · **At**: ${r.at} · **Mode**: ${r.mode}`,
     "",
     "## Summary",
     "",
@@ -186,7 +207,11 @@ export function runReviewer(
     if (config.doNotFireOn.includes(event)) return none(`doNotFireOn: ${event}`);
     if (source.kind === "goal" && source.terminal !== "goal-complete") return none(`not a completion: ${source.terminal}`);
     if (!config.fireOn.includes(source.kind === "goal" ? "goal-complete" : "list-complete")) return none("fireOn excludes this event");
-    if (reviewerFiredRecently(deps.ledgerEntries, REVIEWER_REFIRE_WINDOW_MS, deps.nowMs)) {
+    // v0.26.2: in auto mode the queue emptying is the cascade's natural
+    // rhythm, not a runaway — the refire window must not strangle it.
+    // (The per-day cap below still bounds everything.)
+    const refireWindowApplies = !(config.mode === "auto" && source.kind === "list");
+    if (refireWindowApplies && reviewerFiredRecently(deps.ledgerEntries, REVIEWER_REFIRE_WINDOW_MS, deps.nowMs)) {
       deps.ledger("reviewer_suppressed", { reason: "refire-window", goalId: source.goalId });
       return none("reviewer fired within the last 5 minutes (runaway prevention)");
     }
@@ -205,32 +230,47 @@ export function runReviewer(
   let enqueued = 0;
   let proposed = 0;
   let cascadeStep = "notify-and-idle";
+  const auto = config.mode === "auto";
+  const reportOnly = config.mode === "report";
 
   // Cascade: findings → list items (leverage: fix-without-confirm).
   const convertStep = source.kind === "goal" ? "convert-findings-to-list" : "queue-leftovers";
-  if (bugs.length > 0 && config.cascade.includes(convertStep)) {
+  if (bugs.length > 0 && config.cascade.includes(convertStep) && !reportOnly) {
     deps.enqueueListItems(bugs.map((f) => f.text));
     enqueued = bugs.length;
     cascadeStep = convertStep;
   }
-  // Architectural findings → /goal proposal WITH Confirm.
-  if (architectural.length > 0) {
-    deps.proposeGoal(
-      architectural.map((f) => f.text).join("; "),
-      `reviewer found ${architectural.length} architectural-class finding(s) — needs your Confirm`,
-    );
-    proposed += architectural.length;
-    cascadeStep = "propose-goal";
+  // Architectural findings: default mode → /goal proposal WITH Confirm;
+  // auto mode → /list items (the auto-loop rolls straight into them).
+  if (architectural.length > 0 && !reportOnly) {
+    if (auto) {
+      deps.enqueueListItems(architectural.map((f) => f.text));
+      enqueued += architectural.length;
+      cascadeStep = convertStep;
+    } else {
+      deps.proposeGoal(
+        architectural.map((f) => f.text).join("; "),
+        `reviewer found ${architectural.length} architectural-class finding(s) — needs your Confirm`,
+      );
+      proposed += architectural.length;
+      cascadeStep = "propose-goal";
+    }
   }
-  // Clean completion → audit /goal (opt-in cascade step).
-  if (findings.length === 0 && config.cascade.includes("fire-audit-on-clean")) {
-    deps.proposeGoal(
-      `Post-completion regression scan after ${source.goalId} (${config.auditScope})`,
-      "reviewer: completion looks clean — firing the audit step",
-    );
-    proposed++;
+  // Clean completion → audit: default mode proposes a /goal (Confirm);
+  // auto mode enqueues the audit as a /list item (no Confirm — the
+  // cascade keeps rolling until the findings run dry).
+  if (findings.length === 0 && config.cascade.includes("fire-audit-on-clean") && !reportOnly) {
+    const auditObjective = `Post-completion regression scan after ${source.goalId} (${config.auditScope})`;
+    if (auto) {
+      deps.enqueueListItems([auditObjective]);
+      enqueued++;
+    } else {
+      deps.proposeGoal(auditObjective, "reviewer: completion looks clean — firing the audit step");
+      proposed++;
+    }
     cascadeStep = "fire-audit-on-clean";
   }
+  if (reportOnly) cascadeStep = "report-only";
 
   const report: ReviewReport = {
     goalId: source.goalId,
@@ -238,6 +278,7 @@ export function runReviewer(
     objective: source.objective,
     findings,
     cascadeStep,
+    mode: config.mode,
     at: new Date(deps.nowMs).toISOString(),
   };
   const reportPath = writeReviewReport(deps.cwd, report);
@@ -265,6 +306,7 @@ export function runReviewer(
 export function reviewerMenuOptions(cfg: ReviewerConfig): string[] {
   return [
     `Enabled — ${cfg.enabled ? "ON" : "OFF"}`,
+    `Mode — ${cfg.mode} (default = Confirm-gated · auto = auto-loop, no Confirms · report = report only)`,
     `Leverage mode — ${cfg.leverageMode} (bug/refactor findings)`,
     `Fire on goal-complete — ${cfg.fireOn.includes("goal-complete") ? "ON" : "OFF"}`,
     `Fire on list-complete — ${cfg.fireOn.includes("list-complete") ? "ON" : "OFF"}`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.26.1",
+  "version": "0.26.3",
   "description": "Goal. Loop. Audit. Done. — a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor — only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",