pi-goal-list-loop-audit 0.26.0 → 0.26.2

package/extensions/goal-loop-core.ts

@@ -11,6 +11,17 @@ import * as fs from "node:fs";
 import * as path from "node:path";
 import { execSync } from "node:child_process";
 
+/** v0.26.1: consecutive heartbeat refires without a real agent turn
+ * before the supervisor gives up (pauses the goal / stops the loop).
+ * 0 = never escalate (legacy silent-spin behavior). */
+export const DEFAULT_STALL_ESCALATION_REFIRES = 5;
+
+/** v0.26.1: pure gate — has the refire streak hit the escalation
+ * threshold? threshold 0 disables escalation entirely. */
+export function shouldEscalateStall(consecutiveStalls: number, threshold: number): boolean {
+  return threshold > 0 && consecutiveStalls >= threshold;
+}
+
 // =================================================================
 // Types
 // =================================================================

package/extensions/goal-loop-display.ts

@@ -81,17 +81,20 @@ export interface AuditDisplayProgress {
  * One-line status for ctx.ui.setStatus("pi-glla", …).
  * Returns undefined when nothing is being supervised (clears the segment).
  */
-export function buildStatusText(state: State, audit?: AuditDisplayProgress | null, now = Date.now(), theme?: DisplayTheme): string | undefined {
+export function buildStatusText(state: State, audit?: AuditDisplayProgress | null, now = Date.now(), theme?: DisplayTheme, extras?: { stalls?: number }): string | undefined {
   if (state.loop?.active) {
     const l = state.loop;
+    // v0.26.1: surface the refire streak — a spinning supervisor is the
+    // zombie signature (hegemon incident: 619 refires, 0 turns).
+    const stallSuffix = (extras?.stalls ?? 0) > 0 ? ` · ${paint(theme, "warning", `stalls:${extras!.stalls}`)}` : "";
     // v0.23.0: metricless spec loop — no arrow/best/stall, no plateau.
     if (!l.measureCmd) {
-      return `glla: loop ${paint(theme, "accent", "∞")} iter ${l.iteration}${l.maxIterations > 0 ? `/${l.maxIterations}` : ""} · metricless`;
+      return `glla: loop ${paint(theme, "accent", "∞")} iter ${l.iteration}${l.maxIterations > 0 ? `/${l.maxIterations}` : ""} · metricless${stallSuffix}`;
     }
     const arrow = paint(theme, "accent", l.direction === "min" ? "↓" : "↑");
     const stallText = `stall ${l.stallCount}/${l.plateauWindow}`;
     const stall = l.stallCount >= l.plateauWindow - 1 ? paint(theme, "warning", stallText) : stallText;
-    return `glla: loop ${arrow} iter ${l.iteration}/${l.maxIterations > 0 ? l.maxIterations : "∞"} · best ${l.bestValue ?? "n/a"} · ${stall}`;
+    return `glla: loop ${arrow} iter ${l.iteration}/${l.maxIterations > 0 ? l.maxIterations : "∞"} · best ${l.bestValue ?? "n/a"} · ${stall}${stallSuffix}`;
   }
   const g = state.goal;
   if (!g) return undefined;
@@ -146,8 +149,8 @@ function countTotal(g: Goal): number {
  * Widget lines for ctx.ui.setWidget("pi-glla", lines).
  * Returns undefined when nothing is worth showing.
  */
-export function buildWidgetLines(state: State, audit?: AuditDisplayProgress | null, now = Date.now(), theme?: DisplayTheme, width?: number): string[] | undefined {
-  if (state.loop?.active) return loopLines(state.loop, now, theme, width);
+export function buildWidgetLines(state: State, audit?: AuditDisplayProgress | null, now = Date.now(), theme?: DisplayTheme, width?: number, extras?: { stalls?: number }): string[] | undefined {
+  if (state.loop?.active) return loopLines(state.loop, now, theme, width, extras);
   const g = state.goal;
   if (!g) return undefined;
   if (g.status === "complete" || g.status === "aborted") return undefined;
@@ -202,12 +205,14 @@ function goalLines(g: Goal, state: State, audit: AuditDisplayProgress | null | u
   return lines;
 }
 
-function loopLines(l: LoopState, now: number, theme?: DisplayTheme, width?: number): string[] {
+function loopLines(l: LoopState, now: number, theme?: DisplayTheme, width?: number, extras?: { stalls?: number }): string[] {
+  // v0.26.1: the refire streak, shown only while nonzero.
+  const stallNote = (extras?.stalls ?? 0) > 0 ? ` · ${paint(theme, "warning", `stalls:${extras!.stalls}`)}` : "";
   // v0.23.0: metricless spec loop — no arrow/best/stall, no plateau.
   if (!l.measureCmd) {
     const lines = [
       `${paint(theme, "accent", "●")} ${truncate(l.target, budgetFor(width, 3, 64))}`,
-      `├─ loop ∞ iter ${l.iteration}${l.maxIterations > 0 ? `/${l.maxIterations}` : ""} · ${fmtElapsed(now - Date.parse(l.startedAt))}`,
+      `├─ loop ∞ iter ${l.iteration}${l.maxIterations > 0 ? `/${l.maxIterations}` : ""} · ${fmtElapsed(now - Date.parse(l.startedAt))}${stallNote}`,
       `└─ ${paint(theme, "dim", "metricless — work the spec (no plateau)")}`,
     ];
     if (l.branchName) lines.push(`⎇ ${paint(theme, "muted", truncate(l.branchName, budgetFor(width, 3, 50)))}`);

package/extensions/goal-settings.ts

@@ -49,6 +49,9 @@ export interface Settings {
   /** Consecutive stuck interventions before a loop stops (default 5,
    * 10 under aggressiveMode). */
   stuckMaxInterventions?: number;
+  /** v0.26.1: consecutive heartbeat refires without a real turn before
+   * the goal pauses / loop stops (default 5; 0 = never escalate). */
+  stallEscalationRefires?: number;
   /** on → propose_* drafts activate WITHOUT the Confirm dialog and the
    * interview floor is skipped — the seed carries the intent (unattended
    * rigs). Default off: nothing activates before the user confirms. */
@@ -127,6 +130,7 @@ export const SETTINGS_KEYS: Array<keyof Settings> = [
   "aggressiveMode",
   "quotaRetryMinutes",
   "stuckMaxInterventions",
+  "stallEscalationRefires",
 ];
 
 /** Where each effective setting comes from (for the /glla display). */

package/extensions/loops/goal.ts

@@ -33,6 +33,7 @@ import {
   auditFeedbackExcerpt,
   DEFAULT_AUDIT_FEEDBACK_CHARS,
   DEFAULT_QUOTA_RETRY_MINUTES,
+  DEFAULT_STALL_ESCALATION_REFIRES,
   DEFAULT_TOKEN_LIMIT,
   classifyImpossibleReason,
   extractPendingTasks,
@@ -50,6 +51,7 @@ import {
   ledgerPath,
   crossRecommendMode,
   formatListDepth,
+  shouldEscalateStall,
   shouldSuppressHeartbeatForRecentShip,
   mergeSettings,
   parseListImport,
@@ -231,10 +233,16 @@ const countedLoopTokenMessages = new Set<string>();
 let lastActivityAt = Date.now();
 let lastWedgeAlertAt = 0;
 let heartbeatNudges = 0;
+// v0.26.1: consecutive heartbeat refires that produced NO real agent turn.
+// Resets only on real activity (agent_end / tool_call) — never on the
+// refire's own noteActivity, which is what made the hegemon zombie spin
+// self-sustaining (619 refires / 23.5h / zero turns).
+let consecutiveStalls = 0;
 let heartbeatTimer: NodeJS.Timeout | null = null;
 
-function noteActivity(): void {
+function noteActivity(real = false): void {
   lastActivityAt = Date.now();
+  if (real) consecutiveStalls = 0;
 }
 
 function isSupervising(): boolean {
@@ -256,8 +264,8 @@ function refreshUI(ctx: ExtensionContext): void {
     // Terminal width for truncation budgets: on wide terminals the widget
     // uses the room instead of cutting at fixed ~60-char floors.
     const width = process.stdout.columns || 80;
-    ctx.ui.setStatus("pi-glla", buildStatusText(state, latestAuditProgress, Date.now(), theme));
-    ctx.ui.setWidget("pi-glla", buildWidgetLines(state, latestAuditProgress, Date.now(), theme, width));
+    ctx.ui.setStatus("pi-glla", buildStatusText(state, latestAuditProgress, Date.now(), theme, { stalls: consecutiveStalls }));
+    ctx.ui.setWidget("pi-glla", buildWidgetLines(state, latestAuditProgress, Date.now(), theme, width, { stalls: consecutiveStalls }));
   } catch {
     // stale ctx — next event refreshes
   }
@@ -323,8 +331,36 @@ function heartbeatTick(): void {
     return;
   }
   noteActivity();
-  appendLedger(ctx.cwd, "heartbeat_refire", { nudgesSoFar: heartbeatNudges });
-  ctx.ui.notify("Heartbeat: supervisor active but session stalled — re-firing continuation.", "info");
+  consecutiveStalls++;
+  appendLedger(ctx.cwd, "heartbeat_refire", { nudgesSoFar: heartbeatNudges, consecutiveStalls });
+  // v0.26.1: a refire streak means the continuation is NOT landing (wedged
+  // message queue, stale API handle, dead turn trigger). Nudges can't catch
+  // this — they count turns, and a zombie runs none. Escalate to a loud,
+  // actionable stop instead of spinning silently forever.
+  const stallEscalation = loadSettings(ctx.cwd).stallEscalationRefires ?? DEFAULT_STALL_ESCALATION_REFIRES;
+  if (shouldEscalateStall(consecutiveStalls, stallEscalation)) {
+    consecutiveStalls = 0;
+    appendLedger(ctx.cwd, "stall_escalated", { threshold: stallEscalation, kind: isLoopActive() ? "loop" : "goal" });
+    if (isLoopActive()) {
+      clearLoopTimer();
+      state.loop = { ...state.loop!, active: false, stopReason: `stalled: ${stallEscalation} continuation refires landed no turn — the session is not continuing (wedged message queue or stale API). Restart pi, then /loop start again.` };
+      persistState(ctx);
+      ctx.ui.notify(`Loop stopped: ${stallEscalation} refires produced no turn — the continuation is not landing. Restart pi and /loop start.`, "warning");
+      notifyExternal(ctx, "Loop stopped: stalled (continuation not landing).");
+      return;
+    }
+    if (state.goal && state.goal.status === "active") {
+      updateGoal({
+        status: "paused",
+        pauseReason: `stalled: ${stallEscalation} continuation refires landed no turn`,
+        pauseSuggestedAction: "The continuation chain is broken in this process (wedged message queue or stale API). Restart pi, then /goal resume.",
+      }, ctx);
+      ctx.ui.notify(`Goal paused: ${stallEscalation} refires produced no turn. Restart pi, then /goal resume.`, "warning");
+      notifyExternal(ctx, "Goal paused: stalled (continuation not landing).");
+      return;
+    }
+  }
+  ctx.ui.notify(`Heartbeat: supervisor active but session stalled — re-firing continuation (stall ${consecutiveStalls}/${stallEscalation > 0 ? stallEscalation : "∞"}).`, "info");
   if (isLoopActive()) {
     scheduleLoopTick(ctx);
   } else {
@@ -415,7 +451,9 @@ function sendContinuation(goalId: string): void {
       content: continuationPrompt(state.goal!),
       display: false,
     }, { triggerTurn: true, deliverAs: "followUp" });
-  } catch {
+    appendLedger(ctx.cwd, "goal_continuation_sent", { goalId });
+  } catch (err) {
+    appendLedger(ctx.cwd, "goal_continuation_send_failed", { goalId, error: err instanceof Error ? err.message : String(err) });
     // API went stale mid-flight; next agent_end/session_start will reschedule.
   }
 }
@@ -545,11 +583,12 @@ function archiveCurrentGoal(ctx: ExtensionContext, status: Status, stopReason?:
 function fireReviewer(
   ctx: ExtensionContext,
   source: { kind: "goal" | "list"; goalId: string; objective: string; terminal: string },
-  opts: { manual?: boolean } = {},
+  opts: { manual?: boolean; mode?: "default" | "auto" | "report" } = {},
 ): void {
   try {
     const settings = loadSettings(ctx.cwd);
     const config = resolveReviewerConfig(settings.reviewer as Partial<ReviewerConfig> | undefined);
+    if (opts.mode) config.mode = opts.mode;
     const sources: Array<{ name: string; text: string }> = [];
     try {
       sources.push({ name: "archive", text: fs.readFileSync(archivedGoalPath(ctx.cwd, source.goalId), "utf-8") });
@@ -1300,8 +1339,13 @@ function sendLoopTurn(): void {
       content: loopPrompt(loop, regressionNote, strategyNote, boundsNote, interventionNote, variantNote),
       display: false,
     }, { triggerTurn: true, deliverAs: "followUp" });
-  } catch {
-    // stale API — next agent_end reschedules
+    // v0.26.1: the send path is ledgered — the hegemon zombie spun 619
+    // refires with zero visibility into whether sends were landing.
+    appendLedger(ctx.cwd, "loop_turn_sent", { iteration: loop.iteration });
+  } catch (err) {
+    // stale API — next agent_end reschedules (but if none comes, the
+    // heartbeat's stall escalation stops the spin — v0.26.1).
+    appendLedger(ctx.cwd, "loop_turn_send_failed", { error: err instanceof Error ? err.message : String(err) });
   }
 }
 
@@ -2841,9 +2885,16 @@ async function openSettingsUI(ctx: ExtensionContext): Promise<void> {
 
 /** v0.26.0: /review <archived-goal-id> — manual reviewer invocation. */
 async function cmdReview(args: string, ctx: ExtensionContext): Promise<void> {
-  const id = args.trim();
+  const parts = args.trim().split(/\s+/).filter(Boolean);
+  const id = parts[0] ?? "";
+  const modeArg = parts[1];
+  const mode = modeArg === "auto" || modeArg === "report" || modeArg === "default" ? modeArg : undefined;
+  if (modeArg && !mode) {
+    ctx.ui.notify(`Unknown mode "${modeArg}" — use auto | report | default.`, "warning");
+    return;
+  }
   if (!id) {
-    ctx.ui.notify("Usage: /review <goal-id> — see /goal archive for ids.", "info");
+    ctx.ui.notify("Usage: /review <goal-id> [auto|report|default] — see /goal archive for ids.", "info");
     return;
   }
   // Resolve the id against the archive (suffix match allowed).
@@ -2864,7 +2915,7 @@ async function cmdReview(args: string, ctx: ExtensionContext): Promise<void> {
     ctx.ui.notify(`No archive found for ${id}.`, "warning");
     return;
   }
-  fireReviewer(ctx, { kind: "goal", goalId, objective, terminal: "goal-complete" }, { manual: true });
+  fireReviewer(ctx, { kind: "goal", goalId, objective, terminal: "goal-complete" }, { manual: true, mode });
 }
 
 /** v0.26.0: /glla reviewer — the reviewer config menu (project-scoped). */
@@ -2887,6 +2938,7 @@ async function cmdReviewerSettings(ctx: ExtensionContext): Promise<void> {
     if (!choice || choice === "Done") return;
     try {
       if (choice.startsWith("Enabled")) save({ enabled: !cfg.enabled });
+      else if (choice.startsWith("Mode")) save({ mode: cfg.mode === "default" ? "auto" : cfg.mode === "auto" ? "report" : "default" });
       else if (choice.startsWith("Leverage mode")) save({ leverageMode: cfg.leverageMode === "fix-without-confirm" ? "confirm-all" : "fix-without-confirm" });
       else if (choice.startsWith("Fire on goal-complete")) save({ fireOn: cfg.fireOn.includes("goal-complete") ? cfg.fireOn.filter((e) => e !== "goal-complete") : [...cfg.fireOn, "goal-complete"] });
       else if (choice.startsWith("Fire on list-complete")) save({ fireOn: cfg.fireOn.includes("list-complete") ? cfg.fireOn.filter((e) => e !== "list-complete") : [...cfg.fireOn, "list-complete"] });
@@ -3153,6 +3205,19 @@ async function cmdSettings(args: string, ctx: ExtensionContext): Promise<void> {
           ctx.ui.notify(`quotaretryminutes must be a positive integer, got: ${value}`, "warning");
         }
       }
+    } else if (key === "stallescalation" || key === "stallescalationrefires") {
+      if (["unset", "default"].includes(value)) {
+        patch.stallEscalationRefires = undefined;
+        changed = true;
+      } else {
+        const n = Number.parseInt(value, 10);
+        if (Number.isInteger(n) && n >= 0) {
+          patch.stallEscalationRefires = n;
+          changed = true;
+        } else {
+          ctx.ui.notify(`stallescalation must be a non-negative integer (0 = never escalate), got: ${value}`, "warning");
+        }
+      }
     } else if (key === "stuckmax" || key === "stuckmaxinterventions") {
       if (["unset", "default"].includes(value)) {
         patch.stuckMaxInterventions = undefined;
@@ -3302,6 +3367,7 @@ export default function (pi: ExtensionAPI): void {
       ["aggressivemode=", "on: keep-going defaults — autoResume, cap 10, stuck 10, wedge off, quota auto-retry, cap→TODOs"],
       ["quotaretryminutes=", "N: minutes before auto-retrying a quota-exhausted auditor (default 60)"],
       ["stuckmax=", "N: consecutive stuck interventions before a loop stops (default 5)"],
+      ["stallescalation=", "N: heartbeat refires without a turn before goal pauses / loop stops (default 5, 0 = never)"],
       ["stats", "per-project ledger rollups: /glla stats [json|premature|project=<path>]"],
       ["audits", "audit-log browser: /glla audits [N|full] — recent verdicts from .pi-glla/audits.jsonl"],
       ["autoaccept=", "on: drafts activate without the Confirm dialog (unattended rigs)"],
@@ -3311,7 +3377,7 @@ export default function (pi: ExtensionAPI): void {
     handler: settingsHandler,
   });
   pi.registerCommand("review", {
-    description: "Manually run the reviewer on an archived goal: /review <goal-id> — extracts findings, writes a report to .pi-glla/reviews/, enqueues bug-class fixes to /list, proposes architectural items as /goal. Bypasses the trigger gates (explicit user request).",
+    description: "Manually run the reviewer on an archived goal: /review <goal-id> [auto|report|default] — extracts findings, writes a report to .pi-glla/reviews/, cascades per the mode (auto = auto-loop, no Confirms). Bypasses the trigger gates (explicit user request).",
     handler: (args: string, ctx: ExtensionContext) => { rememberCtx(ctx); return cmdReview(args, ctx); },
   });
   pi.registerCommand("list", {
@@ -3367,6 +3433,30 @@ export default function (pi: ExtensionAPI): void {
     }
   }
 
+  // v0.26.1: compaction ends WITHOUT an agent_end (the compaction turn is
+  // not an agent turn), so the continuation chain can dangle until the
+  // 60s heartbeat notices. Re-arm it as soon as pi settles post-compact.
+  pi.on("session_compact", async (_event: any, ctx: ExtensionContext) => {
+    if (isForeignCtx(ctx)) return;
+    rememberCtx(ctx);
+    if (!isSupervising()) return;
+    appendLedger(ctx.cwd, "session_compact", {});
+    const settle = setTimeout(() => {
+      const c = freshCtx();
+      if (!c) return;
+      try {
+        if (c.isIdle() && !c.hasPendingMessages() && continuationTimer === null && loopTimer === null && isSupervising()) {
+          appendLedger(c.cwd, "compaction_refire", {});
+          if (isLoopActive()) scheduleLoopTick(c);
+          else scheduleContinuation(c, true);
+        }
+      } catch {
+        /* settle race — the 60s heartbeat covers it */
+      }
+    }, 2000);
+    settle.unref?.();
+  });
+
   pi.on("message_start", async (event: any, _ctx: ExtensionContext) => {
     // v0.14.0 drafting floor: count real user replies while drafting. Our
     // own injected draft prompt arrives as a user message — skip that one.
@@ -3549,7 +3639,7 @@ export default function (pi: ExtensionAPI): void {
     // v0.23.8: a subagent finishing must not drive the main session's
     // continuation loop.
     if (isForeignCtx(ctx)) return;
-    noteActivity();
+    noteActivity(true);
     // v0.25.2: per-goal turn telemetry (/glla stats).
     if (state.goal && state.goal.status === "active") {
       const t = state.goal.telemetry ?? { turns: 0, fileWrites: 0, bashCalls: 0 };
@@ -3650,7 +3740,7 @@ export default function (pi: ExtensionAPI): void {
 
   pi.on("tool_call", () => {
     toolCallsThisTurn++;
-    noteActivity();
+    noteActivity(true);
     // v0.24.0: count loop-iteration tool calls (narration-only detection).
     if (isLoopActive()) {
       state.loop!.toolsThisTurn = (state.loop!.toolsThisTurn ?? 0) + 1;

package/extensions/reviewer.ts

@@ -15,8 +15,15 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 
+export type ReviewerMode = "default" | "auto" | "report";
+
 export interface ReviewerConfig {
   enabled: boolean;
+  /** v0.26.2: default = Confirm-gated cascade; auto = auto-loop — every
+   * finding class (incl. architectural) and the clean-completion audit
+   * become /list items with zero Confirms (strategic stays notify-only —
+   * decisions never auto-fire); report = write the report + notify only. */
+  mode: ReviewerMode;
   fireOn: Array<"goal-complete" | "list-complete">;
   doNotFireOn: string[];
   cascade: Array<"convert-findings-to-list" | "queue-leftovers" | "fire-audit-on-clean" | "notify-and-idle">;
@@ -30,6 +37,7 @@ export interface ReviewerConfig {
 
 export const DEFAULT_REVIEWER_CONFIG: ReviewerConfig = {
   enabled: true,
+  mode: "default",
   fireOn: ["goal-complete", "list-complete"],
   doNotFireOn: ["goal-aborted", "goal-paused"],
   cascade: ["convert-findings-to-list", "queue-leftovers", "fire-audit-on-clean", "notify-and-idle"],
@@ -61,7 +69,7 @@ const CLASS_PATTERNS: Array<{ class: FindingClass; re: RegExp }> = [
   { class: "strategic", re: /\bshould we\b|\bdeprecat|ship this\??|strategic/i },
   { class: "architectural", re: /\brewrite\b|new dependency|schema change|architectural|redesign/i },
   { class: "bug", re: /\bTODO\b|\bFIXME\b|\bbug\b|\bissue\b|regression|broken|\bfixme\b/i },
-  { class: "refactor", re: /could be cleaner|consider refactoring|duplicat|refactor|left ?out|follow[\s-]?up|deferred/i },
+  { class: "refactor", re: /could be cleaner|consider refactoring|duplicat|refactor|left ?out|follow[\s-]?up|deferred|could be improved|improvement|enhancement|consider adding|would be nice|nice to have/i },
 ];
 
 export function classifyFindingText(line: string): FindingClass | undefined {
@@ -110,6 +118,7 @@ export interface ReviewReport {
   objective: string;
   findings: Finding[];
   cascadeStep: string;
+  mode: ReviewerMode;
   at: string;
 }
 
@@ -120,7 +129,7 @@ export function formatReviewReport(r: ReviewReport): string {
   return [
     `# Review — ${r.goalId}`,
     "",
-    `**Kind**: ${r.kind} · **At**: ${r.at}`,
+    `**Kind**: ${r.kind} · **At**: ${r.at} · **Mode**: ${r.mode}`,
     "",
     "## Summary",
     "",
@@ -186,7 +195,11 @@ export function runReviewer(
     if (config.doNotFireOn.includes(event)) return none(`doNotFireOn: ${event}`);
     if (source.kind === "goal" && source.terminal !== "goal-complete") return none(`not a completion: ${source.terminal}`);
     if (!config.fireOn.includes(source.kind === "goal" ? "goal-complete" : "list-complete")) return none("fireOn excludes this event");
-    if (reviewerFiredRecently(deps.ledgerEntries, REVIEWER_REFIRE_WINDOW_MS, deps.nowMs)) {
+    // v0.26.2: in auto mode the queue emptying is the cascade's natural
+    // rhythm, not a runaway — the refire window must not strangle it.
+    // (The per-day cap below still bounds everything.)
+    const refireWindowApplies = !(config.mode === "auto" && source.kind === "list");
+    if (refireWindowApplies && reviewerFiredRecently(deps.ledgerEntries, REVIEWER_REFIRE_WINDOW_MS, deps.nowMs)) {
       deps.ledger("reviewer_suppressed", { reason: "refire-window", goalId: source.goalId });
       return none("reviewer fired within the last 5 minutes (runaway prevention)");
     }
@@ -205,32 +218,47 @@ export function runReviewer(
   let enqueued = 0;
   let proposed = 0;
   let cascadeStep = "notify-and-idle";
+  const auto = config.mode === "auto";
+  const reportOnly = config.mode === "report";
 
   // Cascade: findings → list items (leverage: fix-without-confirm).
   const convertStep = source.kind === "goal" ? "convert-findings-to-list" : "queue-leftovers";
-  if (bugs.length > 0 && config.cascade.includes(convertStep)) {
+  if (bugs.length > 0 && config.cascade.includes(convertStep) && !reportOnly) {
     deps.enqueueListItems(bugs.map((f) => f.text));
     enqueued = bugs.length;
     cascadeStep = convertStep;
   }
-  // Architectural findings → /goal proposal WITH Confirm.
-  if (architectural.length > 0) {
-    deps.proposeGoal(
-      architectural.map((f) => f.text).join("; "),
-      `reviewer found ${architectural.length} architectural-class finding(s) — needs your Confirm`,
-    );
-    proposed += architectural.length;
-    cascadeStep = "propose-goal";
+  // Architectural findings: default mode → /goal proposal WITH Confirm;
+  // auto mode → /list items (the auto-loop rolls straight into them).
+  if (architectural.length > 0 && !reportOnly) {
+    if (auto) {
+      deps.enqueueListItems(architectural.map((f) => f.text));
+      enqueued += architectural.length;
+      cascadeStep = convertStep;
+    } else {
+      deps.proposeGoal(
+        architectural.map((f) => f.text).join("; "),
+        `reviewer found ${architectural.length} architectural-class finding(s) — needs your Confirm`,
+      );
+      proposed += architectural.length;
+      cascadeStep = "propose-goal";
+    }
   }
-  // Clean completion → audit /goal (opt-in cascade step).
-  if (findings.length === 0 && config.cascade.includes("fire-audit-on-clean")) {
-    deps.proposeGoal(
-      `Post-completion regression scan after ${source.goalId} (${config.auditScope})`,
-      "reviewer: completion looks clean — firing the audit step",
-    );
-    proposed++;
+  // Clean completion → audit: default mode proposes a /goal (Confirm);
+  // auto mode enqueues the audit as a /list item (no Confirm — the
+  // cascade keeps rolling until the findings run dry).
+  if (findings.length === 0 && config.cascade.includes("fire-audit-on-clean") && !reportOnly) {
+    const auditObjective = `Post-completion regression scan after ${source.goalId} (${config.auditScope})`;
+    if (auto) {
+      deps.enqueueListItems([auditObjective]);
+      enqueued++;
+    } else {
+      deps.proposeGoal(auditObjective, "reviewer: completion looks clean — firing the audit step");
+      proposed++;
+    }
     cascadeStep = "fire-audit-on-clean";
   }
+  if (reportOnly) cascadeStep = "report-only";
 
   const report: ReviewReport = {
     goalId: source.goalId,
@@ -238,6 +266,7 @@ export function runReviewer(
     objective: source.objective,
     findings,
     cascadeStep,
+    mode: config.mode,
     at: new Date(deps.nowMs).toISOString(),
   };
   const reportPath = writeReviewReport(deps.cwd, report);
@@ -265,6 +294,7 @@ export function runReviewer(
 export function reviewerMenuOptions(cfg: ReviewerConfig): string[] {
   return [
     `Enabled — ${cfg.enabled ? "ON" : "OFF"}`,
+    `Mode — ${cfg.mode} (default = Confirm-gated · auto = auto-loop, no Confirms · report = report only)`,
     `Leverage mode — ${cfg.leverageMode} (bug/refactor findings)`,
     `Fire on goal-complete — ${cfg.fireOn.includes("goal-complete") ? "ON" : "OFF"}`,
     `Fire on list-complete — ${cfg.fireOn.includes("list-complete") ? "ON" : "OFF"}`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.26.0",
+  "version": "0.26.2",
   "description": "Goal. Loop. Audit. Done. — a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor — only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",