pi-goal-list-loop-audit 0.24.7 → 0.24.9

package/README.md

@@ -201,6 +201,7 @@ No external watchdog plugin needed.
 /glla wedgealert=30                  # hung-command alert minutes (default: 30, 0 = off)
 /glla autoresume=on                  # held goals/loops auto-resume in fresh sessions (unattended rigs)
 /glla auditcap=5                     # pause the goal after N consecutive auditor disapprovals (default 3, 0 = unlimited)
+/glla auditfeedbackchars=800         # cap the executor-visible auditor report (default 0 = full report)
 /glla autoaccept=on                  # drafts ACTIVATE without the Confirm dialog (unattended rigs)
 /glla project tokenlimit=500         # rare per-project override
 ```
@@ -211,6 +212,12 @@ auditor can't auth it — you're told once (info level) with the fix:
 `/glla model=provider/id`, set once, rarely touched again. The plugin never
 picks a model itself. Thinking follows the session too (floor `high`).
 
+On disapproval, the executor receives the full auditor report by default
+(`auditFeedbackChars=0`, since v0.24.9 — a truncated report loses exactly the
+actionable tail of multi-item `<evidence>` blocks). Set a positive
+`auditFeedbackChars` to cap it. The complete report is always stored in audit
+history and is available through `/goal status` regardless.
+
 `autoaccept=on` skips BOTH the Confirm dialog and the drafting interview
 floor — every `propose_*` draft (goal, list batch, loop, task list)
 activates the moment the agent proposes it, with a notification and a
@@ -320,4 +327,4 @@ pi install .
 
 ## License
 
-MIT
+MIT

package/extensions/goal-loop-core.ts

@@ -287,6 +287,23 @@ export function mergeSettings<T extends Record<string, unknown>>(base: T, ...lay
   return out as T;
 }
 
+/**
+ * Default for executor-visible auditor feedback. 0 = no cap: the executor
+ * gets the FULL disapproval report (v0.24.9 — truncating by default cut
+ * exactly the actionable tail of multi-item <evidence> blocks; a few KB of
+ * report is negligible next to a wasted re-attempt). Set a positive
+ * auditFeedbackChars to cap.
+ */
+export const DEFAULT_AUDIT_FEEDBACK_CHARS = 0;
+
+/**
+ * Bound the auditor report returned to the executor after disapproval.
+ * A limit of 0 explicitly means "show the full report".
+ */
+export function auditFeedbackExcerpt(output: string, maxChars: number): string {
+  return maxChars === 0 ? output : output.slice(0, maxChars);
+}
+
 export interface ListItem {
   id: string;
   objective: string;

package/extensions/loops/goal.ts

@@ -30,6 +30,8 @@ import {
   archivedGoalPath,
   buildTaskList,
   buildTaskSummary,
+  auditFeedbackExcerpt,
+  DEFAULT_AUDIT_FEEDBACK_CHARS,
   DEFAULT_TOKEN_LIMIT,
   mergeSettings,
   parseListImport,
@@ -1666,7 +1668,19 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
       // goal the auditor can NEVER approve used to re-continue forever.
       // auditCap consecutive disapprovals → pause + notify, bounded and
       // surfaced like every other stop in this stack.
-      const auditCap = loadSettings(ctx.cwd).auditCap ?? 3;
+      const auditCap = settings.auditCap ?? 3;
+      const configuredFeedbackChars = settings.auditFeedbackChars;
+      const auditFeedbackChars = Number.isInteger(configuredFeedbackChars) && configuredFeedbackChars! >= 0
+        ? configuredFeedbackChars!
+        : DEFAULT_AUDIT_FEEDBACK_CHARS;
+      const auditFeedback = auditFeedbackExcerpt(result.output, auditFeedbackChars);
+      const auditFeedbackIsFull = auditFeedbackChars === 0 || result.output.length <= auditFeedbackChars;
+      const auditFeedbackLabel = auditFeedbackIsFull
+        ? "full report"
+        : `first ${auditFeedbackChars} chars`;
+      const auditFeedbackTruncationHint = auditFeedbackIsFull
+        ? ""
+        : `\n\nReport truncated at the configured limit. /goal status shows the full report; change future feedback with /glla auditfeedbackchars=N (0 = full report).`;
       const trailingDisapprovals = countTrailingDisapprovals(history);
       if (auditCap > 0 && trailingDisapprovals >= auditCap) {
         updateGoal({
@@ -1681,7 +1695,7 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
         return {
           content: [{
             type: "text",
-            text: `The auditor has now disapproved ${trailingDisapprovals} times in a row (cap ${auditCap}). The goal is PAUSED — continuing to re-attempt without addressing the pattern wastes tokens. Latest report (first 800 chars):\n${result.output.slice(0, 800)}\n\nDo not call complete_goal again. Summarize the repeated objections for the user and ask how to proceed (/goal status shows all reports; /goal resume resumes).`,
+            text: `The auditor has now disapproved ${trailingDisapprovals} times in a row (cap ${auditCap}). The goal is PAUSED — continuing to re-attempt without addressing the pattern wastes tokens. Latest report (${auditFeedbackLabel}):\n${auditFeedback}\n\nDo not call complete_goal again. Summarize the repeated objections for the user and ask how to proceed (/goal status shows all reports; /goal resume resumes).`,
           }],
           details: {},
         };
@@ -1696,7 +1710,7 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
       return {
         content: [{
           type: "text",
-          text: `Auditor disapproved. Report (first 800 chars):\n${result.output.slice(0, 800)}${noContractHint}`,
+          text: `Auditor disapproved. Report (${auditFeedbackLabel}):\n${auditFeedback}${auditFeedbackTruncationHint}${noContractHint}`,
         }],
         details: {},
       };
@@ -2267,6 +2281,9 @@ interface Settings {
   autoResume?: boolean;
   /** v0.24.2: pause the goal after N consecutive auditor disapprovals (0 = unlimited). Default 3. */
   auditCap?: number;
+  /** Maximum auditor-report characters returned to the executor after a
+   * disapproval (0 = full report). Default 0 (full report). */
+  auditFeedbackChars?: number;
   /** on → propose_* drafts activate WITHOUT the Confirm dialog and the
    * interview floor is skipped — the seed carries the intent (unattended
    * rigs). Default off: nothing activates before the user confirms. */
@@ -2293,6 +2310,7 @@ const DEFAULT_SETTINGS: Settings = {
   // v0.24.6: subagents inherit the session model by default — one quota
   // pool, no surprise 403s from a pinned default agent's provider.
   subagentModelStrategy: "inherit-parent",
+  auditFeedbackChars: DEFAULT_AUDIT_FEEDBACK_CHARS,
 };
 
 // Two-tier config (v0.7.0): GLOBAL is the normal home — you set things once
@@ -2330,7 +2348,7 @@ function settingsProvenance(cwd: string): Record<keyof Settings, { value: unknow
   const glob = readSettingsFile(globalSettingsPath());
   const effective = loadSettings(cwd);
   const out: Record<string, { value: unknown; source: "project" | "global" | "default" }> = {};
-  const keys: Array<keyof Settings> = ["auditorModel", "auditorThinkingLevel", "notifyCmd", "tokenLimit", "wedgeAlertMinutes", "autoResume", "autoAcceptDrafts", "auditCap"];
+  const keys: Array<keyof Settings> = ["auditorModel", "auditorThinkingLevel", "notifyCmd", "tokenLimit", "wedgeAlertMinutes", "autoResume", "autoAcceptDrafts", "auditCap", "auditFeedbackChars", "subagentModelStrategy", "subagentModelOverrides"];
   for (const k of keys) {
     if ((proj as Record<string, unknown>)[k] !== undefined) out[k] = { value: (proj as any)[k], source: "project" };
     else if ((glob as Record<string, unknown>)[k] !== undefined) out[k] = { value: (glob as any)[k], source: "global" };
@@ -2432,6 +2450,7 @@ async function openSettingsUI(ctx: ExtensionContext): Promise<void> {
           `Wedge alert minutes — ${show("wedgeAlertMinutes", `(${WEDGE_ALERT_DEFAULT_MINUTES}m default)`)}`,
           `Subagent model strategy — ${show("subagentModelStrategy", "(inherit-parent)")}`,
           `Subagent Explore model pin — ${loadSettings(ctx.cwd).subagentModelOverrides?.Explore ?? "(follows strategy)"}`,
+          `Audit feedback characters — ${show("auditFeedbackChars", "(full report)")}`,
           "Done",
         ],
       );
@@ -2485,6 +2504,15 @@ async function openSettingsUI(ctx: ExtensionContext): Promise<void> {
           saveSettings("global", ctx.cwd, { subagentModelOverrides: Object.keys(next).length > 0 ? next : undefined });
           ctx.ui.notify("Explore model pin saved — applies to NEW pi sessions.", "info");
         }
+      } else if (choice.startsWith("Audit feedback")) {
+        const v = await ctx.ui.input("Auditor feedback returned to the executor (characters)", "non-negative integer cap; 0 or empty = full report (default)");
+        if (v !== undefined) {
+          const raw = v.trim();
+          const n = Number(raw);
+          if (/^\d+$/.test(raw) && Number.isSafeInteger(n)) saveSettings("global", ctx.cwd, { auditFeedbackChars: n });
+          else if (!v.trim()) saveSettings("global", ctx.cwd, { auditFeedbackChars: undefined });
+          else ctx.ui.notify(`Not a non-negative integer: ${v}`, "warning");
+        }
       }
     } catch {
       return;
@@ -2500,6 +2528,7 @@ async function cmdSettings(args: string, ctx: ExtensionContext): Promise<void> {
   //   /glla notify='cmd $1'      write to GLOBAL config
   //   /glla tokenlimit=2000000   write to GLOBAL config
   //   /glla wedgealert=30         hung-command alert minutes (0=off, unset=30)
+  //   /glla auditfeedbackchars=800 cap executor-visible disapproval report (0=full, the default)
   //   /glla project model=...    write to PROJECT override (rare)
   //   /glla model=unset          remove key (from global; project model=unset for project)
   const trimmed = args.trim();
@@ -2524,6 +2553,7 @@ async function cmdSettings(args: string, ctx: ExtensionContext): Promise<void> {
         fmt("autoResume", "autoResume"),
         fmt("autoAcceptDrafts", "autoAccept"),
         fmt("auditCap", "auditCap"),
+        fmt("auditFeedbackChars", "auditFeedbackChars"),
         `\nglobal:  ${globalSettingsPath()}`,
         `project: ${projectSettingsPath(ctx.cwd)}`,
         `Set with: /glla key=value (global) · /glla project key=value (project override)`,
@@ -2609,6 +2639,19 @@ async function cmdSettings(args: string, ctx: ExtensionContext): Promise<void> {
           ctx.ui.notify(`auditcap must be a non-negative integer (0 = unlimited), got: ${value}`, "warning");
         }
       }
+    } else if (key === "auditfeedbackchars") {
+      if (["unset", "default"].includes(value)) {
+        patch.auditFeedbackChars = undefined;
+        changed = true;
+      } else {
+        const n = Number(value);
+        if (/^\d+$/.test(value) && Number.isSafeInteger(n)) {
+          patch.auditFeedbackChars = n;
+          changed = true;
+        } else {
+          ctx.ui.notify(`auditfeedbackchars must be a non-negative integer (0 = full report), got: ${value}`, "warning");
+        }
+      }
     } else if (key === "thinking" || key === "auditorthinkinglevel") {
       if (["off", "minimal", "low", "medium", "high", "xhigh"].includes(value)) {
         patch.auditorThinkingLevel = value as Settings["auditorThinkingLevel"];
@@ -2619,13 +2662,13 @@ async function cmdSettings(args: string, ctx: ExtensionContext): Promise<void> {
     }
   }
   if (!changed) {
-    ctx.ui.notify("Nothing changed. Use key=value (model, thinking, notify, tokenlimit, autoresume), optionally prefixed with 'project'.", "info");
+    ctx.ui.notify("Nothing changed. Use key=value (model, thinking, notify, tokenlimit, autoresume, auditcap, auditfeedbackchars), optionally prefixed with 'project'.", "info");
     return;
   }
   saveSettings(scope, ctx.cwd, patch);
   const effective = loadSettings(ctx.cwd);
   ctx.ui.notify(
-    `Saved to ${scope} config. Effective now: model=${effective.auditorModel ?? "(session model)"} thinking=${effective.auditorThinkingLevel ?? "(session)"} notify=${effective.notifyCmd ?? "(off)"} tokenLimit=${effective.tokenLimit ?? 0}${(effective.tokenLimit ?? 0) > 0 ? "" : " (off)"} autoResume=${effective.autoResume === true ? "on" : "off"}\n` +
+    `Saved to ${scope} config. Effective now: model=${effective.auditorModel ?? "(session model)"} thinking=${effective.auditorThinkingLevel ?? "(session)"} notify=${effective.notifyCmd ?? "(off)"} tokenLimit=${effective.tokenLimit ?? 0}${(effective.tokenLimit ?? 0) > 0 ? "" : " (off)"} autoResume=${effective.autoResume === true ? "on" : "off"} auditFeedbackChars=${effective.auditFeedbackChars ?? DEFAULT_AUDIT_FEEDBACK_CHARS}${(effective.auditFeedbackChars ?? DEFAULT_AUDIT_FEEDBACK_CHARS) === 0 ? " (full report)" : ""}\n` +
     `Note: the auditor runs without extensions — it must be a built-in provider, not an extension-registered one.`,
     "info",
   );
@@ -2741,6 +2784,7 @@ export default function (pi: ExtensionAPI): void {
       ["tokenlimit=", "per-goal token budget (0 = off): /glla tokenlimit=2000000"],
       ["autoresume=", "on: auto-resume held goals/loops in fresh sessions"],
       ["auditcap=", "N: pause goal after N consecutive auditor disapprovals (default 3, 0 = unlimited)"],
+      ["auditfeedbackchars=", "cap on executor-visible disapproval report chars (0 = full report, the default)"],
       ["autoaccept=", "on: drafts activate without the Confirm dialog (unattended rigs)"],
       ["project", "write a project override: /glla project key=value"],
     ]),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.24.7",
+  "version": "0.24.9",
   "description": "Goal. Loop. Audit. Done. — a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor — only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",