pi-goal-list-loop-audit 0.23.6 → 0.23.7

package/extensions/goal-loop-core.ts

@@ -300,7 +300,10 @@ export interface ListItem {
 export function goalArgsNeedDrafting(args: string): boolean {
   const t = args.trim();
   if (!t) return false; // no-args is already the drafting path
-  return !/\bdone\s+when\s*:/i.test(t);
+  // v0.23.7: any "done when" phrase counts — requiring the colon to
+  // immediately follow made "Done when ALL of the following are true:"
+  // route to the interview even though the user wrote a contract.
+  return !/\bdone\s+when\b/i.test(t);
 }
 
 /**
@@ -627,3 +630,43 @@ export function normalizeDraftContract(raw: string): string {
 export function draftContractItemCount(normalized: string): number {
   return normalized.split("\n").filter((l) => /^\d+\.\s/.test(l)).length;
 }
+
+/**
+ * Split raw objective text into { objective, verificationContract } at the
+ * first "Done when…:"-family marker (line-start preferred, inline fallback
+ * for one-liners). v0.23.7: the marker family accepts ANY text between the
+ * keyword and the colon ("Done when ALL of the following are true:") —
+ * the shield's contractItems already drops such introducer lines
+ * (v0.23.4), and goalArgsNeedDrafting recognizes the same phrase, so the
+ * three "done when" parsers can no longer drift apart. Lives in the pure
+ * module so tests exercise THIS function, not a copy (the pre-0.23.7 test
+ * re-implemented it and silently went stale).
+ */
+export function extractVerificationContract(raw: string): { objective: string; verificationContract: string } {
+  // Line-based first: a marker at line start begins the contract block.
+  const lines = raw.split("\n");
+  let mode: "obj" | "verify" = "obj";
+  const objParts: string[] = [];
+  const verifyParts: string[] = [];
+  for (const line of lines) {
+    if (line.match(/^\s*(?:done when|verified when|verify|verification|done)\b[^:]*:/i)) {
+      mode = "verify";
+    }
+    if (mode === "obj") objParts.push(line);
+    else verifyParts.push(line);
+  }
+  let objective = objParts.join("\n").trim();
+  let verificationContract = verifyParts.join("\n").trim();
+
+  // Inline fallback: users write one-liners like
+  //   "Create x.txt. Done when: grep -q ok x.txt"
+  // where the marker is mid-line. Split at the first inline marker.
+  if (!verificationContract) {
+    const m = raw.match(/^(.*?)(?:\.|;)??\s+(?:done when|verified when|verify|verification)\b[^:]*:\s*(.+)$/is);
+    if (m) {
+      objective = (m[1] ?? "").trim().replace(/[.;]\s*$/, "");
+      verificationContract = (m[2] ?? "").trim();
+    }
+  }
+  return { objective, verificationContract };
+}

package/extensions/loops/goal.ts

@@ -55,6 +55,7 @@ import {
   piGlaDir,
   normalizeDraftContract,
   draftContractItemCount,
+  extractVerificationContract,
   readState,
   renderGoalMarkdown,
   shouldAutoResumeOnSessionStart,
@@ -354,36 +355,6 @@ function createGoal(objective: string, ctx: ExtensionContext, policy: "goal" | "
   return goal;
 }
 
-function extractVerificationContract(raw: string): { objective: string; verificationContract: string } {
-  // Line-based first: a marker at line start begins the contract block.
-  const lines = raw.split("\n");
-  let mode: "obj" | "verify" = "obj";
-  const objParts: string[] = [];
-  const verifyParts: string[] = [];
-  for (const line of lines) {
-    const lower = line.toLowerCase();
-    if (lower.match(/^\s*(?:done when|verify|verified when|verification|done):/)) {
-      mode = "verify";
-    }
-    if (mode === "obj") objParts.push(line);
-    else verifyParts.push(line);
-  }
-  let objective = objParts.join("\n").trim();
-  let verificationContract = verifyParts.join("\n").trim();
-
-  // Inline fallback: users write one-liners like
-  //   "Create x.txt. Done when: grep -q ok x.txt"
-  // where the marker is mid-line. Split at the first inline marker.
-  if (!verificationContract) {
-    const m = raw.match(/^(.*?)(?:\.|;)??\s+(done when|verified when|verify|verification)\s*:\s*(.+)$/is);
-    if (m) {
-      objective = (m[1] ?? "").trim().replace(/[.;]\s*$/, "");
-      verificationContract = (m[3] ?? "").trim();
-    }
-  }
-  return { objective, verificationContract };
-}
-
 function persistState(ctx: ExtensionContext): void {
   appendLedger(ctx.cwd, "state", { goal: state.goal, list: state.list ?? [], loop: state.loop ?? null });
   refreshUI(ctx); // every state transition flows through here → the TUI is always current
@@ -1607,13 +1578,15 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
       const liveCtx = (execCtx as ExtensionContext | undefined) ?? ctx;
       // Multi-item list draft: one Confirm for the whole batch.
       if (p.items && p.items.length > 0) {
-        const preview = p.items.slice(0, 6).map((t, i) => `  ${i + 1}. ${t.slice(0, 60)}`).join("\n");
+        // v0.23.7: show ALL items in full — the user approves the whole
+        // batch; hidden items would be approved blind.
+        const preview = p.items.map((t, i) => `  ${i + 1}. ${t}`).join("\n");
         const batchActivates = !state.goal || state.goal.status === "complete" || state.goal.status === "aborted";
         let batchConfirmed = false;
         try {
           batchConfirmed = await liveCtx.ui.confirm(
             "Confirm queue batch",
-            `${p.items.length} items:\n${preview}${p.items.length > 6 ? `\n  … and ${p.items.length - 6} more` : ""}${batchActivates ? "\n\n(List is empty — confirming ACTIVATES item 1 immediately as the active goal.)" : ""}`,
+            `${p.items.length} items:\n${preview}${batchActivates ? "\n\n(List is empty — confirming ACTIVATES item 1 immediately as the active goal.)" : ""}`,
           );
         } catch {
           batchConfirmed = false;
@@ -2181,7 +2154,7 @@ async function openSettingsUI(ctx: ExtensionContext): Promise<void> {
           else ctx.ui.notify(`Not a non-negative integer: ${v}`, "warning");
         }
       } else if (choice.startsWith("Wedge alert")) {
-        const v = await ctx.ui.input("Wedge alert threshold (minutes)", "non-negative integer; 0 = off, empty = default 45");
+        const v = await ctx.ui.input("Wedge alert threshold (minutes)", "non-negative integer; 0 = off, empty = default 30");
         if (v !== undefined) {
           const n = Number.parseInt(v.trim(), 10);
           if (Number.isFinite(n) && n >= 0) saveSettings("global", ctx.cwd, { wedgeAlertMinutes: n });
@@ -2270,7 +2243,7 @@ async function cmdSettings(args: string, ctx: ExtensionContext): Promise<void> {
       } else {
         const n = Number.parseInt(value, 10);
         if (Number.isFinite(n) && n >= 0) {
-          patch.wedgeAlertMinutes = n; // 0 = off; unset = default 45
+          patch.wedgeAlertMinutes = n; // 0 = off; unset = default 30
           changed = true;
         } else {
           ctx.ui.notify(`wedgealert must be a non-negative integer (minutes, 0 = off), got: ${value}`, "warning");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.23.6",
+  "version": "0.23.7",
   "description": "Goal. Loop. Audit. Done. — a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor — only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",

package/prompts/goal-loop-forever-draft.md

@@ -38,10 +38,12 @@ stops it.
 3. Clarify the **direction**: is lower better (min) or higher better (max)?
    (Skip this for a metricless loop — there is no direction without a metric.)
 4. Optional tuning: `window` (plateau stop after N non-improving iterations,
-   default 5 — meaningless for metricless), `max` (iteration cap, default 50;
-   `max=0` = truly unbounded). Suggest smaller values for expensive measures.
-   For metricless loops, ALWAYS discuss bounds — an unbounded metricless loop
-   is a deliberate furnace.
+   default 5 — meaningless for metricless), `max` (iteration cap: default 50
+   for METRIC loops; default UNBOUNDED (`max=0`) for metricless loops,
+   v0.23.6 — a bare infinite loop is the point of the metricless form).
+   Suggest smaller values for expensive measures. For metricless loops,
+   ALWAYS discuss bounds — an unbounded metricless loop is a deliberate
+   furnace.
 5. When concrete, call `propose_loop_draft` with `target`, `measureCmd` (or
    omit/`"none"` for metricless), `direction` (measured only), and optional
    `window`/`max`/`time`/`tokens`.