pi-goal-list-loop-audit 0.23.5 → 0.23.7

package/README.md

@@ -58,10 +58,11 @@ matches `/list show`.
 /list remove <n>                   # drop item n from the queue
 /list clear                        # empty the queue
 /loop                              # draft the loop (agent grills; measure is test-run before you confirm)
+/loop start "keep polishing the UI"                          # infinite metricless loop (v0.23.6): no plateau, no cap — ends at time=/tokens= or /loop stop
 /loop start "reduce TODOs" measure="grep -c TODO src.txt | head -1" direction=min
 /loop start "shrink the bundle" measure="..." direction=min time=4 tokens=500000   # arbitrary bounds
 /loop start "reduce TODOs" measure="..." direction=min branch=1   # scratch-branch mode
-/loop start "keep improving SPEC.md" measure=none max=20   # metricless spec loop (v0.23.0)
+/loop start "keep improving SPEC.md" measure=none max=20   # metricless with an explicit cap (v0.23.0)
 /loop status                       # iteration, best, stall, recent values
 /loop stop                         # halt with summary
 ```

package/extensions/goal-loop-core.ts

@@ -300,7 +300,10 @@ export interface ListItem {
 export function goalArgsNeedDrafting(args: string): boolean {
   const t = args.trim();
   if (!t) return false; // no-args is already the drafting path
-  return !/\bdone\s+when\s*:/i.test(t);
+  // v0.23.7: any "done when" phrase counts — requiring the colon to
+  // immediately follow made "Done when ALL of the following are true:"
+  // route to the interview even though the user wrote a contract.
+  return !/\bdone\s+when\b/i.test(t);
 }
 
 /**
@@ -627,3 +630,43 @@ export function normalizeDraftContract(raw: string): string {
 export function draftContractItemCount(normalized: string): number {
   return normalized.split("\n").filter((l) => /^\d+\.\s/.test(l)).length;
 }
+
+/**
+ * Split raw objective text into { objective, verificationContract } at the
+ * first "Done when…:"-family marker (line-start preferred, inline fallback
+ * for one-liners). v0.23.7: the marker family accepts ANY text between the
+ * keyword and the colon ("Done when ALL of the following are true:") —
+ * the shield's contractItems already drops such introducer lines
+ * (v0.23.4), and goalArgsNeedDrafting recognizes the same phrase, so the
+ * three "done when" parsers can no longer drift apart. Lives in the pure
+ * module so tests exercise THIS function, not a copy (the pre-0.23.7 test
+ * re-implemented it and silently went stale).
+ */
+export function extractVerificationContract(raw: string): { objective: string; verificationContract: string } {
+  // Line-based first: a marker at line start begins the contract block.
+  const lines = raw.split("\n");
+  let mode: "obj" | "verify" = "obj";
+  const objParts: string[] = [];
+  const verifyParts: string[] = [];
+  for (const line of lines) {
+    if (line.match(/^\s*(?:done when|verified when|verify|verification|done)\b[^:]*:/i)) {
+      mode = "verify";
+    }
+    if (mode === "obj") objParts.push(line);
+    else verifyParts.push(line);
+  }
+  let objective = objParts.join("\n").trim();
+  let verificationContract = verifyParts.join("\n").trim();
+
+  // Inline fallback: users write one-liners like
+  //   "Create x.txt. Done when: grep -q ok x.txt"
+  // where the marker is mid-line. Split at the first inline marker.
+  if (!verificationContract) {
+    const m = raw.match(/^(.*?)(?:\.|;)??\s+(?:done when|verified when|verify|verification)\b[^:]*:\s*(.+)$/is);
+    if (m) {
+      objective = (m[1] ?? "").trim().replace(/[.;]\s*$/, "");
+      verificationContract = (m[2] ?? "").trim();
+    }
+  }
+  return { objective, verificationContract };
+}

package/extensions/goal-loop-forever.ts

@@ -237,12 +237,17 @@ export function parseLoopStartArgs(raw: string): {
   const measureRaw = (kv.get("measure") ?? "").trim();
   // v0.23.0: measure=none → metricless "spec loop" (Sisyphus mode). No
   // metric, no direction, no plateau — bounds and /loop stop only.
-  const metricless = measureRaw.toLowerCase() === "none";
-  if (!measureRaw) throw new Error('missing measure="<shell command that prints a number>" (or measure=none for a metricless spec loop — no plateau, ends only at bounds or /loop stop)');
+  // v0.23.6: a bare `/loop start "<target>"` IS the infinite command —
+  // no measure= means metricless too. The Confirm dialog names "NO
+  // plateau · NO iteration cap · /loop stop" before anything runs, so
+  // the choice is never silent (the v0.23.0 rule). Metric loops keep
+  // the 50-iteration default cap; metricless loops default to UNBOUNDED
+  // (max=0) unless max= is given explicitly.
+  const metricless = !measureRaw || measureRaw.toLowerCase() === "none";
   const dirRaw = (kv.get("direction") ?? "").toLowerCase();
-  if (metricless && dirRaw) throw new Error("direction= is meaningless with measure=none — there is no metric to have a direction");
-  if (!metricless && dirRaw !== "min" && dirRaw !== "max") throw new Error("missing direction=min|max");
-  if (!target) throw new Error("missing target (what to improve), e.g. /loop start \"reduce test failures\" measure=\"...\" direction=min");
+  if (metricless && dirRaw) throw new Error("direction= is meaningless without a metric — add measure=\"<cmd>\" or drop direction=");
+  if (!metricless && dirRaw !== "min" && dirRaw !== "max") throw new Error("missing direction=min|max (a metric loop needs to know which way is better; a bare /loop start \"<target>\" with no measure= is the infinite metricless form)");
+  if (!target) throw new Error("missing target (what to improve), e.g. /loop start \"keep polishing the UI\" — bare start is metricless + unbounded; add measure=\"<cmd>\" direction=min|max for a metric loop");
 
   const window = Number.parseInt(kv.get("window") ?? "", 10);
   const max = Number.parseInt(kv.get("max") ?? "", 10);
@@ -263,8 +268,11 @@ export function parseLoopStartArgs(raw: string): {
     measureCmd: metricless ? "" : measureRaw,
     direction: metricless ? undefined : dirRaw as LoopDirection,
     plateauWindow: Number.isFinite(window) && window > 0 ? window : LOOP_DEFAULTS.plateauWindow,
-    // v0.23.0: max=0 = truly unbounded (no iteration cap); absent = 50.
-    maxIterations: kv.has("max") ? (Number.isFinite(max) && max >= 0 ? max : LOOP_DEFAULTS.maxIterations) : LOOP_DEFAULTS.maxIterations,
+    // v0.23.0: max=0 = truly unbounded (no iteration cap).
+    // v0.23.6: metricless with no explicit max= defaults to UNBOUNDED —
+    // an infinite loop is the point of the bare form. Metric loops keep
+    // the 50-cap default.
+    maxIterations: kv.has("max") ? (Number.isFinite(max) && max >= 0 ? max : LOOP_DEFAULTS.maxIterations) : metricless ? 0 : LOOP_DEFAULTS.maxIterations,
     branch: branchRaw === "1" || branchRaw === "true" || branchRaw === "yes",
     force: forceRaw === "1" || forceRaw === "true" || forceRaw === "yes",
     timeLimitHours: Number.isFinite(timeRaw) && timeRaw > 0 ? timeRaw : undefined,

package/extensions/loops/goal.ts

@@ -55,6 +55,7 @@ import {
   piGlaDir,
   normalizeDraftContract,
   draftContractItemCount,
+  extractVerificationContract,
   readState,
   renderGoalMarkdown,
   shouldAutoResumeOnSessionStart,
@@ -354,36 +355,6 @@ function createGoal(objective: string, ctx: ExtensionContext, policy: "goal" | "
   return goal;
 }
 
-function extractVerificationContract(raw: string): { objective: string; verificationContract: string } {
-  // Line-based first: a marker at line start begins the contract block.
-  const lines = raw.split("\n");
-  let mode: "obj" | "verify" = "obj";
-  const objParts: string[] = [];
-  const verifyParts: string[] = [];
-  for (const line of lines) {
-    const lower = line.toLowerCase();
-    if (lower.match(/^\s*(?:done when|verify|verified when|verification|done):/)) {
-      mode = "verify";
-    }
-    if (mode === "obj") objParts.push(line);
-    else verifyParts.push(line);
-  }
-  let objective = objParts.join("\n").trim();
-  let verificationContract = verifyParts.join("\n").trim();
-
-  // Inline fallback: users write one-liners like
-  //   "Create x.txt. Done when: grep -q ok x.txt"
-  // where the marker is mid-line. Split at the first inline marker.
-  if (!verificationContract) {
-    const m = raw.match(/^(.*?)(?:\.|;)??\s+(done when|verified when|verify|verification)\s*:\s*(.+)$/is);
-    if (m) {
-      objective = (m[1] ?? "").trim().replace(/[.;]\s*$/, "");
-      verificationContract = (m[3] ?? "").trim();
-    }
-  }
-  return { objective, verificationContract };
-}
-
 function persistState(ctx: ExtensionContext): void {
   appendLedger(ctx.cwd, "state", { goal: state.goal, list: state.list ?? [], loop: state.loop ?? null });
   refreshUI(ctx); // every state transition flows through here → the TUI is always current
@@ -467,7 +438,7 @@ async function startDrafting(ctx: ExtensionContext, target: "goal" | "list" | "l
     target === "list"
       ? `${label}: the objective has no "Done when:" clause — the agent will grill you about it first (nothing activates until you confirm). Add directly instead: include a "Done when:" clause.`
       : target === "loop"
-        ? `${label}: a loop target needs a metric and a direction — the agent will help you design them first (nothing activates until you confirm). Skip the interview entirely: /loop start "<target>" measure="<cmd>" direction=min|max [window=5] [max=50] [time=h] [tokens=n] [branch=1].`
+        ? `${label}: a loop target needs a metric and a direction — the agent will help you design them first (nothing activates until you confirm). Skip the interview entirely: /loop start "<target>" (bare = infinite metricless) or /loop start "<target>" measure="<cmd>" direction=min|max [window=5] [max=50] [time=h] [tokens=n] [branch=1].`
         : `${label}: the objective has no "Done when:" clause — the agent will grill you about it first (nothing activates until you confirm). Skip the interview entirely: /goal start <objective>.`;
   ctx.ui.notify(
     seed
@@ -1258,7 +1229,7 @@ async function cmdLoop(args: string, ctx: ExtensionContext): Promise<void> {
   if (sub === "status") {
     const loop = state.loop;
     if (!loop) {
-      ctx.ui.notify("No loop. /loop to draft one, or /loop start \"<target>\" measure=\"<cmd>\" direction=min|max [window=5] [max=50] [time=<hours>] [tokens=<budget>]", "info");
+      ctx.ui.notify("No loop. /loop to draft one, /loop start \"<target>\" for an infinite metricless loop, or add measure=\"<cmd>\" direction=min|max for a metric loop [window=5] [max=50] [time=<hours>] [tokens=<budget>]", "info");
       return;
     }
     const lines = [
@@ -1607,13 +1578,15 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
       const liveCtx = (execCtx as ExtensionContext | undefined) ?? ctx;
       // Multi-item list draft: one Confirm for the whole batch.
       if (p.items && p.items.length > 0) {
-        const preview = p.items.slice(0, 6).map((t, i) => `  ${i + 1}. ${t.slice(0, 60)}`).join("\n");
+        // v0.23.7: show ALL items in full — the user approves the whole
+        // batch; hidden items would be approved blind.
+        const preview = p.items.map((t, i) => `  ${i + 1}. ${t}`).join("\n");
         const batchActivates = !state.goal || state.goal.status === "complete" || state.goal.status === "aborted";
         let batchConfirmed = false;
         try {
           batchConfirmed = await liveCtx.ui.confirm(
             "Confirm queue batch",
-            `${p.items.length} items:\n${preview}${p.items.length > 6 ? `\n  … and ${p.items.length - 6} more` : ""}${batchActivates ? "\n\n(List is empty — confirming ACTIVATES item 1 immediately as the active goal.)" : ""}`,
+            `${p.items.length} items:\n${preview}${batchActivates ? "\n\n(List is empty — confirming ACTIVATES item 1 immediately as the active goal.)" : ""}`,
           );
         } catch {
           batchConfirmed = false;
@@ -2181,7 +2154,7 @@ async function openSettingsUI(ctx: ExtensionContext): Promise<void> {
           else ctx.ui.notify(`Not a non-negative integer: ${v}`, "warning");
         }
       } else if (choice.startsWith("Wedge alert")) {
-        const v = await ctx.ui.input("Wedge alert threshold (minutes)", "non-negative integer; 0 = off, empty = default 45");
+        const v = await ctx.ui.input("Wedge alert threshold (minutes)", "non-negative integer; 0 = off, empty = default 30");
         if (v !== undefined) {
           const n = Number.parseInt(v.trim(), 10);
           if (Number.isFinite(n) && n >= 0) saveSettings("global", ctx.cwd, { wedgeAlertMinutes: n });
@@ -2270,7 +2243,7 @@ async function cmdSettings(args: string, ctx: ExtensionContext): Promise<void> {
       } else {
         const n = Number.parseInt(value, 10);
         if (Number.isFinite(n) && n >= 0) {
-          patch.wedgeAlertMinutes = n; // 0 = off; unset = default 45
+          patch.wedgeAlertMinutes = n; // 0 = off; unset = default 30
           changed = true;
         } else {
           ctx.ui.notify(`wedgealert must be a non-negative integer (minutes, 0 = off), got: ${value}`, "warning");
@@ -2433,7 +2406,7 @@ export default function (pi: ExtensionAPI): void {
     handler: (args: string, ctx: ExtensionContext) => { rememberCtx(ctx); return cmdList(args, ctx); },
   });
   pi.registerCommand("loop", {
-    description: "Loop 3: metric-driven process — it never completes. /loop <target> drafts the metric with you · /loop start \"<target>\" measure=\"<cmd>\" direction=min|max [window=5] [max=50] [time=<hours>] [tokens=<budget>] [branch=1] skips drafting · measure=none = metricless spec loop (no plateau; max=0 = unbounded) · /loop status · /loop stop. 'Improve until X' is a /goal, not a loop.",
+    description: "Loop 3: metric-driven process — it never completes. /loop <target> drafts the metric with you · /loop start \"<target>\" = infinite metricless loop (no plateau, no cap; ends at time=/tokens= or /loop stop) · add measure=\"<cmd>\" direction=min|max [window=5] [max=50] [branch=1] for a metric loop · /loop status · /loop stop. 'Improve until X' is a /goal, not a loop.",
     getArgumentCompletions: completions([
       ["start", "skip drafting: /loop start \"<target>\" measure=\"<cmd>\" direction=min|max [window=5] [max=50]"],
       ["status", "show metric, iteration, best/last values, stall count"],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.23.5",
+  "version": "0.23.7",
   "description": "Goal. Loop. Audit. Done. — a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor — only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",

package/prompts/goal-loop-forever-draft.md

@@ -38,10 +38,12 @@ stops it.
 3. Clarify the **direction**: is lower better (min) or higher better (max)?
    (Skip this for a metricless loop — there is no direction without a metric.)
 4. Optional tuning: `window` (plateau stop after N non-improving iterations,
-   default 5 — meaningless for metricless), `max` (iteration cap, default 50;
-   `max=0` = truly unbounded). Suggest smaller values for expensive measures.
-   For metricless loops, ALWAYS discuss bounds — an unbounded metricless loop
-   is a deliberate furnace.
+   default 5 — meaningless for metricless), `max` (iteration cap: default 50
+   for METRIC loops; default UNBOUNDED (`max=0`) for metricless loops,
+   v0.23.6 — a bare infinite loop is the point of the metricless form).
+   Suggest smaller values for expensive measures. For metricless loops,
+   ALWAYS discuss bounds — an unbounded metricless loop is a deliberate
+   furnace.
 5. When concrete, call `propose_loop_draft` with `target`, `measureCmd` (or
    omit/`"none"` for metricless), `direction` (measured only), and optional
    `window`/`max`/`time`/`tokens`.