pi-goal-list-loop-audit 0.18.0 → 0.19.0

package/README.md

@@ -41,11 +41,11 @@ Four top-level commands, that's all:
 /goal tweak "<new objective>"      # edit in place (Confirm dialog)
 /goal archive                      # archived goals, newest first
 /glla                               # open the settings UI (or /glla key=value)
-/list fix the login bug, add dark mode, write docs   # dump it — the agent decomposes into items, one Confirm
-/list add                          # draft a contract (or a whole batch via items[])
-/list add "<objective>"            # queue one directly — no interview (the /goal start of lists)
-/list add plan.md                  # file detected → bulk import, one Confirm
-/list add <paste a checklist>      # multi-line paste → same batch flow
+/list fix the login bug, add dark mode, write docs   # dump it — the agent shapes it into items, one Confirm
+/list plan.md                      # file detected → bulk import, one Confirm (sisyphus/Ralph style)
+/list <paste a checklist>          # multi-line paste → same batch flow
+/list "fix the flaky test. Done when: npm test green"   # explicit contract → queues directly, no interview
+/list                              # show the list (add/import are optional no-op aliases — detection routes everything)
 
 (Or just say it: "queue these 10 things…" — the agent manages the list too.)
 
@@ -82,9 +82,9 @@ ONE confirmed batch, not 50 dialogs.
 Note: every queue item is audited individually, so at hundreds of items the
 audit cost per item is the thing to think about.
 
-**Drafting is the default for long-running things.** `/goal`, `/list add`, and
-`/loop` with no arguments all start a grilling turn that ends in a Confirm
-dialog. For `/loop` specifically, the orchestrator **test-runs the proposed
+**Drafting is the default for long-running things.** `/goal` and
+`/loop` with no arguments — and any vague `/list` dump — all start a
+grilling turn that ends in a Confirm dialog. For `/loop` specifically, the orchestrator **test-runs the proposed
 measure command once** and shows the real number in the dialog — you validate
 the metric before a single iteration burns tokens.
 
@@ -132,8 +132,8 @@ redirect you to `/goal`.
 | Loop | Command | Status |
 |---|---|---|
 | 1. Single ordered goal | `/goal "<objective>"` | **shipped v0.1.0** |
-| 2. Queue of goals | `/list add\|show\|next\|remove\|clear` | **shipped v0.2.0** |
-| 3. Forever-polish loop | `/loop start\|status\|stop` | **shipped v0.3.0** |
+| 2. Queue of goals | `/list [show\|next\|remove\|clear]` | **shipped v0.2.0** |
+| 3. Metric-driven process loop | `/loop start\|status\|stop` | **shipped v0.3.0** |
 
 Each loop is a different policy class on the same status machine.
 

package/extensions/goal-loop-core.ts

@@ -201,6 +201,21 @@ export function parseListImport(content: string): string[] {
   return items;
 }
 
+/**
+ * During a LIST drafting session the agent must not queue items one by one
+ * with list_add/list_activate — that bypasses the user's Confirm gate
+ * (observed in the wild: the agent decomposed a dump and ACTIVATED the first
+ * item with zero confirmation). The batch path is propose_goal_draft's
+ * items[]: one Confirm for the whole list. User commands (/list add) are
+ * unaffected — only the agent tools are gated.
+ */
+export function listMutationBlocked(draftingTarget: string | null): boolean {
+  return draftingTarget === "list";
+}
+
+export const LIST_DRAFTING_BLOCK_MESSAGE =
+  "LIST DRAFTING IN PROGRESS — do not queue items one by one. Decompose the request into an items[] array and call propose_goal_draft ONCE: the user confirms the whole batch in a single dialog. list_add / list_activate work again after the drafting session ends.";
+
 /**
  * Route natural-language text handed to `/list` with no subcommand verb
  * (v0.18.0). The user typed a dump — "fix x, do y, write docs" — not a

package/extensions/loops/goal.ts

@@ -33,9 +33,11 @@ import {
   DEFAULT_TOKEN_LIMIT,
   mergeSettings,
   parseListImport,
-  resolveImportFile,
+
   routeGoalArgs,
   routeListText,
+  listMutationBlocked,
+  LIST_DRAFTING_BLOCK_MESSAGE,
   sumNewAssistantTokens,
   takeAt,
   goalArgsNeedDrafting,
@@ -435,7 +437,7 @@ async function startDrafting(ctx: ExtensionContext, target: "goal" | "list" | "l
   const [file, label, tool] = prompts[target]!;
   ctx.ui.notify(
     seed
-      ? `${label}: the objective has no "Done when:" clause — the agent will grill you about it first (nothing activates until you confirm). Skip the interview entirely: ${target === "list" ? "/list add <objective>" : "/goal start <objective>"}.`
+      ? `${label}: the objective has no "Done when:" clause — the agent will grill you about it first (nothing activates until you confirm). ${target === "list" ? "Add directly instead: include a \"Done when:\" clause." : "Skip the interview entirely: /goal start <objective>."}`
       : `${label} started. The agent will grill until the contract is concrete, then ${tool} opens a Confirm dialog. No work begins before confirmation.`,
     "info",
   );
@@ -725,7 +727,7 @@ async function cmdList(args: string, ctx: ExtensionContext): Promise<void> {
       lines.push("Active: (none)");
     }
     if (queue.length === 0) {
-      lines.push("List: empty. /list <describe your tasks> | /list add <one item, no interview> | /list add <file>");
+      lines.push("List: empty. /list <describe your tasks, or a plan file> — the agent shapes dumps into items, files import directly.");
     } else {
       lines.push(`Queue (${queue.length}):`);
       const PAGE = 15;
@@ -739,43 +741,33 @@ async function cmdList(args: string, ctx: ExtensionContext): Promise<void> {
   }
 
 
-  if (sub === "import") {
-    // Backwards-compat alias (0.8.1 shipped it; 0.8.2 folded it into add).
-    const abs = resolveImportFile(ctx.cwd, rest.replace(/^["']|["']$/g, ""));
-    if (!abs) {
-      ctx.ui.notify("Usage: /list add <path> — file detection is automatic now; 'import' is just an alias", "info");
+  // v0.19.0: `add` and `import` are pure no-op aliases — the verb changes
+  // nothing, detection routes everything. `/list plan.md` and
+  // `/list add plan.md` both import; `/list fix x, do y` and
+  // `/list add fix x, do y` both draft. Rationale: a list item activates
+  // RAW when it reaches the head, so the drafting interview is the only
+  // quality gate an item ever gets — a verb whose only job was skipping
+  // that gate was a leak, not an escape hatch. The direct path is an
+  // explicit "Done when:" clause (user already did the contract work).
+  if (sub === "add" || sub === "import") {
+    if (!rest) {
+      await startDrafting(ctx, "list");
       return;
     }
-    await bulkAddFromFile(ctx, abs);
-    return;
-  }
-
-  if (sub === "add") {
-    let raw = rest;
-    if (raw.length >= 2 && ((raw.startsWith('"') && raw.endsWith('"')) || (raw.startsWith("'") && raw.endsWith("'")))) {
-      raw = raw.slice(1, -1).trim();
-    }
-    if (!raw) {
-      // /list add with no args → draft a confirmed contract INTO THE QUEUE.
-      await startDrafting(ctx, "list");
+    const aliased = routeListText(ctx.cwd, rest.replace(/^["']|["']$/g, ""));
+    if (aliased.kind === "file") {
+      await bulkAddFromFile(ctx, aliased.path);
       return;
     }
-    // Explicit verb = explicit intent (the /goal start of lists): file and
-    // multi-line structure are still honored, but vague text adds AS ONE
-    // ITEM — no interview. The conversational path is bare /list <text>.
-    const importFile = resolveImportFile(ctx.cwd, raw);
-    if (importFile) {
-      await bulkAddFromFile(ctx, importFile);
+    if (aliased.kind === "batch") {
+      await bulkAddItems(ctx, aliased.items, "pasted text");
       return;
     }
-    if (raw.includes("\n")) {
-      const pasted = parseListImport(raw);
-      if (pasted.length > 1) {
-        await bulkAddItems(ctx, pasted, "pasted text");
-        return;
-      }
+    if (aliased.kind === "direct") {
+      addSingleItem(ctx, aliased.text);
+      return;
     }
-    addSingleItem(ctx, raw);
+    await startDrafting(ctx, "list", aliased.seed);
     return;
   }
 
@@ -1715,6 +1707,9 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
     }),
     async execute(_id, params, _signal, _onUpdate, execCtx) {
       const p = params as { items: string[] };
+      if (listMutationBlocked(draftingTarget)) {
+        return { content: [{ type: "text", text: LIST_DRAFTING_BLOCK_MESSAGE }], details: {} };
+      }
       if (!Array.isArray(p.items) || p.items.length === 0) {
         return { content: [{ type: "text", text: "No items given." }], details: {} };
       }
@@ -1746,6 +1741,9 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
     }),
     async execute(_id, params, _signal, _onUpdate, execCtx) {
       const p = params as { n: number };
+      if (listMutationBlocked(draftingTarget)) {
+        return { content: [{ type: "text", text: LIST_DRAFTING_BLOCK_MESSAGE }], details: {} };
+      }
       const n = Math.floor(p.n);
       if (!Number.isInteger(n) || n < 1) {
         return { content: [{ type: "text", text: "n must be a positive integer (1-based position)." }], details: {} };
@@ -2198,7 +2196,7 @@ export default function (pi: ExtensionAPI): void {
     handler: settingsHandler,
   });
   pi.registerCommand("list", {
-    description: "Loop 2: the list of audited goals — order is the default, not the law. /list <describe your tasks> (agent decomposes into items, one Confirm) | /list add <item or file> (direct, no interview) | /list show | /list next [n] | /list remove <n> | /list clear",
+    description: "Loop 2: the list of audited goals — order is the default, not the law. /list <describe tasks or name a plan file> (dumps get shaped into items, files import, 'Done when:' adds directly) | /list show | /list next [n] | /list remove <n> | /list clear",
     handler: (args: string, ctx: ExtensionContext) => { rememberCtx(ctx); return cmdList(args, ctx); },
   });
   pi.registerCommand("loop", {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.18.0",
+  "version": "0.19.0",
   "description": "Goal. Loop. Audit. Done. — a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor — only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",