pi-goal-list-loop-audit 0.17.1 → 0.18.1

package/README.md

@@ -41,8 +41,9 @@ Four top-level commands, that's all:
 /goal tweak "<new objective>"      # edit in place (Confirm dialog)
 /goal archive                      # archived goals, newest first
 /glla                               # open the settings UI (or /glla key=value)
+/list fix the login bug, add dark mode, write docs   # dump it — the agent decomposes into items, one Confirm
 /list add                          # draft a contract (or a whole batch via items[])
-/list add "<objective>"            # queue one directly
+/list add "<objective>"            # queue one directly — no interview (the /goal start of lists)
 /list add plan.md                  # file detected → bulk import, one Confirm
 /list add <paste a checklist>      # multi-line paste → same batch flow
 

package/extensions/goal-loop-core.ts

@@ -201,6 +201,50 @@ export function parseListImport(content: string): string[] {
   return items;
 }
 
+/**
+ * During a LIST drafting session the agent must not queue items one by one
+ * with list_add/list_activate — that bypasses the user's Confirm gate
+ * (observed in the wild: the agent decomposed a dump and ACTIVATED the first
+ * item with zero confirmation). The batch path is propose_goal_draft's
+ * items[]: one Confirm for the whole list. User commands (/list add) are
+ * unaffected — only the agent tools are gated.
+ */
+export function listMutationBlocked(draftingTarget: string | null): boolean {
+  return draftingTarget === "list";
+}
+
+export const LIST_DRAFTING_BLOCK_MESSAGE =
+  "LIST DRAFTING IN PROGRESS — do not queue items one by one. Decompose the request into an items[] array and call propose_goal_draft ONCE: the user confirms the whole batch in a single dialog. list_add / list_activate work again after the drafting session ends.";
+
+/**
+ * Route natural-language text handed to `/list` with no subcommand verb
+ * (v0.18.0). The user typed a dump — "fix x, do y, write docs" — not a
+ * command. Flexible by detection, never a usage error:
+ *   file path        → bulk import (sisyphus/Ralph plan file)
+ *   multi-line paste → batch add (structure is already explicit)
+ *   has "Done when:" → one direct item (explicit contract)
+ *   anything else    → conversational decomposition (drafting session;
+ *                      the agent shapes it into items[], one Confirm)
+ * The explicit verb `/list add` stays the direct escape hatch (symmetric
+ * with `/goal start`): it skips the draft branch.
+ */
+export type ListTextRoute =
+  | { kind: "file"; path: string }
+  | { kind: "batch"; items: string[] }
+  | { kind: "direct"; text: string }
+  | { kind: "draft"; seed: string };
+
+export function routeListText(cwd: string, raw: string): ListTextRoute {
+  const importFile = resolveImportFile(cwd, raw);
+  if (importFile) return { kind: "file", path: importFile };
+  if (raw.includes("\n")) {
+    const pasted = parseListImport(raw);
+    if (pasted.length > 1) return { kind: "batch", items: pasted };
+  }
+  if (!goalArgsNeedDrafting(raw)) return { kind: "direct", text: raw };
+  return { kind: "draft", seed: raw };
+}
+
 /**
  * Detect whether a `/list add` argument is a readable file (v0.8.2). File
  * detection, not a separate verb: `/list add plan.md` bulk-imports when the

package/extensions/loops/goal.ts

@@ -35,6 +35,9 @@ import {
   parseListImport,
   resolveImportFile,
   routeGoalArgs,
+  routeListText,
+  listMutationBlocked,
+  LIST_DRAFTING_BLOCK_MESSAGE,
   sumNewAssistantTokens,
   takeAt,
   goalArgsNeedDrafting,
@@ -434,7 +437,7 @@ async function startDrafting(ctx: ExtensionContext, target: "goal" | "list" | "l
   const [file, label, tool] = prompts[target]!;
   ctx.ui.notify(
     seed
-      ? `${label}: the objective has no "Done when:" clause — the agent will grill you about it first (nothing activates until you confirm). Skip the interview entirely: /goal start <objective>.`
+      ? `${label}: the objective has no "Done when:" clause — the agent will grill you about it first (nothing activates until you confirm). Skip the interview entirely: ${target === "list" ? "/list add <objective>" : "/goal start <objective>"}.`
       : `${label} started. The agent will grill until the contract is concrete, then ${tool} opens a Confirm dialog. No work begins before confirmation.`,
     "info",
   );
@@ -724,7 +727,7 @@ async function cmdList(args: string, ctx: ExtensionContext): Promise<void> {
       lines.push("Active: (none)");
     }
     if (queue.length === 0) {
-      lines.push("List: empty. /list add <objective> | /list add <file>");
+      lines.push("List: empty. /list <describe your tasks> | /list add <one item, no interview> | /list add <file>");
     } else {
       lines.push(`Queue (${queue.length}):`);
       const PAGE = 15;
@@ -759,8 +762,9 @@ async function cmdList(args: string, ctx: ExtensionContext): Promise<void> {
       await startDrafting(ctx, "list");
       return;
     }
-    // Flexible by detection, not by verb: an existing file path bulk-imports,
-    // multi-line pasted text parses as a batch, anything else is one objective.
+    // Explicit verb = explicit intent (the /goal start of lists): file and
+    // multi-line structure are still honored, but vague text adds AS ONE
+    // ITEM — no interview. The conversational path is bare /list <text>.
     const importFile = resolveImportFile(ctx.cwd, raw);
     if (importFile) {
       await bulkAddFromFile(ctx, importFile);
@@ -773,17 +777,7 @@ async function cmdList(args: string, ctx: ExtensionContext): Promise<void> {
         return;
       }
     }
-    const { objective, verificationContract } = extractVerificationContract(raw);
-    const item = { id: newGoalId(), objective, verificationContract: verificationContract || undefined, addedAt: nowIso() };
-    state = { ...state, list: [...listQueue(), item] };
-    persistState(ctx);
-    appendLedger(ctx.cwd, "list_added", { id: item.id, objective: item.objective });
-    // Nothing active → activate immediately.
-    if (!state.goal || state.goal.status === "complete" || state.goal.status === "aborted") {
-      activateNextListItem(ctx);
-    } else {
-      ctx.ui.notify(`Queued (${listQueue().length} waiting): ${objective.slice(0, 80)}`, "info");
-    }
+    addSingleItem(ctx, raw);
     return;
   }
 
@@ -828,7 +822,44 @@ async function cmdList(args: string, ctx: ExtensionContext): Promise<void> {
     return;
   }
 
-  ctx.ui.notify("Usage: /list [show] | /list add <objective or file> | /list next | /list remove <n> | /list clear", "info");
+  // v0.18.0: an unknown first word isn't an error — it's a natural-language
+  // dump. "/list fix the login bug, add dark mode, write docs" should MAKE
+  // a list, not print usage. Detection chain: file → batch → contract →
+  // conversational decomposition (drafting). The explicit verb for adding
+  // one item verbatim is /list add.
+  let raw = args.trim();
+  if (raw.length >= 2 && ((raw.startsWith('"') && raw.endsWith('"')) || (raw.startsWith("'") && raw.endsWith("'")))) {
+    raw = raw.slice(1, -1).trim();
+  }
+  const route = routeListText(ctx.cwd, raw);
+  if (route.kind === "file") {
+    await bulkAddFromFile(ctx, route.path);
+    return;
+  }
+  if (route.kind === "batch") {
+    await bulkAddItems(ctx, route.items, "pasted text");
+    return;
+  }
+  if (route.kind === "direct") {
+    addSingleItem(ctx, route.text);
+    return;
+  }
+  await startDrafting(ctx, "list", route.seed);
+}
+
+/** Append one objective to the list; activate immediately when idle. */
+function addSingleItem(ctx: ExtensionContext, raw: string): void {
+  const { objective, verificationContract } = extractVerificationContract(raw);
+  const item = { id: newGoalId(), objective, verificationContract: verificationContract || undefined, addedAt: nowIso() };
+  state = { ...state, list: [...listQueue(), item] };
+  persistState(ctx);
+  appendLedger(ctx.cwd, "list_added", { id: item.id, objective: item.objective });
+  // Nothing active → activate immediately.
+  if (!state.goal || state.goal.status === "complete" || state.goal.status === "aborted") {
+    activateNextListItem(ctx);
+  } else {
+    ctx.ui.notify(`Queued (${listQueue().length} waiting): ${objective.slice(0, 80)}`, "info");
+  }
 }
 
 /**
@@ -1686,6 +1717,9 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
     }),
     async execute(_id, params, _signal, _onUpdate, execCtx) {
       const p = params as { items: string[] };
+      if (listMutationBlocked(draftingTarget)) {
+        return { content: [{ type: "text", text: LIST_DRAFTING_BLOCK_MESSAGE }], details: {} };
+      }
       if (!Array.isArray(p.items) || p.items.length === 0) {
         return { content: [{ type: "text", text: "No items given." }], details: {} };
       }
@@ -1717,6 +1751,9 @@ function registerAgentTools(pi: any, ctx: ExtensionContext): void {
     }),
     async execute(_id, params, _signal, _onUpdate, execCtx) {
       const p = params as { n: number };
+      if (listMutationBlocked(draftingTarget)) {
+        return { content: [{ type: "text", text: LIST_DRAFTING_BLOCK_MESSAGE }], details: {} };
+      }
       const n = Math.floor(p.n);
       if (!Number.isInteger(n) || n < 1) {
         return { content: [{ type: "text", text: "n must be a positive integer (1-based position)." }], details: {} };
@@ -1823,7 +1860,7 @@ interface Settings {
 const DEFAULT_SETTINGS: Settings = {
   // Unset = follow the pi session thinking level (user selects thinking in
   // pi, auditor follows), floor "high" — the auditor is the verification
-  // gate, depth is worth more there than speed. /gla thinking= overrides.
+  // gate, depth is worth more there than speed. /glla thinking= overrides.
   auditorThinkingLevel: undefined,
 };
 
@@ -1856,7 +1893,7 @@ function loadSettings(cwd: string): Settings {
   ) as unknown as Settings;
 }
 
-/** Where each effective setting comes from (for the /gla display). */
+/** Where each effective setting comes from (for the /glla display). */
 function settingsProvenance(cwd: string): Record<keyof Settings, { value: unknown; source: "project" | "global" | "default" }> {
   const proj = readSettingsFile(projectSettingsPath(cwd));
   const glob = readSettingsFile(globalSettingsPath());
@@ -1905,7 +1942,7 @@ function getSessionThinkingLevel(): "off" | "minimal" | "low" | "medium" | "high
  * model in pi; the auditor uses it.** The plugin never picks a model itself.
  *
  * Chain:
- *   1. Explicit `/gla model=provider/id` override (rare).
+ *   1. Explicit `/glla model=provider/id` override (rare).
  *   2. The pi session model (ctx.model) — whatever the user selected.
  *
  * If the session model's provider is extension-registered, the auditor's
@@ -2169,7 +2206,7 @@ export default function (pi: ExtensionAPI): void {
     handler: settingsHandler,
   });
   pi.registerCommand("list", {
-    description: "Loop 2: the list of audited goals — order is the default, not the law. /list add <obj or file or paste> | /list show | /list next [n] | /list remove <n> | /list clear",
+    description: "Loop 2: the list of audited goals — order is the default, not the law. /list <describe your tasks> (agent decomposes into items, one Confirm) | /list add <item or file> (direct, no interview) | /list show | /list next [n] | /list remove <n> | /list clear",
     handler: (args: string, ctx: ExtensionContext) => { rememberCtx(ctx); return cmdList(args, ctx); },
   });
   pi.registerCommand("loop", {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-goal-list-loop-audit",
-  "version": "0.17.1",
+  "version": "0.18.1",
   "description": "Goal. Loop. Audit. Done. — a pi-coding-agent extension that supervises long-running work, with isolated auditor on each completion. Beat bamboozling by design: the auditor runs in a fresh session with no extensions, no skills, no editor — only the read tools needed to verify your goal.",
   "license": "MIT",
   "author": "dracon",