pi-formatter 1.1.0 → 1.1.2

package/README.md

@@ -20,6 +20,9 @@ pi install npm:pi-formatter
 `pi-formatter` detects file types and runs the appropriate formatter as
 best-effort post-processing. Formatter failures never block tool results.
 
+Formatting is limited to files inside the current working directory. Paths
+outside the current directory and paths that traverse symlinks are ignored.
+
 Formatting modes:
 
 - `tool`: format immediately after each successful `write` or `edit` tool call.

package/extensions/formatter/dispatch.ts

@@ -203,6 +203,15 @@ function isTreefmtUnmatchedPathFailure(result: ExecResult): boolean {
   return /\bno formatter for path:/i.test(`${result.stderr}\n${result.stdout}`);
 }
 
+function isTreefmtNixUnmatchedPathSuccess(result: ExecResult): boolean {
+  // Some treefmt-nix formatter wrappers exit successfully even when the target
+  // path does not match any formatter, but they still report that zero files
+  // were emitted for processing.
+  return /\bemitted\s+0\s+files?\s+for processing\b/i.test(
+    `${result.stderr}\n${result.stdout}`,
+  );
+}
+
 function shouldFallbackFromTreefmtNixFailure(result: ExecResult): boolean {
   const output = `${result.stderr}\n${result.stdout}`;
   return (
@@ -306,7 +315,8 @@ async function resolveProjectFormatterCandidates(
     await resolveTreefmtCandidate(filePath, cwd),
     await resolveTreefmtNixCandidate(filePath, cwd),
   ].filter(
-    (candidate): candidate is ProjectFormatterCandidate => candidate !== undefined,
+    (candidate): candidate is ProjectFormatterCandidate =>
+      candidate !== undefined,
   );
 
   return candidates.sort(compareProjectFormatterCandidates);
@@ -442,6 +452,10 @@ async function executeTreefmtNixCandidate(
   );
 
   if (result.code === 0) {
+    if (isTreefmtNixUnmatchedPathSuccess(result)) {
+      return "skipped";
+    }
+
     summaryReporter?.({
       runnerId: candidate.runnerId,
       status: "succeeded",

package/extensions/formatter/path.ts

@@ -1,6 +1,6 @@
-import { access } from "node:fs/promises";
+import { access, lstat } from "node:fs/promises";
 import { homedir } from "node:os";
-import { basename, isAbsolute, join, relative, resolve } from "node:path";
+import { basename, isAbsolute, join, relative, resolve, sep } from "node:path";
 import type { FileKind } from "./types.js";
 
 const UNICODE_SPACES = /[\u00A0\u2000-\u200A\u202F\u205F\u3000]/g;
@@ -71,6 +71,43 @@ export function getRelativePathOrAbsolute(
   return relPath;
 }
 
+export async function isPathInFormattingScope(
+  filePath: string,
+  cwd: string,
+): Promise<boolean> {
+  const rootPath = resolve(cwd);
+  const candidatePath = resolve(filePath);
+
+  if (!isWithinDirectory(candidatePath, rootPath)) {
+    return false;
+  }
+
+  const relPath = relative(rootPath, candidatePath);
+  if (!relPath || relPath === ".") {
+    return false;
+  }
+
+  let currentPath = rootPath;
+
+  for (const segment of relPath.split(sep)) {
+    if (segment.length === 0 || segment === ".") {
+      continue;
+    }
+
+    currentPath = join(currentPath, segment);
+
+    try {
+      if ((await lstat(currentPath)).isSymbolicLink()) {
+        return false;
+      }
+    } catch {
+      return false;
+    }
+  }
+
+  return true;
+}
+
 export function detectFileKind(filePath: string): FileKind | undefined {
   if (
     /(\.(c|h|cc|hh|cpp|hpp|cxx|hxx|ixx|ipp|inl|tpp)|\.(c|h|cc|hh|cpp|hpp|cxx|hxx)\.in)$/i.test(

package/extensions/index.ts

@@ -20,7 +20,7 @@ import {
 import { type FormatCallSummary, formatFile } from "./formatter/dispatch.js";
 import {
   getRelativePathOrAbsolute,
-  pathExists,
+  isPathInFormattingScope,
   resolveToolPath,
 } from "./formatter/path.js";
 
@@ -154,7 +154,7 @@ export default function (pi: ExtensionAPI) {
     filePath: string,
     ctx: FormatterContext,
   ): Promise<string[]> => {
-    if (!(await pathExists(filePath))) {
+    if (!(await isPathInFormattingScope(filePath, ctx.cwd))) {
       return [];
     }
 
@@ -252,7 +252,7 @@ export default function (pi: ExtensionAPI) {
     }
 
     const filePath = resolveEventPath(event.input.path, ctx.cwd);
-    if (!filePath) {
+    if (!filePath || !(await isPathInFormattingScope(filePath, ctx.cwd))) {
       return;
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-formatter",
-  "version": "1.1.0",
+  "version": "1.1.2",
   "description": "Pi extension that auto-formats files.",
   "type": "module",
   "files": [