pi-forge 0.0.0 → 1.1.4

package/dist/server/routes/exec.js

@@ -0,0 +1,217 @@
+import { spawn } from "node:child_process";
+import { errorSchema } from "./_schemas.js";
+import { getSession } from "../session-registry.js";
+import { scrubbedEnv } from "../pty-manager.js";
+/**
+ * One-shot user bash execution — the chat input's `!` / `!!` prefix.
+ *
+ * Mirrors pi-tui's UserBashEvent semantics:
+ *  - `!cmd`  → output appended to the session's message history as a
+ *             BashExecutionMessage; the next agent turn sees it in
+ *             LLM context.
+ *  - `!!cmd` → same render, `excludeFromContext: true` keeps it out
+ *             of the next turn's prompt. Local convenience only.
+ *
+ * Implementation uses the SDK's `AgentSession.executeBash()` directly.
+ * That call:
+ *   1. Spawns the command via the BashOperations we hand it
+ *   2. Pushes a BashExecutionMessage into `agent.state.messages` so
+ *      the next prompt's context window includes it (or skips it
+ *      when excludeFromContext is true)
+ *   3. Persists the message via `sessionManager.appendMessage` so the
+ *      session JSONL captures it on agent_end (pi defers session
+ *      writes until at least one assistant message has landed —
+ *      our message is held in the in-memory list until then)
+ *
+ * Hand-rolling the spawn would let us emit ANSI-stripped output and
+ * apply our own timeout, but it would NOT update agent.state.messages
+ * (that's a private field). The SDK's path is the supported way to
+ * inject context.
+ *
+ * Security posture: BashOperations is overridden to inject our
+ * `scrubbedEnv()` — an allowlist-based filter that only passes
+ * known-harmless system vars (PATH, HOME, TERM, locales, …). pi-forge
+ * secrets, provider keys, cloud credentials, and any other host-env
+ * vars are dropped unless the operator opts them back in via
+ * `TERMINAL_PASSTHROUGH_ENV`. Matches the integrated terminal's
+ * posture. The agent's own bash TOOL may still have an env-exposure
+ * surface — that's a separate fix for a separate code path.
+ */
+const DEFAULT_TIMEOUT_MS = 30_000;
+/**
+ * Build a BashOperations that delegates to local spawn, but with our
+ * scrubbed env. createLocalBashOperations from the SDK would inherit
+ * `process.env` verbatim, leaking secrets the pi-forge process
+ * carries (JWT_SECRET, API_KEY, etc.) — see
+ * pty-manager.TERMINAL_ENV_ALLOWLIST for the full set of allowed
+ * passthrough vars and rationale.
+ */
+function forgeBashOperations() {
+    return {
+        exec: (command, cwd, options) => {
+            return new Promise((resolve, reject) => {
+                const proc = spawn("/bin/sh", ["-c", command], {
+                    cwd,
+                    env: scrubbedEnv(),
+                    stdio: ["ignore", "pipe", "pipe"],
+                });
+                // Honor an external AbortSignal (the SDK ties this to its own
+                // _bashAbortController so abortBash() propagates).
+                const onAbort = () => {
+                    try {
+                        proc.kill("SIGTERM");
+                    }
+                    catch {
+                        // best-effort
+                    }
+                    // SIGKILL after grace if SIGTERM is ignored.
+                    setTimeout(() => {
+                        try {
+                            proc.kill("SIGKILL");
+                        }
+                        catch {
+                            // best-effort
+                        }
+                    }, 2000);
+                };
+                if (options.signal !== undefined) {
+                    if (options.signal.aborted)
+                        onAbort();
+                    else
+                        options.signal.addEventListener("abort", onAbort, { once: true });
+                }
+                // Stream chunks back so the SDK's truncation-and-buffering
+                // logic gets to apply (executor caps total output, writes
+                // overflow to a temp file, etc.).
+                proc.stdout?.on("data", (data) => options.onData(data));
+                proc.stderr?.on("data", (data) => options.onData(data));
+                proc.on("error", (err) => reject(err));
+                proc.on("close", (code) => resolve({ exitCode: code }));
+            });
+        },
+    };
+}
+/**
+ * Wrap a BashOperations so that `options.signal` is the union of the
+ * caller's signal and our own timeout signal. The SDK's executeBash
+ * passes its abort controller as `options.signal`; we still need our
+ * 30s wall-clock cap, so this union forwards an abort from EITHER
+ * source to the inner exec.
+ */
+function timeoutOperations(inner, timeoutSignal) {
+    return {
+        exec: (command, cwd, options) => {
+            const merged = options.signal !== undefined ? mergeSignals(options.signal, timeoutSignal) : timeoutSignal;
+            return inner.exec(command, cwd, { ...options, signal: merged });
+        },
+    };
+}
+function mergeSignals(a, b) {
+    const controller = new AbortController();
+    const onAbort = () => controller.abort();
+    if (a.aborted || b.aborted) {
+        controller.abort();
+    }
+    else {
+        a.addEventListener("abort", onAbort, { once: true });
+        b.addEventListener("abort", onAbort, { once: true });
+    }
+    return controller.signal;
+}
+export const execRoutes = async (fastify) => {
+    fastify.post("/sessions/:id/exec", {
+        schema: {
+            description: "Run a one-shot bash command in the session's project cwd " +
+                "(the chat input's `!` / `!!` prefix dispatches here). The " +
+                "result is added to the session's in-memory context AND " +
+                "persisted to the session JSONL (deferred until the next " +
+                "agent turn finalizes — pi's session-write is gated on " +
+                "having at least one assistant message). With " +
+                "`excludeFromContext: true` (the `!!` prefix) the result " +
+                "is recorded but kept out of the next turn's LLM input. " +
+                "Output is captured whole — no streaming for v1. The " +
+                "spawned shell inherits a scrubbed env (no pi-forge / " +
+                "provider secrets), same posture as the integrated " +
+                "terminal.",
+            tags: ["sessions"],
+            params: {
+                type: "object",
+                required: ["id"],
+                properties: { id: { type: "string" } },
+            },
+            body: {
+                type: "object",
+                required: ["command"],
+                additionalProperties: false,
+                properties: {
+                    command: { type: "string", minLength: 1, maxLength: 4096 },
+                    excludeFromContext: { type: "boolean" },
+                },
+            },
+            response: {
+                200: {
+                    type: "object",
+                    required: ["exitCode", "output", "durationMs", "truncated", "cancelled"],
+                    properties: {
+                        exitCode: { type: ["integer", "null"] },
+                        output: { type: "string" },
+                        durationMs: { type: "integer" },
+                        truncated: { type: "boolean" },
+                        cancelled: { type: "boolean" },
+                    },
+                },
+                404: errorSchema,
+                500: errorSchema,
+            },
+        },
+    }, async (req, reply) => {
+        const live = getSession(req.params.id);
+        if (live === undefined) {
+            return reply.code(404).send({ error: "session_not_found" });
+        }
+        const { command, excludeFromContext = false } = req.body;
+        const started = Date.now();
+        // Defense-in-depth timeout — the SDK's bash executor has its
+        // own truncation behavior but no time cap. We pre-bake an abort
+        // signal that fires after DEFAULT_TIMEOUT_MS so a runaway loop
+        // can't tie up the request handler indefinitely.
+        const timeoutController = new AbortController();
+        const timer = setTimeout(() => timeoutController.abort(), DEFAULT_TIMEOUT_MS);
+        try {
+            const result = await live.session.executeBash(command, undefined, {
+                excludeFromContext,
+                operations: timeoutOperations(forgeBashOperations(), timeoutController.signal),
+            });
+            const durationMs = Date.now() - started;
+            live.lastActivityAt = new Date();
+            // Cross-tab refetch trigger — every other browser viewing this
+            // session schedules a getMessages refetch on `user_bash_result`.
+            // The acting tab refetches off the HTTP response directly.
+            for (const c of live.clients) {
+                try {
+                    c.send({ type: "user_bash_result" });
+                }
+                catch {
+                    // best-effort fan-out; sse-bridge handles client drop on its own
+                }
+            }
+            return {
+                exitCode: result.exitCode === undefined ? null : result.exitCode,
+                output: result.output,
+                durationMs,
+                truncated: result.truncated,
+                cancelled: result.cancelled,
+            };
+        }
+        catch (err) {
+            return reply.code(500).send({
+                error: "exec_failed",
+                message: err instanceof Error ? err.message : String(err),
+            });
+        }
+        finally {
+            clearTimeout(timer);
+        }
+    });
+};
+//# sourceMappingURL=exec.js.map

package/dist/server/routes/exec.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"exec.js","sourceRoot":"","sources":["../../src/routes/exec.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,oBAAoB,CAAC;AAG3C,OAAO,EAAE,WAAW,EAAE,MAAM,eAAe,CAAC;AAC5C,OAAO,EAAE,UAAU,EAAE,MAAM,wBAAwB,CAAC;AACpD,OAAO,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAEhD;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAkCG;AAEH,MAAM,kBAAkB,GAAG,MAAM,CAAC;AAOlC;;;;;;;GAOG;AACH,SAAS,mBAAmB;IAC1B,OAAO;QACL,IAAI,EAAE,CAAC,OAAO,EAAE,GAAG,EAAE,OAAO,EAAE,EAAE;YAC9B,OAAO,IAAI,OAAO,CAA8B,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE;gBAClE,MAAM,IAAI,GAAG,KAAK,CAAC,SAAS,EAAE,CAAC,IAAI,EAAE,OAAO,CAAC,EAAE;oBAC7C,GAAG;oBACH,GAAG,EAAE,WAAW,EAAE;oBAClB,KAAK,EAAE,CAAC,QAAQ,EAAE,MAAM,EAAE,MAAM,CAAC;iBAClC,CAAC,CAAC;gBACH,8DAA8D;gBAC9D,mDAAmD;gBACnD,MAAM,OAAO,GAAG,GAAS,EAAE;oBACzB,IAAI,CAAC;wBACH,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;oBACvB,CAAC;oBAAC,MAAM,CAAC;wBACP,cAAc;oBAChB,CAAC;oBACD,6CAA6C;oBAC7C,UAAU,CAAC,GAAG,EAAE;wBACd,IAAI,CAAC;4BACH,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;wBACvB,CAAC;wBAAC,MAAM,CAAC;4BACP,cAAc;wBAChB,CAAC;oBACH,CAAC,EAAE,IAAI,CAAC,CAAC;gBACX,CAAC,CAAC;gBACF,IAAI,OAAO,CAAC,MAAM,KAAK,SAAS,EAAE,CAAC;oBACjC,IAAI,OAAO,CAAC,MAAM,CAAC,OAAO;wBAAE,OAAO,EAAE,CAAC;;wBACjC,OAAO,CAAC,MAAM,CAAC,gBAAgB,CAAC,OAAO,EAAE,OAAO,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;gBACzE,CAAC;gBACD,2DAA2D;gBAC3D,0DAA0D;gBAC1D,kCAAkC;gBAClC,IAAI,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,EAAE,CAAC,IAAY,EAAE,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC;gBAChE,IAAI,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,EAAE,CAAC,IAAY,EAAE,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC;gBAChE,IAAI,CAAC,EAAE,CAAC,OAAO,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC;gBACvC,IAAI,CAAC,EAAE,CAAC,OAAO,EAAE,CAAC,IAAI,EAAE,EAAE,CAAC,OAAO,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC;YAC1D,CAAC,CAAC,CAAC;QACL,CAAC;KACF,CAAC;AACJ,CAAC;AAED;;;;;;GAMG;AACH,SAAS,iBAAiB,CAAC,KAAqB,EAAE,aAA0B;IAC1E,OAAO;QACL,IAAI,EAAE,CAAC,OAAO,EAAE,GAAG,EAAE,OAAO,EAAE,EAAE;YAC9B,MAAM,MAAM,GACV,OAAO,CAAC,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,YAAY,CAAC,OAAO,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC;YAC7F,OAAO,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,GAAG,EAAE,EAAE,GAAG,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,CAAC,CAAC;QAClE,CAAC;KACF,CAAC;AACJ,CAAC;AAED,SAAS,YAAY,CAAC,CAAc,EAAE,CAAc;IAClD,MAAM,UAAU,GAAG,IAAI,eAAe,EAAE,CAAC;IACzC,MAAM,OAAO,GAAG,GAAS,EAAE,CAAC,UAAU,CAAC,KAAK,EAAE,CAAC;IAC/C,IAAI,CAAC,CAAC,OAAO,IAAI,CAAC,CAAC,OAAO,EAAE,CAAC;QAC3B,UAAU,CAAC,KAAK,EAAE,CAAC;IACrB,CAAC;SAAM,CAAC;QACN,CAAC,CAAC,gBAAgB,CAAC,OAAO,EAAE,OAAO,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;QACrD,CAAC,CAAC,gBAAgB,CAAC,OAAO,EAAE,OAAO,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;IACvD,CAAC;IACD,OAAO,UAAU,CAAC,MAAM,CAAC;AAC3B,CAAC;AAED,MAAM,CAAC,MAAM,UAAU,GAAuB,KAAK,EAAE,OAAO,EAAE,EAAE;IAC9D,OAAO,CAAC,IAAI,CACV,oBAAoB,EACpB;QACE,MAAM,EAAE;YACN,WAAW,EACT,2DAA2D;gBAC3D,4DAA4D;gBAC5D,yDAAyD;gBACzD,0DAA0D;gBAC1D,wDAAwD;gBACxD,+CAA+C;gBAC/C,0DAA0D;gBAC1D,yDAAyD;gBACzD,sDAAsD;gBACtD,uDAAuD;gBACvD,oDAAoD;gBACpD,WAAW;YACb,IAAI,EAAE,CAAC,UAAU,CAAC;YAClB,MAAM,EAAE;gBACN,IAAI,EAAE,QAAQ;gBACd,QAAQ,EAAE,CAAC,IAAI,CAAC;gBAChB,UAAU,EAAE,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE;aACvC;YACD,IAAI,EAAE;gBACJ,IAAI,EAAE,QAAQ;gBACd,QAAQ,EAAE,CAAC,SAAS,CAAC;gBACrB,oBAAoB,EAAE,KAAK;gBAC3B,UAAU,EAAE;oBACV,OAAO,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,SAAS,EAAE,CAAC,EAAE,SAAS,EAAE,IAAI,EAAE;oBAC1D,kBAAkB,EAAE,EAAE,IAAI,EAAE,SAAS,EAAE;iBACxC;aACF;YACD,QAAQ,EAAE;gBACR,GAAG,EAAE;oBACH,IAAI,EAAE,QAAQ;oBACd,QAAQ,EAAE,CAAC,UAAU,EAAE,QAAQ,EAAE,YAAY,EAAE,WAAW,EAAE,WAAW,CAAC;oBACxE,UAAU,EAAE;wBACV,QAAQ,EAAE,EAAE,IAAI,EAAE,CAAC,SAAS,EAAE,MAAM,CAAC,EAAE;wBACvC,MAAM,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBAC1B,UAAU,EAAE,EAAE,IAAI,EAAE,SAAS,EAAE;wBAC/B,SAAS,EAAE,EAAE,IAAI,EAAE,SAAS,EAAE;wBAC9B,SAAS,EAAE,EAAE,IAAI,EAAE,SAAS,EAAE;qBAC/B;iBACF;gBACD,GAAG,EAAE,WAAW;gBAChB,GAAG,EAAE,WAAW;aACjB;SACF;KACF,EACD,KAAK,EAAE,GAAG,EAAE,KAAK,EAAE,EAAE;QACnB,MAAM,IAAI,GAAG,UAAU,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QACvC,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;YACvB,OAAO,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,EAAE,KAAK,EAAE,mBAAmB,EAAE,CAAC,CAAC;QAC9D,CAAC;QACD,MAAM,EAAE,OAAO,EAAE,kBAAkB,GAAG,KAAK,EAAE,GAAG,GAAG,CAAC,IAAI,CAAC;QACzD,MAAM,OAAO,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;QAC3B,6DAA6D;QAC7D,gEAAgE;QAChE,+DAA+D;QAC/D,iDAAiD;QACjD,MAAM,iBAAiB,GAAG,IAAI,eAAe,EAAE,CAAC;QAChD,MAAM,KAAK,GAAG,UAAU,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,KAAK,EAAE,EAAE,kBAAkB,CAAC,CAAC;QAC9E,IAAI,CAAC;YACH,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,OAAO,CAAC,WAAW,CAAC,OAAO,EAAE,SAAS,EAAE;gBAChE,kBAAkB;gBAClB,UAAU,EAAE,iBAAiB,CAAC,mBAAmB,EAAE,EAAE,iBAAiB,CAAC,MAAM,CAAC;aAC/E,CAAC,CAAC;YACH,MAAM,UAAU,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,OAAO,CAAC;YACxC,IAAI,CAAC,cAAc,GAAG,IAAI,IAAI,EAAE,CAAC;YAEjC,+DAA+D;YAC/D,iEAAiE;YACjE,2DAA2D;YAC3D,KAAK,MAAM,CAAC,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC;gBAC7B,IAAI,CAAC;oBACH,CAAC,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,CAAC;gBACvC,CAAC;gBAAC,MAAM,CAAC;oBACP,iEAAiE;gBACnE,CAAC;YACH,CAAC;YAED,OAAO;gBACL,QAAQ,EAAE,MAAM,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC,QAAQ;gBAChE,MAAM,EAAE,MAAM,CAAC,MAAM;gBACrB,UAAU;gBACV,SAAS,EAAE,MAAM,CAAC,SAAS;gBAC3B,SAAS,EAAE,MAAM,CAAC,SAAS;aAC5B,CAAC;QACJ,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACb,OAAO,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC;gBAC1B,KAAK,EAAE,aAAa;gBACpB,OAAO,EAAE,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC;aAC1D,CAAC,CAAC;QACL,CAAC;gBAAS,CAAC;YACT,YAAY,CAAC,KAAK,CAAC,CAAC;QACtB,CAAC;IACH,CAAC,CACF,CAAC;AACJ,CAAC,CAAC"}