pi-firecode 0.8.1 → 1.0.1

package/review/advisor.ts

@@ -1,112 +0,0 @@
-/** 顾问仲裁：连续 N 轮失败后经独立进程内会话返回三选一裁决。 */
-import type { Language } from "../config.js";
-import type { PromptLayers } from "./prompt.js";
-import type { AdvisorResult, AdvisorVerdict } from "./state.js";
-import type { ReviewSessionRunner } from "./session.js";
-import type { ReviewModelConfig } from "./reviewer.js";
-
-export interface RunAdvisorOptions {
-	config: ReviewModelConfig;
-	prompt: PromptLayers;
-	cwd: string;
-	language: Language;
-	signal?: AbortSignal;
-	runSession: ReviewSessionRunner;
-	onEvent?: (event: Record<string, unknown>) => void;
-}
-
-export async function runAdvisor(options: RunAdvisorOptions): Promise<AdvisorResult> {
-	const result = await options.runSession({
-		role: "advisor",
-		model: options.config.model,
-		thinking: options.config.thinking,
-		tools: options.config.tools,
-		prompt: options.prompt,
-		cwd: options.cwd,
-		timeoutMs: options.config.timeoutMs,
-		signal: options.signal,
-		onEvent: options.onEvent,
-	});
-	if (result.kind !== "output") throw new Error(advisorProcessError(result, options.language));
-	return parseAdvisorOutput(result.text, options.language);
-}
-
-const VERDICTS = new Set<AdvisorVerdict>(["continue", "stop", "narrow"]);
-
-function advisorProcessError(
-	result: Exclude<Awaited<ReturnType<ReviewSessionRunner>>, { kind: "output" }>,
-	language: Language,
-): string {
-	const prefix = language === "en" ? "advisor session unavailable" : "顾问会话不可用";
-	if (result.kind === "aborted") return `${prefix}: aborted`;
-	if (result.kind === "timeout") return `${prefix}: timeout`;
-	if (result.kind === "empty") return `${prefix}: empty output`;
-	return `${prefix}: ${result.message}`;
-}
-
-/** 首行应为裸裁决词；容忍模型前言，在前几个非空行内识别裁决行，
- * 其余行（含前言）并入 advice；完全识别不出才回落 continue。 */
-const VERDICT_SCAN_LINES = 8;
-
-export function parseAdvisorOutput(
-	text: string,
-	language: Language,
-): AdvisorResult {
-	const lines = unwrapCodeFence(text.trim().split(/\r?\n/));
-	const firstLine = lines.find((line) => line.trim()) ?? "";
-	let verdict: AdvisorVerdict | undefined;
-	let verdictIndex = -1;
-	let scanned = 0;
-	for (let index = 0; index < lines.length && scanned < VERDICT_SCAN_LINES; index += 1) {
-		if (!lines[index].trim()) continue;
-		scanned += 1;
-		const parsed = normalizeVerdict(lines[index]);
-		if (parsed) {
-			verdict = parsed;
-			verdictIndex = index;
-			break;
-		}
-	}
-	const advice = lines
-		.filter((_, index) => index !== verdictIndex)
-		.join("\n")
-		.trim();
-	if (!verdict) {
-		// 把首行原文带回去：顾问会话跑完即释放、原始输出不落盘，这是事后诊断解析失败的唯一线索。
-		const sample = firstLine.slice(0, 80);
-		return {
-			verdict: "continue",
-			advice:
-				language === "en"
-					? `Advisor output was not parseable (first line: ${sample}); continuing with the current findings.`
-					: `顾问输出无法解析（首行：${sample}），按继续处理当前发现。`,
-		};
-	}
-	return {
-		verdict,
-		advice: advice || (language === "en" ? "(no advice)" : "（无建议）"),
-	};
-}
-
-function unwrapCodeFence(lines: string[]) {
-	const fenced =
-		lines.length >= 2 &&
-		/^```\w*\s*$/u.test(lines[0].trim()) &&
-		/^```\s*$/u.test(lines.at(-1)?.trim() ?? "");
-	return fenced ? lines.slice(1, -1) : lines;
-}
-
-function normalizeVerdict(line: string): AdvisorVerdict | undefined {
-	const normalized = line
-		.trim()
-		.replace(/^\*{1,2}(.+?)\*{1,2}$/u, "$1")
-		.replace(/^#{1,6}\s*/u, "")
-		.replace(/^(?:(?:verdict|裁决|结论)\s*[:：]\s*)/iu, "")
-		// 提示词里裁决词本身带反引号展示，模型照抄 `continue` 很常见，剔掉包裹的反引号。
-		.replace(/^`+(.+?)`+$/u, "$1")
-		.trim()
-		.toLowerCase();
-	return VERDICTS.has(normalized as AdvisorVerdict)
-		? (normalized as AdvisorVerdict)
-		: undefined;
-}

package/review/card.ts

@@ -1,385 +0,0 @@
-/**
- * 结果卡：渲染器 + payload 校验 + 各状态卡构建。
- *
- * 渲染器在 registerReview 顶层无条件注册（不懒加载、不挂 session_start），
- * 因此 live 与 reload 走同一个纯渲染路径，外观只有一种。渲染器永不抛异常：
- * details 校验不过就降级渲染 content 纯文本（pi 对抛异常的渲染器会静默回落默认框，
- * 与未注册表现相同，必须从源头避免）。
- *
- * payload 校验零外部依赖：纯函数一次性整体校验，不做字段级兼容。
- */
-import { getMarkdownTheme, type ExtensionAPI, type Theme } from "@earendil-works/pi-coding-agent";
-import { Box, type Component, Markdown, Spacer, Text } from "@earendil-works/pi-tui";
-import type { Language } from "../config.js";
-import { formatDuration } from "../format.js";
-import type { CardData, StopReason } from "./state.js";
-
-export const CARD_TYPE = "firecode-review-card";
-const VERSION = 1;
-
-const CARD_KINDS = new Set([
-	"queued",
-	"start",
-	"pass",
-	"fail",
-	"stop",
-	"cancel",
-	"timeout",
-	"error",
-	"advisor",
-]);
-const CARD_TONES = new Set(["success", "warning", "error", "neutral", "accent"]);
-
-export type CardDetails = {
-	version: typeof VERSION;
-	kind: CardData["kind"];
-	title: string;
-	lines: string[];
-	tone: "success" | "warning" | "error" | "neutral" | "accent";
-	icon: string;
-};
-
-/** 一次性整体校验结果卡 payload；结构不符返回 false（渲染器降级 content 纯文本）。 */
-export function isValidCardDetails(value: unknown): value is CardDetails {
-	if (typeof value !== "object" || value === null || Array.isArray(value)) return false;
-	const record = value as Record<string, unknown>;
-	if (Object.keys(record).length !== 6) return false;
-	if (record.version !== VERSION) return false;
-	if (typeof record.kind !== "string" || !CARD_KINDS.has(record.kind)) return false;
-	if (typeof record.title !== "string") return false;
-	if (!Array.isArray(record.lines) || !record.lines.every((line) => typeof line === "string"))
-		return false;
-	if (typeof record.tone !== "string" || !CARD_TONES.has(record.tone)) return false;
-	return typeof record.icon === "string";
-}
-
-export interface BuiltCard {
-	content: string;
-	details: CardDetails;
-}
-
-export function registerCardRenderer(pi: ExtensionAPI): void {
-	pi.registerMessageRenderer<CardDetails>(
-		CARD_TYPE,
-		(message, _options, theme) => new ReviewCard(message.details, message.content, theme),
-	);
-}
-
-class ReviewCard implements Component {
-	private readonly card: Component | undefined;
-	private readonly fallback: Component;
-
-	constructor(details: CardDetails | undefined, content: string | (string | unknown)[], theme: Theme) {
-		this.fallback = new Text(plainContent(content), 0, 0);
-		let card: Component | undefined;
-		try {
-			card = isValidCardDetails(details) ? nativeCard(details, theme) : undefined;
-		} catch {
-			card = undefined;
-		}
-		this.card = card;
-	}
-
-	render(width: number): string[] {
-		try {
-			return (this.card ?? this.fallback).render(Math.max(1, width));
-		} catch {
-			try {
-				return this.fallback.render(Math.max(1, width));
-			} catch {
-				return [];
-			}
-		}
-	}
-
-	invalidate(): void {
-		this.card?.invalidate?.();
-		this.fallback.invalidate?.();
-	}
-}
-
-function nativeCard(details: CardDetails, theme: Theme): Component {
-	// 全家卡统一：无垂直内边距；消息间距由宿主 CustomMessageComponent 提供，不再叠加。
-	const box = new Box(1, 0, (text) => theme.bg(backgroundFor(details.tone), text));
-	box.addChild(new Text(`${details.icon} ${details.title}`, 0, 0));
-	box.addChild(new Spacer(1));
-	box.addChild(new Markdown(details.lines.join("\n"), 0, 0, getMarkdownTheme()));
-	return box;
-}
-
-function backgroundFor(tone: CardDetails["tone"]) {
-	if (tone === "success") return "toolSuccessBg" as const;
-	if (tone === "warning" || tone === "error") return "toolErrorBg" as const;
-	return "customMessageBg" as const;
-}
-
-function plainContent(content: string | (string | unknown)[]): string {
-	if (typeof content === "string") return content;
-	if (!Array.isArray(content)) return "";
-	return content.map(plainPart).filter(Boolean).join("\n");
-}
-
-function plainPart(part: unknown): string {
-	return typeof part === "object" && part !== null && "text" in part
-		? String((part as { text: unknown }).text)
-		: "";
-}
-
-// ---- 卡构建：content 给 LLM（纯文本事实），details 给渲染（本地化成品行）----
-
-export function buildCard(card: CardData, language: Language): BuiltCard {
-	switch (card.kind) {
-		case "start":
-			return started(card, language);
-		case "pass":
-			return passed(card, language);
-		case "fail":
-			return failed(card, language);
-		case "stop":
-			return stopped(card, language);
-		case "cancel":
-			return cancelled(card, language);
-		case "timeout":
-			return timedOut(card, language);
-		case "error":
-			return errored(card, language);
-		case "advisor":
-			return advisorCard(card, language);
-	}
-}
-
-// "queued" 仍留在 CARD_KINDS：旧会话的排队卡 reload 时要能继续按卡渲染，只是不再新发。
-
-function started(card: Extract<CardData, { kind: "start" }>, language: Language): BuiltCard {
-	const title = language === "en" ? "Review started" : "审查开始";
-	const lines = [
-		language === "en"
-			? `Models: ${card.models.map(shortModel).join(", ")}`
-			: `模型：${card.models.map(shortModel).join("、")}`,
-	];
-	return spec(language, "start", title, lines, "neutral", "🔥");
-}
-
-function shortModel(model: string) {
-	return model.split("/").at(-1) || model;
-}
-
-function passed(card: Extract<CardData, { kind: "pass" }>, language: Language): BuiltCard {
-	const title = qualityTitle(card.round, language === "en" ? "Review passed" : "审查通过", language);
-	const lines = withFooter(formatReviewResultLines(card.summary), [
-		elapsedLine(card.elapsedMs, card.totalElapsedMs, card.round > 1, language),
-	]);
-	return spec(language, "pass", title, lines, "success", "✅");
-}
-
-function failed(card: Extract<CardData, { kind: "fail" }>, language: Language): BuiltCard {
-	const title = qualityTitle(card.round, language === "en" ? "Review failed" : "审查未通过", language);
-	const footer = [
-		...(card.advisor?.advice
-			? [language === "en" ? "Advisor note" : "顾问建议", ...adviceLines(card.advisor.advice)]
-			: []),
-		...(card.elapsedMs === undefined
-			? []
-			: [elapsedLine(card.elapsedMs, card.totalElapsedMs, false, language)]),
-	];
-	return spec(
-		language,
-		"fail",
-		title,
-		withFooter(formatReviewResultLines(card.details), footer),
-		"warning",
-		"❌",
-	);
-}
-
-function stopped(card: Extract<CardData, { kind: "stop" }>, language: Language): BuiltCard {
-	const footer = card.elapsedMs === undefined
-		? []
-		: [elapsedLine(card.elapsedMs, card.totalElapsedMs, false, language)];
-	if (card.reason === "advisor") {
-		const title = qualityTitle(
-			card.round,
-			language === "en" ? "Review stopped by advisor" : "审查已由顾问终止",
-			language,
-		);
-		const body = [advisorModelLine(card.advisorModel, language), "", ...adviceLines(card.advisor.advice)];
-		return spec(language, "stop", title, withFooter(body, footer), "warning", "❌");
-	}
-	const title = qualityTitle(card.round, language === "en" ? "Review failed" : "审查未通过", language);
-	const body = formatReviewResultLines(card.details || stopReason(card.reason, language));
-	return spec(language, "stop", title, withFooter(body, footer), "warning", "❌");
-}
-
-function cancelled(card: Extract<CardData, { kind: "cancel" }>, language: Language): BuiltCard {
-	const title = language === "en" ? "Review cancelled" : "审查已取消";
-	return spec(language, "cancel", title, [reasonText(card.reason, language)], "neutral", "⏸");
-}
-
-function timedOut(_card: Extract<CardData, { kind: "timeout" }>, language: Language): BuiltCard {
-	const title = language === "en" ? "Review incomplete" : "审查未完成";
-	const lines = [
-		language === "en" ? "Blocker: review timed out" : "卡点：审查超时",
-		language === "en" ? "Reason: overall time limit exceeded" : "原因：超过总体时限",
-	];
-	return spec(language, "timeout", title, lines, "warning", "🛑");
-}
-
-/** 终止原因的展示文案（reducer 只出枚举，这里本地化）。 */
-function reasonText(reason: StopReason, language: Language) {
-	if (reason === "user")
-		return language === "en" ? "Stopped by user" : "已按你的操作停止";
-	if (reason === "shutdown")
-		return language === "en" ? "Stopped when the session closed" : "会话关闭时停止";
-	return language === "en" ? "Stopped" : "已停止";
-}
-
-function stopReason(reason: StopReason, language: Language) {
-	if (reason === "advisor")
-		return language === "en" ? "Advisor recommends stopping" : "顾问建议停止";
-	if (reason === "max_rounds")
-		return language === "en" ? "Maximum review rounds reached" : "已达到最大审查轮数";
-	return reasonText(reason, language);
-}
-
-function errored(card: Extract<CardData, { kind: "error" }>, language: Language): BuiltCard {
-	const title = language === "en" ? "Review incomplete" : "审查未完成";
-	const lines = [
-		language === "en" ? "Blocker: review did not complete" : "卡点：审查未完成",
-		language === "en" ? `Reason: ${card.message}` : `原因：${card.message}`,
-		...(card.elapsedMs === undefined
-			? []
-			: ["", elapsedLine(card.elapsedMs, card.totalElapsedMs, false, language)]),
-	];
-	return spec(language, "error", title, lines, "warning", "🛑");
-}
-
-/** 顾问卡与审查结果卡同构：裁决进标题，正文用粗体模型分节行开头。 */
-function advisorCard(card: Extract<CardData, { kind: "advisor" }>, language: Language): BuiltCard {
-	const decision = decisionText(card.advisor.verdict, language);
-	const title = language === "en" ? `Advisor guidance · ${decision}` : `顾问指引 · ${decision}`;
-	const body = [advisorModelLine(card.advisorModel, language), "", ...adviceLines(card.advisor.advice)];
-	const footer = card.elapsedMs === undefined ? [] : [elapsedLine(card.elapsedMs, undefined, false, language)];
-	return spec(language, "advisor", title, withFooter(body, footer), "neutral", "🧭");
-}
-
-/** 裁决词→人话文案的唯一映射：卡标题与活动条摘要共用，防两处文案漂移。 */
-export function decisionText(verdict: "continue" | "narrow" | "stop", language: Language) {
-	return language === "en"
-		? { continue: "Continue fixing", narrow: "Narrow scope", stop: "Stop fixing" }[verdict]
-		: { continue: "继续修复", narrow: "收窄范围", stop: "停止修复" }[verdict];
-}
-
-/** 与审查结果卡的「**模型 N · xxx**」分节行同款式。 */
-function advisorModelLine(model: string, language: Language) {
-	return `**${language === "en" ? "Model" : "模型"} · ${shortModel(model)}**`;
-}
-
-/** 顾问建议排版：粗体段标题前补空行——Markdown 把单换行折进同段，不补行三段会糊成一块。 */
-function adviceLines(advice: string) {
-	const output: string[] = [];
-	for (const line of advice.split(/\r?\n/u)) {
-		if (/^\*\*[^*]+\*\*\s*[:：]/u.test(line.trim()) && output.length > 0 && output.at(-1) !== "")
-			output.push("");
-		output.push(line);
-	}
-	return output;
-}
-
-function qualityTitle(round: number, title: string, language: Language) {
-	if (round <= 1) return title;
-	return language === "en" ? `Round ${round} ${title}` : `第 ${round} 轮${title}`;
-}
-
-function withFooter(lines: string[], footer: string[]) {
-	if (footer.length === 0) return lines;
-	return [...lines, ...(lines.length > 0 ? ["", "---", ""] : []), ...footer];
-}
-
-function elapsedLine(
-	ms: number,
-	totalMs: number | undefined,
-	showTotal: boolean,
-	language: Language,
-) {
-	const elapsed = showTotal && totalMs !== undefined
-		? `${formatDuration(ms)} / ${language === "en" ? "total" : "总"} ${formatDuration(totalMs)}`
-		: formatDuration(ms);
-	return language === "en" ? `⏱ Elapsed: ${elapsed}` : `⏱ 用时：${elapsed}`;
-}
-
-function formatReviewResultLines(review: string) {
-	const lines = review.split(/\r?\n/u);
-	const sections: { title: string; body: string[] }[] = [];
-	const preface: string[] = [];
-	let current: { title: string; body: string[] } | undefined;
-	for (const line of lines) {
-		if (/^(?:模型|Model)\s+\d+\s+·\s+/iu.test(line.trim())) {
-			if (current) sections.push(current);
-			current = { title: line.trim(), body: [] };
-		} else if (current) current.body.push(line);
-		else preface.push(line);
-	}
-	if (current) sections.push(current);
-	if (sections.length === 0) return normalizedReviewLines(review);
-	return [
-		...normalizedReviewLines(preface.join("\n")),
-		...(preface.join("").trim() ? [""] : []),
-		...sections.flatMap((section, index) => [
-			...(index > 0 ? ["", "---", ""] : []),
-			`**${section.title}**`,
-			"",
-			...normalizedReviewLines(section.body.join("\n")),
-		]),
-	];
-}
-
-function normalizedReviewLines(review: string) {
-	const lines = review
-		.split(/\r?\n/u)
-		.map((line) => line.trimEnd())
-		.filter((line) => !REDUNDANT_REVIEW_LINES.has(line.trim()));
-	const output: string[] = [];
-	for (const line of lines) {
-		if (line.trim() === "" && (output.length === 0 || output.at(-1) === "")) continue;
-		// 证据/验证命令是取证区：与上面的结论区空一行分隔，密集长行不再糊成一片。
-		if (
-			/^[-*+]?\s*(?:\*\*)?(?:证据|Evidence)(?:\*\*)?\s*[:：]/u.test(line.trim()) &&
-			output.length > 0 &&
-			output.at(-1) !== ""
-		) output.push("");
-		output.push(line.trim() === "" ? "" : line);
-	}
-	while (output.at(-1) === "") output.pop();
-	return output;
-}
-
-const REDUNDANT_REVIEW_LINES = new Set([
-	"PASS",
-	"FAIL",
-	"通过",
-	"未通过",
-	"审查通过",
-	"审查未通过",
-	"Review passed",
-	"Review failed",
-]);
-
-function spec(
-	language: Language,
-	kind: CardDetails["kind"],
-	title: string,
-	lines: string[],
-	tone: CardDetails["tone"],
-	icon: string,
-): BuiltCard {
-	const localized = localize(lines, language);
-	return {
-		content: `${title}\n${lines.join("\n")}`,
-		details: { version: VERSION, kind, title, lines: localized, tone, icon },
-	};
-}
-
-/** details 行已本地化成品；content 里除标题外都是事实，不做二次翻译。 */
-function localize(lines: string[], language: Language) {
-	return lines;
-}