pi-file-change-reminder 1.0.0 → 2.0.0

package/README.md

@@ -45,20 +45,38 @@ You can also include a specific change request:
 
 ## Rules file resolution
 
-Default rules path is `.pi/reminders.json` resolved from the **nearest ancestor directory** containing either:
+Preferred configuration uses Pi settings via the package-scoped `pi-file-change-reminder` block.
 
-- `.git`, or
-- `.pi`
+Global `~/.pi/agent/settings.json`:
 
-If no ancestor contains either marker, resolution falls back to Pi's current working directory.
+```json
+{
+  "pi-file-change-reminder": {
+    "rulesFile": ".pi/reminders.json"
+  }
+}
+```
 
-You can override with `PI_REMINDERS_FILE`:
+Project `<cwd>/.pi/settings.json`:
 
-```bash
-export PI_REMINDERS_FILE=/absolute/path/to/reminders.json
+```json
+{
+  "pi-file-change-reminder": {
+    "rulesFile": "config/reminders.json"
+  }
+}
 ```
 
-If `PI_REMINDERS_FILE` is relative, it is resolved from the detected project directory (same logic as above).
+The extension reads both scopes through Pi's `SettingsManager`, with project settings overriding global settings.
+
+If no setting is configured, the default rules path is `.pi/reminders.json` resolved from the **nearest ancestor directory** containing either:
+
+- `.git`, or
+- `.pi`
+
+If no ancestor contains either marker, resolution falls back to Pi's current working directory.
+
+Relative `rulesFile` values are resolved from that detected project directory. Absolute `rulesFile` values are used as-is.
 
 ## Glob behavior
 
@@ -73,8 +91,16 @@ If `PI_REMINDERS_FILE` is relative, it is resolved from the detected project dir
 
 ## Development
 
+This package uses npm.
+
 ```bash
 npm install
+npm run check
+```
+
+Or run the individual checks:
+
+```bash
 npm run typecheck
 npm run verify:pi-load
 ```

package/fileChangeReminderExtension.ts

@@ -1,7 +1,7 @@
 import { readFile, stat } from "node:fs/promises";
 import path from "node:path";
 import picomatch from "picomatch";
-import type { ExtensionAPI, ExtensionContext } from "@mariozechner/pi-coding-agent";
+import { SettingsManager, type ExtensionAPI, type ExtensionContext } from "@mariozechner/pi-coding-agent";
 
 interface IReminderRule {
 	glob: string;
@@ -13,6 +13,7 @@ interface IToolInputWithPath {
 }
 
 const EXTENSION_ID = "file-change-reminder";
+const SETTINGS_NAMESPACE = "pi-file-change-reminder";
 const DEFAULT_RULES_FILE = ".pi/reminders.json";
 const COMMAND_NAME = "pi-file-change-reminder";
 const INJECTED_ENTRY_TYPE = `${EXTENSION_ID}.injected`;
@@ -22,6 +23,7 @@ export default function fileChangeReminderExtension(pi: ExtensionAPI): void {
 	let rulesMtimeMs = -1;
 	let hasLoadedRules = false;
 	let lastLoadError = "";
+	let lastSettingsError = "";
 	let injectedReminderKeys = new Set<string>();
 	const globMatcherCache = new Map<string, (candidatePath: string) => boolean>();
 	const projectDirectoryCache = new Map<string, string>();
@@ -71,9 +73,41 @@ export default function fileChangeReminderExtension(pi: ExtensionAPI): void {
 		}
 	};
 
-	const resolveRulesFilePathFromProjectDirectory = (projectDirectory: string): string => {
-		const envValue = process.env.PI_REMINDERS_FILE;
-		const configuredPath = readNonEmptyString(envValue) ?? DEFAULT_RULES_FILE;
+	const reportSettingsErrors = (ctx: ExtensionContext, settingsManager: SettingsManager): void => {
+		const settingsErrors = settingsManager.drainErrors();
+		if (settingsErrors.length === 0) {
+			lastSettingsError = "";
+			return;
+		}
+
+		const settingsErrorMessage = settingsErrors
+			.map(({ scope, error }) => `${scope}: ${getErrorMessage(error)}`)
+			.join("; ");
+		if (settingsErrorMessage !== lastSettingsError && ctx.hasUI) {
+			ctx.ui.notify(`Failed to load reminder settings: ${settingsErrorMessage}`, "warning");
+		}
+
+		lastSettingsError = settingsErrorMessage;
+	};
+
+	const getConfiguredRulesFilePath = (ctx: ExtensionContext): string | null => {
+		const settingsManager = SettingsManager.create(ctx.cwd);
+		reportSettingsErrors(ctx, settingsManager);
+
+		const projectConfiguredPath = readRulesFilePathFromSettings(settingsManager.getProjectSettings());
+		if (projectConfiguredPath !== null) {
+			return projectConfiguredPath;
+		}
+
+		const globalConfiguredPath = readRulesFilePathFromSettings(settingsManager.getGlobalSettings());
+		if (globalConfiguredPath !== null) {
+			return globalConfiguredPath;
+		}
+
+		return null;
+	};
+
+	const resolveRulesFilePathFromProjectDirectory = (projectDirectory: string, configuredPath: string): string => {
 		if (path.isAbsolute(configuredPath)) {
 			return configuredPath;
 		}
@@ -81,13 +115,14 @@ export default function fileChangeReminderExtension(pi: ExtensionAPI): void {
 		return path.resolve(projectDirectory, configuredPath);
 	};
 
-	const resolveRulesFilePath = async (cwd: string): Promise<string> => {
-		const projectDirectory = await resolveProjectDirectory(cwd);
-		return resolveRulesFilePathFromProjectDirectory(projectDirectory);
+	const resolveRulesFilePath = async (ctx: ExtensionContext): Promise<string> => {
+		const projectDirectory = await resolveProjectDirectory(ctx.cwd);
+		const configuredPath = getConfiguredRulesFilePath(ctx) ?? DEFAULT_RULES_FILE;
+		return resolveRulesFilePathFromProjectDirectory(projectDirectory, configuredPath);
 	};
 
 	const loadRules = async (ctx: ExtensionContext, force: boolean): Promise<IReminderRule[]> => {
-		const rulesFilePath = await resolveRulesFilePath(ctx.cwd);
+		const rulesFilePath = await resolveRulesFilePath(ctx);
 
 		let mtimeMs = -1;
 		try {
@@ -181,7 +216,7 @@ export default function fileChangeReminderExtension(pi: ExtensionAPI): void {
 		description: "Inject a prompt that explains how to update reminder rules",
 		handler: async (args, ctx) => {
 			const projectDirectory = await resolveProjectDirectory(ctx.cwd);
-			const rulesFilePath = resolveRulesFilePathFromProjectDirectory(projectDirectory);
+			const rulesFilePath = await resolveRulesFilePath(ctx);
 			const normalizedRulesFilePath = normalizePath(rulesFilePath);
 			const normalizedProjectDirectory = normalizePath(projectDirectory);
 			const prompt = buildReminderEditPrompt(normalizedRulesFilePath, normalizedProjectDirectory, args);
@@ -366,6 +401,19 @@ function buildReminderEditPrompt(rulesFilePath: string, projectDirectory: string
 	].join("\n");
 }
 
+function readRulesFilePathFromSettings(settings: unknown): string | null {
+	if (!isRecord(settings)) {
+		return null;
+	}
+
+	const extensionSettings = settings[SETTINGS_NAMESPACE];
+	if (!isRecord(extensionSettings)) {
+		return null;
+	}
+
+	return readNonEmptyString(extensionSettings.rulesFile);
+}
+
 async function pathExists(filePath: string): Promise<boolean> {
 	try {
 		await stat(filePath);

package/package.json

@@ -1,9 +1,13 @@
 {
   "name": "pi-file-change-reminder",
-  "version": "1.0.0",
+  "version": "2.0.0",
   "description": "Pi extension that injects reminder messages when specific files are modified.",
   "type": "module",
   "license": "MIT",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/alexgorbatchev/pi-file-change-reminder.git"
+  },
   "keywords": [
     "pi-package",
     "pi-extension",
@@ -30,6 +34,7 @@
     "typescript": "^5.9.3"
   },
   "scripts": {
+    "check": "npm run typecheck && npm run verify:pi-load",
     "typecheck": "tsc --noEmit -p tsconfig.json",
     "verify:pi-load": "PI_OFFLINE=1 pi --no-extensions -e ./fileChangeReminderExtension.ts --list-models > /dev/null"
   }