pi-extmgr 0.1.27 → 0.1.28

package/src/ui/unified.ts

@@ -2,19 +2,23 @@
  * Unified extension manager UI
  * Displays local extensions and installed packages in one view
  */
-import type { ExtensionAPI, ExtensionCommandContext } from "@mariozechner/pi-coding-agent";
-import type { Theme } from "@mariozechner/pi-coding-agent";
-import { getSettingsListTheme, DynamicBorder } from "@mariozechner/pi-coding-agent";
+import {
+  DynamicBorder,
+  type ExtensionAPI,
+  type ExtensionCommandContext,
+  getSettingsListTheme,
+  type Theme,
+} from "@mariozechner/pi-coding-agent";
 import {
   Container,
+  Key,
+  matchesKey,
+  type SettingItem,
   SettingsList,
-  Text,
   Spacer,
-  type SettingItem,
-  matchesKey,
-  Key,
+  Text,
 } from "@mariozechner/pi-tui";
-import type { UnifiedItem, State, UnifiedAction, InstalledPackage } from "../types/index.js";
+import { UI } from "../constants.js";
 import {
   discoverExtensions,
   removeLocalExtension,
@@ -22,34 +26,40 @@ import {
 } from "../extensions/discovery.js";
 import { getInstalledPackages } from "../packages/discovery.js";
 import {
-  updatePackageWithOutcome,
   removePackageWithOutcome,
-  updatePackagesWithOutcome,
   showInstalledPackagesList,
+  updatePackagesWithOutcome,
+  updatePackageWithOutcome,
 } from "../packages/management.js";
-import { showRemote } from "./remote.js";
-import { showHelp } from "./help.js";
-import { runTaskWithLoader } from "./async-task.js";
-import { formatEntry as formatExtEntry, dynamicTruncate, formatBytes } from "../utils/format.js";
 import {
-  getStatusIcon,
-  getPackageIcon,
-  getScopeIcon,
-  getChangeMarker,
-  formatSize,
-} from "./theme.js";
-import { buildFooterState, buildFooterShortcuts, getPendingToggleChangeCount } from "./footer.js";
-import { logExtensionDelete, logExtensionToggle } from "../utils/history.js";
+  type InstalledPackage,
+  type LocalUnifiedItem,
+  type State,
+  type UnifiedAction,
+  type UnifiedItem,
+} from "../types/index.js";
 import { getKnownUpdates, promptAutoUpdateWizard } from "../utils/auto-update.js";
-import { updateExtmgrStatus } from "../utils/status.js";
 import { parseChoiceByLabel } from "../utils/command.js";
+import { dynamicTruncate, formatBytes, formatEntry as formatExtEntry } from "../utils/format.js";
+import { logExtensionDelete, logExtensionToggle } from "../utils/history.js";
+import { hasCustomUI, runCustomUI } from "../utils/mode.js";
 import { notify } from "../utils/notify.js";
-import { confirmReload } from "../utils/ui-helpers.js";
 import { getPackageSourceKind, normalizePackageIdentity } from "../utils/package-source.js";
-import { hasCustomUI, runCustomUI } from "../utils/mode.js";
 import { getSettingsListSelectedIndex } from "../utils/settings-list.js";
-import { UI } from "../constants.js";
+import { updateExtmgrStatus } from "../utils/status.js";
+import { confirmReload } from "../utils/ui-helpers.js";
+import { runTaskWithLoader } from "./async-task.js";
+import { buildFooterShortcuts, buildFooterState, getPendingToggleChangeCount } from "./footer.js";
+import { showHelp } from "./help.js";
 import { configurePackageExtensions } from "./package-config.js";
+import { showRemote } from "./remote.js";
+import {
+  formatSize,
+  getChangeMarker,
+  getPackageIcon,
+  getScopeIcon,
+  getStatusIcon,
+} from "./theme.js";
 
 async function showInteractiveFallback(
   ctx: ExtensionCommandContext,
@@ -190,8 +200,8 @@ async function showInteractiveOnce(
             if (!item) continue;
 
             if (item.type === "local") {
-              const currentState = staged.get(item.id) ?? item.state!;
-              const changed = staged.has(item.id) && currentState !== item.originalState;
+              const currentState = staged.get(item.id) ?? item.state;
+              const changed = currentState !== item.originalState;
               settingsItem.label = formatUnifiedItemLabel(item, currentState, theme, changed);
             } else {
               settingsItem.label = formatUnifiedItemLabel(item, "enabled", theme, false);
@@ -209,7 +219,11 @@ async function showInteractiveOnce(
             if (!item || item.type !== "local") return;
 
             const state = newValue as State;
-            staged.set(id, state);
+            if (state === item.originalState) {
+              staged.delete(id);
+            } else {
+              staged.set(id, state);
+            }
 
             const settingsItem = settingsItems.find((x) => x.id === id);
             if (settingsItem) {
@@ -380,16 +394,7 @@ export function buildUnifiedItems(
         isDuplicate = true;
         break;
       }
-      if (
-        pkgResolvedNormalized &&
-        (localPath.startsWith(`${pkgResolvedNormalized}/`) ||
-          pkgResolvedNormalized.startsWith(localPath))
-      ) {
-        isDuplicate = true;
-        break;
-      }
-      const localDir = localPath.split("/").slice(0, -1).join("/");
-      if (pkgResolvedNormalized && pkgResolvedNormalized === localDir) {
+      if (pkgResolvedNormalized && localPath.startsWith(`${pkgResolvedNormalized}/`)) {
         isDuplicate = true;
         break;
       }
@@ -400,7 +405,6 @@ export function buildUnifiedItems(
       type: "package",
       id: `pkg:${pkg.source}`,
       displayName: pkg.name,
-      summary: pkg.description || `${pkg.source} (${pkg.scope})`,
       scope: pkg.scope,
       source: pkg.source,
       version: pkg.version,
@@ -432,8 +436,8 @@ function buildSettingsItems(
 ): SettingItem[] {
   return items.map((item) => {
     if (item.type === "local") {
-      const currentState = staged.get(item.id) ?? item.state!;
-      const changed = staged.has(item.id) && staged.get(item.id) !== item.originalState;
+      const currentState = staged.get(item.id) ?? item.state;
+      const changed = currentState !== item.originalState;
       return {
         id: item.id,
         label: formatUnifiedItemLabel(item, currentState, theme, changed),
@@ -458,7 +462,7 @@ function formatUnifiedItemLabel(
   changed = false
 ): string {
   if (item.type === "local") {
-    const statusIcon = getStatusIcon(theme, state === "enabled" ? "enabled" : "disabled");
+    const statusIcon = getStatusIcon(theme, state);
     const scopeIcon = getScopeIcon(theme, item.scope);
     const changeMarker = getChangeMarker(theme, changed);
     const name = theme.bold(item.displayName);
@@ -466,7 +470,7 @@ function formatUnifiedItemLabel(
     return `${statusIcon} [${scopeIcon}] ${name} - ${summary}${changeMarker}`;
   }
 
-  const sourceKind = getPackageSourceKind(item.source ?? "");
+  const sourceKind = getPackageSourceKind(item.source);
   const pkgIcon = getPackageIcon(
     theme,
     sourceKind === "npm" || sourceKind === "git" || sourceKind === "local" ? sourceKind : "local"
@@ -500,8 +504,8 @@ function formatUnifiedItemLabel(
   return `${pkgIcon} [${scopeIcon}] ${name}${version}${updateBadge} - ${summary}`;
 }
 
-function getToggleItemsForApply(items: UnifiedItem[]): UnifiedItem[] {
-  return items.filter((item) => item.type === "local");
+function getToggleItemsForApply(items: UnifiedItem[]): LocalUnifiedItem[] {
+  return items.filter((item): item is LocalUnifiedItem => item.type === "local");
 }
 
 async function applyToggleChangesFromManager(
@@ -510,7 +514,7 @@ async function applyToggleChangesFromManager(
   ctx: ExtensionCommandContext,
   pi: ExtensionAPI,
   options?: { promptReload?: boolean }
-): Promise<{ changed: number; reloaded: boolean }> {
+): Promise<{ changed: number; reloaded: boolean; hasErrors: boolean }> {
   const toggleItems = getToggleItemsForApply(items);
   const apply = await applyStagedChanges(toggleItems, staged, pi);
 
@@ -529,24 +533,14 @@ async function applyToggleChangesFromManager(
     const shouldPromptReload = options?.promptReload ?? true;
 
     if (shouldPromptReload) {
-      const shouldReload = await ctx.ui.confirm(
-        "Reload Required",
-        "Local extensions changed. Reload pi now?"
-      );
-
-      if (shouldReload) {
-        await ctx.reload();
-        return { changed: apply.changed, reloaded: true };
-      }
-    } else {
-      ctx.ui.notify(
-        "Changes saved. Reload pi later to fully apply extension state updates.",
-        "info"
-      );
+      const reloaded = await confirmReload(ctx, "Local extensions changed.");
+      return { changed: apply.changed, reloaded, hasErrors: apply.errors.length > 0 };
     }
+
+    ctx.ui.notify("Changes saved. Reload pi later to fully apply extension state updates.", "info");
   }
 
-  return { changed: apply.changed, reloaded: false };
+  return { changed: apply.changed, reloaded: false, hasErrors: apply.errors.length > 0 };
 }
 
 async function resolvePendingChangesBeforeLeave(
@@ -556,7 +550,7 @@ async function resolvePendingChangesBeforeLeave(
   ctx: ExtensionCommandContext,
   pi: ExtensionAPI,
   destinationLabel: string
-): Promise<"continue" | "stay" | "exit"> {
+): Promise<"continue" | "stay"> {
   const pendingCount = getPendingToggleChangeCount(staged, byId);
   if (pendingCount === 0) return "continue";
 
@@ -574,10 +568,10 @@ async function resolvePendingChangesBeforeLeave(
     return "continue";
   }
 
-  const result = await applyToggleChangesFromManager(items, staged, ctx, pi, {
+  const apply = await applyToggleChangesFromManager(items, staged, ctx, pi, {
     promptReload: false,
   });
-  return result.reloaded ? "exit" : "continue";
+  return apply.changed === 0 && apply.hasErrors ? "stay" : "continue";
 }
 
 const PALETTE_OPTIONS = {
@@ -648,7 +642,6 @@ async function navigateWithPendingGuard(
     QUICK_DESTINATION_LABELS[destination]
   );
   if (pending === "stay") return "stay";
-  if (pending === "exit") return "exit";
 
   switch (destination) {
     case "install":
@@ -703,6 +696,7 @@ async function handleUnifiedAction(
       if (choice === "Save and exit") {
         const apply = await applyToggleChangesFromManager(items, staged, ctx, pi);
         if (apply.reloaded) return true;
+        if (apply.changed === 0 && apply.hasErrors) return false;
       }
     }
 
@@ -712,7 +706,6 @@ async function handleUnifiedAction(
   if (result.type === "remote") {
     const pending = await resolvePendingChangesBeforeLeave(items, staged, byId, ctx, pi, "Remote");
     if (pending === "stay") return false;
-    if (pending === "exit") return true;
 
     await showRemote("", ctx, pi);
     return false;
@@ -721,7 +714,6 @@ async function handleUnifiedAction(
   if (result.type === "help") {
     const pending = await resolvePendingChangesBeforeLeave(items, staged, byId, ctx, pi, "Help");
     if (pending === "stay") return false;
-    if (pending === "exit") return true;
 
     showHelp(ctx);
     return false;
@@ -778,7 +770,6 @@ async function handleUnifiedAction(
       pendingDestination
     );
     if (pending === "stay") return false;
-    if (pending === "exit") return true;
 
     if (item.type === "local") {
       if (result.action !== "remove") return false;
@@ -790,7 +781,7 @@ async function handleUnifiedAction(
       if (!confirmed) return false;
 
       const removal = await removeLocalExtension(
-        { activePath: item.activePath!, disabledPath: item.disabledPath! },
+        { activePath: item.activePath, disabledPath: item.disabledPath },
         ctx.cwd
       );
       if (!removal.ok) {
@@ -805,16 +796,11 @@ async function handleUnifiedAction(
         "info"
       );
 
-      const reloaded = await confirmReload(ctx, "Extension removed.");
-      if (reloaded) {
-        return true;
-      }
-
-      return false;
+      return await confirmReload(ctx, "Extension removed.");
     }
 
     const pkg: InstalledPackage = {
-      source: item.source!,
+      source: item.source,
       name: item.displayName,
       ...(item.version ? { version: item.version } : {}),
       scope: item.scope,
@@ -860,7 +846,7 @@ async function handleUnifiedAction(
 }
 
 async function applyStagedChanges(
-  items: UnifiedItem[],
+  items: LocalUnifiedItem[],
   staged: Map<string, State>,
   pi: ExtensionAPI
 ) {
@@ -868,10 +854,6 @@ async function applyStagedChanges(
   const errors: string[] = [];
 
   for (const item of items) {
-    if (item.type !== "local" || !item.originalState || !item.activePath || !item.disabledPath) {
-      continue;
-    }
-
     const target = staged.get(item.id) ?? item.originalState;
     if (target === item.originalState) continue;
 

package/src/utils/auto-update.ts

@@ -1,25 +1,25 @@
 /**
  * Auto-update logic and background checker
  */
-import type {
-  ExtensionAPI,
-  ExtensionCommandContext,
-  ExtensionContext,
+import {
+  type ExtensionAPI,
+  type ExtensionCommandContext,
+  type ExtensionContext,
 } from "@mariozechner/pi-coding-agent";
 import { getPackageCatalog } from "../packages/catalog.js";
+import { logAutoUpdateConfig } from "./history.js";
 import { notify } from "./notify.js";
+import { normalizePackageIdentity } from "./package-source.js";
 import {
+  type AutoUpdateConfig,
+  calculateNextCheck,
   getAutoUpdateConfig,
-  saveAutoUpdateConfig,
   getScheduleInterval,
-  calculateNextCheck,
   parseDuration,
-  type AutoUpdateConfig,
+  saveAutoUpdateConfig,
 } from "./settings.js";
-import { normalizePackageIdentity } from "./package-source.js";
-import { logAutoUpdateConfig } from "./history.js";
 
-import { startTimer, stopTimer, isTimerRunning } from "./timer.js";
+import { isTimerRunning, startTimer, stopTimer } from "./timer.js";
 
 // Context provider for safe session handling
 export type ContextProvider = () => (ExtensionCommandContext | ExtensionContext) | undefined;

package/src/utils/cache.ts

@@ -1,11 +1,11 @@
 /**
  * Persistent cache for package metadata to reduce npm API calls
  */
-import { readFile, writeFile, mkdir, access, rename, rm } from "node:fs/promises";
-import { join } from "node:path";
+import { access, mkdir, readFile, rename, rm, writeFile } from "node:fs/promises";
 import { homedir } from "node:os";
-import type { NpmPackage, InstalledPackage } from "../types/index.js";
+import { join } from "node:path";
 import { CACHE_LIMITS } from "../constants.js";
+import { type InstalledPackage, type NpmPackage } from "../types/index.js";
 import { parseNpmSource } from "./format.js";
 
 const CACHE_DIR = process.env.PI_EXTMGR_CACHE_DIR

package/src/utils/command.ts

@@ -18,7 +18,7 @@ export function tokenizeArgs(input: string): string[] {
   };
 
   for (let i = 0; i < input.length; i++) {
-    const char = input[i]!;
+    const char = input.charAt(i);
     const next = input[i + 1];
 
     if (inSingleQuote) {

package/src/utils/format.ts

@@ -1,11 +1,12 @@
 /**
  * Formatting utilities
  */
-import type { ExtensionEntry, InstalledPackage } from "../types/index.js";
+import { type ExtensionEntry, type InstalledPackage } from "../types/index.js";
 
 export function truncate(text: string, maxLength: number): string {
   if (text.length <= maxLength) return text;
-  return text.slice(0, maxLength - 3) + "...";
+  if (maxLength <= 3) return text.slice(0, maxLength);
+  return `${text.slice(0, maxLength - 3)}...`;
 }
 
 /**
@@ -54,7 +55,7 @@ export function formatBytes(bytes: number): string {
   const k = 1024;
   const sizes = ["B", "KB", "MB", "GB"];
   const i = Math.floor(Math.log(bytes) / Math.log(k));
-  return `${parseFloat((bytes / Math.pow(k, i)).toFixed(1))} ${sizes[i]}`;
+  return `${parseFloat((bytes / k ** i).toFixed(1))} ${sizes[i]}`;
 }
 
 const GIT_PATTERNS = {

package/src/utils/history.ts

@@ -2,10 +2,12 @@
  * Extension change history tracking using pi.appendEntry()
  * This persists extension management actions to the session
  */
-import type { ExtensionAPI, ExtensionCommandContext } from "@mariozechner/pi-coding-agent";
+
+import { type Dirent } from "node:fs";
 import { readdir, readFile } from "node:fs/promises";
 import { homedir } from "node:os";
 import { join } from "node:path";
+import { type ExtensionAPI, type ExtensionCommandContext } from "@mariozechner/pi-coding-agent";
 
 export type ChangeAction =
   | "extension_toggle"
@@ -278,7 +280,7 @@ function isRecord(value: unknown): value is Record<string, unknown> {
 async function walkSessionFiles(dir: string): Promise<string[]> {
   const result: string[] = [];
 
-  let entries;
+  let entries: Dirent<string>[];
   try {
     entries = await readdir(dir, { withFileTypes: true, encoding: "utf8" });
   } catch {

package/src/utils/mode.ts

@@ -1,7 +1,7 @@
 /**
  * UI capability helpers
  */
-import type { ExtensionCommandContext, ExtensionContext } from "@mariozechner/pi-coding-agent";
+import { type ExtensionCommandContext, type ExtensionContext } from "@mariozechner/pi-coding-agent";
 import { notify } from "./notify.js";
 
 type AnyContext = ExtensionCommandContext | ExtensionContext;

package/src/utils/notify.ts

@@ -1,7 +1,7 @@
 /**
  * Centralized notification handling for UI and non-UI modes
  */
-import type { ExtensionCommandContext, ExtensionContext } from "@mariozechner/pi-coding-agent";
+import { type ExtensionCommandContext, type ExtensionContext } from "@mariozechner/pi-coding-agent";
 
 export type NotifyLevel = "info" | "warning" | "error";
 

package/src/utils/npm-exec.ts

@@ -1,6 +1,6 @@
 import path from "node:path";
 import { execPath, platform } from "node:process";
-import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
+import { type ExtensionAPI } from "@mariozechner/pi-coding-agent";
 
 interface NpmCommandResolutionOptions {
   platform?: NodeJS.Platform;

package/src/utils/package-source.ts

@@ -1,6 +1,9 @@
 /**
  * Package source parsing helpers shared across discovery/management flows.
  */
+import { homedir } from "node:os";
+import { join, resolve as resolvePath } from "node:path";
+import { fileURLToPath } from "node:url";
 import { parseNpmSource } from "./format.js";
 
 export type PackageSourceKind = "npm" | "git" | "local" | "unknown";
@@ -61,9 +64,35 @@ export function stripGitSourcePrefix(source: string): string {
   return withoutGitPlus.startsWith("git:") ? withoutGitPlus.slice(4) : withoutGitPlus;
 }
 
+function resolveLocalSourceForIdentity(source: string, cwd?: string): string {
+  if (source.startsWith("file://")) {
+    try {
+      return fileURLToPath(source);
+    } catch {
+      return source;
+    }
+  }
+
+  if (source.startsWith("~/")) {
+    return join(homedir(), source.slice(2));
+  }
+
+  if (
+    cwd &&
+    (source.startsWith("./") ||
+      source.startsWith("../") ||
+      source.startsWith(".\\") ||
+      source.startsWith("..\\"))
+  ) {
+    return resolvePath(cwd, source);
+  }
+
+  return source;
+}
+
 export function normalizePackageIdentity(
   source: string,
-  options?: { resolvedPath?: string }
+  options?: { resolvedPath?: string; cwd?: string }
 ): string {
   const normalized = sanitizeSource(source);
   const kind = getPackageSourceKind(normalized);
@@ -80,7 +109,9 @@ export function normalizePackageIdentity(
   }
 
   if (kind === "local") {
-    return `local:${normalizeLocalSourceIdentity(options?.resolvedPath ?? normalized)}`;
+    const localSource =
+      options?.resolvedPath ?? resolveLocalSourceForIdentity(normalized, options?.cwd);
+    return `local:${normalizeLocalSourceIdentity(localSource)}`;
   }
 
   return `raw:${normalized.replace(/\\/g, "/").toLowerCase()}`;

package/src/utils/retry.ts

@@ -23,7 +23,7 @@ export async function retryWithBackoff<T>(
     if (attempt < maxAttempts) {
       const delay =
         backoff === "exponential"
-          ? delayMs * Math.pow(2, attempt - 1)
+          ? delayMs * 2 ** (attempt - 1)
           : backoff === "linear"
             ? delayMs * attempt
             : delayMs;

package/src/utils/settings.ts

@@ -2,14 +2,15 @@
  * Auto-update settings storage
  * Persists to disk so config survives across pi sessions.
  */
-import type {
-  ExtensionAPI,
-  ExtensionCommandContext,
-  ExtensionContext,
-} from "@mariozechner/pi-coding-agent";
-import { readFile, writeFile, mkdir, rename, rm } from "node:fs/promises";
+
+import { mkdir, readFile, rename, rm, writeFile } from "node:fs/promises";
 import { homedir } from "node:os";
 import { join } from "node:path";
+import {
+  type ExtensionAPI,
+  type ExtensionCommandContext,
+  type ExtensionContext,
+} from "@mariozechner/pi-coding-agent";
 import { fileExists } from "./fs.js";
 import { normalizePackageIdentity } from "./package-source.js";
 
@@ -328,8 +329,16 @@ export function parseDuration(input: string): { ms: number; display: string } |
     /^(\d+)\s*(h|hr|hrs|hour|hours|d|day|days|w|wk|wks|week|weeks|m|mo|mos|month|months)$/
   );
   if (durationMatch) {
-    const value = parseInt(durationMatch[1]!, 10);
-    const unit = durationMatch[2]![0]; // First character of unit
+    const [, rawValue, rawUnit] = durationMatch;
+    if (!rawValue || !rawUnit) {
+      return undefined;
+    }
+
+    const value = Number.parseInt(rawValue, 10);
+    const unit = rawUnit[0];
+    if (!unit) {
+      return undefined;
+    }
 
     let ms: number;
     let display: string;

package/src/utils/status.ts

@@ -1,10 +1,11 @@
 /**
  * Status bar helpers for extmgr
  */
-import type {
-  ExtensionAPI,
-  ExtensionCommandContext,
-  ExtensionContext,
+import {
+  type ExtensionAPI,
+  type ExtensionCommandContext,
+  type ExtensionContext,
+  getAgentDir,
 } from "@mariozechner/pi-coding-agent";
 import { getPackageCatalog, type PackageCatalog } from "../packages/catalog.js";
 import { getAutoUpdateStatus } from "./auto-update.js";
@@ -15,14 +16,15 @@ type CatalogInstalledPackages = Awaited<ReturnType<PackageCatalog["listInstalled
 
 function filterStaleUpdates(
   knownUpdates: string[],
-  installedPackages: CatalogInstalledPackages
+  installedPackages: CatalogInstalledPackages,
+  cwd: string
 ): string[] {
   const installedIdentities = new Set(
     installedPackages.map((pkg) =>
-      normalizePackageIdentity(
-        pkg.source,
-        pkg.resolvedPath ? { resolvedPath: pkg.resolvedPath } : undefined
-      )
+      normalizePackageIdentity(pkg.source, {
+        ...(pkg.resolvedPath ? { resolvedPath: pkg.resolvedPath } : {}),
+        cwd: pkg.scope === "project" ? cwd : getAgentDir(),
+      })
     )
   );
   return knownUpdates.filter((identity) => installedIdentities.has(identity));
@@ -52,7 +54,7 @@ export async function updateExtmgrStatus(
 
     // Validate updates against actually installed packages (handles external pi update)
     const knownUpdates = autoUpdateConfig.updatesAvailable ?? [];
-    const validUpdates = filterStaleUpdates(knownUpdates, packages);
+    const validUpdates = filterStaleUpdates(knownUpdates, packages, ctx.cwd);
 
     // If stale updates were filtered, persist the correction
     if (validUpdates.length !== knownUpdates.length) {

package/src/utils/ui-helpers.ts

@@ -1,9 +1,9 @@
 /**
  * Common UI helper patterns
  */
-import type { ExtensionCommandContext } from "@mariozechner/pi-coding-agent";
-import { notify } from "./notify.js";
+import { type ExtensionCommandContext } from "@mariozechner/pi-coding-agent";
 import { UI } from "../constants.js";
+import { notify } from "./notify.js";
 
 /**
  * Confirm and trigger reload