pi-extension-utils 0.5.0 → 0.5.2

package/dist/src/pane/chrome.js

@@ -34,7 +34,11 @@ export function pad(s, len) {
     return s + " ".repeat(Math.max(0, len - vis));
 }
 function normalizeRenderableText(text) {
-    return text
+    // Coerce defensively: a non-string here reaches truncateToWidth/text.slice
+    // and hard-crashes pi ("text.slice is not a function"). Callers pass values
+    // derived from on-disk/agent state that may be out-of-contract.
+    const s = typeof text === "string" ? text : text == null ? "" : String(text);
+    return s
         .replaceAll("\t", "    ")
         .replace(/[\u0000-\u0008\u000B\u000C\u000E-\u001A\u001C-\u001F\u007F]/g, "");
 }
@@ -94,12 +98,12 @@ export function titledTopSegment(theme, opts) {
             return dash(width);
         const labelColor = opts.labelColor ?? "text";
         const tailColor = opts.tailColor ?? "dim";
-        const tailPlain = opts.tailPlain ?? opts.tail ?? "";
+        const tailPlain = normalizeRenderableText(opts.tailPlain ?? opts.tail ?? "");
         const tailRendered = opts.tailRendered ?? (opts.tail !== undefined ? theme.fg(tailColor, opts.tail) : "");
         const tailLen = visibleWidth(tailPlain);
         const canShowTail = tailLen > 0 && width - tailLen >= 14;
         const labelBudget = Math.max(0, width - (canShowTail ? tailLen + 6 : 4));
-        const labelText = clipText(opts.label ?? "", labelBudget);
+        const labelText = clipText(normalizeRenderableText(opts.label ?? ""), labelBudget);
         const labelLen = visibleWidth(labelText);
         if (labelLen === 0)
             return dash(width);
@@ -118,7 +122,7 @@ export function titledTopSegment(theme, opts) {
         return "";
     const labelColor = opts.labelColor ?? "text";
     const tailColor = opts.tailColor ?? "dim";
-    const tailPlain = opts.tailPlain ?? opts.tail ?? "";
+    const tailPlain = normalizeRenderableText(opts.tailPlain ?? opts.tail ?? "");
     const rawTailRendered = opts.tailRendered ?? (opts.tail !== undefined ? theme.fg(tailColor, opts.tail) : "");
     const tailLen = visibleWidth(tailPlain);
     // With a tail, the minimum chrome is:
@@ -129,7 +133,7 @@ export function titledTopSegment(theme, opts) {
     const labelBudget = tailFits ? Math.max(0, width - tailLen - 7) : Math.max(0, width - 3);
     // Defensive: callers occasionally pass undefined labels for transient/legacy
     // runs that lack agent+mode+label; treat as empty rather than crashing pi.
-    const rawLabel = opts.label ?? "";
+    const rawLabel = normalizeRenderableText(opts.label ?? "");
     const labelText = truncateToWidth(rawLabel, labelBudget, "").replace(/\u001b\[[0-9;]*m/g, "");
     const labelStyled = opts.labelBold && theme.bold
         ? theme.bold(theme.fg(labelColor, labelText))
@@ -153,11 +157,12 @@ export function titledBottomSegment(theme, width, hint, focused) {
     const dash = (n) => theme.fg("dim", "─".repeat(Math.max(0, n)));
     if (width <= 0)
         return "";
-    if (!hint)
+    const safeHint = normalizeRenderableText(hint);
+    if (!safeHint)
         return dash(width);
     // Reserve at minimum `─ ` + hint + ` `; truncate hint to fit when narrow so we never overflow.
     const hintBudget = Math.max(0, width - 3);
-    const clipped = truncateToWidth(hint, hintBudget);
+    const clipped = truncateToWidth(safeHint, hintBudget);
     const clippedLen = visibleWidth(clipped);
     if (clippedLen === 0)
         return dash(width);
@@ -196,10 +201,11 @@ export function flatRule(theme, title, width, opts) {
     if (width <= 0)
         return "";
     const dash = (n) => theme.fg("dim", "─".repeat(Math.max(0, n)));
-    if (!title)
+    const safeTitle = normalizeRenderableText(title);
+    if (!safeTitle)
         return dash(width);
     if (opts?.leadingDashes !== undefined) {
-        const label = ` ${title} `;
+        const label = ` ${safeTitle} `;
         const labelW = visibleWidth(label);
         if (labelW + 4 >= width)
             return dash(width);
@@ -207,7 +213,7 @@ export function flatRule(theme, title, width, opts) {
         const trailing = Math.max(0, width - labelW - leading);
         return `${dash(leading)}${theme.fg("dim", label)}${dash(trailing)}`;
     }
-    const clipped = truncateToWidth(title, Math.max(0, width - 4));
+    const clipped = truncateToWidth(safeTitle, Math.max(0, width - 4));
     const clippedLen = visibleWidth(clipped);
     const styled = theme.fg("dim", clipped);
     const trailing = Math.max(0, width - (clippedLen + 3));

package/dist/src/pane/overlay.d.ts

@@ -72,7 +72,12 @@ export interface PaneOverlaySplitOptions {
 export interface PaneCollapseOptions {
     key?: string;
     collapsedWidth?: number;
-    label?: string;
+    /**
+     * Legend/divider label for the collapse toggle. A function receives the
+     * current collapsed state so the hint can read e.g. "hide sidebar" when open
+     * and "open sidebar" when collapsed.
+     */
+    label?: string | ((collapsed: boolean) => string);
 }
 export interface PaneOverlayOptions<T = unknown, Row = unknown> {
     primary: PrimaryPaneOptions<Row>;

package/dist/src/pane/overlay.js

@@ -89,6 +89,10 @@ export function paneOverlay(options) {
         let finished = false;
         let focus = "primary";
         let collapsed = false;
+        const collapseLabel = (fallback) => {
+            const label = collapse?.label;
+            return typeof label === "function" ? label(collapsed) : (label ?? fallback);
+        };
         let leftFraction = split.initialFraction ?? 0.5;
         let lastRenderWidth = 80;
         let lastSelectedKey;
@@ -339,7 +343,7 @@ export function paneOverlay(options) {
             if (!collapsed)
                 entries.push({ key: "[/]", label: "resize" });
             if (collapse)
-                entries.push({ key: collapseKey, label: collapse.label ?? "collapse" });
+                entries.push({ key: collapseKey, label: collapseLabel("collapse") });
             for (const action of customActions) {
                 if (action.showInLegend === false)
                     continue;
@@ -453,10 +457,16 @@ export function paneOverlay(options) {
                         : primaryRows.length > primaryHeight
                             ? formatScrollInfo(primaryState.scrollOffset, Math.max(0, primaryRows.length - primaryHeight), { style: "position" })
                             : "");
-                const detailFooterText = resolveValue(options.detail.footer, ctx)
-                    ?? (detailRows.length > detailHeight
+                const detailFooterBase = resolveValue(options.detail.footer, ctx) ??
+                    (detailRows.length > detailHeight
                         ? formatScrollInfo(detailState.scrollOffset, Math.max(0, detailRows.length - detailHeight), { style: "position" })
                         : "");
+                // When the primary pane is collapsed its legend (and the collapse hint with
+                // it) disappears, so the user can't see how to reopen it. Surface the
+                // reopen hint in the always-visible detail footer instead.
+                const detailFooterText = collapsed && collapse
+                    ? [`${collapseKey} ${collapseLabel("expand")}`, detailFooterBase].filter(Boolean).join(" \u00b7 ")
+                    : detailFooterBase;
                 const bottomPrimary = titledBottomSegment(chromeTheme, primaryWidth, primaryFooterText, focus === "primary");
                 const bottomDetail = titledBottomSegment(chromeTheme, detailWidth, detailFooterText, focus === "detail");
                 const bottomBorder = primaryWidth === 0
@@ -474,7 +484,7 @@ export function paneOverlay(options) {
                         primaryCell = infoLines[row - infoStart - 1] ?? "";
                     }
                     else if (legendPlacement === "primary" && row === legendStart && legendLines.length > 0) {
-                        primaryCell = flatRule(chromeTheme, collapse?.label ?? "actions", primaryWidth);
+                        primaryCell = flatRule(chromeTheme, collapse ? collapseLabel("actions") : "actions", primaryWidth);
                     }
                     if (legendPlacement === "primary" && row > legendStart) {
                         const legendIndex = row - legendStart - 1;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-extension-utils",
-	"version": "0.5.0",
+	"version": "0.5.2",
 	"description": "Shared Pi extension utilities for coordinated widgets, fullscreen leases, and logging.",
 	"type": "module",
 	"main": "./dist/src/index.js",