pi-do-always 0.12.0 → 0.15.0

package/extensions/pi-do-always/tasks.ts

@@ -37,6 +37,21 @@ export interface DoAlwaysTask {
 	 * Omitted/undefined always shows the task. Evaluated by `evaluateWhen`.
 	 */
 	when?: string | Record<string, unknown>;
+	/**
+	 * Hide the task from the selector and the `list` commands. Hidden tasks
+	 * are not standalone user-visible entries; they can still be resolved by
+	 * name on the command line and are offered as candidates by the commit
+	 * picker. The built-in "Review commits" uses this: it is a pick-after-
+	 * browse option, not an entry point ("Browse commits" is the entry).
+	 */
+	hidden?: boolean;
+	/**
+	 * Exclude the task from the commit picker (the "run on the selected
+	 * commits" list shown after a commit selection). For Plan tasks that
+	 * operate on the working tree or the whole project rather than on a set
+	 * of commits. The task is otherwise unaffected (selector, lists, CLI).
+	 */
+	notForCommits?: boolean;
 	/**
 	 * Extra selection-time guards, evaluated alongside the legacy `requireDirty`
 	 * (see `evaluateGuards`). Each guard blocks the task (with a message, not a
@@ -44,6 +59,14 @@ export interface DoAlwaysTask {
 	 * compatibility; new guards use this array so the set is extensible.
 	 */
 	guards?: Guard[];
+	/**
+	 * A browser to open on selection instead of injecting the prompt directly.
+	 * Currently only "commits": opens the date-grouped commit browser, and the
+	 * selected commits drive the review prompt (see `fillPrompt` in index.ts).
+	 * The built-in "Review commits" task also triggers the browser by name, so
+	 * configs that predate this field keep working.
+	 */
+	browser?: BrowserType;
 }
 
 /** The set of known guard types (used for validation at parse time). */
@@ -66,6 +89,13 @@ export interface Guard {
 	value?: string;
 }
 
+/** The set of known browser types (used for validation at parse time). */
+export const BROWSER_TYPES = [
+	"commits",
+] as const;
+
+export type BrowserType = (typeof BROWSER_TYPES)[number];
+
 /**
  * A config file can be a bare array of tasks, or {"tasks": [...], "shortcut": ...}.
  * `shortcut` is a key id string (e.g. "f4", "ctrl+shift+p"), or null to disable
@@ -144,6 +174,12 @@ export interface TaskContext {
 	stagedFiles: string[];
 	/** Modified-but-unstaged files. */
 	unstagedFiles: string[];
+	/**
+	 * Commits selected in the commit browser, formatted for prompt injection
+	 * (see `formatSelectedCommits`), or "none" when no selection is active.
+	 * Context builds always set "none"; the browser flow overrides it at render.
+	 */
+	selectedCommits: string;
 	/** True when cwd is inside a git working tree (authoritative, not inferred from the branch name). */
 	isGitRepo: boolean;
 }
@@ -166,6 +202,7 @@ export const PROMPT_CONTEXT_KEYS = [
 	"repo",
 	"staged_files",
 	"unstaged_files",
+	"selected_commits",
 ] as const;
 
 /** A fully populated prompt context: one entry per PROMPT_CONTEXT_KEYS. */
@@ -193,6 +230,7 @@ export function toPromptContext(ctx: TaskContext): PromptContext {
 		repo: ctx.repo,
 		staged_files: formatFileLines(ctx.stagedFiles),
 		unstaged_files: formatFileLines(ctx.unstagedFiles),
+		selected_commits: ctx.selectedCommits,
 	};
 }
 
@@ -315,6 +353,7 @@ export const DEFAULT_TASKS: DoAlwaysTask[] = [
 		category: "Plan",
 		description: "Review the current code changes (Plan)",
 		requireDirty: true,
+		notForCommits: true,
 		prompt:
 			"Review the changes on branch {{branch}} ({{files_changed_count}} changed files: {{files_changed}}). " +
 			"Change summary: {{diff_stat}}. Last commit: {{last_commit}}. " +
@@ -326,6 +365,7 @@ export const DEFAULT_TASKS: DoAlwaysTask[] = [
 		name: "Review code",
 		category: "Plan",
 		description: "Review the whole project's code quality (Plan)",
+		notForCommits: true,
 		prompt:
 			"Review this project's code holistically: identify code smells, dead code, duplication, awkward architecture or patterns, maintainability issues, inconsistencies, and missing or unclear documentation. " +
 			"Prioritize by impact, propose a plan for the fixes, and summarize your findings. Do not make any changes yet.",
@@ -378,7 +418,7 @@ export const DEFAULT_TASKS: DoAlwaysTask[] = [
 		description: "Prepare a release (version, changelog, tag)",
 		when: "git",
 		prompt:
-			"Prepare a release for this project (branch {{branch}}): check `git log` since the last tag, update the version in package.json (or the equivalent location), add a changelog entry summarizing the changes, and create a git tag if git present. Do not push.",
+			"Prepare a release for this project (branch {{branch}}): check `git log` since the last tag, then bump the version in package.json (or the equivalent location) to the next version, and add a changelog entry under that exact version summarizing the changes. The changelog entry must use the same version number now set in package.json — never add a changelog section for a version that package.json does not yet contain, and never leave an 'Unreleased' or placeholder version heading. Create a git tag if git present. Do not push.",
 	},
 	{
 		name: "Commit",
@@ -393,9 +433,29 @@ export const DEFAULT_TASKS: DoAlwaysTask[] = [
 		name: "Propose features",
 		category: "Plan",
 		description: "Propose new features (Plan)",
+		notForCommits: true,
 		prompt:
 			"Review this project and propose new features that would add value. For each idea, describe the problem it solves, the user benefit, and a rough implementation approach. Prioritize by impact and effort. Do not make any changes yet. Try to evaluate how many lines this will be in terms of changes, whether this will break APIs, or introduce compatibility issues.",
 	},
+	{
+		name: "Review commits",
+		category: "Plan",
+		description: "Review the selected commits (Plan)",
+		browser: "commits",
+		hidden: true,
+		prompt:
+			"Review the selected commits: {{selected_commits}}. Inspect each with `git show <hash>`, " +
+			"double-check the changes for bugs, edge cases, security issues, and consistency with the rest of the codebase. " +
+			"Summarize your findings per commit and propose a plan for any fixes if needed. Do not make any changes yet.",
+	},
+	{
+		name: "Browse commits",
+		category: "Browse",
+		description: "Browse and select commits, then pick a task to run on them",
+		browser: "commits",
+		when: "git",
+		prompt: "Browse recent commits, select some, then pick a task to run on them.",
+	},
 ];
 
 /**
@@ -427,7 +487,7 @@ export function parseConfig(
 	const tasks: DoAlwaysTask[] = [];
 	for (const entry of list) {
 		const t = entry as Partial<DoAlwaysTask> | null;
-		if (t && typeof t.name === "string" && t.name.length > 0 && typeof t.prompt === "string" && t.prompt.length > 0) {
+		if (t && typeof t.name === "string" && t.name.length > 0 && typeof t.prompt === "string" && (t.prompt.length > 0 || t.autoRun === true)) {
 			const task: DoAlwaysTask = {
 				name: t.name,
 				prompt: t.prompt,
@@ -436,6 +496,15 @@ export function parseConfig(
 				if (typeof t.category === "string" && t.category.trim() !== "") task.category = t.category.trim();
 				if (typeof t.autoRun === "boolean") task.autoRun = t.autoRun;
 				if (typeof t.requireDirty === "boolean") task.requireDirty = t.requireDirty;
+				if (typeof t.hidden === "boolean") task.hidden = t.hidden;
+				if (typeof t.notForCommits === "boolean") task.notForCommits = t.notForCommits;
+				if (t.browser !== undefined) {
+					if (typeof t.browser === "string" && BROWSER_TYPES.includes(t.browser as BrowserType)) {
+						task.browser = t.browser as BrowserType;
+					} else {
+						onError(`do-always: ignoring invalid "browser" in ${path} (expected one of: ${BROWSER_TYPES.join(", ")})`);
+					}
+				}
 				if (t.guards !== undefined) {
 					if (Array.isArray(t.guards)) {
 						const guards: Guard[] = [];
@@ -665,8 +734,17 @@ export function evaluateWhen(task: DoAlwaysTask, ctx: TaskContext): boolean {
 	return true;
 }
 
+/**
+ * Whether a task is visible in the selector and the lists: not `hidden` and
+ * its `when` condition passes. Single source of truth so the TUI selector and
+ * the `/do-always <n>` numbering can never diverge.
+ */
+export function isTaskVisible(task: DoAlwaysTask, ctx: TaskContext): boolean {
+	return !task.hidden && evaluateWhen(task, ctx);
+}
+
 /** Default order for category headers in the selector. Exported for tests. */
-export const DEFAULT_CATEGORY_ORDER = ["Plan", "Do", "Docs", "Ops", "Other"];
+export const DEFAULT_CATEGORY_ORDER = ["Plan", "Browse", "Do", "Docs", "Ops", "Other"];
 
 /** A category group: a display name and the tasks that belong to it. */
 interface TaskGroup {
@@ -1263,3 +1341,153 @@ function outcomeToMarker(outcome: ChainStepOutcome): string {
 			throw new Error(`unexpected outcome: ${outcome as string}`);
 	}
 }
+
+// ── Commit browser types ─────────────────────────────────────────────────
+//
+// Types and constants for the date-grouped commit browser (used by
+// the "Review commits" task in index.ts). Pure data — no Pi dependencies.
+
+/** Maximum commits shown per page in the date-grouped browser. */
+export const COMMIT_BROWSER_MAX = 20;
+
+/** Maximum commits that can be selected for a review chain. */
+export const COMMIT_SELECT_MAX = 20;
+
+/** A single commit as returned by `git log --format`. */
+export interface CommitInfo {
+	/** Full 40-char SHA. */
+	hash: string;
+	/** Short 7-char SHA. */
+	shortHash: string;
+	/** Commit subject line. */
+	subject: string;
+	/** Commit date (YYYY-MM-DD). */
+	date: string;
+	/** Commit author name. */
+	author: string;
+	/** Number of files changed in this commit. */
+	filesChanged: number;
+	/** Insertions in this commit. */
+	insertions: number;
+	/** Deletions in this commit. */
+	deletions: number;
+}
+
+/** A commit selected by the user for review. */
+export interface SelectedCommit extends CommitInfo {
+	/** 1-based position in the user's selection order. */
+	selectionOrder: number;
+}
+
+/** Group of commits sharing the same date. */
+export interface DateGroup {
+	/** Date string (YYYY-MM-DD). */
+	date: string;
+	/** Number of commits in this group. */
+	count: number;
+	/** Commits in this group (newest first). */
+	commits: CommitInfo[];
+}
+
+/**
+ * Parse git log output formatted with:
+ * `COMMIT%x09%H%x09%h%x09%s%x09%ad%x09%an` and optional `--shortstat`.
+ */
+export function parseGitLogOutput(output: string): CommitInfo[] {
+	if (!output) return [];
+	const commits: CommitInfo[] = [];
+	let current: CommitInfo | null = null;
+	for (const rawLine of output.split("\n")) {
+		const line = rawLine.trim();
+		if (line.startsWith("COMMIT\t")) {
+			if (current) commits.push(current);
+			const parts = line.split("\t");
+			if (parts.length >= 6) {
+				const hash = parts[1];
+				const shortHash = parts[2];
+				const date = parts[parts.length - 2];
+				const author = parts[parts.length - 1];
+				const subject = parts.slice(3, parts.length - 2).join("\t") || "(no subject)";
+				current = {
+					hash,
+					shortHash,
+					subject,
+					date,
+					author,
+					filesChanged: 0,
+					insertions: 0,
+					deletions: 0,
+				};
+			} else {
+				current = null;
+			}
+			continue;
+		}
+		if (current && line.includes("changed")) {
+			const mFiles = line.match(/(\d+) file/);
+			const mIns = line.match(/(\d+) insertion/);
+			const mDel = line.match(/(\d+) deletion/);
+			if (mFiles) current.filesChanged = Number(mFiles[1]);
+			if (mIns) current.insertions = Number(mIns[1]);
+			if (mDel) current.deletions = Number(mDel[1]);
+		}
+	}
+	if (current) commits.push(current);
+	return commits;
+}
+
+/** Group commits by date (preserving existing order within and between groups). */
+export function groupCommitsByDate(commits: CommitInfo[]): DateGroup[] {
+	const groups = new Map<string, CommitInfo[]>();
+	for (const c of commits) {
+		if (!groups.has(c.date)) groups.set(c.date, []);
+		groups.get(c.date)!.push(c);
+	}
+	return [...groups.entries()].map(([date, groupCommits]) => ({
+		date,
+		count: groupCommits.length,
+		commits: groupCommits,
+	}));
+}
+
+/**
+ * Format the selected commits as a numbered detail block (hash, subject,
+ * author, date, stats per commit). Injected into task prompts via the
+ * `{{selected_commits}}` placeholder; composed into the full review prompt by
+ * `formatCommitReviewPrompt`.
+ */
+export function formatSelectedCommits(commits: SelectedCommit[]): string {
+	const count = commits.length;
+	return commits
+		.map((c, i) => {
+			const num = count > 1 ? `${i + 1}. ` : "";
+			return (
+				`${num}Commit ${c.shortHash} (${c.hash})\n` +
+				`   Subject: ${c.subject}\n` +
+				`   Author:  ${c.author} on ${c.date}\n` +
+				`   Stats:   ${c.filesChanged} file${c.filesChanged !== 1 ? "s" : ""} changed, +${c.insertions}/-${c.deletions} lines`
+			);
+		})
+		.join("\n\n");
+}
+
+/**
+ * Build the review prompt for the selected commits to send to the agent.
+ */
+export function formatCommitReviewPrompt(commits: SelectedCommit[]): string {
+	const count = commits.length;
+	const commitDetails = formatSelectedCommits(commits);
+
+	const showCmd = count === 1 ? `git show ${commits[0].hash}` : "git show <hash>";
+
+	return (
+		`Review the following git commit${count !== 1 ? "s" : ""}:\n\n` +
+		`${commitDetails}\n\n` +
+		`Please inspect the changes using \`${showCmd}\` (and any related files in the repository). ` +
+		`Double-check the changes for:\n` +
+		`1. Bugs, edge cases, potential regressions, and logic errors.\n` +
+		`2. Code quality, security, and unintended side effects.\n` +
+		`3. Consistency with surrounding project patterns and tests.\n\n` +
+		`Summarize your findings for each commit and propose a plan for any fixes if needed. Do not make changes yet.`
+	);
+}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-do-always",
-	"version": "0.12.0",
+	"version": "0.15.0",
 	"type": "module",
 	"description": "Pi extension: /do-always — pick a common task by number, it fills your prompt",
 	"author": {