pi-diff-review 0.1.4 → 0.1.5

package/README.md

@@ -4,7 +4,7 @@
 
 Easily provide code reviews directly within [pi](https://pi.dev/).
 
-<img width="1947" height="1103" alt="image" src="https://github.com/user-attachments/assets/3b1e1c51-4c77-4430-8915-1f7d481b64cb" />
+<img width="1095" height="853" alt="pi-diff-review-screenshot" src="https://github.com/user-attachments/assets/f1a39117-f2a6-4ee7-bf72-a299990ab1dd" />
 
 ## Install
 
@@ -27,6 +27,7 @@ pi install https://github.com/cmpadden/pi-diff-review
 - `/diff` reviews the current unstaged `git diff`
 - `/diff <git-diff-args>` passes arguments through to `git diff` (for example `/diff main...HEAD`)
 - `j/k` or arrow keys to move
+- `g/G` to jump to the top or bottom of the diff
 - `ctrl-u` / `ctrl-d` to move up/down by half a page
 - `t` toggles the diff between unified and side-by-side split rendering
 - `J/K` to extend a highlighted selection into a comment range

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-diff-review",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "description": "Local diff review TUI extension for pi",
   "license": "MIT",
   "repository": {

package/src/diff-source.ts

@@ -11,7 +11,7 @@ export function parseDiffSource(args: string): DiffSource {
     };
   }
 
-  const gitArgs = trimmed.split(/\s+/).filter(Boolean);
+  const gitArgs = tokenizeDiffArgs(trimmed);
   return {
     label: `git diff ${trimmed}`,
     promptLabel: `\`git diff ${trimmed}\``,
@@ -19,6 +19,51 @@ export function parseDiffSource(args: string): DiffSource {
   };
 }
 
+function tokenizeDiffArgs(input: string): string[] {
+  const args: string[] = [];
+  let current = "";
+  let quote: '"' | "'" | undefined;
+  let escaping = false;
+
+  for (const char of input) {
+    if (escaping) {
+      current += char;
+      escaping = false;
+      continue;
+    }
+
+    if (char === "\\" && quote !== "'") {
+      escaping = true;
+      continue;
+    }
+
+    if ((char === '"' || char === "'") && !quote) {
+      quote = char;
+      continue;
+    }
+
+    if (char === quote) {
+      quote = undefined;
+      continue;
+    }
+
+    if (/\s/.test(char) && !quote) {
+      if (current) {
+        args.push(current);
+        current = "";
+      }
+      continue;
+    }
+
+    current += char;
+  }
+
+  if (escaping) current += "\\";
+  if (quote) throw new Error(`Unterminated ${quote} quote in git diff args`);
+  if (current) args.push(current);
+  return args;
+}
+
 export function getDiff(cwd: string, source: DiffSource): string {
   return execFileSync(
     "git",

package/src/index.ts

@@ -6,19 +6,20 @@ import { getDiff, parseDiffSource } from "./diff-source.ts";
 import { parseDiff } from "./diff-parser.ts";
 import { buildReviewPrompt } from "./prompt.ts";
 import { ReviewComponent } from "./review-component.ts";
-import type { ReviewComment, ReviewResult } from "./types.ts";
+import type { DiffSource, ReviewComment, ReviewResult } from "./types.ts";
 
 export function registerDiffReviewCommand(pi: ExtensionAPI): void {
   pi.registerCommand("diff", {
     description: "Review a git diff in a custom TUI (/diff [git diff args])",
     handler: async (args: string, ctx: ExtensionCommandContext) => {
-      const source = parseDiffSource(args);
+      let source: DiffSource;
       let diffText: string;
       try {
+        source = parseDiffSource(args);
         diffText = getDiff(ctx.cwd, source);
       } catch (error) {
         const message = error instanceof Error ? error.message : String(error);
-        ctx.ui.notify(`Unable to read ${source.label}: ${message}`, "error");
+        ctx.ui.notify(`Unable to read diff: ${message}`, "error");
         return;
       }
 

package/src/review-component.ts

@@ -126,6 +126,14 @@ export class ReviewComponent {
       this.move(-1);
       return;
     }
+    if (data === "g") {
+      this.jumpToBoundary("start");
+      return;
+    }
+    if (data === "G") {
+      this.jumpToBoundary("end");
+      return;
+    }
     if (data === "J") {
       this.extendSelection(1);
       return;
@@ -172,7 +180,7 @@ export class ReviewComponent {
             ? `${this.lines.length} lines • ${this.comments.size} comments • editing comment • Enter save • Esc/Ctrl+C cancel`
             : this.hasSelection()
               ? `${this.lines.length} lines • ${this.comments.size} comments • J/K extend • Esc clear selection • c comment range • Enter submit`
-              : `${this.lines.length} lines • ${this.comments.size} comments • j/k move • ctrl-u/d page • t unified/split • J/K extend • c comment • x delete • n/p hunk • Enter submit • q quit`,
+              : `${this.lines.length} lines • ${this.comments.size} comments • ${this.getPositionText(selectedLine)} • j/k move • g/G top/bottom • ctrl-u/d page • t unified/split • J/K extend • c comment • x delete • n/p hunk • Enter submit • q quit`,
         ),
         width,
       ),
@@ -344,6 +352,12 @@ export class ReviewComponent {
     this.tui.requestRender();
   }
 
+  private jumpToBoundary(boundary: "start" | "end"): void {
+    this.selected =
+      boundary === "start" ? 0 : Math.max(0, this.lines.length - 1);
+    this.clearSelection();
+  }
+
   private toggleLayout(): void {
     this.layout = this.layout === "side-by-side" ? "stacked" : "side-by-side";
     this.tui.requestRender(true);
@@ -456,6 +470,13 @@ export class ReviewComponent {
     };
   }
 
+  private getPositionText(selectedLine?: ReviewLine): string {
+    const position = `${Math.min(this.selected + 1, this.lines.length)}/${this.lines.length}`;
+    return selectedLine?.filePath
+      ? `${position} ${selectedLine.filePath}`
+      : position;
+  }
+
   private getFooterText(selectedLine?: ReviewLine): string {
     const selection = this.getSelectionBounds();
     if (selection) {