pi-diff-review 0.1.19 → 0.1.20

package/src/review/cache.ts

@@ -0,0 +1,171 @@
+import type {
+  ExtensionAPI,
+  ExtensionCommandContext,
+} from "@earendil-works/pi-coding-agent";
+import type { PersistedAsk, ReviewComment } from "./types.ts";
+
+const REVIEW_COMMENT_CACHE_ENTRY = "pi-diff-review-cache";
+const REVIEW_EXPLANATION_CACHE_ENTRY = "pi-diff-review-explanation-cache";
+const REVIEW_ASK_CACHE_ENTRY = "pi-diff-review-ask-cache";
+
+type ReviewCommentCacheEntry = {
+  cacheKey: string;
+  comments: ReviewComment[];
+  updatedAt: number;
+};
+
+type ReviewExplanationCacheEntry = {
+  cacheKey: string;
+  explanations: Record<string, string>;
+  updatedAt: number;
+};
+
+type ReviewAskCacheEntry = {
+  cacheKey: string;
+  ask?: PersistedAsk;
+  updatedAt: number;
+};
+
+export function getCachedComments(
+  ctx: ExtensionCommandContext,
+  cacheKey: string,
+): Map<string, ReviewComment> {
+  let latest: ReviewCommentCacheEntry | undefined;
+  for (const entry of ctx.sessionManager.getEntries()) {
+    if (
+      entry.type !== "custom" ||
+      entry.customType !== REVIEW_COMMENT_CACHE_ENTRY
+    ) {
+      continue;
+    }
+
+    const data = entry.data as Partial<ReviewCommentCacheEntry> | undefined;
+    if (data?.cacheKey !== cacheKey || !Array.isArray(data.comments)) continue;
+
+    if (!latest || (data.updatedAt ?? 0) >= latest.updatedAt) {
+      latest = {
+        cacheKey: data.cacheKey,
+        comments: data.comments,
+        updatedAt: data.updatedAt ?? 0,
+      };
+    }
+  }
+
+  return new Map(
+    (latest?.comments ?? []).map((comment) => [comment.id, comment]),
+  );
+}
+
+export function persistCachedComments(
+  pi: ExtensionAPI,
+  cacheKey: string,
+  comments: Iterable<ReviewComment>,
+): void {
+  pi.appendEntry(REVIEW_COMMENT_CACHE_ENTRY, {
+    cacheKey,
+    comments: [...comments],
+    updatedAt: Date.now(),
+  } satisfies ReviewCommentCacheEntry);
+}
+
+export function getCachedExplanations(
+  ctx: ExtensionCommandContext,
+  cacheKey: string,
+): Map<string, string> {
+  let latest: ReviewExplanationCacheEntry | undefined;
+  for (const entry of ctx.sessionManager.getEntries()) {
+    if (
+      entry.type !== "custom" ||
+      entry.customType !== REVIEW_EXPLANATION_CACHE_ENTRY
+    ) {
+      continue;
+    }
+
+    const data = entry.data as Partial<ReviewExplanationCacheEntry> | undefined;
+    if (
+      data?.cacheKey !== cacheKey ||
+      !data.explanations ||
+      typeof data.explanations !== "object" ||
+      Array.isArray(data.explanations)
+    ) {
+      continue;
+    }
+
+    if (!latest || (data.updatedAt ?? 0) >= latest.updatedAt) {
+      latest = {
+        cacheKey: data.cacheKey,
+        explanations: Object.fromEntries(
+          Object.entries(data.explanations).filter(
+            (entry): entry is [string, string] =>
+              typeof entry[0] === "string" && typeof entry[1] === "string",
+          ),
+        ),
+        updatedAt: data.updatedAt ?? 0,
+      };
+    }
+  }
+
+  return new Map(Object.entries(latest?.explanations ?? {}));
+}
+
+export function persistCachedExplanations(
+  pi: ExtensionAPI,
+  cacheKey: string,
+  explanations: Map<string, string>,
+): void {
+  pi.appendEntry(REVIEW_EXPLANATION_CACHE_ENTRY, {
+    cacheKey,
+    explanations: Object.fromEntries(explanations),
+    updatedAt: Date.now(),
+  } satisfies ReviewExplanationCacheEntry);
+}
+
+export function getCachedAsk(
+  ctx: ExtensionCommandContext,
+  cacheKey: string,
+): PersistedAsk | undefined {
+  let latest: ReviewAskCacheEntry | undefined;
+  for (const entry of ctx.sessionManager.getEntries()) {
+    if (
+      entry.type !== "custom" ||
+      entry.customType !== REVIEW_ASK_CACHE_ENTRY
+    ) {
+      continue;
+    }
+
+    const data = entry.data as Partial<ReviewAskCacheEntry> | undefined;
+    if (data?.cacheKey !== cacheKey) continue;
+
+    const ask = data.ask;
+    const validAsk =
+      ask &&
+      typeof ask === "object" &&
+      typeof ask.scopeKey === "string" &&
+      typeof ask.anchorLineId === "string" &&
+      typeof ask.text === "string"
+        ? ask
+        : undefined;
+
+    if (!latest || (data.updatedAt ?? 0) >= latest.updatedAt) {
+      latest = {
+        cacheKey: data.cacheKey,
+        ask: validAsk,
+        updatedAt: data.updatedAt ?? 0,
+      };
+    }
+  }
+
+  return latest?.ask;
+}
+
+export function persistCachedAsk(
+  pi: ExtensionAPI,
+  cacheKey: string,
+  ask?: PersistedAsk,
+): void {
+  pi.appendEntry(REVIEW_ASK_CACHE_ENTRY, {
+    cacheKey,
+    ask,
+    updatedAt: Date.now(),
+  } satisfies ReviewAskCacheEntry);
+}

package/src/review/component.ts

@@ -41,6 +41,7 @@ import type {
   SelectionBounds,
   SplitDiffCell,
   SplitDiffRow,
+  WorkspaceCommentSummary,
 } from "./types.ts";
 
 type InlineBoxPart = "top" | "body" | "bottom";
@@ -122,6 +123,9 @@ export class ReviewComponent {
     private onExplanationsChanged?: (explanations: Map<string, string>) => void,
     cachedAsk?: PersistedAsk,
     private onAskChanged?: (ask?: PersistedAsk) => void,
+    private getWorkspaceCommentSummary?: (
+      comments: Map<string, ReviewComment>,
+    ) => WorkspaceCommentSummary | undefined,
   ) {
     const firstCommentable = this.lines.findIndex((line) => line.commentable);
     this.navigation = new ReviewNavigationState(
@@ -394,11 +398,12 @@ export class ReviewComponent {
   render(width: number): string[] {
     const viewportHeight = this.getContentHeight();
     const selectedLine = this.lines[this.selected];
+    const workspaceSummary = this.getWorkspaceCommentSummary?.(this.comments);
     const output: string[] = [];
 
     output.push(
       this.renderStatusLine(
-        this.getHeaderText(selectedLine),
+        this.getHeaderText(selectedLine, workspaceSummary),
         "Press h for help",
         width,
       ),
@@ -409,15 +414,21 @@ export class ReviewComponent {
 
     output.push(
       truncateToWidth(
-        this.theme.fg("muted", this.getFooterText(selectedLine)),
+        this.theme.fg(
+          "muted",
+          this.getFooterText(selectedLine, workspaceSummary),
+        ),
         width,
       ),
     );
     return this.helpVisible ? this.renderHelpModal(output, width) : output;
   }
 
-  private getHeaderText(selectedLine?: ReviewLine): string {
-    const base = `${this.title} • ${this.lines.length} lines • ${this.comments.size} comments`;
+  private getHeaderText(
+    selectedLine?: ReviewLine,
+    workspaceSummary?: WorkspaceCommentSummary,
+  ): string {
+    const base = `${this.title} • ${this.lines.length} lines • ${this.comments.size} comments${this.formatWorkspaceSummary(workspaceSummary)}`;
 
     if (this.editMode) {
       return `${base} • editing ${this.editingCommentKey === GLOBAL_COMMENT_KEY ? "overall comment" : "inline comment"}`;
@@ -1209,7 +1220,10 @@ export class ReviewComponent {
       : position;
   }
 
-  private getFooterText(selectedLine?: ReviewLine): string {
+  private getFooterText(
+    selectedLine?: ReviewLine,
+    workspaceSummary?: WorkspaceCommentSummary,
+  ): string {
     if (this.search.mode) {
       return `Search: /${this.search.draftQuery} • Enter jump • Esc cancel`;
     }
@@ -1224,7 +1238,28 @@ export class ReviewComponent {
       const endLine = this.lines[selection.end]!;
       return `Selected ${count} lines: ${formatLocation(startLine)} -> ${formatLocation(endLine)}`;
     }
-    return `Selected: ${selectedLine ? formatLocation(selectedLine) : "(no selection)"}`;
+
+    const selectedText = `Selected: ${selectedLine ? formatLocation(selectedLine) : "(no selection)"}`;
+    const workspaceText = this.formatWorkspaceSummary(workspaceSummary, false);
+    return workspaceText ? `${selectedText} • ${workspaceText}` : selectedText;
+  }
+
+  private formatWorkspaceSummary(
+    summary?: WorkspaceCommentSummary,
+    includeVisible = true,
+  ): string {
+    if (!summary) return "";
+
+    const parts: string[] = [];
+    if (includeVisible && summary.visible > 0)
+      parts.push(`${summary.visible} visible persisted`);
+    if (summary.hiddenInCurrentFiles > 0) {
+      parts.push(`${summary.hiddenInCurrentFiles} hidden in current files`);
+    }
+    if (summary.elsewhere > 0) parts.push(`${summary.elsewhere} elsewhere`);
+    if (summary.stale > 0) parts.push(`${summary.stale} stale`);
+    if (summary.orphaned > 0) parts.push(`${summary.orphaned} orphaned`);
+    return parts.length > 0 ? ` • ${parts.join(" • ")}` : "";
   }
 
   private jumpHunk(direction: 1 | -1): void {

package/src/review/prompt.ts

@@ -36,16 +36,39 @@ export function formatCommentLocation(comment: ReviewComment): string {
 export function buildReviewPrompt(
   comments: ReviewComment[],
   promptLabel: string,
+): string {
+  return buildCommentPrompt(
+    comments,
+    `Address this local code review feedback for ${promptLabel}.`,
+    "diff",
+  );
+}
+
+export function buildViewReviewPrompt(
+  comments: ReviewComment[],
+  promptLabel: string,
+): string {
+  return buildCommentPrompt(
+    comments,
+    `Address this code review feedback for ${promptLabel}.`,
+    "ts",
+  );
+}
+
+function buildCommentPrompt(
+  comments: ReviewComment[],
+  intro: string,
+  codeFenceLanguage: string,
 ): string {
   const body = comments
     .map((comment) => {
       const location = formatCommentLocation(comment);
       const excerpt = comment.lineText.trim()
-        ? `\n  Excerpt:\n\n\`\`\`diff\n${comment.lineText}\n\`\`\``
+        ? `\n  Excerpt:\n\n\`\`\`${codeFenceLanguage}\n${comment.lineText}\n\`\`\``
         : "";
       return `- \`${location}\` — ${comment.text}${excerpt}`;
     })
     .join("\n");
 
-  return `Address this local code review feedback for ${promptLabel}.\n\n## Review comments\n${body}\n\nPlease apply the feedback and summarize what changed.`;
+  return `${intro}\n\n## Review comments\n${body}\n\nPlease apply the feedback and summarize what changed.`;
 }

package/src/review/types.ts

@@ -48,6 +48,14 @@ export type PersistedAsk = {
   text: string;
 };
 
+export type WorkspaceCommentSummary = {
+  visible: number;
+  hiddenInCurrentFiles: number;
+  elsewhere: number;
+  stale: number;
+  orphaned: number;
+};
+
 export type DiffRenderMode = "unified" | "split";
 
 export type SplitDiffCell = {