pi-dev-team 0.2.0

package/knowledge/review-template.md

@@ -0,0 +1,104 @@
+# Code Review Report Template
+
+Use this template for non-JSON (`--json` not set) code review output.
+The orchestrator reads this file during Step 5 (Aggregate and report).
+
+---
+
+## Report Structure
+
+```
+# Code Review Summary
+
+**Overall: {PASS|WARN|FAIL}** — {1-sentence summary}
+**Date:** {ISO 8601}
+**Scope:** {file count} files ({uncommitted changes|--since <ref>|--path <dir>|full repo})
+**Health:** {🟢|🟠|🔴} ({see review-rubric.md for scoring})
+
+## Pre-Flight Gates
+
+| Gate | Result | Details |
+|------|--------|---------|
+| Lint | ✅/❌/➖ | {pass/fail/skipped} |
+| Type check | ✅/❌/➖ | {pass/fail/skipped} |
+| Secret scan | ✅/❌/➖ | {pass/fail/skipped} |
+| Semgrep | ✅/❌/➖ | {pass/fail/skipped} |
+| Pipeline | ✅/❌/➖ | {pass/fail/skipped} |
+
+## Agent Results
+
+| Agent | Status | Issues | Model |
+|-------|--------|--------|-------|
+| {name} | PASS/WARN/FAIL | {count} | {haiku/sonnet/opus} |
+| ... | | | |
+
+**Totals:** {N} errors, {N} warnings, {N} suggestions
+
+## Dispatch Failures
+
+| Agent | Attempts | Error |
+|-------|----------|-------|
+| {name} | 2 | {error text, e.g. "Tool result missing due to internal error"} |
+
+Gate NOT written: {N} lens(es) never ran and their retry also failed. Re-run
+/code-review to retry the missing lens(es).
+
+{Present only when one or more agents failed dispatch and then failed their
+single retry (issue #1752) — a lens that never ran. Never omit this section
+when it has at least one row, regardless of how the rest of the panel
+scored; omit it entirely on a clean run. A non-empty table here means the
+`.pr-review-passed` gate was not written this run — see SKILL.md step 9.}
+
+## Institutional Context
+
+{If REVIEW-CONTEXT.md was found, summarize key points that influenced the review.
+ Omit this section if no context file exists.}
+
+## Issues by File
+
+### {file path}
+
+| # | Severity | Agent | Message | Confidence |
+|---|----------|-------|---------|------------|
+| 1 | 🔴 error | security-review | {message} | high |
+| 2 | 🟠 warning | test-review | {message} | medium |
+| 3 | 💡 suggestion | naming-review | {message} | high |
+
+{Repeat for each file with issues, sorted by severity (errors first).}
+{Issues with confidence: none are marked [human review required].}
+
+## Recommendations
+
+Top 3 priorities synthesized across all agent findings:
+
+1. **{Priority 1}** — {1-2 sentences, cite agent and file}
+2. **{Priority 2}** — {1-2 sentences, cite agent and file}
+3. **{Priority 3}** — {1-2 sentences, cite agent and file}
+
+## Tool Availability
+
+| Tool | Available | Used By |
+|------|-----------|---------|
+| {MCP tool name} | ✅/❌ | {agent names} |
+| semgrep | ✅/❌ | pre-flight, security-review |
+
+{Omit this section if no optional tools were probed.}
+```
+
+## Severity Icons
+
+Use these consistently:
+
+| Severity | Icon |
+|----------|------|
+| error | 🔴 |
+| warning | 🟠 |
+| suggestion | 💡 |
+
+## Health Score Icons
+
+| Health | Icon |
+|--------|------|
+| Healthy | 🟢 |
+| Needs attention | 🟠 |
+| Critical | 🔴 |

package/knowledge/rule-fixtures/A02.insecure-random-js/negative.js

@@ -0,0 +1 @@
+const token = crypto.randomBytes(32).toString("hex");

package/knowledge/rule-fixtures/A02.insecure-random-js/positive.js

@@ -0,0 +1 @@
+const token = Math.random().toString(36);

package/knowledge/rule-fixtures/A02.weak-hashing-md5/negative.py

@@ -0,0 +1 @@
+import hashlib; hashlib.sha256(data).hexdigest()

package/knowledge/rule-fixtures/A02.weak-hashing-md5/positive.py

@@ -0,0 +1 @@
+import hashlib; hashlib.md5(password.encode()).hexdigest()

package/knowledge/rule-fixtures/A03.command-injection/negative.js

@@ -0,0 +1 @@
+execFile("ls", [safeArg]);

package/knowledge/rule-fixtures/A03.command-injection/positive.js

@@ -0,0 +1 @@
+const { exec } = require("child_process"); exec(`ls ${userInput}`)

package/knowledge/rule-fixtures/A03.sql-injection/negative.js

@@ -0,0 +1 @@
+db.query("SELECT * FROM users WHERE id = ?", [userId])

package/knowledge/rule-fixtures/A03.sql-injection/positive.js

@@ -0,0 +1 @@
+db.query(`SELECT * FROM users WHERE id = ${userId}`)

package/knowledge/rule-fixtures/A03.xss-innerhtml/negative.js

@@ -0,0 +1 @@
+el.textContent = userInput;

package/knowledge/rule-fixtures/A03.xss-innerhtml/positive.js

@@ -0,0 +1 @@
+el.innerHTML = userInput;

package/knowledge/rule-fixtures/A05.cors-wildcard/negative.js

@@ -0,0 +1 @@
+app.use(cors({ origin: "https://app.example.com" }));

package/knowledge/rule-fixtures/A05.cors-wildcard/positive.js

@@ -0,0 +1 @@
+app.use(cors({ origin: "*" }));

package/knowledge/rule-fixtures/A05.default-credentials/negative.js

@@ -0,0 +1 @@
+const user = process.env.DB_USER; const pass = process.env.DB_PASS;

package/knowledge/rule-fixtures/A05.default-credentials/positive.js

@@ -0,0 +1 @@
+const user = "admin"; const pass = "admin";

package/knowledge/rule-fixtures/A07.jwt-alg-none/negative.js

@@ -0,0 +1 @@
+jwt.verify(token, key, { algorithms: ["RS256"] });

package/knowledge/rule-fixtures/A07.jwt-alg-none/positive.js

@@ -0,0 +1 @@
+jwt.verify(token, key, { algorithms: ["none"] });

package/knowledge/rule-fixtures/A08.binary-formatter/negative.cs

@@ -0,0 +1 @@
+var data = JsonSerializer.Deserialize<T>(json);

package/knowledge/rule-fixtures/A08.binary-formatter/positive.cs

@@ -0,0 +1 @@
+var f = new BinaryFormatter(); f.Deserialize(stream);

package/knowledge/rule-fixtures/A08.js-eval/negative.js

@@ -0,0 +1 @@
+JSON.parse(userSuppliedJson);

package/knowledge/rule-fixtures/A08.js-eval/positive.js

@@ -0,0 +1 @@
+eval(userSuppliedCode);

package/knowledge/rule-fixtures/A08.object-input-stream/negative.java

@@ -0,0 +1 @@
+var obj = objectMapper.readValue(json, Foo.class);

package/knowledge/rule-fixtures/A08.object-input-stream/positive.java

@@ -0,0 +1 @@
+ObjectInputStream in = new ObjectInputStream(s); in.readObject();

package/knowledge/schemas/disposition-register-v1.json

@@ -0,0 +1,65 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://dev-team.local/schemas/disposition-register-v1.json",
+  "title": "Disposition register v1.0",
+  "description": "Output of fp-reduction (companion plugin). One disposition entry per unified finding processed. See security-primitives-contract.md for versioning.",
+  "type": "object",
+  "required": ["schema_version", "generated_at", "dispositioner", "entries"],
+  "additionalProperties": false,
+  "properties": {
+    "schema_version": { "type": "string", "const": "1.0" },
+    "generated_at": { "type": "string", "format": "date-time" },
+    "dispositioner": {
+      "type": "string",
+      "description": "Agent ID that produced this register. Typically 'fp-reduction'."
+    },
+    "reachability_tool": {
+      "type": "string",
+      "enum": ["joern-cpg", "llm-fallback"],
+      "description": "Which reachability source drove this register overall. Per-entry override via entries[*].reachability_source."
+    },
+    "entries": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "required": ["finding", "verdict", "reachability", "reachability_source", "exploitability", "dispositioned_at"],
+        "additionalProperties": false,
+        "properties": {
+          "finding": {
+            "$ref": "unified-finding-v1.json",
+            "description": "The unified finding being dispositioned, embedded verbatim (not a reference — the disposition register is self-contained for archival)."
+          },
+          "verdict": {
+            "type": "string",
+            "enum": ["true_positive", "likely_true_positive", "uncertain", "likely_false_positive", "false_positive"]
+          },
+          "reachability": {
+            "type": "object",
+            "required": ["reachable", "rationale"],
+            "additionalProperties": false,
+            "properties": {
+              "reachable": { "type": "boolean" },
+              "rationale": { "type": "string", "minLength": 20 }
+            }
+          },
+          "reachability_source": {
+            "type": "string",
+            "enum": ["joern-cpg", "llm-fallback"],
+            "description": "Per-entry override of the register-level reachability_tool. Drives the exec report's fallback banner logic (if any entry has reachability_source = llm-fallback, banner is shown)."
+          },
+          "exploitability": {
+            "type": "object",
+            "required": ["score", "rationale"],
+            "additionalProperties": false,
+            "properties": {
+              "score": { "type": "integer", "minimum": 0, "maximum": 10 },
+              "rationale": { "type": "string", "minLength": 20 }
+            }
+          },
+          "dispositioner": { "type": "string" },
+          "dispositioned_at": { "type": "string", "format": "date-time" }
+        }
+      }
+    }
+  }
+}

package/knowledge/schemas/recon-envelope-v1.json

@@ -0,0 +1,198 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://dev-team.local/schemas/recon-envelope-v1.json",
+  "title": "RECON envelope v1.0",
+  "description": "Finalized RECON envelope produced by the codebase-recon agent. Supersedes the v0.1 placeholder at evals/codebase-recon/expected-schema.json once the consumer plugin (security-assessment) loads. See plugins/dev-team/knowledge/security-primitives-contract.md for context.",
+  "type": "object",
+  "required": [
+    "schema_version",
+    "generated_at",
+    "repo",
+    "entry_points",
+    "languages",
+    "dependencies",
+    "architecture",
+    "security_surface",
+    "git_history"
+  ],
+  "additionalProperties": false,
+  "properties": {
+    "schema_version": { "type": "string", "const": "1.0" },
+    "generated_at": { "type": "string", "format": "date-time" },
+    "repo": {
+      "type": "object",
+      "required": ["name", "root", "package_manager"],
+      "additionalProperties": false,
+      "properties": {
+        "name": { "type": "string" },
+        "root": { "type": "string" },
+        "package_manager": {
+          "type": "string",
+          "enum": ["npm", "pnpm", "yarn", "pip", "poetry", "pipenv", "go-modules", "maven", "gradle", "cargo", "mixed", "unknown"]
+        },
+        "monorepo": { "type": "boolean" },
+        "workspaces": { "type": "array", "items": { "type": "string" } },
+        "vcs": {
+          "type": "object",
+          "description": "Added in v1.0. Distinguishes git/mercurial/none.",
+          "required": ["kind"],
+          "additionalProperties": false,
+          "properties": {
+            "kind": { "type": "string", "enum": ["git", "mercurial", "none"] },
+            "remote_host": { "type": ["string", "null"] },
+            "default_branch": { "type": ["string", "null"] }
+          }
+        }
+      }
+    },
+    "entry_points": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "required": ["path", "kind", "rationale"],
+        "additionalProperties": false,
+        "properties": {
+          "path": { "type": "string" },
+          "kind": { "type": "string", "enum": ["cli", "http-server", "worker", "lambda", "cron", "test-runner", "build-tool", "module-index", "other"] },
+          "rationale": { "type": "string" },
+          "language": { "type": "string" }
+        }
+      }
+    },
+    "languages": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "required": ["name", "file_count"],
+        "additionalProperties": false,
+        "properties": {
+          "name": { "type": "string" },
+          "file_count": { "type": "integer", "minimum": 1 },
+          "dominant_framework": { "type": ["string", "null"] }
+        }
+      }
+    },
+    "dependencies": {
+      "type": "object",
+      "additionalProperties": false,
+      "properties": {
+        "web": { "type": "array", "items": { "type": "string" } },
+        "data": { "type": "array", "items": { "type": "string" } },
+        "crypto": { "type": "array", "items": { "type": "string" } },
+        "auth": { "type": "array", "items": { "type": "string" } },
+        "messaging": { "type": "array", "items": { "type": "string" } },
+        "ml": { "type": "array", "items": { "type": "string" } },
+        "other_notable": { "type": "array", "items": { "type": "string" } }
+      }
+    },
+    "architecture": {
+      "type": "object",
+      "required": ["summary", "layers"],
+      "additionalProperties": false,
+      "properties": {
+        "summary": { "type": "string" },
+        "layers": {
+          "type": "array",
+          "items": {
+            "type": "object",
+            "required": ["name", "paths"],
+            "additionalProperties": false,
+            "properties": {
+              "name": { "type": "string" },
+              "paths": { "type": "array", "items": { "type": "string" } },
+              "purpose": { "type": "string" }
+            }
+          }
+        },
+        "notable_anti_patterns": {
+          "type": "array",
+          "description": "Added in v1.0. Open-ended notes from the recon pass (e.g. 'domain imports ORM directly in packages/core/src/user.ts').",
+          "items": { "type": "string" }
+        }
+      }
+    },
+    "security_surface": {
+      "type": "object",
+      "required": ["auth_paths", "network_egress", "secrets_referenced", "crypto_calls"],
+      "additionalProperties": false,
+      "properties": {
+        "auth_paths": { "type": "array", "items": { "type": "string" } },
+        "network_egress": { "type": "array", "items": { "type": "string" } },
+        "secrets_referenced": { "type": "array", "items": { "type": "string" } },
+        "crypto_calls": { "type": "array", "items": { "type": "string" } },
+        "ml_models_loaded": { "type": "array", "items": { "type": "string" } },
+        "csp_headers": {
+          "type": "array",
+          "description": "Added in v1.0. Files declaring Content-Security-Policy headers (surface discovery only).",
+          "items": { "type": "string" }
+        }
+      }
+    },
+    "git_history": {
+      "type": "object",
+      "required": ["branches", "recent_activity", "sensitive_file_history"],
+      "additionalProperties": false,
+      "properties": {
+        "branches": {
+          "type": "object",
+          "required": ["current", "main_count", "feature_count", "names"],
+          "additionalProperties": false,
+          "properties": {
+            "current": { "type": "string" },
+            "main_count": { "type": "integer", "minimum": 0 },
+            "feature_count": { "type": "integer", "minimum": 0 },
+            "names": { "type": "array", "items": { "type": "string" } }
+          }
+        },
+        "recent_activity": {
+          "type": "object",
+          "required": ["last_commit_date", "commits_last_30d", "authors_last_30d"],
+          "additionalProperties": false,
+          "properties": {
+            "last_commit_date": { "type": "string", "format": "date-time" },
+            "commits_last_30d": { "type": "integer", "minimum": 0 },
+            "authors_last_30d": { "type": "integer", "minimum": 0 }
+          }
+        },
+        "sensitive_file_history": {
+          "type": "array",
+          "items": {
+            "type": "object",
+            "required": ["path", "in_current_tree", "appeared_in_history"],
+            "additionalProperties": false,
+            "properties": {
+              "path": { "type": "string" },
+              "in_current_tree": { "type": "boolean" },
+              "appeared_in_history": { "type": "boolean" },
+              "first_seen_commit": { "type": ["string", "null"] },
+              "removed_commit": { "type": ["string", "null"] }
+            }
+          }
+        }
+      }
+    },
+    "file_inventory": {
+      "type": "object",
+      "description": "Added in v1.2.0. Pointer to the sibling inventory file memory/recon-<slug>.inventory.txt. Object is optional at schema level (backward-compat with pre-1.2.0 envelopes); codebase-recon always emits it from 1.2.0 forward.",
+      "required": ["source", "count", "sibling_ref"],
+      "additionalProperties": false,
+      "properties": {
+        "source": {
+          "type": "string",
+          "enum": ["git-ls-files", "filesystem-walk"],
+          "description": "Enumeration branch: git-ls-files (git target) or filesystem-walk (non-git target)."
+        },
+        "count": {
+          "type": "integer",
+          "minimum": 0,
+          "description": "Number of lines in the sibling file. MUST equal wc -l of memory/recon-<slug>.inventory.txt."
+        },
+        "sibling_ref": {
+          "type": "string",
+          "description": "Basename of the sibling inventory file, e.g. 'recon-ts-monorepo.inventory.txt'."
+        }
+      }
+    },
+    "notes": { "type": "array", "items": { "type": "string" } }
+  }
+}

package/knowledge/schemas/unified-finding-v1.json

@@ -0,0 +1,72 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "https://dev-team.local/schemas/unified-finding-v1.json",
+  "title": "Unified finding envelope v1.0",
+  "description": "Narrow normalization of a SARIF result object. One instance per finding produced by any review agent or static-analysis adapter. See security-primitives-contract.md for versioning policy.",
+  "type": "object",
+  "required": ["rule_id", "file", "line", "severity", "message", "metadata"],
+  "additionalProperties": false,
+  "properties": {
+    "rule_id": {
+      "type": "string",
+      "pattern": "^[a-z0-9_-]+(\\.[a-z0-9_-]+)+$",
+      "description": "Dotted path: <source>.<language?>.<rule>. Examples: 'semgrep.python.hardcoded-password', 'gitleaks.generic.aws-access-key', 'security-review.auth.missing-csrf'."
+    },
+    "file": {
+      "type": "string",
+      "description": "Repo-relative POSIX path. No leading slash. No absolute paths."
+    },
+    "line": {
+      "type": "integer",
+      "minimum": 1,
+      "description": "1-indexed line number of the finding's primary location."
+    },
+    "column": { "type": "integer", "minimum": 1 },
+    "end_line": { "type": "integer", "minimum": 1 },
+    "end_column": { "type": "integer", "minimum": 1 },
+    "severity": {
+      "type": "string",
+      "enum": ["error", "warning", "suggestion", "info"]
+    },
+    "message": {
+      "type": "string",
+      "description": "One-line human-readable summary. Multi-line detail belongs in metadata.",
+      "maxLength": 500
+    },
+    "cwe": {
+      "type": "array",
+      "items": { "type": "string", "pattern": "^CWE-[0-9]+$" }
+    },
+    "cve": {
+      "type": "array",
+      "items": { "type": "string", "pattern": "^CVE-[0-9]{4}-[0-9]+$" }
+    },
+    "owasp": {
+      "type": "array",
+      "items": { "type": "string" }
+    },
+    "metadata": {
+      "type": "object",
+      "required": ["source", "confidence"],
+      "additionalProperties": true,
+      "properties": {
+        "source": {
+          "type": "string",
+          "description": "Tool or agent that produced this finding. Examples: 'semgrep', 'gitleaks', 'security-review', 'trivy'."
+        },
+        "confidence": {
+          "type": "string",
+          "enum": ["high", "medium", "low", "none"]
+        },
+        "source_ref": {
+          "description": "Opaque pointer to the raw tool output for debugging. Shape is NOT contract-stable; consumers MUST not depend on it.",
+          "type": ["string", "object", "null"]
+        },
+        "exploitability": {
+          "type": "string",
+          "enum": ["demonstrated", "plausible", "theoretical", "unknown"]
+        }
+      }
+    }
+  }
+}