pi-cursor-sdk 0.1.32 → 0.1.34

package/scripts/platform-smoke.mjs

@@ -3,8 +3,7 @@
 import { createRequire } from "node:module";
 import { resolve, dirname } from "node:path";
 import { fileURLToPath } from "node:url";
-import { accessSync, constants, readFileSync } from "node:fs";
-import { spawnSync } from "node:child_process";
+import { accessSync, constants } from "node:fs";
 
 // ── helpers ────────────────────────────────────────────────────────────────
 const __filename = fileURLToPath(import.meta.url);
@@ -47,11 +46,11 @@ Environment:
   PLATFORM_SMOKE_MAC_HOST         macOS SSH host (default: localhost)
   PLATFORM_SMOKE_MAC_USER         macOS SSH user (default: \$USER)
   PLATFORM_SMOKE_MAC_WORK_ROOT    macOS work root
-  PLATFORM_SMOKE_WINDOWS_VM       Parallels source VM name
-  PLATFORM_SMOKE_WINDOWS_SNAPSHOT Snapshot name
-  PLATFORM_SMOKE_WINDOWS_USER     Windows SSH user
-  PLATFORM_SMOKE_UBUNTU_IMAGE        Ubuntu container image
-  PLATFORM_SMOKE_WINDOWS_NATIVE_WORK_ROOT  Windows native work root
+  PLATFORM_SMOKE_UBUNTU_IMAGE     Ubuntu container image
+  PLATFORM_SMOKE_WINDOWS_VM       Parallels source VM override (default from config)
+  PLATFORM_SMOKE_WINDOWS_SNAPSHOT Snapshot override (default from config)
+  PLATFORM_SMOKE_WINDOWS_USER     Windows SSH user override (default: \$USER)
+  PLATFORM_SMOKE_WINDOWS_NATIVE_WORK_ROOT  Windows native work root override (default from config)
 `);
 }
 
@@ -90,17 +89,17 @@ function parseArgs(argv) {
 	return args;
 }
 
-function assertHostReleaseVersionGuard() {
-	const packageJson = JSON.parse(readFileSync(resolve(repoRoot, "package.json"), "utf8"));
-	const result = spawnSync("git", ["tag", "--list", "v[0-9]*.[0-9]*.[0-9]*", "--sort=-v:refname"], {
-		cwd: repoRoot,
-		encoding: "utf8",
-	});
-	if (result.status !== 0) throw new Error(`failed to inspect release tags: ${result.stderr || result.error?.message || "unknown git error"}`);
-	const latestTag = result.stdout.split(/\r?\n/).find((tag) => tag.length > 0);
-	if (!latestTag) throw new Error("no local release tags found; cannot enforce package version reuse guard");
-	const latestVersion = latestTag.replace(/^v/, "");
-	if (packageJson.version === latestVersion) throw new Error(`package version ${packageJson.version} reuses latest release tag ${latestTag}`);
+function validateSelections(targets, suites) {
+	const allowedTargets = new Set(config.requiredTargets ?? []);
+	const allowedSuites = new Set(config.requiredSuites ?? []);
+	const badTargets = targets.filter((target) => !allowedTargets.has(target));
+	const badSuites = suites.filter((suite) => !allowedSuites.has(suite));
+	if (badTargets.length > 0) {
+		throw new Error(`unknown target(s): ${badTargets.join(", ")}; allowed: ${[...allowedTargets].join(", ")}`);
+	}
+	if (badSuites.length > 0) {
+		throw new Error(`unknown suite(s): ${badSuites.join(", ")}; allowed: ${[...allowedSuites].join(", ")}`);
+	}
 }
 
 // ── commands ───────────────────────────────────────────────────────────────
@@ -158,7 +157,6 @@ async function main() {
 	}
 
 	if (args.command === "run") {
-		assertHostReleaseVersionGuard();
 		const targets = args.target
 			? args.target.split(",").map((s) => s.trim()).filter(Boolean)
 			: config.requiredTargets;
@@ -167,6 +165,13 @@ async function main() {
 			? [args.suite]
 			: config.requiredSuites;
 
+		try {
+			validateSelections(targets, suites);
+		} catch (err) {
+			console.error(err.message);
+			process.exit(2);
+		}
+
 		const targetRuns = targets.map(async (targetName) => {
 			console.log(`\n=== Target: ${targetName} ===`);
 			const result = args.suite

package/src/cursor-live-run-coordinator.ts

@@ -11,6 +11,7 @@ import type { CursorNativeToolDisplayItem } from "./cursor-native-tool-display.j
 import type { CursorPiBridgeToolRequest, CursorPiToolBridgeRun } from "./cursor-pi-tool-bridge.js";
 import { getCursorSessionScopeKey } from "./cursor-session-scope.js";
 import type { CursorSdkEventDebugRecorder } from "./cursor-sdk-event-debug.js";
+import { installCursorSdkProcessErrorGuard } from "./cursor-sdk-process-error-guard.js";
 
 export class CursorLiveRunAbortError extends Error {
 	constructor() {
@@ -118,6 +119,17 @@ interface LeaseWaiter {
 	onAbort?: () => void;
 }
 
+async function cancelCursorLiveSdkRun(run: CursorLiveRun): Promise<void> {
+	if (!run.sdkRun) return;
+	const guard = installCursorSdkProcessErrorGuard();
+	guard.suppressAbortErrors();
+	try {
+		await run.sdkRun.cancel();
+	} finally {
+		guard.dispose();
+	}
+}
+
 interface CursorLiveRunPrivateState {
 	waiters: Set<ProgressWaiter>;
 	idleDisposeTimer?: ReturnType<typeof setTimeout>;
@@ -474,7 +486,7 @@ export function createCursorLiveRunCoordinator(deps: CursorLiveRunCoordinatorDep
 				if (abandoned) {
 					if (!run.done) {
 						try {
-							await run.sdkRun?.cancel();
+							await cancelCursorLiveSdkRun(run);
 						} catch {
 							// cancellation failure should not block session-agent abandonment
 						}

package/src/cursor-native-tool-display-registration.ts

@@ -39,7 +39,9 @@ function hasNonBuiltinTool(pi: Pick<ExtensionAPI, "getAllTools">, toolName: Nati
 	return existingTool !== undefined && existingTool.sourceInfo.source !== "builtin";
 }
 
-type NativeRegistrationContext = { hasUI: boolean; ui: Pick<ExtensionContext["ui"], "notify">; model?: ExtensionContext["model"] };
+type NativeRegistrationContext = Pick<ExtensionContext, "mode" | "model"> & {
+	ui: Pick<ExtensionContext["ui"], "notify">;
+};
 
 function registerNativeCursorToolsFromSet(
 	pi: CursorNativeToolRegistryApi,
@@ -60,7 +62,7 @@ function registerNativeCursorToolsFromSet(
 }
 
 function notifySkippedNativeCursorToolsIfNeeded(ctx: NativeRegistrationContext, skippedToolNames: readonly NativeCursorToolName[]): void {
-	if (skippedToolNames.length === 0 || readBooleanEnv(NATIVE_CURSOR_TOOL_DISPLAY_ENV) !== true || !ctx.hasUI) return;
+	if (skippedToolNames.length === 0 || readBooleanEnv(NATIVE_CURSOR_TOOL_DISPLAY_ENV) !== true || ctx.mode !== "tui") return;
 	ctx.ui.notify(
 		`Cursor native tool replay skipped for ${skippedToolNames.join(", ")} because another extension already provides ${skippedToolNames.length === 1 ? "that tool" : "those tools"}. Cursor will use scrubbed activity transcripts for skipped tools.`,
 		"warning",
@@ -101,7 +103,7 @@ function ensureNativeCursorToolsRegisteredForModel(pi: CursorNativeToolRegistryA
 		skippedNativeToolNames.clear();
 		return;
 	}
-	if (!isCursorModel(ctx.model) || hasAttemptedNativeCursorToolRegistration()) return;
+	if (ctx.mode !== "tui" || !isCursorModel(ctx.model) || hasAttemptedNativeCursorToolRegistration()) return;
 
 	const nonCoreToolNames = NATIVE_CURSOR_TOOL_NAMES.filter((toolName) => !isCursorCorePiReplayToolName(toolName));
 	const skippedToolNames = [

package/src/cursor-provider-errors.ts

@@ -60,13 +60,15 @@ function getCursorConnectSource(error: unknown, record: Record<string, unknown>
 		const type = getErrorStringField(asRecord(detail), "type");
 		return typeof type === "string" && type.startsWith("aiserver.");
 	});
-	return hasCursorBackendDetails ? "cursor-backend-details" : "generic-connect";
+	if (hasCursorBackendDetails) return "cursor-backend-details";
+	return stack.includes("@connectrpc/connect-node") ? "connect-node-stack" : "generic-connect";
 }
 
 export type CursorConnectErrorSource =
 	| "cursor-sdk-stack"
 	| "cursor-extension-connect-stack"
 	| "cursor-backend-details"
+	| "connect-node-stack"
 	| "generic-connect";
 
 export type CursorConnectErrorClassification =

package/src/cursor-question-tool.ts

@@ -204,23 +204,12 @@ export function registerCursorQuestionTool(pi: CursorQuestionToolExtensionApi):
 		async execute(_toolCallId, params, _signal, _onUpdate, ctx) {
 			const questions = normalizeQuestions(params as CursorAskQuestionParams);
 			if (questions.length === 0) {
-				return {
-					content: [{ type: "text" as const, text: "No valid question was provided." }],
-					details: buildDetails([], [], ctx.hasUI),
-					isError: true,
-				};
+				throw new Error("No valid question was provided.");
 			}
 			if (!ctx.hasUI) {
-				return {
-					content: [
-						{
-							type: "text" as const,
-							text: "Cannot ask the user because pi UI is unavailable. Make a reasonable default choice and state the assumption before proceeding.",
-						},
-					],
-					details: buildDetails(questions, [], false),
-					isError: true,
-				};
+				throw new Error(
+					"Cannot ask the user because pi UI is unavailable. Make a reasonable default choice and state the assumption before proceeding.",
+				);
 			}
 
 			const answers: CursorQuestionAnswer[] = [];

package/src/cursor-sdk-process-error-guard.ts

@@ -13,7 +13,7 @@ type GenericProcessEmit = (event: string | symbol, ...args: unknown[]) => boolea
 
 // The local Cursor SDK can surface some ConnectRPC failures as process-level
 // uncaught exceptions/unhandled rejections even when run.wait()/run.cancel() is awaited.
-// Keep suppression scoped to active Cursor provider turns and tightly matched SDK shapes.
+// Keep suppression scoped to active Cursor provider turns and tightly matched ConnectRPC shapes.
 const activeProviderTurns = new Set<CursorSdkProcessErrorGuardToken>();
 let originalProcessEmit: GenericProcessEmit | undefined;
 let captureCallbackInstalled = false;
@@ -35,7 +35,9 @@ function shouldSuppressProcessError(event: string | symbol, args: readonly unkno
 	const classification = classifyCursorConnectError(error);
 	if (!classification) return false;
 	if (classification.kind === "abort") return hasActiveAbortSuppression();
-	return activeProviderTurns.size > 0 && isCursorProvenance(classification.source);
+	if (activeProviderTurns.size === 0) return false;
+	if (classification.kind === "network") return isCursorProvenance(classification.source) || classification.source === "connect-node-stack";
+	return isCursorProvenance(classification.source);
 }
 
 function installProcessEmitPatch(): void {

package/src/cursor-skill-tool.ts

@@ -197,19 +197,13 @@ export function registerCursorSkillTool(pi: CursorSkillToolExtensionApi): void {
 		async execute(_toolCallId, params) {
 			const requestedName = (params as CursorActivateSkillParams).name?.trim();
 			if (!requestedName) {
-				return {
-					content: [{ type: "text" as const, text: "No skill name was provided." }],
-					details: buildActivationDetails(undefined),
-					isError: true,
-				};
+				throw new Error("No skill name was provided.");
 			}
 			const skill = currentSkillsByName.get(requestedName);
 			if (!skill) {
-				return {
-					content: [{ type: "text" as const, text: `Skill not available: ${requestedName}. Available skills: ${getAvailableSkillNames().join(", ") || "none"}.` }],
-					details: buildActivationDetails(undefined),
-					isError: true,
-				};
+				throw new Error(
+					`Skill not available: ${requestedName}. Available skills: ${getAvailableSkillNames().join(", ") || "none"}.`,
+				);
 			}
 
 			try {
@@ -222,16 +216,9 @@ export function registerCursorSkillTool(pi: CursorSkillToolExtensionApi): void {
 					details: buildActivationDetails(skill, resources),
 				};
 			} catch (error) {
-				return {
-					content: [
-						{
-							type: "text" as const,
-							text: `Failed to load skill ${requestedName} from ${skill.filePath}: ${error instanceof Error ? error.message : String(error)}`,
-						},
-					],
-					details: buildActivationDetails(skill),
-					isError: true,
-				};
+				throw new Error(
+					`Failed to load skill ${requestedName} from ${skill.filePath}: ${error instanceof Error ? error.message : String(error)}`,
+				);
 			}
 		},
 	});

package/src/cursor-state.ts

@@ -255,7 +255,7 @@ function persistCursorModePreference(pi: Pick<ExtensionAPI, "appendEntry">, mode
 	}
 }
 
-function restoreCliCursorMode(raw: boolean | string | undefined, hasUI: boolean, notify: ExtensionContext["ui"]["notify"]): void {
+function restoreCliCursorMode(raw: boolean | string | undefined, mode: ExtensionContext["mode"], notify: ExtensionContext["ui"]["notify"]): void {
 	cliCursorModeState = { kind: "unset" };
 	if (raw === undefined || raw === "" || raw === false) return;
 	const parsed = parseCursorAgentMode(raw);
@@ -266,7 +266,7 @@ function restoreCliCursorMode(raw: boolean | string | undefined, hasUI: boolean,
 	const rawText = String(raw);
 	const message = formatInvalidCursorMode(rawText);
 	cliCursorModeState = { kind: "invalid", raw: rawText, message };
-	if (hasUI) {
+	if (mode === "tui") {
 		notify(message, "error");
 		return;
 	}
@@ -435,7 +435,7 @@ export function registerCursorRuntimeControls(pi: CursorRuntimeControlsExtension
 		cliForceNoFast = pi.getFlag("cursor-no-fast") === true;
 		restoreSessionFastPreferences(ctx);
 		restoreSessionCursorMode(ctx);
-		restoreCliCursorMode(pi.getFlag("cursor-mode"), ctx.hasUI, ctx.ui.notify.bind(ctx.ui));
+		restoreCliCursorMode(pi.getFlag("cursor-mode"), ctx.mode, ctx.ui.notify.bind(ctx.ui));
 		updateCursorStatus(ctx);
 	});