pi-crew 0.9.68 → 0.10.2

package/src/state/stores/instinct-store.ts

@@ -1,275 +0,0 @@
-import { randomUUID } from "node:crypto";
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { assertSafePathId } from "../../utils/safe-paths.ts";
-import { atomicWriteFile } from "../atomic-write.ts";
-
-/**
- * Represents a learned instinct that guides agent behavior.
- * Instincts can be project-scoped or global.
- */
-export interface Instinct {
-	/** Unique identifier for this instinct */
-	id: string;
-	/** What triggers this instinct */
-	trigger: string;
-	/** What action to take when triggered */
-	action: string;
-	/** Confidence level: 0.3 (low), 0.6 (medium), 0.9 (high) */
-	confidence: 0.3 | 0.6 | 0.9;
-	/** Whether this instinct applies to a project or globally */
-	scope: "project" | "global";
-	/** Project identifier (undefined for global instincts) */
-	projectId?: string;
-	/** ISO timestamp of when this instinct was created */
-	createdAt: string;
-	/** Examples/evidence supporting this instinct */
-	evidence: string[];
-}
-
-/** Input type for creating a new instinct (excludes auto-generated fields) */
-export type NewInstinct = Omit<Instinct, "id" | "createdAt">;
-
-const INSTINCT_FILE = "instincts.jsonl";
-
-/**
- * InstinctStore manages persistence of learned instincts using JSONL files.
- * - Project instincts: `.crew/instincts/projects/{projectId}/instincts.jsonl`
- * - Global instincts: `.crew/instincts/global/instincts.jsonl`
- */
-export class InstinctStore {
-	private readonly crewRoot: string;
-
-	constructor(crewRoot: string) {
-		this.crewRoot = crewRoot;
-	}
-
-	/**
-	 * Get the file path for project instincts
-	 */
-	private getProjectInstinctPath(projectId: string): string {
-		return path.join(this.crewRoot, "instincts", "projects", projectId, INSTINCT_FILE);
-	}
-
-	/**
-	 * Get the file path for global instincts
-	 */
-	private getGlobalInstinctPath(): string {
-		return path.join(this.crewRoot, "instincts", "global", INSTINCT_FILE);
-	}
-
-	/**
-	 * Ensure a directory exists, creating it recursively if needed
-	 */
-	private ensureDir(dirPath: string): void {
-		fs.mkdirSync(dirPath, { recursive: true });
-	}
-
-	/**
-	 * Parse a JSONL file and return all instincts
-	 */
-	private readInstinctsFromFile(filePath: string): Instinct[] {
-		if (!fs.existsSync(filePath)) {
-			return [];
-		}
-		try {
-			const content = fs.readFileSync(filePath, "utf-8");
-			const lines = content.split("\n").filter((line) => line.trim() !== "");
-			return lines.map((line) => JSON.parse(line) as Instinct);
-		} catch {
-			// If file is corrupted, return empty array
-			return [];
-		}
-	}
-
-	/**
-	 * Append a single instinct to a JSONL file
-	 */
-	private appendInstinctToFile(filePath: string, instinct: Instinct): void {
-		const dir = path.dirname(filePath);
-		this.ensureDir(dir);
-		// ST-3: read existing + append + atomic rewrite. appendFileSync has no fsync and
-		// can interleave bytes on concurrent writes. Callers should wrap this in
-		// withFileLockSync(filePath) to serialize concurrent RMW on the same file.
-		const existing = fs.existsSync(filePath) ? this.readInstinctsFromFile(filePath) : [];
-		existing.push(instinct);
-		const content = existing.map((i) => JSON.stringify(i)).join("\n") + "\n";
-		atomicWriteFile(filePath, content);
-	}
-
-	/**
-	 * Rewrite a JSONL file with the given instincts
-	 */
-	private rewriteFile(filePath: string, instincts: Instinct[]): void {
-		const dir = path.dirname(filePath);
-		this.ensureDir(dir);
-		const content = instincts.map((i) => JSON.stringify(i)).join("\n") + "\n";
-		// ST-3: atomic write (temp + rename + fsync) — crash mid-writeFileSync truncates
-		// the JSONL and readInstinctsFromFile silently returns [] (all instincts lost).
-		atomicWriteFile(filePath, content);
-	}
-
-	/**
-	 * Save a new instinct with auto-generated id and timestamp.
-	 * Direct scope is determined by the instinct's scope field.
-	 *
-	 * @param instinct - The instinct to save (without id and createdAt)
-	 * @returns The saved instinct with generated id and createdAt
-	 */
-	saveInstinct(instinct: NewInstinct): Instinct {
-		const savedInstinct: Instinct = {
-			...instinct,
-			id: randomUUID(),
-			createdAt: new Date().toISOString(),
-		};
-
-		if (savedInstinct.scope === "global") {
-			savedInstinct.projectId = undefined;
-			this.appendInstinctToFile(this.getGlobalInstinctPath(), savedInstinct);
-		} else {
-			if (!savedInstinct.projectId) {
-				throw new Error("Project-scoped instinct requires a projectId");
-			}
-			assertSafePathId("projectId", savedInstinct.projectId);
-			this.appendInstinctToFile(this.getProjectInstinctPath(savedInstinct.projectId), savedInstinct);
-		}
-
-		return savedInstinct;
-	}
-
-	/**
-	 * Get all instincts, optionally filtered by scope.
-	 *
-	 * @param scope - Optional filter: 'project' or 'global'
-	 * @returns Array of instincts matching the filter
-	 */
-	getInstincts(scope?: "project" | "global"): Instinct[] {
-		const results: Instinct[] = [];
-
-		if (!scope || scope === "project") {
-			const projectsDir = path.join(this.crewRoot, "instincts", "projects");
-			if (fs.existsSync(projectsDir)) {
-				for (const projectId of fs
-					.readdirSync(projectsDir, { withFileTypes: true })
-					.filter((e) => e.isDirectory())
-					.map((e) => e.name)) {
-					const filePath = path.join(projectsDir, projectId, INSTINCT_FILE);
-					results.push(...this.readInstinctsFromFile(filePath));
-				}
-			}
-		}
-
-		if (!scope || scope === "global") {
-			results.push(...this.readInstinctsFromFile(this.getGlobalInstinctPath()));
-		}
-
-		return results;
-	}
-
-	/**
-	 * Get all instincts for a specific project.
-	 * Includes both project-scoped instincts and global instincts.
-	 *
-	 * @param projectId - The project identifier
-	 * @returns Array of instincts for the project
-	 */
-	getProjectInstincts(projectId: string): Instinct[] {
-		assertSafePathId("projectId", projectId);
-		const projectInstincts = this.readInstinctsFromFile(this.getProjectInstinctPath(projectId));
-		const globalInstincts = this.readInstinctsFromFile(this.getGlobalInstinctPath());
-		return [...projectInstincts, ...globalInstincts];
-	}
-
-	/**
-	 * Promote a project-scoped instinct to global scope.
-	 * Creates a copy in global instincts and removes from project.
-	 *
-	 * @param instinctId - The instinct id to promote
-	 * @returns The promoted instinct, or null if not found
-	 */
-	promoteInstinct(instinctId: string): Instinct | null {
-		// Search in all project instinct files
-		const projectsDir = path.join(this.crewRoot, "instincts", "projects");
-		if (fs.existsSync(projectsDir)) {
-			for (const projectId of fs
-				.readdirSync(projectsDir, { withFileTypes: true })
-				.filter((e) => e.isDirectory())
-				.map((e) => e.name)) {
-				assertSafePathId("projectId", projectId);
-				const filePath = path.join(projectsDir, projectId, INSTINCT_FILE);
-				const instincts = this.readInstinctsFromFile(filePath);
-				const index = instincts.findIndex((i) => i.id === instinctId);
-
-				if (index !== -1) {
-					const instinct = instincts[index];
-
-					// Create promoted version (global)
-					const promotedInstinct: Instinct = {
-						...instinct,
-						id: randomUUID(), // New id for promoted instinct
-						scope: "global",
-						projectId: undefined,
-						createdAt: new Date().toISOString(),
-					};
-
-					// Add to global instincts
-					this.appendInstinctToFile(this.getGlobalInstinctPath(), promotedInstinct);
-
-					// Remove from project instincts
-					const updatedInstincts = instincts.filter((i) => i.id !== instinctId);
-					this.rewriteFile(filePath, updatedInstincts);
-
-					return promotedInstinct;
-				}
-			}
-		}
-
-		return null;
-	}
-
-	/**
-	 * Delete an instinct by id.
-	 *
-	 * @param instinctId - The instinct id to delete
-	 * @returns true if deleted, false if not found
-	 */
-	deleteInstinct(instinctId: string): boolean {
-		// Search in global instincts first
-		const globalPath = this.getGlobalInstinctPath();
-		let instincts = this.readInstinctsFromFile(globalPath);
-		let index = instincts.findIndex((i) => i.id === instinctId);
-
-		if (index !== -1) {
-			const updatedInstincts = instincts.filter((i) => i.id !== instinctId);
-			this.rewriteFile(globalPath, updatedInstincts);
-			return true;
-		}
-
-		// Search in project instincts
-		const projectsDir = path.join(this.crewRoot, "instincts", "projects");
-		if (fs.existsSync(projectsDir)) {
-			for (const projectId of fs
-				.readdirSync(projectsDir, { withFileTypes: true })
-				.filter((e) => e.isDirectory())
-				.map((e) => e.name)) {
-				assertSafePathId("projectId", projectId);
-				const filePath = path.join(projectsDir, projectId, INSTINCT_FILE);
-				instincts = this.readInstinctsFromFile(filePath);
-				index = instincts.findIndex((i) => i.id === instinctId);
-
-				if (index !== -1) {
-					const updatedInstincts = instincts.filter((i) => i.id !== instinctId);
-					this.rewriteFile(filePath, updatedInstincts);
-					return true;
-				}
-			}
-		}
-
-		return false;
-	}
-}
-
-export {
-	getGlobalStorageDir,
-	getProjectStorageDir,
-} from "../../utils/project-detector.ts";

package/src/state/stores/observation-store.ts

@@ -1,176 +0,0 @@
-import { existsSync, readFileSync } from "node:fs";
-import { logInternalError } from "../../utils/internal-error.ts";
-import { atomicWriteJson } from "../atomic-write.ts";
-
-// ── Types ────────────────────────────────────────────────────────────────
-
-export interface Observation {
-	tool: string;
-	input: string;
-	output: string;
-	filesRead: string[];
-	filesModified: string[];
-	timestamp: number;
-	sessionId: string;
-	taskId?: string;
-}
-
-export interface CompressedObservation {
-	summary: string;
-	patterns: string[];
-	decisions: string[];
-	filesAffected: string[];
-	relevanceScore: number;
-	timestamp: number;
-	sessionId: string;
-}
-
-export interface ObservationStoreConfig {
-	maxObservations: number;
-	maxCompressed: number;
-	privacyTags: string[]; // tags to strip before storage
-}
-
-const DEFAULT_CONFIG: ObservationStoreConfig = {
-	maxObservations: 1000,
-	maxCompressed: 200,
-	privacyTags: ["<private>", "<secret>", "<credentials>"],
-};
-
-// ── Privacy ──────────────────────────────────────────────────────────────
-
-/**
- * Strip privacy-tagged content from a string.
- */
-export function stripPrivacyTags(content: string, config = DEFAULT_CONFIG): string {
-	let result = content;
-	for (const tag of config.privacyTags) {
-		const openTag = tag;
-		const closeTag = tag.replace("<", "</");
-		// Remove everything between open and close tags
-		const regex = new RegExp(`${escapeRegex(openTag)}[\\s\\S]*?${escapeRegex(closeTag)}`, "gi");
-		result = result.replace(regex, "[REDACTED]");
-	}
-	return result;
-}
-
-function escapeRegex(str: string): string {
-	return str.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
-}
-
-// ── Observation Store ────────────────────────────────────────────────────
-
-export class ObservationStore {
-	private observations: Observation[] = [];
-	private compressed: CompressedObservation[] = [];
-	private config: ObservationStoreConfig;
-	private storePath: string;
-
-	constructor(storePath: string, config: Partial<ObservationStoreConfig> = {}) {
-		this.config = { ...DEFAULT_CONFIG, ...config };
-		this.storePath = storePath;
-		if (existsSync(storePath)) {
-			this.load();
-		}
-	}
-
-	/**
-	 * Record a new observation.
-	 */
-	record(observation: Observation): void {
-		// Strip privacy
-		const sanitized: Observation = {
-			...observation,
-			input: stripPrivacyTags(observation.input, this.config),
-			output: stripPrivacyTags(observation.output, this.config),
-		};
-
-		this.observations.push(sanitized);
-
-		// Enforce capacity
-		if (this.observations.length > this.config.maxObservations) {
-			this.observations = this.observations.slice(-this.config.maxObservations);
-		}
-	}
-
-	/**
-	 * Get recent observations.
-	 */
-	getRecent(count = 10): Observation[] {
-		return this.observations.slice(-count);
-	}
-
-	/**
-	 * Store a compressed observation.
-	 */
-	addCompressed(compressed: CompressedObservation): void {
-		this.compressed.push(compressed);
-
-		if (this.compressed.length > this.config.maxCompressed) {
-			this.compressed = this.compressed.slice(-this.config.maxCompressed);
-		}
-	}
-
-	/**
-	 * Get compressed observations for injection.
-	 */
-	getCompressed(limit = 5): CompressedObservation[] {
-		return this.compressed.sort((a, b) => b.relevanceScore - a.relevanceScore).slice(0, limit);
-	}
-
-	/**
-	 * Format compressed observations for prompt injection.
-	 */
-	injectCompressed(limit = 5): string {
-		const items = this.getCompressed(limit);
-		if (items.length === 0) return "";
-
-		return (
-			"## Observations from Previous Sessions\n\n" +
-			items
-				.map(
-					(o) =>
-						`### ${o.summary}\n` +
-						`Patterns: ${o.patterns.join(", ")}\n` +
-						`Decisions: ${o.decisions.join(", ")}\n` +
-						`Files: ${o.filesAffected.join(", ")}`,
-				)
-				.join("\n\n") +
-			"\n"
-		);
-	}
-
-	/**
-	 * Persist to disk.
-	 */
-	save(): void {
-		try {
-			// BUGFIX (Round 12 I4): use atomicWriteJson (temp-file + rename) instead
-			// of raw writeFileSync, so a crash mid-write cannot leave a truncated /
-			// empty file that breaks load() on restart.
-			atomicWriteJson(this.storePath, {
-				observations: this.observations,
-				compressed: this.compressed,
-			});
-		} catch (error) {
-			logInternalError("observation-store.save", error, `path=${this.storePath}`);
-		}
-	}
-
-	get stats(): { observations: number; compressed: number } {
-		return {
-			observations: this.observations.length,
-			compressed: this.compressed.length,
-		};
-	}
-
-	private load(): void {
-		try {
-			const data = JSON.parse(readFileSync(this.storePath, "utf-8"));
-			if (Array.isArray(data.observations)) this.observations = data.observations;
-			if (Array.isArray(data.compressed)) this.compressed = data.compressed;
-		} catch (error) {
-			logInternalError("observation-store.load", error, `path=${this.storePath}`);
-		}
-	}
-}