pi-crew 0.9.56 → 0.9.57

package/scripts/bench-cold-start.mjs

@@ -1,216 +0,0 @@
-#!/usr/bin/env node
-/**
- * Cold-start benchmark: bundle vs strip-types.
- *
- * Compares two entry paths from a fresh node process:
- *   - STRIP-TYPES: node --experimental-strip-types loads src/extension/register.ts
- *                   (or src/extension/index.ts via the package entry)
- *   - BUNDLE:      node loads dist/index.mjs (esbuild-bundled 2.9MB single file)
- *
- * For each path we spawn N child node processes and measure:
- *   - totalMs: time from process spawn to its exit
- *   - importMs: time the child reports for `await import(...)`
- *   - registerMs: time the child reports for registerPiTeams(mockPi)
- *
- * We report:
- *   - per-path median, p95, max for each metric
- *   - bundle vs strip-types speedup (negative = bundle faster)
- *
- * Usage:
- *   node scripts/bench-cold-start.mjs                  # default 10 iters
- *   node scripts/bench-cold-start.mjs --iters 20
- *
- * Output goes to stdout as JSON plus a human-readable summary.
- */
-import { execFileSync, spawnSync } from "node:child_process";
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { pathToFileURL } from "node:url";
-
-const root = path.resolve(import.meta.dirname, "..");
-const args = process.argv.slice(2);
-let iters = 10;
-for (let i = 0; i < args.length; i++) {
-	if (args[i] === "--iters" && args[i + 1]) {
-		iters = Number(args[i + 1]);
-		i++;
-	}
-}
-
-// Driver template. We capture wall-clock per sample using performance.now()
-// and emit JSON lines (one per sample). The outer harness parses them.
-const driverTemplate = (entrySpec, registerImport) => `
-import { performance } from "node:perf_hooks";
-
-const tSpawn = performance.now();
-
-function createEvents() {
-	const handlers = new Map();
-	return {
-		on(event, handler) {
-			const set = handlers.get(event) ?? new Set();
-			set.add(handler);
-			handlers.set(event, set);
-			return () => set.delete(handler);
-		},
-		emit(event, payload) {
-			for (const h of handlers.get(event) ?? []) h(payload);
-		},
-	};
-}
-
-const mockPi = {
-	cwd: process.cwd(),
-	events: createEvents(),
-	hasUI: false,
-	getFlag: () => undefined,
-	getAllFlags: () => ({}),
-	settings: {},
-	storage: undefined,
-	on() {},
-	registerTool() {},
-	registerCommand() {},
-	appendEntry: async () => undefined,
-	sendMessage: async () => undefined,
-	sendUserMessage: async () => undefined,
-};
-
-const tImport0 = performance.now();
-const entry = await import(${JSON.stringify(entrySpec)});
-const tImportMs = performance.now() - tImport0;
-
-const register = ${registerImport};
-
-const tReg0 = performance.now();
-register(mockPi);
-const tRegMs = performance.now() - tReg0;
-
-const tTotal = performance.now();
-process.stdout.write(JSON.stringify({
-	total: tTotal - tSpawn,
-	import: tImportMs,
-	register: tRegMs,
-	defaultKind: typeof entry.default,
-	hasRegister: typeof ${registerImport === "entry.registerPiTeams" ? "entry.registerPiTeams" : "register"},
-}) + "\\n");
-`;
-
-async function runPath(label, entrySpec, registerImport, itersCount) {
-	const driverPath = path.join(root, `.bench-${label}-${process.pid}.mjs`);
-	const driverSrc = driverTemplate(entrySpec, registerImport);
-	fs.writeFileSync(driverPath, driverSrc, "utf-8");
-
-	const cmd = label === "strip-types"
-		? ["--experimental-strip-types", "--no-warnings", driverPath]
-		: ["--no-warnings", driverPath];
-
-	const samples = [];
-	for (let i = 0; i < itersCount; i++) {
-		const t0 = performance.now();
-		const r = spawnSync(process.execPath, cmd, { encoding: "utf-8", cwd: root });
-		const wall = performance.now() - t0;
-		if (r.status !== 0) {
-			console.error(`[bench:${label}] iter ${i} failed:`, r.stderr?.slice(0, 200));
-			continue;
-		}
-		const lastLine = r.stdout.trim().split("\n").pop();
-		try {
-			const sample = JSON.parse(lastLine);
-			samples.push({ ...sample, wall });
-		} catch {
-			console.error(`[bench:${label}] iter ${i} parse error:`, lastLine);
-		}
-	}
-
-	fs.unlinkSync(driverPath);
-	return samples;
-}
-
-function stats(arr) {
-	const sorted = [...arr].sort((a, b) => a - b);
-	const p = (q) => sorted[Math.min(sorted.length - 1, Math.floor((sorted.length - 1) * q))];
-	return {
-		n: sorted.length,
-		min: sorted[0],
-		p50: p(0.5),
-		p95: p(0.95),
-		max: sorted[sorted.length - 1],
-		mean: sorted.reduce((s, x) => s + x, 0) / sorted.length,
-	};
-}
-
-function pctDelta(newer, older) {
-	// positive = newer is slower than older
-	return (((newer - older) / older) * 100).toFixed(1);
-}
-
-console.log(`[bench] Running ${iters} iters per path...`);
-console.log("");
-
-const stripSpec = pathToFileURL(path.join(root, "src/extension/register.ts")).href;
-const stripRegister = "(await import(" + JSON.stringify(stripSpec) + ")).registerPiTeams";
-const stripSamples = await runPath("strip-types", stripSpec, stripRegister, iters);
-
-const bundleSpec = pathToFileURL(path.join(root, "dist/index.mjs")).href;
-const bundleRegister = "(await import(" + JSON.stringify(bundleSpec) + ")).registerPiTeams";
-const bundleSamples = await runPath("bundle", bundleSpec, bundleRegister, iters);
-
-if (stripSamples.length === 0 || bundleSamples.length === 0) {
-	console.error("[bench] insufficient samples; aborting");
-	process.exit(1);
-}
-
-const summary = {
-	timestamp: new Date().toISOString(),
-	iters,
-	strip: {
-		total: stats(stripSamples.map((s) => s.total)),
-		import: stats(stripSamples.map((s) => s.import)),
-		register: stats(stripSamples.map((s) => s.register)),
-		wall: stats(stripSamples.map((s) => s.wall)),
-	},
-	bundle: {
-		total: stats(bundleSamples.map((s) => s.total)),
-		import: stats(bundleSamples.map((s) => s.import)),
-		register: stats(bundleSamples.map((s) => s.register)),
-		wall: stats(bundleSamples.map((s) => s.wall)),
-	},
-};
-
-// Speedup = strip - bundle (positive = bundle faster)
-summary.speedup = {
-	total: summary.strip.total.p50 - summary.bundle.total.p50,
-	totalPct: pctDelta(summary.bundle.total.p50, summary.strip.total.p50),
-	import: summary.strip.import.p50 - summary.bundle.import.p50,
-	importPct: pctDelta(summary.bundle.import.p50, summary.strip.import.p50),
-	register: summary.strip.register.p50 - summary.bundle.register.p50,
-	registerPct: pctDelta(summary.bundle.register.p50, summary.strip.register.p50),
-	wall: summary.strip.wall.p50 - summary.bundle.wall.p50,
-	wallPct: pctDelta(summary.bundle.wall.p50, summary.strip.wall.p50),
-};
-
-// Print human-readable summary
-console.log("=== Cold-start benchmark: strip-types vs bundle ===\n");
-
-const printPath = (label, data) => {
-	console.log(`  ${label}:`);
-	console.log(`    total (child process wall-clock):  p50=${data.total.p50.toFixed(1)}ms  p95=${data.total.p95.toFixed(1)}ms  min=${data.total.min.toFixed(1)}ms`);
-	console.log(`    import (await import(...)):         p50=${data.import.p50.toFixed(1)}ms  p95=${data.import.p95.toFixed(1)}ms`);
-	console.log(`    register (registerPiTeams(mockPi)): p50=${data.register.p50.toFixed(1)}ms  p95=${data.register.p95.toFixed(1)}ms`);
-	console.log("");
-};
-
-printPath("STRIP-TYPES (--experimental-strip-types + 1100 .ts files)", summary.strip);
-printPath("BUNDLE      (dist/index.mjs, 2.9MB single file)", summary.bundle);
-
-console.log(`  Speedup (bundle vs strip-types, p50):`);
-console.log(`    total:        ${summary.speedup.total >= 0 ? "FASTER" : "SLOWER"} by ${Math.abs(summary.speedup.total).toFixed(1)}ms (${summary.speedup.totalPct}%)`);
-console.log(`    import:       ${summary.speedup.import >= 0 ? "FASTER" : "SLOWER"} by ${Math.abs(summary.speedup.import).toFixed(1)}ms (${summary.speedup.importPct}%)`);
-console.log(`    register:     ${summary.speedup.register >= 0 ? "FASTER" : "SLOWER"} by ${Math.abs(summary.speedup.register).toFixed(1)}ms (${summary.speedup.registerPct}%)`);
-console.log(`    outer wall:   ${summary.speedup.wall >= 0 ? "FASTER" : "SLOWER"} by ${Math.abs(summary.speedup.wall).toFixed(1)}ms (${summary.speedup.wallPct}%)`);
-
-const benchDir = path.join(root, ".bench");
-fs.mkdirSync(benchDir, { recursive: true });
-const outFile = path.join(benchDir, `cold-start-${Date.now()}.json`);
-fs.writeFileSync(outFile, JSON.stringify(summary, null, 2) + "\n", "utf-8");
-console.log(`\n[bench] Raw results: ${outFile}`);

package/scripts/build-bundle.mjs

@@ -1,92 +0,0 @@
-#!/usr/bin/env node
-/**
- * 5.5 — Bundle pi-crew into a single ESM file using esbuild.
- *
- * Output:
- *   dist/index.mjs        — bundled extension entrypoint
- *   dist/index.mjs.map    — source map
- *
- * Pi peer dependencies are kept external. Bundling shrinks parse+module-
- * resolution cost on cold start: with strip-types Node still has to parse
- * each .ts file individually, so a single .mjs cuts the per-file overhead.
- *
- * This script is invoked by `npm run build:bundle`. The `package.json#exports`
- * field is configured so:
- *   - `dist/index.mjs` is the preferred entrypoint when present (set by Pi
- *     extension loader via "pi.extensions").
- *   - `index.ts` remains the fallback when dist/ is missing (e.g. running
- *     directly out of a clone without prior build).
- */
-import { build } from "esbuild";
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { fileURLToPath } from "node:url";
-
-const here = path.dirname(fileURLToPath(import.meta.url));
-const root = path.resolve(here, "..");
-
-const distDir = path.join(root, "dist");
-fs.mkdirSync(distDir, { recursive: true });
-
-const start = Date.now();
-const result = await build({
-	// Bundle entry must be the bare extension (index.bundle.ts) NOT the
-	// entry shell (index.ts). If we bundled index.ts, the bundled code
-	// would re-resolve dist/index.mjs relative to ITS OWN location
-	// (file:///.../dist/index.mjs), producing dist/dist/index.mjs and a
-	// recursion error. index.bundle.ts has no shell logic so this is
-	// a clean single-file bundle. See index.bundle.ts header for details.
-	entryPoints: [path.join(root, "index.bundle.ts")],
-	bundle: true,
-	format: "esm",
-	platform: "node",
-	target: "node22",
-	outfile: path.join(distDir, "index.mjs"),
-	sourcemap: true,
-	logLevel: "info",
-	// Keep peer deps external so consumers' Pi versions resolve naturally.
-	external: [
-		"@earendil-works/pi-coding-agent",
-		"@earendil-works/pi-ai",
-		"@earendil-works/pi-agent-core",
-		"@earendil-works/pi-tui",
-		// Direct deps as well — bundling their full graph would inflate the
-		// output and override consumer-installed versions.
-		"cli-highlight",
-		"diff",
-		"jiti",
-		"@sinclair/typebox",
-		"acorn",
-		// esbuild must stay external: its CJS source references __filename/__dirname
-		// (CJS globals) for self-location. Bundling it into the ESM .mjs makes those
-		// undefined at runtime → "__filename is not defined" when the dynamic-workflow
-		// runner (or strip-types loader) invokes esbuild transformSync. Keeping it
-		// external lets it resolve from node_modules as proper CJS. (esbuild also
-		// ships a native binary, which shouldn't be bundled anyway.)
-		"esbuild",
-	],
-	// All node:* and Node-builtin modules are external by default for
-	// platform=node, but list explicitly for clarity.
-	//
-	// CJS-shim banner: pi-crew's dependency graph includes CommonJS modules
-	// (notably `yaml`) whose source calls `require("process")` etc. esbuild
-	// emits these as runtime `__require(...)` calls; in a pure-ESM context
-	// `require` is undefined, so we inject a `createRequire`-backed shim
-	// at the top of the bundle. This is the standard pattern for shipping
-	// CJS-mixed bundles as `.mjs`. See phase-2 H2 investigation (2026-06-30).
-	banner: {
-		js:
-			"// pi-crew bundled by scripts/build-bundle.mjs (5.5)\n" +
-			"// CJS-shim for legacy deps (yaml, etc.) that call require() in ESM context.\n" +
-			"import { createRequire as __piCrewCreateRequire } from 'node:module';\n" +
-			"const require = __piCrewCreateRequire(import.meta.url);\n" +
-			"const module = { exports: {} };\n" +
-			"const exports = module.exports;\n",
-	},
-	metafile: true,
-});
-
-fs.writeFileSync(path.join(distDir, "build-meta.json"), JSON.stringify(result.metafile, null, 2) + "\n", "utf-8");
-const elapsedMs = Date.now() - start;
-const stat = fs.statSync(path.join(distDir, "index.mjs"));
-console.log(`[build-bundle] dist/index.mjs ${(stat.size / 1024).toFixed(1)} KB in ${elapsedMs} ms`);

package/scripts/check-all-skills.ts

@@ -1,294 +0,0 @@
-#!/usr/bin/env node
-
-/**
- * Check All Skills Script
- *
- * Runs verify-skill.ts against all skills and produces a summary report.
- *
- * Usage:
- *   node scripts/check-all-skills.ts
- */
-
-import { spawnSync } from "node:child_process";
-import * as fs from "node:fs";
-import * as path from "node:path";
-
-interface SkillSummary {
-	name: string;
-	path: string;
-	status: "pass" | "fail" | "warning";
-	warnings: string[];
-	errors: string[];
-}
-
-interface Report {
-	total: number;
-	passed: number;
-	failed: number;
-	warningsOnly: number;
-	skills: SkillSummary[];
-	timestamp: string;
-}
-
-const SKILLS_DIR = path.join(process.cwd(), "skills");
-
-/**
- * Get all skill directories
- */
-function getSkillDirs(): string[] {
-	if (!fs.existsSync(SKILLS_DIR)) {
-		console.error("Skills directory not found: " + SKILLS_DIR);
-		return [];
-	}
-
-	const dirs: string[] = [];
-	const entries = fs.readdirSync(SKILLS_DIR, { withFileTypes: true });
-
-	for (const entry of entries) {
-		if (entry.isDirectory()) {
-			const skillPath = path.join(SKILLS_DIR, entry.name, "SKILL.md");
-			if (fs.existsSync(skillPath)) {
-				dirs.push(entry.name);
-			}
-		}
-	}
-
-	return dirs.sort();
-}
-
-/**
- * Run verify-skill.ts for a single skill
- */
-function verifySingleSkill(skillName: string): {
-	passed: boolean;
-	warnings: string[];
-	errors: string[];
-} {
-	const skillPath = path.join(SKILLS_DIR, skillName, "SKILL.md");
-
-	const result = spawnSync("node", ["scripts/verify-skill.ts", skillPath], {
-		cwd: process.cwd(),
-		encoding: "utf-8",
-	});
-
-	const output = result.stdout + result.stderr;
-	const warnings: string[] = [];
-	const errors: string[] = [];
-
-	// Parse output
-	const warningMatches = output.match(/[^\n]*⚠️[^\n]*/g);
-	const errorMatches = output.match(/[^\n]+FAIL[^\n]+/g);
-
-	if (warningMatches) {
-		warnings.push(...warningMatches.map((w) => w.trim()));
-	}
-	if (errorMatches) {
-		errors.push(...errorMatches.map((e) => e.trim()));
-	}
-
-	const passed = result.status === 0;
-
-	return { passed, warnings, errors };
-}
-
-/**
- * Generate markdown report
- */
-function generateMarkdownReport(report: Report): string {
-	const lines: string[] = [];
-
-	lines.push("# Skill Verification Report");
-	lines.push("");
-	lines.push("Generated: " + report.timestamp);
-	lines.push("");
-
-	// Summary table
-	lines.push("## Summary");
-	lines.push("");
-	lines.push("| Status | Count |");
-	lines.push("|--------|-------|");
-	lines.push("| PASS | " + report.passed + " |");
-	lines.push("| FAIL | " + report.failed + " |");
-	lines.push("| Warnings | " + report.warningsOnly + " |");
-	lines.push("| **Total** | **" + report.total + "** |");
-	lines.push("");
-
-	// Skill list by status
-	lines.push("## Skills by Status");
-	lines.push("");
-
-	// Passed skills
-	const passedSkills = report.skills.filter((s) => s.status === "pass");
-	if (passedSkills.length > 0) {
-		lines.push("### Passing Skills");
-		lines.push("");
-		for (const skill of passedSkills) {
-			lines.push("- " + skill.name);
-		}
-		lines.push("");
-	}
-
-	// Failed skills
-	const failedSkills = report.skills.filter((s) => s.status === "fail");
-	if (failedSkills.length > 0) {
-		lines.push("### Failing Skills");
-		lines.push("");
-		for (const skill of failedSkills) {
-			lines.push("- **" + skill.name + "**");
-			for (const error of skill.errors) {
-				lines.push("  - " + error);
-			}
-		}
-		lines.push("");
-	}
-
-	// Warning skills
-	const warningSkills = report.skills.filter((s) => s.status === "warning");
-	if (warningSkills.length > 0) {
-		lines.push("### Skills with Warnings");
-		lines.push("");
-		for (const skill of warningSkills) {
-			lines.push("- **" + skill.name + "**");
-			for (const warning of skill.warnings) {
-				lines.push("  - " + warning);
-			}
-		}
-		lines.push("");
-	}
-
-	// Recommendations
-	lines.push("## Recommendations");
-	lines.push("");
-	if (failedSkills.length > 0) {
-		lines.push("1. Fix " + failedSkills.length + " failing skills to have proper RED/GREEN gates");
-		lines.push("2. Add trigger sections (When to Activate) if missing");
-		lines.push("3. Add anti-patterns sections to prevent common mistakes");
-		lines.push("");
-	}
-	if (warningSkills.length > 0) {
-		lines.push("4. Review " + warningSkills.length + " skills with warnings for improvements");
-	}
-
-	return lines.join("\n");
-}
-
-/**
- * Generate JSON report
- */
-function generateJsonReport(report: Report): string {
-	return JSON.stringify(report, null, 2);
-}
-
-/**
- * Main entry point
- */
-async function main() {
-	console.log("Checking all skills...\n");
-
-	const skillNames = getSkillDirs();
-	console.log("Found " + skillNames.length + " skills\n");
-
-	const report: Report = {
-		total: skillNames.length,
-		passed: 0,
-		failed: 0,
-		warningsOnly: 0,
-		skills: [],
-		timestamp: new Date().toISOString(),
-	};
-
-	for (const skillName of skillNames) {
-		process.stdout.write(".");
-
-		const result = verifySingleSkill(skillName);
-
-		let status: "pass" | "fail" | "warning" = "pass";
-		if (!result.passed && result.errors.length > 0) {
-			status = "fail";
-			report.failed++;
-		} else if (result.warnings.length > 0) {
-			status = "warning";
-			report.warningsOnly++;
-		} else {
-			report.passed++;
-		}
-
-		report.skills.push({
-			name: skillName,
-			path: path.join("skills", skillName, "SKILL.md"),
-			status,
-			warnings: result.warnings,
-			errors: result.errors,
-		});
-	}
-
-	console.log("\n\n");
-
-	// Print summary
-	console.log("=== Skill Verification Summary ===");
-	console.log("Total: " + report.total);
-	console.log("Passed: " + report.passed);
-	console.log("Failed: " + report.failed);
-	console.log("Warnings only: " + report.warningsOnly);
-	console.log("");
-
-	// List failed skills
-	if (report.failed > 0) {
-		console.log("Failing skills:");
-		for (const skill of report.skills.filter((s) => s.status === "fail")) {
-			console.log("  - " + skill.name);
-			for (const error of skill.errors) {
-				console.log("    " + error);
-			}
-		}
-		console.log("");
-	}
-
-	// List skills with warnings
-	if (report.warningsOnly > 0) {
-		console.log("Skills with warnings:");
-		for (const skill of report.skills.filter((s) => s.status === "warning")) {
-			console.log("  - " + skill.name);
-			for (const warning of skill.warnings) {
-				console.log("    " + warning);
-			}
-		}
-		console.log("");
-	}
-
-	// Write reports
-	const reportDir = path.join(process.cwd(), "reports");
-	if (!fs.existsSync(reportDir)) {
-		fs.mkdirSync(reportDir, { recursive: true });
-	}
-
-	const timestamp = new Date().toISOString().replace(/[:.]/g, "-");
-	const mdReportPath = path.join(reportDir, "skill-verification-" + timestamp + ".md");
-	const jsonReportPath = path.join(reportDir, "skill-verification-" + timestamp + ".json");
-	const latestMdPath = path.join(reportDir, "skill-verification-latest.md");
-	const latestJsonPath = path.join(reportDir, "skill-verification-latest.json");
-
-	fs.writeFileSync(mdReportPath, generateMarkdownReport(report));
-	fs.writeFileSync(jsonReportPath, generateJsonReport(report));
-	fs.writeFileSync(latestMdPath, generateMarkdownReport(report));
-	fs.writeFileSync(latestJsonPath, generateJsonReport(report));
-
-	console.log("Reports written to:");
-	console.log("  - " + mdReportPath);
-	console.log("  - " + jsonReportPath);
-	console.log("  - " + latestMdPath + " (latest)");
-	console.log("  - " + latestJsonPath + " (latest)");
-
-	// Exit with appropriate code
-	if (report.failed > 0) {
-		process.exit(1);
-	} else if (report.warningsOnly > 0) {
-		process.exit(2);
-	}
-	process.exit(0);
-}
-
-main().catch((err) => {
-	console.error("Fatal error:", err);
-	process.exit(1);
-});

package/scripts/check-bundle-size.mjs

@@ -1,38 +0,0 @@
-#!/usr/bin/env node
-/**
- * CI gate: enforce a max size budget on dist/index.mjs.
- *
- * The bundle is the cold-start entrypoint (preferred over strip-types
- * loading since v0.9.17). A growing bundle directly increases parse
- * time and npm install cost. This guard FAILS the build if the bundle
- * exceeds the budget, surfacing regressions early.
- *
- * Budget: 3.5 MB (see ROADMAP-2026-07-27 Sprint 6 CI-4).
- *
- * Exits:
- *   0 — bundle is within budget (or absent, deferring to build:bundle)
- *   1 — bundle exceeds budget
- */
-
-import { existsSync, statSync } from "node:fs";
-
-const BUDGET_BYTES = 3.5 * 1024 * 1024; // 3.5 MB
-const distPath = "dist/index.mjs";
-
-if (!existsSync(distPath)) {
-	console.log("[check-bundle-size] dist/index.mjs absent — nothing to check. OK.");
-	process.exit(0);
-}
-
-const sizeBytes = statSync(distPath).size;
-
-if (sizeBytes > BUDGET_BYTES) {
-	console.error(
-		`[check-bundle-size] FAIL: dist/index.mjs (${(sizeBytes / 1024 / 1024).toFixed(2)} MB) exceeds budget (${(BUDGET_BYTES / 1024 / 1024).toFixed(1)} MB).`,
-	);
-	process.exit(1);
-}
-
-console.log(
-	`[check-bundle-size] OK: dist/index.mjs is ${(sizeBytes / 1024 / 1024).toFixed(2)} MB (budget ${(BUDGET_BYTES / 1024 / 1024).toFixed(1)} MB).`,
-);