pi-crew 0.9.55 → 0.9.57

package/index.bundle.ts

@@ -1,25 +0,0 @@
-/**
- * Bundle entry point — NO shell logic.
- *
- * Bundled by `scripts/build-bundle.mjs` into `dist/index.mjs`. Keep this
- * file minimal — the bundle should NOT try to recursively load itself
- * or do path resolution. The shell (load-with-fallback) lives in
- * `index.ts`; this file just re-exports the inner extension API so the
- * bundle is a single self-contained module the shell can `import()`.
- *
- * Why a separate file from `index.ts`:
- *   - `index.ts` runs at the package root and resolves `dist/index.mjs`
- *     relative to its own location.
- *   - If the bundle were built FROM `index.ts`, the bundled code would
- *     resolve `dist/index.mjs` relative to ITS OWN location (inside
- *     `dist/`), producing `dist/dist/index.mjs` and a recursion error.
- *   - Building from `index.bundle.ts` (which has no shell) sidesteps
- *     this chicken-and-egg entirely.
- */
-import { registerPiTeams } from "./src/extension/register.ts";
-import { waitForRun } from "./src/runtime/run-tracker.ts";
-
-export { waitForRun, registerPiTeams };
-export default function (pi: Parameters<typeof registerPiTeams>[0]): void {
-	registerPiTeams(pi);
-}

package/scripts/bench-check.mjs

@@ -1,96 +0,0 @@
-#!/usr/bin/env node
-/**
- * Compare test/bench/results.json against test/bench/baseline.json.
- *
- * Fails if any p95 metric regresses by more than the allowed threshold.
- *
- * Usage:
- *   npm run bench:check                      # default 15% threshold
- *   THRESHOLD_PCT=10 npm run bench:check     # tighter
- *   BASELINE=test/bench/baseline.json npm run bench:check
- */
-import * as fs from "node:fs";
-import * as path from "node:path";
-
-const root = path.resolve(import.meta.dirname, "..");
-const benchDir = path.join(root, "test", "bench");
-const resultsPath = path.join(benchDir, "results.json");
-const baselinePath = process.env.BASELINE ? path.resolve(process.env.BASELINE) : path.join(benchDir, "baseline.json");
-const threshold = Number(process.env.THRESHOLD_PCT ?? 15) / 100;
-
-if (!fs.existsSync(resultsPath)) {
-	console.error(`[bench:check] missing ${resultsPath}; run \`npm run bench\` first.`);
-	process.exit(2);
-}
-if (!fs.existsSync(baselinePath)) {
-	console.error(`[bench:check] missing baseline ${baselinePath}.`);
-	console.error("              Capture baseline with: npm run bench && cp test/bench/results.json test/bench/baseline.json");
-	process.exit(2);
-}
-
-const results = JSON.parse(fs.readFileSync(resultsPath, "utf-8"));
-const baseline = JSON.parse(fs.readFileSync(baselinePath, "utf-8"));
-
-/**
- * Walk each bench's nested numeric metrics and pair with baseline.
- * Reports any p95 metric where current > baseline * (1 + threshold).
- */
-const regressions = [];
-const improvements = [];
-for (const [benchName, current] of Object.entries(results.results)) {
-	const base = baseline.results?.[benchName];
-	if (!base) {
-		console.log(`[bench:check] no baseline for ${benchName} — skipping`);
-		continue;
-	}
-	for (const metric of metricKeys(current)) {
-		const cur = readPath(current, metric);
-		const ref = readPath(base, metric);
-		if (typeof cur !== "number" || typeof ref !== "number" || ref === 0) continue;
-		// Sub-ms metrics are dominated by GC / OS jitter — applying a strict
-		// percentage gate causes false positives. Use absolute delta cap instead.
-		if (ref < 1.0) {
-			const absDelta = cur - ref;
-			if (absDelta > 0.5) regressions.push({ bench: benchName, metric: metric.join("."), baseline: ref, current: cur, deltaPct: round(((cur - ref) / ref) * 100), reason: "abs > 0.5ms" });
-			else if (absDelta < -0.05) improvements.push({ bench: benchName, metric: metric.join("."), baseline: ref, current: cur, deltaPct: round(((cur - ref) / ref) * 100) });
-			continue;
-		}
-		const delta = (cur - ref) / ref;
-		if (delta > threshold) regressions.push({ bench: benchName, metric: metric.join("."), baseline: ref, current: cur, deltaPct: round(delta * 100) });
-		else if (delta < -0.05) improvements.push({ bench: benchName, metric: metric.join("."), baseline: ref, current: cur, deltaPct: round(delta * 100) });
-	}
-}
-
-if (improvements.length) {
-	console.log("[bench:check] improvements:");
-	for (const item of improvements) console.log(`  ${item.bench}.${item.metric}: ${item.baseline} → ${item.current} (${item.deltaPct}%)`);
-}
-if (regressions.length) {
-	console.error(`[bench:check] regressions (>${(threshold * 100).toFixed(0)}%):`);
-	for (const item of regressions) console.error(`  ${item.bench}.${item.metric}: ${item.baseline} → ${item.current} (+${item.deltaPct}%)`);
-	process.exit(1);
-}
-console.log(`[bench:check] all benches within ${(threshold * 100).toFixed(0)}% of baseline.`);
-
-function metricKeys(obj, prefix = []) {
-	const skip = new Set(["name", "unit", "iters", "tasks", "events", "eventsPerIter"]);
-	const keys = [];
-	for (const [k, v] of Object.entries(obj)) {
-		if (skip.has(k)) continue;
-		if (k === "p50" || k === "p95" || k === "p99" || k === "min" || k === "max") {
-			// We only gate on p95; min/max printed but not enforced.
-			if (k === "p95") keys.push([...prefix, k]);
-			continue;
-		}
-		if (v && typeof v === "object" && !Array.isArray(v)) keys.push(...metricKeys(v, [...prefix, k]));
-	}
-	return keys;
-}
-
-function readPath(obj, parts) {
-	let cur = obj;
-	for (const p of parts) cur = cur?.[p];
-	return cur;
-}
-
-function round(n) { return Math.round(n * 100) / 100; }

package/scripts/bench-cold-start.mjs

@@ -1,216 +0,0 @@
-#!/usr/bin/env node
-/**
- * Cold-start benchmark: bundle vs strip-types.
- *
- * Compares two entry paths from a fresh node process:
- *   - STRIP-TYPES: node --experimental-strip-types loads src/extension/register.ts
- *                   (or src/extension/index.ts via the package entry)
- *   - BUNDLE:      node loads dist/index.mjs (esbuild-bundled 2.9MB single file)
- *
- * For each path we spawn N child node processes and measure:
- *   - totalMs: time from process spawn to its exit
- *   - importMs: time the child reports for `await import(...)`
- *   - registerMs: time the child reports for registerPiTeams(mockPi)
- *
- * We report:
- *   - per-path median, p95, max for each metric
- *   - bundle vs strip-types speedup (negative = bundle faster)
- *
- * Usage:
- *   node scripts/bench-cold-start.mjs                  # default 10 iters
- *   node scripts/bench-cold-start.mjs --iters 20
- *
- * Output goes to stdout as JSON plus a human-readable summary.
- */
-import { execFileSync, spawnSync } from "node:child_process";
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { pathToFileURL } from "node:url";
-
-const root = path.resolve(import.meta.dirname, "..");
-const args = process.argv.slice(2);
-let iters = 10;
-for (let i = 0; i < args.length; i++) {
-	if (args[i] === "--iters" && args[i + 1]) {
-		iters = Number(args[i + 1]);
-		i++;
-	}
-}
-
-// Driver template. We capture wall-clock per sample using performance.now()
-// and emit JSON lines (one per sample). The outer harness parses them.
-const driverTemplate = (entrySpec, registerImport) => `
-import { performance } from "node:perf_hooks";
-
-const tSpawn = performance.now();
-
-function createEvents() {
-	const handlers = new Map();
-	return {
-		on(event, handler) {
-			const set = handlers.get(event) ?? new Set();
-			set.add(handler);
-			handlers.set(event, set);
-			return () => set.delete(handler);
-		},
-		emit(event, payload) {
-			for (const h of handlers.get(event) ?? []) h(payload);
-		},
-	};
-}
-
-const mockPi = {
-	cwd: process.cwd(),
-	events: createEvents(),
-	hasUI: false,
-	getFlag: () => undefined,
-	getAllFlags: () => ({}),
-	settings: {},
-	storage: undefined,
-	on() {},
-	registerTool() {},
-	registerCommand() {},
-	appendEntry: async () => undefined,
-	sendMessage: async () => undefined,
-	sendUserMessage: async () => undefined,
-};
-
-const tImport0 = performance.now();
-const entry = await import(${JSON.stringify(entrySpec)});
-const tImportMs = performance.now() - tImport0;
-
-const register = ${registerImport};
-
-const tReg0 = performance.now();
-register(mockPi);
-const tRegMs = performance.now() - tReg0;
-
-const tTotal = performance.now();
-process.stdout.write(JSON.stringify({
-	total: tTotal - tSpawn,
-	import: tImportMs,
-	register: tRegMs,
-	defaultKind: typeof entry.default,
-	hasRegister: typeof ${registerImport === "entry.registerPiTeams" ? "entry.registerPiTeams" : "register"},
-}) + "\\n");
-`;
-
-async function runPath(label, entrySpec, registerImport, itersCount) {
-	const driverPath = path.join(root, `.bench-${label}-${process.pid}.mjs`);
-	const driverSrc = driverTemplate(entrySpec, registerImport);
-	fs.writeFileSync(driverPath, driverSrc, "utf-8");
-
-	const cmd = label === "strip-types"
-		? ["--experimental-strip-types", "--no-warnings", driverPath]
-		: ["--no-warnings", driverPath];
-
-	const samples = [];
-	for (let i = 0; i < itersCount; i++) {
-		const t0 = performance.now();
-		const r = spawnSync(process.execPath, cmd, { encoding: "utf-8", cwd: root });
-		const wall = performance.now() - t0;
-		if (r.status !== 0) {
-			console.error(`[bench:${label}] iter ${i} failed:`, r.stderr?.slice(0, 200));
-			continue;
-		}
-		const lastLine = r.stdout.trim().split("\n").pop();
-		try {
-			const sample = JSON.parse(lastLine);
-			samples.push({ ...sample, wall });
-		} catch {
-			console.error(`[bench:${label}] iter ${i} parse error:`, lastLine);
-		}
-	}
-
-	fs.unlinkSync(driverPath);
-	return samples;
-}
-
-function stats(arr) {
-	const sorted = [...arr].sort((a, b) => a - b);
-	const p = (q) => sorted[Math.min(sorted.length - 1, Math.floor((sorted.length - 1) * q))];
-	return {
-		n: sorted.length,
-		min: sorted[0],
-		p50: p(0.5),
-		p95: p(0.95),
-		max: sorted[sorted.length - 1],
-		mean: sorted.reduce((s, x) => s + x, 0) / sorted.length,
-	};
-}
-
-function pctDelta(newer, older) {
-	// positive = newer is slower than older
-	return (((newer - older) / older) * 100).toFixed(1);
-}
-
-console.log(`[bench] Running ${iters} iters per path...`);
-console.log("");
-
-const stripSpec = pathToFileURL(path.join(root, "src/extension/register.ts")).href;
-const stripRegister = "(await import(" + JSON.stringify(stripSpec) + ")).registerPiTeams";
-const stripSamples = await runPath("strip-types", stripSpec, stripRegister, iters);
-
-const bundleSpec = pathToFileURL(path.join(root, "dist/index.mjs")).href;
-const bundleRegister = "(await import(" + JSON.stringify(bundleSpec) + ")).registerPiTeams";
-const bundleSamples = await runPath("bundle", bundleSpec, bundleRegister, iters);
-
-if (stripSamples.length === 0 || bundleSamples.length === 0) {
-	console.error("[bench] insufficient samples; aborting");
-	process.exit(1);
-}
-
-const summary = {
-	timestamp: new Date().toISOString(),
-	iters,
-	strip: {
-		total: stats(stripSamples.map((s) => s.total)),
-		import: stats(stripSamples.map((s) => s.import)),
-		register: stats(stripSamples.map((s) => s.register)),
-		wall: stats(stripSamples.map((s) => s.wall)),
-	},
-	bundle: {
-		total: stats(bundleSamples.map((s) => s.total)),
-		import: stats(bundleSamples.map((s) => s.import)),
-		register: stats(bundleSamples.map((s) => s.register)),
-		wall: stats(bundleSamples.map((s) => s.wall)),
-	},
-};
-
-// Speedup = strip - bundle (positive = bundle faster)
-summary.speedup = {
-	total: summary.strip.total.p50 - summary.bundle.total.p50,
-	totalPct: pctDelta(summary.bundle.total.p50, summary.strip.total.p50),
-	import: summary.strip.import.p50 - summary.bundle.import.p50,
-	importPct: pctDelta(summary.bundle.import.p50, summary.strip.import.p50),
-	register: summary.strip.register.p50 - summary.bundle.register.p50,
-	registerPct: pctDelta(summary.bundle.register.p50, summary.strip.register.p50),
-	wall: summary.strip.wall.p50 - summary.bundle.wall.p50,
-	wallPct: pctDelta(summary.bundle.wall.p50, summary.strip.wall.p50),
-};
-
-// Print human-readable summary
-console.log("=== Cold-start benchmark: strip-types vs bundle ===\n");
-
-const printPath = (label, data) => {
-	console.log(`  ${label}:`);
-	console.log(`    total (child process wall-clock):  p50=${data.total.p50.toFixed(1)}ms  p95=${data.total.p95.toFixed(1)}ms  min=${data.total.min.toFixed(1)}ms`);
-	console.log(`    import (await import(...)):         p50=${data.import.p50.toFixed(1)}ms  p95=${data.import.p95.toFixed(1)}ms`);
-	console.log(`    register (registerPiTeams(mockPi)): p50=${data.register.p50.toFixed(1)}ms  p95=${data.register.p95.toFixed(1)}ms`);
-	console.log("");
-};
-
-printPath("STRIP-TYPES (--experimental-strip-types + 1100 .ts files)", summary.strip);
-printPath("BUNDLE      (dist/index.mjs, 2.9MB single file)", summary.bundle);
-
-console.log(`  Speedup (bundle vs strip-types, p50):`);
-console.log(`    total:        ${summary.speedup.total >= 0 ? "FASTER" : "SLOWER"} by ${Math.abs(summary.speedup.total).toFixed(1)}ms (${summary.speedup.totalPct}%)`);
-console.log(`    import:       ${summary.speedup.import >= 0 ? "FASTER" : "SLOWER"} by ${Math.abs(summary.speedup.import).toFixed(1)}ms (${summary.speedup.importPct}%)`);
-console.log(`    register:     ${summary.speedup.register >= 0 ? "FASTER" : "SLOWER"} by ${Math.abs(summary.speedup.register).toFixed(1)}ms (${summary.speedup.registerPct}%)`);
-console.log(`    outer wall:   ${summary.speedup.wall >= 0 ? "FASTER" : "SLOWER"} by ${Math.abs(summary.speedup.wall).toFixed(1)}ms (${summary.speedup.wallPct}%)`);
-
-const benchDir = path.join(root, ".bench");
-fs.mkdirSync(benchDir, { recursive: true });
-const outFile = path.join(benchDir, `cold-start-${Date.now()}.json`);
-fs.writeFileSync(outFile, JSON.stringify(summary, null, 2) + "\n", "utf-8");
-console.log(`\n[bench] Raw results: ${outFile}`);

package/scripts/build-bundle.mjs

@@ -1,92 +0,0 @@
-#!/usr/bin/env node
-/**
- * 5.5 — Bundle pi-crew into a single ESM file using esbuild.
- *
- * Output:
- *   dist/index.mjs        — bundled extension entrypoint
- *   dist/index.mjs.map    — source map
- *
- * Pi peer dependencies are kept external. Bundling shrinks parse+module-
- * resolution cost on cold start: with strip-types Node still has to parse
- * each .ts file individually, so a single .mjs cuts the per-file overhead.
- *
- * This script is invoked by `npm run build:bundle`. The `package.json#exports`
- * field is configured so:
- *   - `dist/index.mjs` is the preferred entrypoint when present (set by Pi
- *     extension loader via "pi.extensions").
- *   - `index.ts` remains the fallback when dist/ is missing (e.g. running
- *     directly out of a clone without prior build).
- */
-import { build } from "esbuild";
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { fileURLToPath } from "node:url";
-
-const here = path.dirname(fileURLToPath(import.meta.url));
-const root = path.resolve(here, "..");
-
-const distDir = path.join(root, "dist");
-fs.mkdirSync(distDir, { recursive: true });
-
-const start = Date.now();
-const result = await build({
-	// Bundle entry must be the bare extension (index.bundle.ts) NOT the
-	// entry shell (index.ts). If we bundled index.ts, the bundled code
-	// would re-resolve dist/index.mjs relative to ITS OWN location
-	// (file:///.../dist/index.mjs), producing dist/dist/index.mjs and a
-	// recursion error. index.bundle.ts has no shell logic so this is
-	// a clean single-file bundle. See index.bundle.ts header for details.
-	entryPoints: [path.join(root, "index.bundle.ts")],
-	bundle: true,
-	format: "esm",
-	platform: "node",
-	target: "node22",
-	outfile: path.join(distDir, "index.mjs"),
-	sourcemap: true,
-	logLevel: "info",
-	// Keep peer deps external so consumers' Pi versions resolve naturally.
-	external: [
-		"@earendil-works/pi-coding-agent",
-		"@earendil-works/pi-ai",
-		"@earendil-works/pi-agent-core",
-		"@earendil-works/pi-tui",
-		// Direct deps as well — bundling their full graph would inflate the
-		// output and override consumer-installed versions.
-		"cli-highlight",
-		"diff",
-		"jiti",
-		"@sinclair/typebox",
-		"acorn",
-		// esbuild must stay external: its CJS source references __filename/__dirname
-		// (CJS globals) for self-location. Bundling it into the ESM .mjs makes those
-		// undefined at runtime → "__filename is not defined" when the dynamic-workflow
-		// runner (or strip-types loader) invokes esbuild transformSync. Keeping it
-		// external lets it resolve from node_modules as proper CJS. (esbuild also
-		// ships a native binary, which shouldn't be bundled anyway.)
-		"esbuild",
-	],
-	// All node:* and Node-builtin modules are external by default for
-	// platform=node, but list explicitly for clarity.
-	//
-	// CJS-shim banner: pi-crew's dependency graph includes CommonJS modules
-	// (notably `yaml`) whose source calls `require("process")` etc. esbuild
-	// emits these as runtime `__require(...)` calls; in a pure-ESM context
-	// `require` is undefined, so we inject a `createRequire`-backed shim
-	// at the top of the bundle. This is the standard pattern for shipping
-	// CJS-mixed bundles as `.mjs`. See phase-2 H2 investigation (2026-06-30).
-	banner: {
-		js:
-			"// pi-crew bundled by scripts/build-bundle.mjs (5.5)\n" +
-			"// CJS-shim for legacy deps (yaml, etc.) that call require() in ESM context.\n" +
-			"import { createRequire as __piCrewCreateRequire } from 'node:module';\n" +
-			"const require = __piCrewCreateRequire(import.meta.url);\n" +
-			"const module = { exports: {} };\n" +
-			"const exports = module.exports;\n",
-	},
-	metafile: true,
-});
-
-fs.writeFileSync(path.join(distDir, "build-meta.json"), JSON.stringify(result.metafile, null, 2) + "\n", "utf-8");
-const elapsedMs = Date.now() - start;
-const stat = fs.statSync(path.join(distDir, "index.mjs"));
-console.log(`[build-bundle] dist/index.mjs ${(stat.size / 1024).toFixed(1)} KB in ${elapsedMs} ms`);