pi-crew 0.9.49 → 0.9.50

package/src/extension/team-tool/run.ts

@@ -15,6 +15,7 @@ import { assertCleanLeaderAsync, findGitRootAsync } from "../../worktree/worktre
 // eslint-disable-next-line @typescript-eslint/no-unused-vars -- type-only import for TS inference
 const _typeCheck: typeof ExecuteTeamRunFn = null as never as typeof ExecuteTeamRunFn;
 
+import { errorMessage } from "../../utils/guards.ts";
 import { logInternalError } from "../../utils/internal-error.ts";
 import { resolveContainedPath, resolveRealContainedPath } from "../../utils/safe-paths.ts";
 
@@ -432,7 +433,7 @@ export async function handleRun(params: TeamToolParamsValue, ctx: TeamContext):
 			try {
 				await assertCleanLeaderAsync(gitRoot);
 			} catch (err) {
-				const msg = err instanceof Error ? err.message : String(err);
+				const msg = errorMessage(err);
 				return result(
 					`${msg}\nCommit or stash changes before using worktree mode, or use workspaceMode: 'single'.`,
 					{ action: "run", status: "error" },
@@ -655,7 +656,7 @@ export async function handleRun(params: TeamToolParamsValue, ctx: TeamContext):
 				// Round-11 runtime fix: persist manifest with status=failed when runner throws
 				// (e.g., script timeout, script syntax error, async failure). Previously the
 				// manifest stayed at 'queued' indefinitely, leaving an orphan state file.
-				const failureReason = runnerError instanceof Error ? runnerError.message : String(runnerError);
+				const failureReason = errorMessage(runnerError);
 				const failedManifest = {
 					...dwfManifest,
 					status: "failed" as const,
@@ -856,13 +857,13 @@ export async function handleRun(params: TeamToolParamsValue, ctx: TeamContext):
 				workspaceId: ctx.sessionId ?? ctx.cwd,
 			});
 		} catch (waitError: unknown) {
-			const errorMessage = waitError instanceof Error ? waitError.message : String(waitError);
+			const waitErrMsg = errorMessage(waitError);
 			return result(
 				[
 					`pi-crew run timed out or failed: ${updatedManifest.runId}`,
 					`Team: ${team.name}`,
 					`Workflow: ${workflow.name}`,
-					`Error: ${errorMessage}`,
+					`Error: ${waitErrMsg}`,
 					"",
 					`Check status with: team status runId=${updatedManifest.runId}`,
 					`State: ${updatedManifest.stateRoot}`,
@@ -970,13 +971,13 @@ export async function handleRun(params: TeamToolParamsValue, ctx: TeamContext):
 				workspaceId: ctx.sessionId ?? ctx.cwd,
 			});
 		} catch (waitError: unknown) {
-			const errorMessage = waitError instanceof Error ? waitError.message : String(waitError);
+			const waitErrMsg = errorMessage(waitError);
 			return result(
 				[
 					`pi-crew run timed out or failed: ${updatedManifest.runId}`,
 					`Team: ${team.name}`,
 					`Workflow: ${workflow.name}`,
-					`Error: ${errorMessage}`,
+					`Error: ${waitErrMsg}`,
 					"",
 					`Check status with: team status runId=${updatedManifest.runId}`,
 					`State: ${updatedManifest.stateRoot}`,

package/src/runtime/chain-runner.ts

@@ -10,6 +10,7 @@
  * @see docs/pi-boomerang-integration-plan.md
  */
 
+import { errorMessage } from "../utils/guards.ts";
 import type { ChainStep as DSLChainStep } from "./chain-parser.ts";
 import { parseChainDSL } from "./chain-parser.ts";
 import type { HandoffManager, HandoffSummary, TaskPacket, TaskResult } from "./handoff-manager.ts";
@@ -250,14 +251,14 @@ export class ChainRunner {
 					});
 				}
 			} catch (error) {
-				const errorMessage = error instanceof Error ? error.message : String(error);
+				const errMsg = errorMessage(error);
 
 				stepResults.push({
 					step: i + 1,
 					name: step.name,
 					outcome: "failure",
 					duration: Date.now() - stepStart,
-					error: errorMessage,
+					error: errMsg,
 				});
 
 				// Stop chain on failure unless configured to continue

package/src/runtime/pipeline-runner.ts

@@ -1,5 +1,6 @@
 import { errors } from "../errors.ts";
 import { appendEventAsync, flushEventLogBuffer } from "../state/event-log.ts";
+import { errorMessage } from "../utils/guards.ts";
 import type { WorkflowConfig } from "../workflows/workflow-config.ts";
 import { mapConcurrent } from "./parallel-utils.ts";
 
@@ -166,26 +167,26 @@ export class PipelineRunner {
 					});
 				} catch (error) {
 					const duration = Date.now() - stageStartTime;
-					const errorMessage = error instanceof Error ? error.message : String(error);
+					const errMsg = errorMessage(error);
 
 					if (effectiveStopOnError) {
 						stages.push({
 							name: stage.name,
 							status: "failed",
 							results: [],
-							error: errorMessage,
+							error: errMsg,
 							duration,
 						});
 
 						await appendEventAsync(eventsPath, {
 							type: "pipeline:stage_failed",
 							runId,
-							message: `Stage '${stage.name}' failed: ${errorMessage}`,
+							message: `Stage '${stage.name}' failed: ${errMsg}`,
 							data: {
 								stageIndex: i,
 								stageName: stage.name,
 								duration,
-								error: errorMessage,
+								error: errMsg,
 							},
 						});
 
@@ -193,7 +194,7 @@ export class PipelineRunner {
 							type: "pipeline:failed",
 							runId,
 							message: `Pipeline '${workflow.name}' failed at stage '${stage.name}'`,
-							data: { failedStage: stage.name, error: errorMessage },
+							data: { failedStage: stage.name, error: errMsg },
 						});
 
 						return {
@@ -207,7 +208,7 @@ export class PipelineRunner {
 							name: stage.name,
 							status: "failed",
 							results: [],
-							error: errorMessage,
+							error: errMsg,
 							duration,
 						});
 
@@ -219,7 +220,7 @@ export class PipelineRunner {
 								stageIndex: i,
 								stageName: stage.name,
 								duration,
-								error: errorMessage,
+								error: errMsg,
 							},
 						});
 					}

package/src/ui/live-run-sidebar.ts

@@ -270,10 +270,12 @@ export class LiveRunSidebar {
 			if (isTerminal && !hasActiveAgents && !this.hasAutoClosed) {
 				const autoCloseMs = this.config?.autoCloseDashboardMs ?? 3000;
 				if (autoCloseMs > 0) {
+					if (this.autoCloseTimeout) clearTimeout(this.autoCloseTimeout);
 					this.autoCloseTimeout = setTimeout(() => {
 						this.hasAutoClosed = true;
 						this.done(undefined);
 					}, autoCloseMs);
+					this.autoCloseTimeout?.unref();
 					lines.push(line(`auto-close in ${Math.round(autoCloseMs / 1000)}s…`, w));
 				}
 			}

package/src/ui/mascot.ts

@@ -226,7 +226,7 @@ export class AnimatedMascot {
 	private tickTypewriter(): boolean {
 		const state = this.effectState;
 		if (state.pos === undefined) return true;
-		for (let i = 0; i < 6; i++) {
+		for (let i = 0; i < 18; i++) {
 			const row = Math.floor(state.pos / ARMIN_WIDTH);
 			const x = state.pos % ARMIN_WIDTH;
 			if (row >= ARMIN_DISPLAY_HEIGHT) return true;
@@ -239,9 +239,11 @@ export class AnimatedMascot {
 	private tickScanline(): boolean {
 		const state = this.effectState;
 		if (state.row === undefined) return true;
-		if (state.row >= ARMIN_DISPLAY_HEIGHT) return true;
-		for (let x = 0; x < ARMIN_WIDTH; x++) this.currentArminGrid[state.row][x] = this.finalArminGrid[state.row][x];
-		state.row++;
+		for (let step = 0; step < 3; step++) {
+			if (state.row >= ARMIN_DISPLAY_HEIGHT) return true;
+			for (let x = 0; x < ARMIN_WIDTH; x++) this.currentArminGrid[state.row][x] = this.finalArminGrid[state.row][x];
+			state.row++;
+		}
 		return false;
 	}
 
@@ -264,7 +266,7 @@ export class AnimatedMascot {
 					break;
 				}
 			}
-			drop.y++;
+			drop.y += 3;
 			if (drop.y >= 0 && drop.y < ARMIN_DISPLAY_HEIGHT) {
 				if (targetRow >= 0 && drop.y >= targetRow) {
 					drop.settled = ARMIN_DISPLAY_HEIGHT - targetRow;
@@ -280,7 +282,7 @@ export class AnimatedMascot {
 	private tickFade(): boolean {
 		const state = this.effectState;
 		if (!state.positions || state.idx === undefined) return true;
-		for (let i = 0; i < 18; i++) {
+		for (let i = 0; i < 54; i++) {
 			if (state.idx >= state.positions.length) return true;
 			const [row, x] = state.positions[state.idx];
 			this.currentArminGrid[row][x] = this.finalArminGrid[row][x];
@@ -299,7 +301,7 @@ export class AnimatedMascot {
 		for (let row = Math.max(0, top); row <= Math.min(ARMIN_DISPLAY_HEIGHT - 1, bottom); row++) {
 			for (let x = 0; x < ARMIN_WIDTH; x++) this.currentArminGrid[row][x] = this.finalArminGrid[row][x];
 		}
-		state.expansion++;
+		state.expansion += 3;
 		return state.expansion > ARMIN_DISPLAY_HEIGHT;
 	}
 
@@ -321,7 +323,7 @@ export class AnimatedMascot {
 					}
 				}
 			}
-			state.phase++;
+			state.phase += 3;
 			return false;
 		}
 		// Restore final grid in-place
@@ -336,7 +338,7 @@ export class AnimatedMascot {
 	private tickDissolve(): boolean {
 		const state = this.effectState;
 		if (!state.positions || state.idx === undefined) return true;
-		for (let i = 0; i < 22; i++) {
+		for (let i = 0; i < 66; i++) {
 			if (state.idx >= state.positions.length) return true;
 			const [row, x] = state.positions[state.idx];
 			this.currentArminGrid[row][x] = this.finalArminGrid[row][x];

package/src/ui/render-coalescer.ts

@@ -73,6 +73,15 @@ export class RenderCoalescer {
 			this.#timerId = null;
 		}
 		this.#pending = false;
+		const dropped = this.#dropped;
+		this.#dropped = 0;
+		if (dropped > 0) {
+			try {
+				this.#onDrop(dropped);
+			} catch {
+				/* drop callback errors are non-fatal */
+			}
+		}
 		this.#callback();
 	}
 

package/src/ui/run-snapshot-cache.ts

@@ -1005,17 +1005,16 @@ export function createRunSnapshotCache(cwd: string, options: RunSnapshotCacheOpt
 	const scheduleRefresh = (runId: string): void => {
 		const existing = pendingRefreshes.get(runId);
 		if (existing) clearTimeout(existing);
-		pendingRefreshes.set(
-			runId,
-			setTimeout(() => {
-				pendingRefreshes.delete(runId);
-				try {
-					localRefreshIfStale(runId);
-				} catch {
-					/* best-effort; widget falls back gracefully */
-				}
-			}, INVAL_COALESCE_MS),
-		);
+		const timer = setTimeout(() => {
+			pendingRefreshes.delete(runId);
+			try {
+				localRefreshIfStale(runId);
+			} catch {
+				/* best-effort; widget falls back gracefully */
+			}
+		}, INVAL_COALESCE_MS);
+		timer.unref();
+		pendingRefreshes.set(runId, timer);
 	};
 	const unsubState = runEventBus.onChannel("run:state", (event) => {
 		if (entries.has(event.runId)) scheduleRefresh(event.runId);

package/src/ui/terminal-status.ts

@@ -213,6 +213,9 @@ export function createTerminalStatusController(ctx: TerminalStatusUi): TerminalS
 			setTerminalTitle(ctx, buildIdleTitle());
 			scheduleIdleReassert(Math.min(delay * 2, IDLE_REASSERT_MAX_MS));
 		}, delay);
+		// Unref so this recursive backoff timer never keeps the event loop alive
+		// (critical on SIGTERM where dispose() is not reached → process hang).
+		state.idleTimer.unref?.();
 	};
 
 	return {
@@ -240,6 +243,8 @@ export function createTerminalStatusController(ctx: TerminalStatusUi): TerminalS
 					ghosttyClear();
 				}
 			}, COMPLETE_FLASH_MS);
+			// Unref so the one-shot flash clear never blocks process exit.
+			state.flashTimer.unref?.();
 		},
 		onIdle(): void {
 			if (state.destroyed) return;

package/src/ui/widget/index.ts

@@ -154,7 +154,7 @@ class CrewWidgetComponent implements WidgetComponent {
 			[...listLiveAgents()].some((h) => h.status === "running");
 		const animation = hasRunning ? `:spin=${spinnerBucket()}` : "";
 
-		return (
+		const sig =
 			runs
 				.map(
 					(entry) =>
@@ -175,8 +175,8 @@ class CrewWidgetComponent implements WidgetComponent {
 								})
 								.join(","),
 				)
-				.join("|") + `|live:${liveSig}${animation}`
-		);
+				.join("|") + `|live:${liveSig}${animation}`;
+		return sig;
 	}
 
 	private colorize(lines: string[], width: number): string[] {
@@ -342,8 +342,6 @@ export function stopCrewWidget(
 	state: CrewWidgetState,
 	config?: CrewUiConfig,
 ): void {
-	if (state.interval) clearInterval(state.interval);
-	state.interval = undefined;
 	if (ctx?.hasUI) {
 		const placement = config?.widgetPlacement ?? DEFAULT_UI.widgetPlacement;
 		ctx.ui.setStatus(STATUS_KEY, undefined);

package/src/ui/widget/widget-types.ts

@@ -25,7 +25,6 @@ export interface CrewWidgetModel {
 
 export interface CrewWidgetState {
 	frame: number;
-	interval?: ReturnType<typeof setInterval>;
 	lastPlacement?: string;
 	lastVisibility?: "hidden" | "visible";
 	lastKey?: string;