pi-crew 0.9.44 → 0.9.47

package/src/utils/visual.ts

@@ -1,98 +1,28 @@
+import { visibleWidth as tuiVisibleWidth } from "@earendil-works/pi-tui";
+
 export const ANSI_PATTERN = /\u001b\[[0-?]*[ -/]*[@-~]/g;
 
 const WIDTH_CACHE_LIMIT = 256;
 const widthCache = new Map<string, number>();
 
-/** Code-point ranges that render as width 2 in most terminals (CJK + emoji). */
-const WIDE_RANGES: Array<[number, number]> = [
-	// CJK Unified Ideographs
-	[0x4e00, 0x9fff],
-	// CJK Extension A
-	[0x3400, 0x4dbf],
-	// CJK Compatibility Ideographs
-	[0xf900, 0xfaff],
-	// Hangul Syllables
-	[0xac00, 0xd7af],
-	// CJK Symbols and Punctuation, Hiragana, Katakana
-	[0x3000, 0x33ff],
-	// Fullwidth forms
-	[0xff01, 0xff60],
-	// Emoji blocks
-	// Emoji-presentation codepoints in 0x2600-0x27BF (narrow chars like ✓✗★ excluded)
-	[0x2615, 0x2615],
-	[0x2648, 0x2653],
-	[0x267f, 0x267f],
-	[0x2693, 0x2693],
-	[0x26a1, 0x26a1],
-	[0x26aa, 0x26ab],
-	[0x26bd, 0x26be],
-	[0x26c4, 0x26c5],
-	[0x26ce, 0x26ce],
-	[0x26d4, 0x26d4],
-	[0x26ea, 0x26ea],
-	[0x26f2, 0x26f3],
-	[0x26f5, 0x26f5],
-	[0x26fa, 0x26fa],
-	[0x26fd, 0x26fd],
-	[0x2702, 0x2702],
-	[0x2705, 0x2705],
-	[0x2708, 0x270d],
-	[0x270f, 0x270f],
-	[0x2712, 0x2712],
-	[0x2714, 0x2714],
-	[0x2716, 0x2716],
-	[0x271d, 0x271d],
-	[0x2721, 0x2721],
-	[0x2728, 0x2728],
-	[0x2733, 0x2734],
-	[0x2744, 0x2744],
-	[0x2747, 0x2747],
-	[0x274c, 0x274c],
-	[0x274e, 0x274e],
-	[0x2753, 0x2755],
-	[0x2757, 0x2757],
-	[0x2763, 0x2764],
-	[0x2795, 0x2797],
-	[0x27a1, 0x27a1],
-	[0x27b0, 0x27b0],
-	[0x27bf, 0x27bf],
-	// Geometric Shapes / Misc Symbols-Arrows emoji that pi-tui upstream counts as
-	// width=2 (RGI emoji). Mismatch here caused the "Rendered line N exceeds
-	// terminal width (160 > 159)" TUI crash: pi-crew truncated to width 159 by
-	// its own (mismatched) measure, then Box padded to 159 chars, but pi-tui
-	// re-measured the padded line at 160 because ⬜ counts as 2 upstream.
-	[0x2b1b, 0x2b1c], // ⬛ BLACK LARGE SQUARE, ⬜ WHITE LARGE SQUARE
-	[0x1f300, 0x1f9ff], // Misc Symbols, Emoticons, Transport, Map, Supplement
-	[0x1fa00, 0x1faff], // Symbols Extended-A
-	[0x1f000, 0x1f02f], // Mahjong, Dominos
-	[0xfe00, 0xfe0f], // Variation Selectors (emoji presentation)
-];
-// NOTE: U+200D (Zero Width Joiner, ZWJ) is intentionally NOT listed as wide.
-// ZWJ has zero advance width by Unicode definition; miscounting it as 2 caused
-// slight over-truncation/over-padding of compound-emoji goals (T-1).
-
-function isWideCodePoint(code: number): boolean {
-	for (const [lo, hi] of WIDE_RANGES) {
-		if (code >= lo && code <= hi) return true;
-	}
-	return false;
-}
+// NOTE: width measurement is delegated to pi-tui's `visibleWidth` (see below).
+// pi-tui is the renderer that HARD-ABORTS the session if any line exceeds the
+// terminal width by ITS measure, so our truncate/pad/wrap MUST agree with it.
+// A previous hand-maintained WIDE_RANGES table diverged from pi-tui's
+// grapheme+RGI-emoji model on codepoints like ⏳ U+23F3 (hourglass: we counted
+// 1, pi-tui counts 2) → lines we believed fit were rejected →
+// "Rendered line N exceeds terminal width (160 > 159)" crash. Delegating makes
+// divergence structurally impossible.
 
 export function visibleWidth(value: string): number {
-	// Skip caching for very long strings to avoid memory pressure.
-	if (value.length > 4096) {
-		let length = 0;
-		for (const char of value.replace(ANSI_PATTERN, "")) {
-			if (char !== "\n") length += isWideCodePoint(char.codePointAt(0) ?? 0) ? 2 : 1;
-		}
-		return length;
-	}
+	// Delegate to pi-tui's authoritative width model so our truncate/pad/wrap
+	// can never disagree with the renderer's doRender measurement. Keep our own
+	// LRU cache on top (pi-tui caches too, but this avoids repeated calls for the
+	// hot render path).
+	if (value.length > 4096) return tuiVisibleWidth(value);
 	const cached = widthCache.get(value);
 	if (cached !== undefined) return cached;
-	let length = 0;
-	for (const char of value.replace(ANSI_PATTERN, "")) {
-		if (char !== "\n") length += isWideCodePoint(char.codePointAt(0) ?? 0) ? 2 : 1;
-	}
+	const length = tuiVisibleWidth(value);
 	if (widthCache.size >= WIDTH_CACHE_LIMIT) {
 		const firstKey = widthCache.keys().next().value;
 		if (firstKey !== undefined) widthCache.delete(firstKey);
@@ -132,15 +62,21 @@ export function truncateToWidth(value: string, width: number, ellipsis = "…"):
 	if (width <= ellipsis.length) return ellipsis.slice(0, width);
 	let output = "";
 	let renderedWidth = 0;
-	for (let i = 0; i < value.length; i++) {
+	for (let i = 0; i < value.length; ) {
 		const ansiLen = consumeAnsi(value, i);
 		if (ansiLen) {
 			output += value.slice(i, i + ansiLen);
-			i += ansiLen - 1;
+			i += ansiLen;
 			continue;
 		}
-		const char = value[i] as string;
-		const nextIndex = (char.codePointAt(0) ?? 0) > 0xffff ? i + 2 : i + 1;
+		// Read the codepoint at position i on the FULL string — NOT
+		// `value[i].codePointAt(0)`, which for a surrogate pair returns the
+		// lone half (≤ 0xFFFF) and slices each half separately. pi-tui's
+		// visibleWidth zero-widths lone `\p{Surrogate}` halves, so 🤖 would
+		// undercount as 0 and truncation would never cut (latent bug unmasked
+		// once visibleWidth delegated to pi-tui).
+		const codepoint = value.codePointAt(i) ?? 0;
+		const nextIndex = codepoint > 0xffff ? i + 2 : i + 1;
 		const segment = value.slice(i, nextIndex);
 		const charWidth = visibleWidth(segment);
 		if (renderedWidth + charWidth > width - ellipsis.length) {
@@ -148,7 +84,7 @@ export function truncateToWidth(value: string, width: number, ellipsis = "…"):
 		}
 		output += segment;
 		renderedWidth += charWidth;
-		i = nextIndex - 1;
+		i = nextIndex;
 	}
 	return output;
 }

package/workflows/default.workflow.md

@@ -28,4 +28,4 @@ dependsOn: execute
 verify: true
 
 Verify completion for: {goal}
-Run tests ONCE (cache to .crew/cache/), read changed files from executor context. Cross-reference test output with the changes. Do NOT re-run tests. Give PASS or FAIL with specific test evidence.
+Run FAST checks ONCE (cache output to .crew/cache/): `npm run test:critical && npx tsc --noEmit` (completes in <60s). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with the changes. Do NOT re-run tests. Give PASS or FAIL with specific test evidence.

package/workflows/fast-fix.workflow.md

@@ -21,4 +21,4 @@ dependsOn: execute
 verify: true
 
 Verify the fix with available evidence.
-Run tests ONCE (cache to .crew/cache/), read changed files from executor context. Cross-reference test output with the fix. Do NOT re-run tests. Give PASS or FAIL with specific test evidence.
+Run FAST checks ONCE (cache output to .crew/cache/): `npm run test:critical && npx tsc --noEmit` (completes in <60s). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with the fix. Do NOT re-run tests. Give PASS or FAIL with specific test evidence.

package/workflows/plan-execute.workflow.md

@@ -27,4 +27,4 @@ dependsOn: execute
 verify: true
 
 Verify completion for: {goal}
-Run tests ONCE (cache to .crew/cache/), read changed files from executor context. Cross-reference test output with the changes. Do NOT re-run tests. Give PASS or FAIL with specific test evidence.
+Run FAST checks ONCE (cache output to .crew/cache/): `npm run test:critical && npx tsc --noEmit` (completes in <60s). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with the changes. Do NOT re-run tests. Give PASS or FAIL with specific test evidence.

package/workflows/review.workflow.md

@@ -28,4 +28,4 @@ role: verifier
 dependsOn: code-review, security-review
 verify: true
 
-Run the project test suite ONCE (cache to .crew/cache/), then cross-reference test results with reviewer and security-reviewer findings. Confirm each finding against real test output. Give PASS if findings match evidence, FAIL if critical findings are false positives or tests reveal new issues.
+Run FAST checks ONCE (cache output to .crew/cache/): `npm run test:critical && npx tsc --noEmit` (completes in <60s). Do NOT run `npm run test:unit` or `npm test` — too slow (642 files, >4 min). Cross-reference cached output with reviewer and security-reviewer findings. Confirm each finding against real test output. Give PASS if findings match evidence, FAIL if critical findings are false positives or tests reveal new issues.

package/src/runtime/auto-resume.ts

@@ -1,100 +0,0 @@
-/**
- * Auto-resume controller with settle window — prevents premature context injection
- * by waiting for Pi's setTimeout(0) + setTimeout(100) to drain before resuming.
- *
- * Distilled from pi-autoresearch's auto-resume / settle-window pattern.
- */
-
-/** Time to wait before auto-resuming (ms). Outlasts Pi's setTimeout(0) + setTimeout(100). */
-export const SETTLE_WINDOW_MS = 800;
-
-/** Maximum number of auto-resume turns before forcing a stop. */
-export const MAX_AUTORESUME_TURNS = 20;
-
-/**
- * Controller for scheduling auto-resume actions with a settle window.
- *
- * The settle window ensures that pending async operations (e.g., Pi's
- * internal setTimeout(0) and setTimeout(100) callbacks) have completed
- * before the resume callback fires.
- */
-export class AutoResumeController {
-	private timerId: ReturnType<typeof setTimeout> | null = null;
-	private turnCount = 0;
-	private cancelled = false;
-
-	/**
-	 * Get the current auto-resume turn count.
-	 */
-	get currentTurnCount(): number {
-		return this.turnCount;
-	}
-
-	/**
-	 * Get the maximum allowed auto-resume turns.
-	 */
-	get maxTurns(): number {
-		return MAX_AUTORESUME_TURNS;
-	}
-
-	/**
-	 * Schedule an auto-resume callback after the settle window elapses.
-	 *
-	 * If a resume is already pending, it is cancelled first (debounce behavior).
-	 * If the turn limit has been reached, the callback is not scheduled.
-	 *
-	 * @param message - Description of why the resume is being scheduled
-	 * @param callback - Function to call after the settle window
-	 */
-	scheduleResume(message: string, callback: () => void): void {
-		// Cancel any existing pending resume
-		this.cancelResume();
-
-		// Enforce turn limit
-		if (this.turnCount >= MAX_AUTORESUME_TURNS) {
-			return;
-		}
-
-		this.cancelled = false;
-		this.turnCount++;
-
-		this.timerId = setTimeout(() => {
-			if (!this.cancelled) {
-				this.timerId = null;
-				callback();
-			}
-		}, SETTLE_WINDOW_MS);
-
-		// Prevent the timer from keeping the process alive
-		if (this.timerId && typeof this.timerId === "object" && "unref" in this.timerId) {
-			this.timerId.unref();
-		}
-	}
-
-	/**
-	 * Cancel any pending auto-resume.
-	 */
-	cancelResume(): void {
-		if (this.timerId !== null) {
-			clearTimeout(this.timerId);
-			this.timerId = null;
-		}
-		this.cancelled = true;
-	}
-
-	/**
-	 * Check whether an auto-resume is currently pending.
-	 */
-	hasPendingResume(): boolean {
-		return this.timerId !== null;
-	}
-
-	/**
-	 * Reset the turn counter. Called when a new agent starts processing
-	 * to allow a fresh set of auto-resume turns.
-	 */
-	resetTurnCount(): void {
-		this.turnCount = 0;
-		this.cancelled = false;
-	}
-}

package/src/runtime/notebook-helpers.ts

@@ -1,88 +0,0 @@
-export interface NotebookCell {
-	index: number;
-	cellType: "code" | "markdown" | "raw";
-	source: string;
-	outputs?: unknown[];
-	metadata?: Record<string, unknown>;
-}
-
-export interface Notebook {
-	cells: NotebookCell[];
-	metadata?: Record<string, unknown>;
-	nbformat: number;
-}
-
-/** Check if a file path is a notebook */
-export function isNotebookPath(filePath: string): boolean {
-	return filePath.toLowerCase().endsWith(".ipynb");
-}
-
-function normalizeSource(source: unknown): string {
-	if (typeof source === "string") return source;
-	if (Array.isArray(source)) return source.join("");
-	return "";
-}
-
-/** Parse a .ipynb JSON file into a Notebook structure */
-export function parseNotebook(content: string): Notebook {
-	let raw: unknown;
-	try {
-		raw = JSON.parse(content);
-	} catch {
-		return { cells: [], nbformat: 4 };
-	}
-	if (typeof raw !== "object" || raw === null) return { cells: [], nbformat: 4 };
-	const obj = raw as Record<string, unknown>;
-	const nbformat = typeof obj.nbformat === "number" ? obj.nbformat : 4;
-	const rawCells = Array.isArray(obj.cells) ? obj.cells : [];
-	const cells: NotebookCell[] = rawCells
-		.map((c: unknown, i: number): NotebookCell | null => {
-			if (typeof c !== "object" || c === null) return null;
-			const cell = c as Record<string, unknown>;
-			const cellType = cell.cell_type;
-			if (cellType !== "code" && cellType !== "markdown" && cellType !== "raw") return null;
-			return {
-				index: i,
-				cellType,
-				source: normalizeSource(cell.source),
-				outputs: Array.isArray(cell.outputs) ? cell.outputs : undefined,
-				metadata:
-					cell.metadata && typeof cell.metadata === "object" && !Array.isArray(cell.metadata)
-						? (cell.metadata as Record<string, unknown>)
-						: undefined,
-			};
-		})
-		.filter((c: NotebookCell | null): c is NotebookCell => c !== null);
-	const metadata =
-		obj.metadata && typeof obj.metadata === "object" && !Array.isArray(obj.metadata)
-			? (obj.metadata as Record<string, unknown>)
-			: undefined;
-	return { cells, metadata, nbformat };
-}
-
-/** Get a specific cell by index */
-export function getCell(notebook: Notebook, index: number): NotebookCell | undefined {
-	return notebook.cells.find((c) => c.index === index);
-}
-
-/** Update a cell's source content, returning a new Notebook */
-export function updateCell(notebook: Notebook, index: number, source: string): Notebook {
-	const cells = notebook.cells.map((c) => (c.index === index ? { ...c, source } : c));
-	return { ...notebook, cells };
-}
-
-/** Serialize a Notebook back to .ipynb JSON string */
-export function serializeNotebook(notebook: Notebook): string {
-	const raw = {
-		nbformat: notebook.nbformat,
-		nbformat_minor: 5,
-		metadata: notebook.metadata ?? {},
-		cells: notebook.cells.map((c) => ({
-			cell_type: c.cellType,
-			source: c.source,
-			metadata: c.metadata ?? {},
-			...(c.cellType === "code" ? { outputs: c.outputs ?? [], execution_count: null } : {}),
-		})),
-	};
-	return JSON.stringify(raw, null, 2) + "\n";
-}

package/src/runtime/orphan-sentinel.ts

@@ -1,7 +0,0 @@
-/**
- * Orphan sentinel — DEPRECATED, replaced by parent-guard.ts.
- *
- * Keeping this file as a no-op placeholder until all references are removed.
- * Workers now self-monitor via startParentGuard() instead of relying on
- * an external sentinel process.
- */