pi-crew 0.9.44 → 0.9.46

package/CHANGELOG.md

@@ -3,6 +3,82 @@
 > **Note:** `atomic-write-v2.ts` / `AtomicWriter` mentioned in historical entries below was consolidated into `atomic-write.ts` as of v0.9.42. This changelog is preserved as historical record — the migration was completed (the v2 class was never adopted; v1 won on simplicity + symlink-safety + link+unlink atomicity). See `docs/migration/atomic-write-v2-migration.md` for the decision rationale.
 
 
+## [0.9.46] — UI stability + notification coalescing (2026-07-20)
+
+Three user-facing UI/notification fixes layered on top of the v0.9.45
+remediation, plus CI hygiene. All verified live in a restarted Pi session.
+
+### UI flicker — stop render-path snapshot-cache deletes
+
+The run-snapshot cache has a deliberate stale-while-revalidate design so the
+widget always shows a populated snapshot. That was defeated by three hot-path
+call sites in `lifecycle-handlers.ts` that hard-deleted cache entries; the worst
+ran `invalidate(undefined)` on every ~160ms fallback tick, wiping ALL entries
+→ `activeWidgetRuns` dropped every run to "(loading…)" until the async preload
+rebuilt the cache → continuous flicker across the widget, powerbar, and live
+sidebar/dashboard. (`src/extension/registration/lifecycle-handlers.ts`)
+
+**Fix:** never hard-delete from the render path. A no-runId tick is now a no-op;
+a specific runId calls `refreshIfStale` (stale-while-revalidate); the two
+`fs.watch` change handlers call `refresh` (rebuild-in-place). All three keep the
+entry populated so `get()` never returns `undefined`.
+
+### TUI width-overflow crash — delegate `visibleWidth` to pi-tui
+
+`Rendered line N exceeds terminal width (160 > 159)` killed the host Pi process
+whenever an agent emitted an emoji that pi-crew's hand-maintained `WIDE_RANGES`
+table counted as 1 column but pi-tui (the renderer) counted as 2 (e.g. `⏳`
+U+23F3). pi-crew truncated/padded to its own measure, pi-tui re-measured and
+hard-aborted. This was patched twice before by adding individual codepoints —
+whack-a-mole, since ANY emoji in agent output could trigger it.
+(`src/utils/visual.ts`)
+
+**Definitive fix:** `visibleWidth` now delegates to pi-tui's own `visibleWidth`
+(the function that drives the crash assert). truncate/pad/wrap therefore always
+agree with the renderer; an emoji-width mismatch is structurally impossible. The
+hand-maintained `WIDE_RANGES`/`isWideCodePoint` table is removed.
+
+### Notification coalescing — N drip → 1 consolidated wake-up
+
+Launching N background subagents (no `batch_id`) produced N separate "changed
+state" wake-ups, delivered one-per-turn at turn boundaries; after the leader
+joined them all, redundant per-agent notices kept dripping in over later turns.
+(`src/extension/registration/subagent-manager-setup.ts`)
+
+**Fix (Rule 3):** a debounced coalescer for non-batch completions. Completions
+within an 800ms window (reset on each new arrival) merge into ONE wake-up; each
+is `resultConsumed`-re-checked before emit (Rule 2), so already-joined agents
+are dropped and an all-consumed batch is suppressed entirely. Completions far
+apart (>800ms) still flush separately. The explicit-`batch_id` path (Rule 1,
+BatchBarrier) is unchanged.
+
+### CI hygiene
+
+`biome check --write` applied across the v0.9.45 remediation files (lint +
+format), and two unused test imports were removed — the local remediation
+commits had never been CI-checked; this brings lint + format:check green.
+
+## [0.9.45] — Deep-review 2026-07-20 remediation (all 5 phases, 14 findings)
+
+### ⚠️ BREAKING: custom agent roles default to read-only (FIND-12)
+
+`permissionForRole()` now returns `"read_only"` for unknown/custom agent
+roles instead of the previous permissive `"workspace_write"`. This is a
+security hardening (default-deny) to prevent privilege escalation via
+typo'd or unrecognized agent names.
+
+**Migration:** write-capable roles are now an EXPLICIT allowlist
+(`WRITE_ROLES` in `src/runtime/role-permission.ts`). All shipped
+write-capable roles are listed: `executor`, `writer`, `verifier`,
+`test-engineer`, `agent` (direct-agent default), `cold-verifier`,
+`chain-executor` (chain workflow), and `worker` (goal-loop + dynamic
+workflow). A custom agent role that needs workspace write access
+must be added to `WRITE_ROLES`. Built-in read-only roles (`explorer`,
+`reviewer`, `security-reviewer`, `analyst`, `critic`, `planner`) are
+unaffected. (An earlier draft proposed a `permissions.workspaceWrite`
+agent-config opt-in; it was dropped — unreachable from the call sites.)
+
+
 ## [0.9.44] — 3 flaky CI test fixes (2026-07-19)
 
 Three pre-existing flaky tests in the CI suite have been fixed, completing

package/README.md

@@ -282,7 +282,28 @@ The advisory is **informational only** — there is no `force:true` flag needed
 
 - `test/functional/pi-crew-live.test.ts` + `test/functional/pi-crew-live-broad.test.ts` — 16 live integration tests run against the **real pi binary + real LLM provider** (verified after v0.9.42 audit, ~26 commits). Use these when you want to confirm end-to-end behavior, not just unit-level invariants.
 
-## Recent changes (since v0.9.42)
+## Recent changes
+
+### v0.9.45 – v0.9.46 (2026-07-20): security + perf remediation, UI stability
+
+- **Custom agent roles default to read-only (FIND-12, breaking):**
+  `permissionForRole()` returns `"read_only"` for unknown roles (was
+  permissive `"workspace_write"`). Write-capable roles are now an explicit
+  allowlist (`WRITE_ROLES`). See `CHANGELOG.md` for the migration.
+- **Mailbox / snapshot-cache / scan perf:** delivery cache + async append
+  (FIND-01/02), `listActive` TTL + mtime-sort strict limit (FIND-03/04),
+  byte-bounded event-log tail-read (FIND-05).
+- **Heartbeat race (FIND-06):** in-flight guard + drain + terminal-safety +
+  late-save repair in the coalesced task group.
+- **UI flicker eliminated:** the render path no longer hard-deletes snapshot
+  entries, so the crew widget / powerbar / live sidebar stay stable (no more
+  "(loading…)" flashing every ~160ms).
+- **Emoji width-overflow crash fixed for good:** `visibleWidth` delegates to
+  pi-tui's own measure, so agent-output emoji can never exceed terminal width.
+- **Background-subagent notifications coalesce:** N near-simultaneous
+  completions now produce ONE consolidated wake-up instead of N drips.
+
+### v0.9.42 – v0.9.44: 4-wave audit + flaky-CI fixes
 
 A 4-wave audit + fix pass was completed (see `UPGRADE_REVIEW.md` for the full 647-line report and `CHANGELOG.md` for the diff):
 

package/dist/build-meta.json

@@ -126,7 +126,7 @@
       "format": "esm"
     },
     "src/state/locks.ts": {
-      "bytes": 21665,
+      "bytes": 24376,
       "imports": [
         {
           "path": "node:async_hooks",
@@ -378,7 +378,7 @@
       "format": "esm"
     },
     "src/agents/discover-agents.ts": {
-      "bytes": 25646,
+      "bytes": 25658,
       "imports": [
         {
           "path": "node:fs",
@@ -1194,7 +1194,7 @@
       "format": "esm"
     },
     "src/utils/incremental-reader.ts": {
-      "bytes": 2588,
+      "bytes": 6221,
       "imports": [
         {
           "path": "node:fs",
@@ -1231,7 +1231,7 @@
       "format": "esm"
     },
     "src/state/event-log.ts": {
-      "bytes": 52073,
+      "bytes": 54432,
       "imports": [
         {
           "path": "node:crypto",
@@ -1537,7 +1537,7 @@
       "format": "esm"
     },
     "src/state/mailbox.ts": {
-      "bytes": 28080,
+      "bytes": 34179,
       "imports": [
         {
           "path": "node:fs",
@@ -3645,7 +3645,7 @@
       "format": "esm"
     },
     "src/runtime/role-permission.ts": {
-      "bytes": 1396,
+      "bytes": 2938,
       "imports": [],
       "format": "esm"
     },
@@ -5389,7 +5389,7 @@
       "format": "esm"
     },
     "src/extension/team-tool/api.ts": {
-      "bytes": 40596,
+      "bytes": 40676,
       "imports": [
         {
           "path": "node:fs",
@@ -6229,7 +6229,7 @@
       "format": "esm"
     },
     "src/runtime/async-runner.ts": {
-      "bytes": 14825,
+      "bytes": 15391,
       "imports": [
         {
           "path": "node:child_process",
@@ -6281,6 +6281,11 @@
           "kind": "import-statement",
           "original": "../utils/paths.ts"
         },
+        {
+          "path": "src/utils/redaction.ts",
+          "kind": "import-statement",
+          "original": "../utils/redaction.ts"
+        },
         {
           "path": "src/runtime/orphan-worker-registry.ts",
           "kind": "import-statement",
@@ -6666,7 +6671,7 @@
       "format": "esm"
     },
     "src/extension/run-import.ts": {
-      "bytes": 5982,
+      "bytes": 7115,
       "imports": [
         {
           "path": "node:crypto",
@@ -6698,6 +6703,11 @@
           "kind": "import-statement",
           "original": "../state/atomic-write.ts"
         },
+        {
+          "path": "src/utils/internal-error.ts",
+          "kind": "import-statement",
+          "original": "../utils/internal-error.ts"
+        },
         {
           "path": "src/utils/paths.ts",
           "kind": "import-statement",
@@ -6922,8 +6932,14 @@
       "format": "esm"
     },
     "src/utils/visual.ts": {
-      "bytes": 8407,
-      "imports": [],
+      "bytes": 7078,
+      "imports": [
+        {
+          "path": "@earendil-works/pi-tui",
+          "kind": "import-statement",
+          "external": true
+        }
+      ],
       "format": "esm"
     },
     "src/ui/live-duration.ts": {
@@ -8250,7 +8266,7 @@
       "format": "esm"
     },
     "src/runtime/task-packet.ts": {
-      "bytes": 10509,
+      "bytes": 10512,
       "imports": [
         {
           "path": "node:path",
@@ -8292,7 +8308,7 @@
       "format": "esm"
     },
     "src/runtime/run-coalesced-task-group.ts": {
-      "bytes": 8999,
+      "bytes": 11679,
       "imports": [
         {
           "path": "src/state/artifact-store.ts",
@@ -9343,7 +9359,7 @@
       "format": "esm"
     },
     "src/state/run-metrics.ts": {
-      "bytes": 4530,
+      "bytes": 5832,
       "imports": [
         {
           "path": "node:fs",
@@ -10722,7 +10738,7 @@
       "format": "esm"
     },
     "src/ui/run-dashboard.ts": {
-      "bytes": 38956,
+      "bytes": 38776,
       "imports": [
         {
           "path": "node:fs",
@@ -10814,11 +10830,6 @@
           "kind": "import-statement",
           "original": "./keybinding-map.ts"
         },
-        {
-          "path": "src/ui/layout-primitives.ts",
-          "kind": "import-statement",
-          "original": "./layout-primitives.ts"
-        },
         {
           "path": "src/ui/overlays/help-overlay.ts",
           "kind": "import-statement",
@@ -10848,6 +10859,11 @@
           "path": "src/ui/theme-adapter.ts",
           "kind": "import-statement",
           "original": "./theme-adapter.ts"
+        },
+        {
+          "path": "src/ui/widget/widget-renderer.ts",
+          "kind": "import-statement",
+          "original": "./widget/widget-renderer.ts"
         }
       ],
       "format": "esm"
@@ -11438,7 +11454,7 @@
       "format": "esm"
     },
     "src/runtime/manifest-cache.ts": {
-      "bytes": 11387,
+      "bytes": 12865,
       "imports": [
         {
           "path": "node:fs",
@@ -11665,7 +11681,7 @@
       "format": "esm"
     },
     "src/ui/live-run-sidebar.ts": {
-      "bytes": 11936,
+      "bytes": 11756,
       "imports": [
         {
           "path": "node:fs",
@@ -11707,11 +11723,6 @@
           "kind": "import-statement",
           "original": "../utils/visual.ts"
         },
-        {
-          "path": "src/ui/layout-primitives.ts",
-          "kind": "import-statement",
-          "original": "./layout-primitives.ts"
-        },
         {
           "path": "src/ui/render-scheduler.ts",
           "kind": "import-statement",
@@ -11736,6 +11747,11 @@
           "path": "src/ui/theme-adapter.ts",
           "kind": "import-statement",
           "original": "./theme-adapter.ts"
+        },
+        {
+          "path": "src/ui/widget/widget-renderer.ts",
+          "kind": "import-statement",
+          "original": "./widget/widget-renderer.ts"
         }
       ],
       "format": "esm"
@@ -12399,7 +12415,7 @@
       "format": "esm"
     },
     "src/extension/registration/lifecycle-handlers.ts": {
-      "bytes": 28646,
+      "bytes": 30286,
       "imports": [
         {
           "path": "node:fs",
@@ -12631,7 +12647,7 @@
       "format": "esm"
     },
     "src/extension/registration/subagent-manager-setup.ts": {
-      "bytes": 8033,
+      "bytes": 12885,
       "imports": [
         {
           "path": "src/config/config.ts",
@@ -12802,7 +12818,7 @@
       "format": "esm"
     },
     "src/runtime/resilient-edit.ts": {
-      "bytes": 5549,
+      "bytes": 5531,
       "imports": [
         {
           "path": "src/runtime/replace.ts",
@@ -12980,7 +12996,7 @@
       "imports": [],
       "exports": [],
       "inputs": {},
-      "bytes": 5999575
+      "bytes": 6035945
     },
     "dist/index.mjs": {
       "imports": [
@@ -13929,6 +13945,11 @@
           "kind": "import-statement",
           "external": true
         },
+        {
+          "path": "@earendil-works/pi-tui",
+          "kind": "import-statement",
+          "external": true
+        },
         {
           "path": "node:fs",
           "kind": "import-statement",
@@ -14624,7 +14645,7 @@
           "bytesInOutput": 4426
         },
         "src/state/locks.ts": {
-          "bytesInOutput": 8382
+          "bytesInOutput": 9166
         },
         "src/utils/paths.ts": {
           "bytesInOutput": 5250
@@ -14765,13 +14786,13 @@
           "bytesInOutput": 10871
         },
         "src/utils/incremental-reader.ts": {
-          "bytesInOutput": 2166
+          "bytesInOutput": 3934
         },
         "src/state/event-log-rotation.ts": {
           "bytesInOutput": 4480
         },
         "src/state/event-log.ts": {
-          "bytesInOutput": 28022
+          "bytesInOutput": 28864
         },
         "src/utils/task-name-generator.ts": {
           "bytesInOutput": 106
@@ -14810,7 +14831,7 @@
           "bytesInOutput": 4465
         },
         "src/state/mailbox.ts": {
-          "bytesInOutput": 18349
+          "bytesInOutput": 21862
         },
         "src/extension/help.ts": {
           "bytesInOutput": 2863
@@ -15104,7 +15125,7 @@
           "bytesInOutput": 15395
         },
         "src/runtime/role-permission.ts": {
-          "bytesInOutput": 1002
+          "bytesInOutput": 1050
         },
         "src/runtime/worker-heartbeat.ts": {
           "bytesInOutput": 580
@@ -15383,7 +15404,7 @@
           "bytesInOutput": 241
         },
         "src/extension/team-tool/api.ts": {
-          "bytesInOutput": 41740
+          "bytesInOutput": 41762
         },
         "src/runtime/checkpoint.ts": {
           "bytesInOutput": 2566
@@ -15464,7 +15485,7 @@
           "bytesInOutput": 7769
         },
         "src/runtime/async-runner.ts": {
-          "bytesInOutput": 9083
+          "bytesInOutput": 9162
         },
         "src/subagents/async-entry.ts": {
           "bytesInOutput": 119
@@ -15512,7 +15533,7 @@
           "bytesInOutput": 4221
         },
         "src/extension/run-import.ts": {
-          "bytesInOutput": 4272
+          "bytesInOutput": 4467
         },
         "src/extension/run-maintenance.ts": {
           "bytesInOutput": 4797
@@ -15530,7 +15551,7 @@
           "bytesInOutput": 1979
         },
         "src/utils/visual.ts": {
-          "bytesInOutput": 6973
+          "bytesInOutput": 4539
         },
         "src/ui/live-duration.ts": {
           "bytesInOutput": 793
@@ -15728,7 +15749,7 @@
           "bytesInOutput": 7286
         },
         "src/runtime/run-coalesced-task-group.ts": {
-          "bytesInOutput": 6596
+          "bytesInOutput": 7581
         },
         "src/runtime/runtime-policy.ts": {
           "bytesInOutput": 575
@@ -15944,7 +15965,7 @@
           "bytesInOutput": 4154
         },
         "src/ui/run-dashboard.ts": {
-          "bytesInOutput": 29994
+          "bytesInOutput": 29822
         },
         "src/ui/overlays/confirm-overlay.ts": {
           "bytesInOutput": 2237
@@ -15980,7 +16001,7 @@
           "bytesInOutput": 4563
         },
         "src/ui/live-run-sidebar.ts": {
-          "bytesInOutput": 9966
+          "bytesInOutput": 9794
         },
         "src/extension/registration/ui.ts": {
           "bytesInOutput": 4277
@@ -16091,7 +16112,7 @@
           "bytesInOutput": 3062
         },
         "src/runtime/manifest-cache.ts": {
-          "bytesInOutput": 8432
+          "bytesInOutput": 8928
         },
         "src/utils/fs-watch.ts": {
           "bytesInOutput": 382
@@ -16118,7 +16139,7 @@
           "bytesInOutput": 2451
         },
         "src/extension/registration/lifecycle-handlers.ts": {
-          "bytesInOutput": 20920
+          "bytesInOutput": 21304
         },
         "src/runtime/session-resources.ts": {
           "bytesInOutput": 463
@@ -16145,7 +16166,7 @@
           "bytesInOutput": 5262
         },
         "src/extension/registration/subagent-manager-setup.ts": {
-          "bytesInOutput": 4912
+          "bytesInOutput": 7568
         },
         "src/extension/registration/subagent-tools.ts": {
           "bytesInOutput": 15572
@@ -16166,7 +16187,7 @@
           "bytesInOutput": 81
         }
       },
-      "bytes": 2791928
+      "bytes": 2800922
     }
   }
 }