pi-crew 0.9.38 → 0.9.40

package/CHANGELOG.md

@@ -1,5 +1,31 @@
 # Changelog
 
+## [0.9.40] — stale-reconciler fix + async dispatch + gitignore cleanup (2026-07-16)
+
+### Fixes
+
+- **Stale-reconciler `needs_attention` status inference** — `src/runtime/stale-reconciler.ts`. When all tasks end in `needs_attention` (no explicit failure), `reconcileStaleRun` previously marked the run `completed`. This contradicted the codebase convention in `chain-executor.ts:147` (treating `needs_attention` as a non-clean terminal). Now includes `needs_attention` in the `hasFailed` predicate, marking the run `failed` instead. Tests cover: all-`needs_attention` → failed; mix `needs_attention`+completed → failed.
+
+### Performance
+
+- **Async `saveRunTasks` in `runCoalescedTaskGroup`** — `src/runtime/run-coalesced-task-group.ts`. Replaced 4 synchronous `saveRunTasks` calls with `await saveRunTasksAsync` (from `state-store.ts:493`). The heartbeat `setInterval` callback was promoted to `async () =>` to support the await. With many coalesced groups running in parallel these sync writes blocked the event loop briefly; the async version uses `withRunLock` (non-blocking). No behavioral change.
+
+### Cleanup
+
+- **`src/**/*.js` gitignored** — `.gitignore`. 290 strip-types companion files in `src/` were untracked noise in `git status`. Added `src/**/*.js` rule. No runtime impact.
+
+## [0.9.39] — foreground abort fix + security hardening (2026-07-15)
+
+### Fixes
+
+- **Foreground abort semantics** — `src/extension/register.ts`. The `session_shutdown` handler now checks `event.reason` before aborting foreground team runs. Session switch (`reason="resume"/"new"/"fork"`) preserves foreground runs per P0 fix intent; only actual shutdown (`reason="quit"/"reload"`) aborts them. Extracted `cleanupSessionResourcesOnly()` for session-switch cleanup path.
+- **`createRunPaths` cwd validation** — `src/state/state-store.ts`. Added defensive check rejecting `undefined`/empty/null `cwd` to prevent accidental `undefined/` directory creation.
+- **EPERM lock handling documented** — `src/state/locks.ts`. Added detailed JSDoc explaining the EPERM-as-stealable trade-off rationale. Added `SEC-008` entry in `SECURITY-ISSUES.md` as accepted risk.
+
+### Cleanup
+
+- Removed stale `undefined/` directory and added to `.gitignore`.
+
 ## [0.9.38] — cold context activation + UI polish (2026-07-15)
 
 Fixes and UX polish following v0.9.37's cold-context groundwork:

package/dist/build-meta.json

@@ -6175,7 +6175,7 @@
       "format": "esm"
     },
     "src/state/locks.ts": {
-      "bytes": 15906,
+      "bytes": 17045,
       "imports": [
         {
           "path": "node:crypto",
@@ -6598,7 +6598,7 @@
       "format": "esm"
     },
     "src/state/state-store.ts": {
-      "bytes": 40339,
+      "bytes": 40424,
       "imports": [
         {
           "path": "node:fs",
@@ -6794,7 +6794,7 @@
       "format": "esm"
     },
     "src/runtime/stale-reconciler.ts": {
-      "bytes": 28660,
+      "bytes": 28694,
       "imports": [
         {
           "path": "node:fs",
@@ -14343,7 +14343,7 @@
       "format": "esm"
     },
     "src/runtime/run-coalesced-task-group.ts": {
-      "bytes": 9226,
+      "bytes": 9281,
       "imports": [
         {
           "path": "node:fs/promises",
@@ -18003,7 +18003,7 @@
       "format": "esm"
     },
     "src/extension/register.ts": {
-      "bytes": 68063,
+      "bytes": 70731,
       "imports": [
         {
           "path": "node:fs",
@@ -18425,7 +18425,7 @@
       "imports": [],
       "exports": [],
       "inputs": {},
-      "bytes": 6704580
+      "bytes": 6709812
     },
     "dist/index.mjs": {
       "imports": [
@@ -20704,7 +20704,7 @@
           "bytesInOutput": 1803
         },
         "src/state/state-store.ts": {
-          "bytesInOutput": 20386
+          "bytesInOutput": 20475
         },
         "src/utils/file-coalescer.ts": {
           "bytesInOutput": 1204
@@ -20725,7 +20725,7 @@
           "bytesInOutput": 4162
         },
         "src/runtime/stale-reconciler.ts": {
-          "bytesInOutput": 16497
+          "bytesInOutput": 16532
         },
         "src/runtime/worker-heartbeat.ts": {
           "bytesInOutput": 580
@@ -21733,7 +21733,7 @@
           "bytesInOutput": 7286
         },
         "src/runtime/run-coalesced-task-group.ts": {
-          "bytesInOutput": 6313
+          "bytesInOutput": 6363
         },
         "src/runtime/runtime-policy.ts": {
           "bytesInOutput": 575
@@ -22030,7 +22030,7 @@
           "bytesInOutput": 3150
         },
         "src/extension/register.ts": {
-          "bytesInOutput": 45555
+          "bytesInOutput": 47211
         },
         "src/runtime/batch-barrier.ts": {
           "bytesInOutput": 3060
@@ -22135,7 +22135,7 @@
           "bytesInOutput": 81
         }
       },
-      "bytes": 3175900
+      "bytes": 3177730
     }
   }
 }

package/dist/index.mjs

@@ -13483,6 +13483,9 @@ function validateRunManifestPaths(cwd, runId, manifest, stateRoot, tasksPath) {
   return true;
 }
 function createRunPaths(cwd, runId = createRunId()) {
+  if (!cwd || typeof cwd !== "string") {
+    throw new Error(`Invalid cwd: ${cwd}`);
+  }
   assertSafePathId("runId", runId);
   const baseRoot = scopeBaseRoot(cwd);
   const stateRoot = resolveContainedRelativePath(path11.join(baseRoot, DEFAULT_PATHS.state.runsSubdir), runId, "runId");
@@ -14998,7 +15001,7 @@ function checkResultFile(manifest, tasks) {
     (t2) => t2.status === "completed" || t2.status === "failed" || t2.status === "cancelled" || t2.status === "skipped" || t2.status === "needs_attention"
   );
   if (allTerminal) {
-    const hasFailed = tasks.some((t2) => t2.status === "failed");
+    const hasFailed = tasks.some((t2) => t2.status === "failed" || t2.status === "needs_attention");
     const onlyCancelledOrSkipped = tasks.every((t2) => t2.status === "cancelled" || t2.status === "skipped");
     manifest.status = hasFailed ? "failed" : onlyCancelledOrSkipped ? "cancelled" : "completed";
     saveRunManifest(manifest);
@@ -55557,7 +55560,7 @@ async function runCoalescedTaskGroup(input) {
     }
     return t2;
   });
-  saveRunTasks(manifest, updatedTasks);
+  await saveRunTasksAsync(manifest, updatedTasks);
   await appendEventAsync(manifest.eventsPath, {
     type: "task.coalesced_dispatch_start",
     runId: manifest.runId,
@@ -55572,14 +55575,14 @@ async function runCoalescedTaskGroup(input) {
       heartbeat: t2.heartbeat ?? createWorkerHeartbeat(t2.id)
     };
   });
-  saveRunTasks(manifest, updatedTasks);
+  await saveRunTasksAsync(manifest, updatedTasks);
   let rawOutput = "";
   let success = false;
   if (!executeWorkers) {
     rawOutput = buildScaffoldOutput(groupTasks);
     success = true;
   } else {
-    const heartbeatTimer = setInterval(() => {
+    const heartbeatTimer = setInterval(async () => {
       const now = (/* @__PURE__ */ new Date()).toISOString();
       updatedTasks = updatedTasks.map((t2) => {
         if (!taskIds.includes(t2.id)) return t2;
@@ -55589,7 +55592,7 @@ async function runCoalescedTaskGroup(input) {
         };
       });
       try {
-        saveRunTasks(manifest, updatedTasks);
+        await saveRunTasksAsync(manifest, updatedTasks);
       } catch {
       }
     }, 15e3);
@@ -55639,7 +55642,7 @@ async function runCoalescedTaskGroup(input) {
       resultArtifact
     };
   });
-  saveRunTasks(manifest, updatedTasks);
+  await saveRunTasksAsync(manifest, updatedTasks);
   let updatedManifest = {
     ...manifest,
     artifacts: mergeArtifacts([...manifest.artifacts, ...newArtifacts])
@@ -85061,6 +85064,45 @@ Subagent may need manual intervention.`
       return loaded.tasks.some((t2) => t2.status === "running" || t2.status === "queued");
     };
   });
+  const cleanupSessionResourcesOnly = () => {
+    if (cleanedUp) return;
+    cleanedUp = true;
+    if (preloadTimer) {
+      clearTimeout(preloadTimer);
+      preloadTimer = void 0;
+    }
+    crewRunWatchers?.closeAll();
+    crewRunWatchers = void 0;
+    userCrewWatchers?.closeAll();
+    userCrewWatchers = void 0;
+    stopSessionBoundSubagents();
+    crewScheduler?.stop();
+    stopAsyncRunNotifier(notifierState);
+    purgeStaleActiveRunIndexSyncIfLoaded();
+    stopCrewWidget(currentCtx, widgetState, currentCtx ? loadConfig(currentCtx.cwd).config.ui : void 0);
+    clearPiCrewPowerbar(pi.events);
+    disposePowerbarCoalescer();
+    disposeObservability(observabilityState, cleanedUp);
+    lifecycleState.deliveryCoordinator?.dispose();
+    clearHooksScoped();
+    uninstallCrewGlobalRegistry();
+    lifecycleState.overflowTracker?.dispose();
+    lifecycleState.deliveryCoordinator = void 0;
+    lifecycleState.overflowTracker = void 0;
+    manifestCache2.dispose();
+    runSnapshotCache.dispose?.();
+    clearProjectRootCache();
+    renderScheduler?.dispose();
+    renderScheduler = void 0;
+    autoRecoveryLast.clear();
+    disposeNotifications(lifecycleState);
+    rpcHandle?.unsubscribe();
+    rpcHandle = void 0;
+    disposeI18n();
+    sessionGeneration += 1;
+    currentCtx = void 0;
+    if (globalStore[runtimeCleanupStoreKey] === cleanupSessionResourcesOnly) delete globalStore[runtimeCleanupStoreKey];
+  };
   const cleanupRuntime = () => {
     if (cleanedUp) return;
     cleanedUp = true;
@@ -85103,6 +85145,14 @@ Subagent may need manual intervention.`
     if (globalStore[runtimeCleanupStoreKey] === cleanupRuntime) delete globalStore[runtimeCleanupStoreKey];
   };
   globalStore[runtimeCleanupStoreKey] = cleanupRuntime;
+  pi.on("session_shutdown", (event) => {
+    const reason = typeof event === "object" && event !== null && "reason" in event ? event.reason : void 0;
+    if (reason === "quit" || reason === "reload") {
+      cleanupRuntime();
+    } else {
+      cleanupSessionResourcesOnly();
+    }
+  });
   pi.on("session_start", (_event, ctx) => {
     runArtifactCleanup(ctx.cwd);
     try {
@@ -85583,7 +85633,6 @@ Subagent may need manual intervention.`
     stopAsyncRunNotifier(notifierState);
     stopSessionBoundSubagents();
   });
-  pi.on("session_shutdown", () => cleanupRuntime());
   try {
     pi.on("resources_discover", () => {
       const sessionCwd = currentCtx?.cwd ?? process.cwd();