pi-crew 0.9.16 → 0.9.18

package/src/extension/team-tool/context.ts

@@ -1,24 +1,25 @@
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
 import type { PiTeamsConfig } from "../../config/config.ts";
 import type { MetricRegistry } from "../../observability/metric-registry.ts";
-import type { TeamToolDetails } from "../team-tool-types.ts";
 import type { RunSnapshotCache } from "../../ui/run-snapshot-cache.ts";
-import { toolResult, type PiTeamsToolResult } from "../tool-result.ts";
+import type { TeamToolDetails } from "../team-tool-types.ts";
+import { type PiTeamsToolResult, toolResult } from "../tool-result.ts";
 
-export type TeamContext = Pick<ExtensionContext, "cwd"> & Partial<Pick<ExtensionContext, "model">> & {
-	sessionId?: string;
-	modelRegistry?: unknown;
-	sessionManager?: { getBranch?: () => unknown[] };
-	events?: { emit?: (event: string, data: unknown) => void };
-	metricRegistry?: MetricRegistry;
-	signal?: AbortSignal;
-	startForegroundRun?: (runner: (signal?: AbortSignal) => Promise<void>, runId?: string) => void;
-	abortForegroundRun?: (runId: string) => boolean;
-	onRunStarted?: (runId: string) => void;
-	onJsonEvent?: (taskId: string, runId: string, event: unknown) => void;
-	config?: PiTeamsConfig;
-	getRunSnapshotCache?: (cwd: string) => RunSnapshotCache;
-};
+export type TeamContext = Pick<ExtensionContext, "cwd"> &
+	Partial<Pick<ExtensionContext, "model">> & {
+		sessionId?: string;
+		modelRegistry?: unknown;
+		sessionManager?: { getBranch?: () => unknown[] };
+		events?: { emit?: (event: string, data: unknown) => void };
+		metricRegistry?: MetricRegistry;
+		signal?: AbortSignal;
+		startForegroundRun?: (runner: (signal?: AbortSignal) => Promise<void>, runId?: string) => void;
+		abortForegroundRun?: (runId: string) => boolean;
+		onRunStarted?: (runId: string) => void;
+		onJsonEvent?: (taskId: string, runId: string, event: unknown) => void;
+		config?: PiTeamsConfig;
+		getRunSnapshotCache?: (cwd: string) => RunSnapshotCache;
+	};
 
 export function withSessionId<T extends Pick<ExtensionContext, "sessionManager">>(ctx: T): T & { sessionId?: string } {
 	const sessionId = ctx.sessionManager?.getSessionId?.();
@@ -36,7 +37,14 @@ export function formatScoped(name: string, source: string, description: string):
 function extractTextContent(content: unknown): string {
 	if (typeof content === "string") return content;
 	if (!Array.isArray(content)) return "";
-	return content.map((part) => part && typeof part === "object" && !Array.isArray(part) && typeof (part as { text?: unknown }).text === "string" ? (part as { text: string }).text : "").filter(Boolean).join("\n");
+	return content
+		.map((part) =>
+			part && typeof part === "object" && !Array.isArray(part) && typeof (part as { text?: unknown }).text === "string"
+				? (part as { text: string }).text
+				: "",
+		)
+		.filter(Boolean)
+		.join("\n");
 }
 
 export function buildParentContext(ctx: TeamContext): string | undefined {
@@ -45,15 +53,27 @@ export function buildParentContext(ctx: TeamContext): string | undefined {
 	const parts: string[] = [];
 	for (const entry of branch.slice(-20)) {
 		if (!entry || typeof entry !== "object" || Array.isArray(entry)) continue;
-		const record = entry as { type?: unknown; message?: unknown; summary?: unknown };
+		const record = entry as {
+			type?: unknown;
+			message?: unknown;
+			summary?: unknown;
+		};
 		if (record.type === "compaction" && typeof record.summary === "string") parts.push(`[Summary]: ${record.summary}`);
-		const message = record.message && typeof record.message === "object" && !Array.isArray(record.message) ? record.message as { role?: unknown; content?: unknown } : undefined;
+		const message =
+			record.message && typeof record.message === "object" && !Array.isArray(record.message)
+				? (record.message as { role?: unknown; content?: unknown })
+				: undefined;
 		if (!message || (message.role !== "user" && message.role !== "assistant")) continue;
 		const text = extractTextContent(message.content).trim();
 		if (text) parts.push(`[${message.role === "user" ? "User" : "Assistant"}]: ${text}`);
 	}
 	if (!parts.length) return undefined;
-	return [`# Parent Conversation Context`, "The following context was inherited from the parent Pi session. Treat it as reference-only.", "", parts.join("\n\n")].join("\n");
+	return [
+		`# Parent Conversation Context`,
+		"The following context was inherited from the parent Pi session. Treat it as reference-only.",
+		"",
+		parts.join("\n\n"),
+	].join("\n");
 }
 
 export function configRecord(config: unknown): Record<string, unknown> {

package/src/extension/team-tool/destructive-gate.ts

@@ -20,7 +20,15 @@
  *  5. Otherwise → blocked with a reason telling the user what to pass.
  */
 
-export const DESTRUCTIVE_TEAM_ACTIONS = new Set(["delete", "forget", "prune", "cleanup", "workflow-create", "workflow-save", "workflow-delete"]);
+export const DESTRUCTIVE_TEAM_ACTIONS = new Set([
+	"delete",
+	"forget",
+	"prune",
+	"cleanup",
+	"workflow-create",
+	"workflow-save",
+	"workflow-delete",
+]);
 
 export interface TeamToolInputLike {
 	action?: unknown;
@@ -33,10 +41,7 @@ export interface TeamToolInputLike {
  * Decide whether a destructive team action should be blocked.
  * @returns block reason string, or `undefined` to allow.
  */
-export function shouldBlockDestructiveTeamAction(
-	action: string | undefined,
-	input: TeamToolInputLike,
-): string | undefined {
+export function shouldBlockDestructiveTeamAction(action: string | undefined, input: TeamToolInputLike): string | undefined {
 	if (!action || !DESTRUCTIVE_TEAM_ACTIONS.has(action)) return undefined;
 	// dryRun cleanup is a PREVIEW (no writes) — never needs confirm.
 	if (action === "cleanup" && input.dryRun === true) return undefined;

package/src/extension/team-tool/doctor.ts

@@ -2,19 +2,19 @@ import { execFileSync, spawnSync } from "node:child_process";
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { allAgents, discoverAgents } from "../../agents/discover-agents.ts";
-import { allTeams, discoverTeams } from "../../teams/discover-teams.ts";
-import { allWorkflows, discoverWorkflows } from "../../workflows/discover-workflows.ts";
 import { loadConfig } from "../../config/config.ts";
-import { projectCrewRoot, userCrewRoot } from "../../utils/paths.ts";
 import { DEFAULT_PATHS } from "../../config/defaults.ts";
-import type { TeamToolParamsValue } from "../../schema/team-tool-schema.ts";
+import { type DriftReport, detectDrift, formatDriftReport } from "../../config/drift-detector.ts";
 import { getPiSpawnCommand } from "../../runtime/pi-spawn.ts";
 import { getRuntimeWarmupStatus } from "../../runtime/runtime-warmup.ts";
-import { scanZombieSubagents, formatZombieReport } from "../../runtime/zombie-scanner.ts";
-import { validateResources } from "../validate-resources.ts";
-import { detectDrift, formatDriftReport, type DriftReport } from "../../config/drift-detector.ts";
+import { formatZombieReport, scanZombieSubagents } from "../../runtime/zombie-scanner.ts";
+import type { TeamToolParamsValue } from "../../schema/team-tool-schema.ts";
 import { TeamToolParams } from "../../schema/team-tool-schema.ts";
+import { allTeams, discoverTeams } from "../../teams/discover-teams.ts";
+import { projectCrewRoot, userCrewRoot } from "../../utils/paths.ts";
+import { allWorkflows, discoverWorkflows } from "../../workflows/discover-workflows.ts";
 import type { PiTeamsToolResult } from "../tool-result.ts";
+import { validateResources } from "../validate-resources.ts";
 import { configRecord, result, type TeamContext } from "./context.ts";
 
 interface DoctorCheck {
@@ -25,7 +25,12 @@ interface DoctorCheck {
 
 function firstOutputLine(stdout: string | null | undefined, stderr: string | null | undefined): string {
 	const output = `${stdout ?? ""}\n${stderr ?? ""}`.trim();
-	return output.split(/\r?\n/).find((line) => line.trim().length > 0)?.trim() ?? "available";
+	return (
+		output
+			.split(/\r?\n/)
+			.find((line) => line.trim().length > 0)
+			?.trim() ?? "available"
+	);
 }
 
 // Round 29 optimization: memoize spawnSync probe results at module level.
@@ -42,16 +47,28 @@ function commandExists(command: string, args: string[]): { ok: boolean; detail:
 	if (cached) return cached;
 	let result: { ok: boolean; detail: string };
 	try {
-		const output = spawnSync(command, args, { encoding: "utf-8", stdio: ["ignore", "pipe", "pipe"] });
+		const output = spawnSync(command, args, {
+			encoding: "utf-8",
+			stdio: ["ignore", "pipe", "pipe"],
+		});
 		if (output.error) {
 			result = { ok: false, detail: output.error.message };
 		} else if (output.status !== 0) {
-			result = { ok: false, detail: firstOutputLine(output.stdout, output.stderr) || `status ${output.status}` };
+			result = {
+				ok: false,
+				detail: firstOutputLine(output.stdout, output.stderr) || `status ${output.status}`,
+			};
 		} else {
-			result = { ok: true, detail: firstOutputLine(output.stdout, output.stderr) };
+			result = {
+				ok: true,
+				detail: firstOutputLine(output.stdout, output.stderr),
+			};
 		}
 	} catch (error) {
-		result = { ok: false, detail: error instanceof Error ? error.message : String(error) };
+		result = {
+			ok: false,
+			detail: error instanceof Error ? error.message : String(error),
+		};
 	}
 	commandExistsCache.set(cacheKey, result);
 	return result;
@@ -67,7 +84,10 @@ function piCommandExists(): { ok: boolean; detail: string } {
 		return piCommandExistsCache;
 	}
 	const executable = spec.command === "pi" ? "pi" : `${spec.command} ${spec.args[0] ?? ""}`.trim();
-	piCommandExistsCache = { ok: true, detail: `${output.detail} (${executable})` };
+	piCommandExistsCache = {
+		ok: true,
+		detail: `${output.detail} (${executable})`,
+	};
 	return piCommandExistsCache;
 }
 
@@ -81,7 +101,10 @@ function checkWritableDir(dir: string): { ok: boolean; detail: string } {
 			fs.writeFileSync(probePath, "ok", "utf-8");
 			fs.rmSync(probePath, { force: true });
 		} catch {
-			return { ok: false, detail: `${dir}: not writable (write test failed)` };
+			return {
+				ok: false,
+				detail: `${dir}: not writable (write test failed)`,
+			};
 		}
 		return { ok: true, detail: dir };
 	} catch (error) {
@@ -96,7 +119,8 @@ function auditJsonSchema(schema: unknown): string[] {
 		if (!node || typeof node !== "object" || Array.isArray(node)) return;
 		const record = node as Record<string, unknown>;
 		if (Array.isArray(record.type)) issues.push("schema node uses array-valued type");
-		if (record.description && !record.type && !record.anyOf && !record.oneOf && !record.allOf && !record.properties) issues.push(`description-only schema node: ${record.description}`);
+		if (record.description && !record.type && !record.anyOf && !record.oneOf && !record.allOf && !record.properties)
+			issues.push(`description-only schema node: ${record.description}`);
 		if (record.type === "array" && !record.items) issues.push("array schema missing items");
 		if (record.type && (record.anyOf || record.oneOf)) issues.push("schema node combines type with union keyword");
 		for (const value of Object.values(record)) {
@@ -160,58 +184,128 @@ export function buildTeamDoctorReport(input: TeamDoctorReportInput): TeamDoctorR
 			const pi = piCommandExists();
 			return [
 				{ label: "cwd", ok: true, detail: input.cwd },
-				{ label: "platform", ok: true, detail: `${process.platform}/${process.arch} node=${process.version}` },
+				{
+					label: "platform",
+					ok: true,
+					detail: `${process.platform}/${process.arch} node=${process.version}`,
+				},
 				{ label: "pi command", ok: pi.ok, detail: pi.detail },
 				{ label: "git command", ok: git.ok, detail: git.detail },
-				{ label: "config", ok: input.configErrors.length === 0, detail: `${input.configPath} (${input.configErrors.length} errors)` },
-				{ label: "model", ok: true, detail: input.model ? `${input.model.provider}/${input.model.id}` : "not available in this context" },
-				{ label: "config warnings", ok: true, detail: `${input.configWarnings.length} warnings` },
+				{
+					label: "config",
+					ok: input.configErrors.length === 0,
+					detail: `${input.configPath} (${input.configErrors.length} errors)`,
+				},
+				{
+					label: "model",
+					ok: true,
+					detail: input.model ? `${input.model.provider}/${input.model.id}` : "not available in this context",
+				},
+				{
+					label: "config warnings",
+					ok: true,
+					detail: `${input.configWarnings.length} warnings`,
+				},
 			];
 		}),
 		section("Filesystem", () => {
 			const userWritable = checkWritableDir(userCrewRoot());
 			const projectWritable = checkWritableDir(projectCrewRoot(input.cwd));
 			return [
-				{ label: "user state", ok: userWritable.ok || userWritable.detail.endsWith(": missing"), detail: userWritable.detail },
-				{ label: "project state", ok: projectWritable.ok || projectWritable.detail.endsWith(": missing"), detail: projectWritable.detail },
-				{ label: "project state root", ok: true, detail: path.join(projectCrewRoot(input.cwd), DEFAULT_PATHS.state.runsSubdir) },
-				{ label: "artifacts root", ok: true, detail: path.join(projectCrewRoot(input.cwd), DEFAULT_PATHS.state.artifactsSubdir) },
+				{
+					label: "user state",
+					ok: userWritable.ok || userWritable.detail.endsWith(": missing"),
+					detail: userWritable.detail,
+				},
+				{
+					label: "project state",
+					ok: projectWritable.ok || projectWritable.detail.endsWith(": missing"),
+					detail: projectWritable.detail,
+				},
+				{
+					label: "project state root",
+					ok: true,
+					detail: path.join(projectCrewRoot(input.cwd), DEFAULT_PATHS.state.runsSubdir),
+				},
+				{
+					label: "artifacts root",
+					ok: true,
+					detail: path.join(projectCrewRoot(input.cwd), DEFAULT_PATHS.state.artifactsSubdir),
+				},
 			];
 		}),
 		section("Discovery", () => {
 			const agentModelHints = discoveredAgentsAll.filter((agent) => agent.model || agent.fallbackModels?.length).length;
 			return [
-				{ label: "agents", ok: true, detail: `${discoveredAgentsAll.length} discovered` },
-				{ label: "teams", ok: true, detail: `${discoveredTeamsAll.length} discovered` },
-				{ label: "workflows", ok: true, detail: `${discoveredWorkflowsAll.length} discovered` },
-				{ label: "resource model hints", ok: true, detail: `${agentModelHints} agents declare model/fallback preferences` },
+				{
+					label: "agents",
+					ok: true,
+					detail: `${discoveredAgentsAll.length} discovered`,
+				},
+				{
+					label: "teams",
+					ok: true,
+					detail: `${discoveredTeamsAll.length} discovered`,
+				},
+				{
+					label: "workflows",
+					ok: true,
+					detail: `${discoveredWorkflowsAll.length} discovered`,
+				},
+				{
+					label: "resource model hints",
+					ok: true,
+					detail: `${agentModelHints} agents declare model/fallback preferences`,
+				},
 			];
 		}),
-		section("Resource validation", () => [{
-			label: "resource validation",
-			ok: input.validationErrors === 0,
-			detail: `${input.validationErrors} errors, ${input.validationWarnings} warnings`,
-		}]),
+		section("Resource validation", () => [
+			{
+				label: "resource validation",
+				ok: input.validationErrors === 0,
+				detail: `${input.validationErrors} errors, ${input.validationWarnings} warnings`,
+			},
+		]),
 		section("Drift", () => {
 			const driftErrors = driftResult.items.filter((item) => item.severity === "error").length;
 			const driftWarnings = driftResult.items.filter((item) => item.severity === "warning").length;
-			return [{
-				label: "config drift",
-				ok: !driftResult.hasDrift || driftErrors === 0,
-				detail: driftResult.hasDrift ? `${driftErrors} errors, ${driftWarnings} warnings` : "no drift detected",
-			}];
+			return [
+				{
+					label: "config drift",
+					ok: !driftResult.hasDrift || driftErrors === 0,
+					detail: driftResult.hasDrift ? `${driftErrors} errors, ${driftWarnings} warnings` : "no drift detected",
+				},
+			];
 		}),
 		section("Schema", () => {
 			const schemaIssues = auditJsonSchema(TeamToolParams);
-			return [{ label: "strict-provider schema", ok: schemaIssues.length === 0, detail: schemaIssues.length ? schemaIssues.slice(0, 3).join("; ") : "team tool schema compatible" }];
+			return [
+				{
+					label: "strict-provider schema",
+					ok: schemaIssues.length === 0,
+					detail: schemaIssues.length ? schemaIssues.slice(0, 3).join("; ") : "team tool schema compatible",
+				},
+			];
 		}),
 		section("Async/result delivery", () => [
-			{ label: "result watcher", ok: true, detail: "fs.watch with polling fallback for EMFILE/ENOSPC/EPERM" },
-			{ label: "async notifier", ok: true, detail: "session-stale guarded completion notifications enabled" },
+			{
+				label: "result watcher",
+				ok: true,
+				detail: "fs.watch with polling fallback for EMFILE/ENOSPC/EPERM",
+			},
+			{
+				label: "async notifier",
+				ok: true,
+				detail: "session-stale guarded completion notifications enabled",
+			},
 		]),
 		section("Worktrees", () => [
 			{ label: "leader repository", ok: true, detail: input.cwd },
-			{ label: "cleanup policy", ok: true, detail: "dirty worktrees preserved unless force is set" },
+			{
+				label: "cleanup policy",
+				ok: true,
+				detail: "dirty worktrees preserved unless force is set",
+			},
 		]),
 		section("Runtime warmup (cold-start fix v0.8.6)", () => {
 			// Surface whether the general cold-start-race fix is active + how long
@@ -229,17 +323,27 @@ export function buildTeamDoctorReport(input: TeamDoctorReportInput): TeamDoctorR
 				{
 					label: "warmup started",
 					ok: true, // informational — "not started" is not a failure
-					detail: status.started ? "module graph pre-warmed at registration" : "not started in this process (normal for direct unit-test calls; in a live Pi session, started at extension load)",
+					detail: status.started
+						? "module graph pre-warmed at registration"
+						: "not started in this process (normal for direct unit-test calls; in a live Pi session, started at extension load)",
 				},
 			];
 			if (status.started) {
 				checks.push({
 					label: "warmup completed",
 					ok: status.completed,
-					detail: status.completed ? (status.durationMs !== undefined ? `graph warm in ${status.durationMs}ms` : "completed") : "in progress",
+					detail: status.completed
+						? status.durationMs !== undefined
+							? `graph warm in ${status.durationMs}ms`
+							: "completed"
+						: "in progress",
 				});
 				if (status.error) {
-					checks.push({ label: "warmup error", ok: false, detail: status.error });
+					checks.push({
+						label: "warmup error",
+						ok: false,
+						detail: status.error,
+					});
 				}
 			}
 			return checks;
@@ -257,7 +361,11 @@ export function buildTeamDoctorReport(input: TeamDoctorReportInput): TeamDoctorR
 	}
 	if (lines.at(-1) === "") lines.pop();
 	const text = lines.join("\n");
-	return { text, hasErrors: sections.some((sectionLines) => sectionLines.some((line) => line.includes("FAIL"))), drift: driftResult.hasDrift ? driftResult : undefined };
+	return {
+		text,
+		hasErrors: sections.some((sectionLines) => sectionLines.some((line) => line.includes("FAIL"))),
+		drift: driftResult.hasDrift ? driftResult : undefined,
+	};
 }
 
 export function handleDoctor(ctx: TeamContext, params: TeamToolParamsValue = {}): PiTeamsToolResult {
@@ -267,11 +375,19 @@ export function handleDoctor(ctx: TeamContext, params: TeamToolParamsValue = {})
 	if (params.focus === "zombies") {
 		const scan = scanZombieSubagents();
 		const text = formatZombieReport(scan);
-		return result(text, {
-			action: "doctor",
-			status: "ok",
-			data: { zombies: scan.zombies.length, live: scan.live.length, errors: scan.errors.length },
-		}, false);
+		return result(
+			text,
+			{
+				action: "doctor",
+				status: "ok",
+				data: {
+					zombies: scan.zombies.length,
+					live: scan.live.length,
+					errors: scan.errors.length,
+				},
+			},
+			false,
+		);
 	}
 
 	const loadedConfig = loadConfig(ctx.cwd);
@@ -285,7 +401,10 @@ export function handleDoctor(ctx: TeamContext, params: TeamToolParamsValue = {})
 				stdio: ["ignore", "pipe", "pipe"],
 				timeout: 15_000,
 			}).trim();
-			smokeChildPi = { ok: output.includes("PI-TEAMS-SMOKE-OK"), detail: output.split("\n").slice(-1)[0] ?? "completed" };
+			smokeChildPi = {
+				ok: output.includes("PI-TEAMS-SMOKE-OK"),
+				detail: output.split("\n").slice(-1)[0] ?? "completed",
+			};
 		} catch (error) {
 			const message = error instanceof Error ? error.message : String(error);
 			smokeChildPi = { ok: false, detail: message };