pi-crew 0.9.16 → 0.9.17

package/src/extension/team-tool/status.ts

@@ -1,20 +1,20 @@
 import { loadConfig } from "../../config/config.ts";
-import type { TeamToolParamsValue } from "../../schema/team-tool-schema.ts";
-import { appendEvent, readEvents } from "../../state/event-log.ts";
-import { readDeliveryState, readMailbox } from "../../state/mailbox.ts";
-import { loadRunManifestById, updateRunStatus, saveRunTasks } from "../../state/state-store.ts";
-import { aggregateUsage, formatUsage, formatCost } from "../../state/usage.ts";
 import { applyAttentionState, formatActivityAge, resolveCrewControlConfig } from "../../runtime/agent-control.ts";
+import { extractCommandTrace } from "../../runtime/command-trace.ts";
+import { verifyTaskCompletion } from "../../runtime/completion-guard.ts";
 import { readCrewAgents } from "../../runtime/crew-agent-records.ts";
+import { evaluateRunEffectiveness } from "../../runtime/effectiveness.ts";
+import { computePhaseProgress } from "../../runtime/phase-progress.ts";
 import { checkProcessLiveness, isActiveRunStatus } from "../../runtime/process-status.ts";
 import { formatTaskGraphLines, waitingReason } from "../../runtime/task-display.ts";
-import { computePhaseProgress } from "../../runtime/phase-progress.ts";
+import type { TeamToolParamsValue } from "../../schema/team-tool-schema.ts";
+import { appendEvent, readEvents } from "../../state/event-log.ts";
+import { readDeliveryState, readMailbox } from "../../state/mailbox.ts";
+import { loadRunManifestById, saveRunTasks, updateRunStatus } from "../../state/state-store.ts";
+import { aggregateUsage, formatCost, formatUsage } from "../../state/usage.ts";
 import { formatDuration } from "../../ui/tool-render.ts";
-import { verifyTaskCompletion } from "../../runtime/completion-guard.ts";
-import { evaluateRunEffectiveness } from "../../runtime/effectiveness.ts";
-import { extractCommandTrace } from "../../runtime/command-trace.ts";
-import type { PiTeamsToolResult } from "../tool-result.ts";
 import { locateRunCwd } from "../team-tool.ts";
+import type { PiTeamsToolResult } from "../tool-result.ts";
 import { result, type TeamContext } from "./context.ts";
 import { RUN_NOT_FOUND_HINT } from "./run-not-found.ts";
 
@@ -36,9 +36,23 @@ export function handleStatus(params: TeamToolParamsValue, ctx: TeamContext): PiT
 		asyncLivenessLine = `Async: pid=${asyncState.pid ?? "unknown"} alive=${liveness.alive ? "true" : "false"} detail=${liveness.detail} log=${asyncState.logPath} spawnedAt=${asyncState.spawnedAt}`;
 		if (!liveness.alive && isActiveRunStatus(manifest.status)) {
 			manifest = updateRunStatus(manifest, "failed", `Async process stale: ${liveness.detail}`);
-			tasks = tasks.map((task) => task.status === "running" ? { ...task, status: "cancelled" as const, finishedAt: new Date().toISOString(), error: "Async process died; task was not completed." } : task);
+			tasks = tasks.map((task) =>
+				task.status === "running"
+					? {
+							...task,
+							status: "cancelled" as const,
+							finishedAt: new Date().toISOString(),
+							error: "Async process died; task was not completed.",
+						}
+					: task,
+			);
 			saveRunTasks(manifest, tasks);
-			appendEvent(manifest.eventsPath, { type: "async.stale", runId: manifest.runId, message: liveness.detail, data: { pid: asyncState.pid } });
+			appendEvent(manifest.eventsPath, {
+				type: "async.stale",
+				runId: manifest.runId,
+				message: liveness.detail,
+				data: { pid: asyncState.pid },
+			});
 		}
 	}
 	const counts = new Map<string, number>();
@@ -46,32 +60,64 @@ export function handleStatus(params: TeamToolParamsValue, ctx: TeamContext): PiT
 	const phaseProgress = computePhaseProgress(tasks);
 	const allEvents = readEvents(manifest.eventsPath);
 	const events = allEvents.slice(-8);
-	const attentionByTask = new Map(allEvents.filter((event) => event.type === "task.attention" && event.taskId).map((event) => [event.taskId!, event]));
+	const attentionByTask = new Map(
+		allEvents.filter((event) => event.type === "task.attention" && event.taskId).map((event) => [event.taskId!, event]),
+	);
 	const controlConfig = resolveCrewControlConfig(loadConfig(ctx.cwd).config);
 	const crewAgents = readCrewAgents(manifest).map((agent) => applyAttentionState(manifest, agent, controlConfig));
-	const artifactLines = manifest.artifacts.slice(-10).map((artifact) => `- ${artifact.kind}: ${artifact.path}${artifact.sizeBytes !== undefined ? ` (${artifact.sizeBytes} bytes)` : ""}`);
+	const artifactLines = manifest.artifacts
+		.slice(-10)
+		.map(
+			(artifact) => `- ${artifact.kind}: ${artifact.path}${artifact.sizeBytes !== undefined ? ` (${artifact.sizeBytes} bytes)` : ""}`,
+		);
 	const deliveryState = readDeliveryState(manifest);
 	const ackTimeoutMs = loadConfig(ctx.cwd).config.runtime?.groupJoinAckTimeoutMs;
 	const groupJoinLines: string[] = [];
-	for (const message of readMailbox(manifest, "outbox").filter((m) => m.data?.kind === "group_join").slice(-5)) {
+	for (const message of readMailbox(manifest, "outbox")
+		.filter((m) => m.data?.kind === "group_join")
+		.slice(-5)) {
 		const ack = deliveryState.messages[message.id] === "acknowledged" ? "acknowledged" : "pending";
 		const ageMs = Date.now() - new Date(message.createdAt).getTime();
 		const requestId = String(message.data?.requestId ?? "unknown");
 		const timedOut = ack === "pending" && ackTimeoutMs !== undefined && Number.isFinite(ageMs) && ageMs > ackTimeoutMs;
 		if (timedOut && !allEvents.some((event) => event.type === "agent.group_join.ack_timeout" && event.data?.requestId === requestId)) {
-			appendEvent(manifest.eventsPath, { type: "agent.group_join.ack_timeout", runId: manifest.runId, message: "Group join delivery ack timed out; mailbox delivery remains the fallback.", data: { requestId, messageId: message.id, batchId: message.data?.batchId, partial: message.data?.partial, ageMs, ackTimeoutMs } });
+			appendEvent(manifest.eventsPath, {
+				type: "agent.group_join.ack_timeout",
+				runId: manifest.runId,
+				message: "Group join delivery ack timed out; mailbox delivery remains the fallback.",
+				data: {
+					requestId,
+					messageId: message.id,
+					batchId: message.data?.batchId,
+					partial: message.data?.partial,
+					ageMs,
+					ackTimeoutMs,
+				},
+			});
 		}
-		groupJoinLines.push(`- ${String(message.data?.partial) === "true" ? "partial" : "completed"} request=${requestId} message=${message.id} ack=${timedOut ? "timeout" : ack}`);
+		groupJoinLines.push(
+			`- ${String(message.data?.partial) === "true" ? "partial" : "completed"} request=${requestId} message=${message.id} ack=${timedOut ? "timeout" : ack}`,
+		);
 	}
 	const totalUsage = aggregateUsage(tasks);
 	const completedTasks = tasks.filter((task) => task.status === "completed");
-	const effectiveness = evaluateRunEffectiveness({ manifest, tasks, executeWorkers: manifest.runtimeResolution?.kind !== "scaffold", runtimeConfig: loadConfig(ctx.cwd).config.runtime });
-	const noObservedWorkTasks = effectiveness.noObservedWorkTaskIds.map((id) => tasks.find((task) => task.id === id)).filter((task): task is typeof tasks[number] => task !== undefined);
-	const attentionTasks = effectiveness.needsAttentionTaskIds.map((id) => tasks.find((task) => task.id === id)).filter((task): task is typeof tasks[number] => task !== undefined);
+	const effectiveness = evaluateRunEffectiveness({
+		manifest,
+		tasks,
+		executeWorkers: manifest.runtimeResolution?.kind !== "scaffold",
+		runtimeConfig: loadConfig(ctx.cwd).config.runtime,
+	});
+	const noObservedWorkTasks = effectiveness.noObservedWorkTaskIds
+		.map((id) => tasks.find((task) => task.id === id))
+		.filter((task): task is (typeof tasks)[number] => task !== undefined);
+	const attentionTasks = effectiveness.needsAttentionTaskIds
+		.map((id) => tasks.find((task) => task.id === id))
+		.filter((task): task is (typeof tasks)[number] => task !== undefined);
 	const activeAgents = crewAgents.filter((agent) => agent.status === "running");
 	const completedAgents = crewAgents.filter((agent) => agent.status !== "running");
 	const waitingTasks = tasks.filter((task) => task.status === "queued" || task.status === "waiting");
-	const agentLine = (agent: typeof crewAgents[number]): string => `- ${agent.id} [${agent.status}] ${agent.role} -> ${agent.agent} runtime=${agent.runtime}${agent.model ? ` model=${agent.model}` : ""}${agent.usage ? ` usage=${formatUsage(agent.usage)}` : ""}${agent.usage?.cost ? ` cost=${formatCost(agent.usage.cost)}` : ""}${agent.progress?.activityState ? ` activityState=${agent.progress.activityState}` : ""}${formatActivityAge(agent) ? ` activity=${formatActivityAge(agent)}` : ""}${agent.progress?.currentTool ? ` tool=${agent.progress.currentTool}` : ""}${agent.toolUses ? ` tools=${agent.toolUses}` : ""}${!agent.usage && agent.progress?.tokens ? ` tokens=${agent.progress.tokens}` : ""}${agent.progress?.turns ? ` turns=${agent.progress.turns}` : ""}${agent.jsonEvents !== undefined ? ` jsonEvents=${agent.jsonEvents}` : ""}${agent.outputPath ? ` output=${agent.outputPath}` : ""}${agent.transcriptPath ? ` transcript=${agent.transcriptPath}` : ""}${agent.statusPath ? ` status=${agent.statusPath}` : ""}${agent.error ? ` error=${agent.error}` : ""}`;
+	const agentLine = (agent: (typeof crewAgents)[number]): string =>
+		`- ${agent.id} [${agent.status}] ${agent.role} -> ${agent.agent} runtime=${agent.runtime}${agent.model ? ` model=${agent.model}` : ""}${agent.usage ? ` usage=${formatUsage(agent.usage)}` : ""}${agent.usage?.cost ? ` cost=${formatCost(agent.usage.cost)}` : ""}${agent.progress?.activityState ? ` activityState=${agent.progress.activityState}` : ""}${formatActivityAge(agent) ? ` activity=${formatActivityAge(agent)}` : ""}${agent.progress?.currentTool ? ` tool=${agent.progress.currentTool}` : ""}${agent.toolUses ? ` tools=${agent.toolUses}` : ""}${!agent.usage && agent.progress?.tokens ? ` tokens=${agent.progress.tokens}` : ""}${agent.progress?.turns ? ` turns=${agent.progress.turns}` : ""}${agent.jsonEvents !== undefined ? ` jsonEvents=${agent.jsonEvents}` : ""}${agent.outputPath ? ` output=${agent.outputPath}` : ""}${agent.transcriptPath ? ` transcript=${agent.transcriptPath}` : ""}${agent.statusPath ? ` status=${agent.statusPath}` : ""}${agent.error ? ` error=${agent.error}` : ""}`;
 	const lines = [
 		`Run: ${manifest.runId}`,
 		`Team: ${manifest.team}`,
@@ -79,7 +125,13 @@ export function handleStatus(params: TeamToolParamsValue, ctx: TeamContext): PiT
 		`Status: ${manifest.status}`,
 		`Progress: ${phaseProgress.overallPercentage}% (~${formatDuration(phaseProgress.estimatedRemainingMs)} remaining)`,
 		`Workspace mode: ${manifest.workspaceMode}`,
-		...(manifest.runtimeResolution ? [`Runtime: ${manifest.runtimeResolution.kind}`, `Runtime safety: ${manifest.runtimeResolution.safety}`, `Runtime requested: ${manifest.runtimeResolution.requestedMode}${manifest.runtimeResolution.reason ? ` (${manifest.runtimeResolution.reason})` : ""}`] : []),
+		...(manifest.runtimeResolution
+			? [
+					`Runtime: ${manifest.runtimeResolution.kind}`,
+					`Runtime safety: ${manifest.runtimeResolution.safety}`,
+					`Runtime requested: ${manifest.runtimeResolution.requestedMode}${manifest.runtimeResolution.reason ? ` (${manifest.runtimeResolution.reason})` : ""}`,
+				]
+			: []),
 		`Goal: ${manifest.goal}`,
 		`Created: ${manifest.createdAt}`,
 		`Updated: ${manifest.updatedAt}`,
@@ -89,7 +141,15 @@ export function handleStatus(params: TeamToolParamsValue, ctx: TeamContext): PiT
 		"Task graph:",
 		...formatTaskGraphLines(tasks),
 		"Tasks:",
-		...(tasks.length ? tasks.map((task) => `- ${task.id} [${task.status}] ${task.role} -> ${task.agent}${task.taskPacket ? ` scope=${task.taskPacket.scope}` : ""}${task.verification ? ` green=${task.verification.observedGreenLevel}/${task.verification.requiredGreenLevel}` : ""}${task.modelAttempts?.length ? ` attempts=${task.modelAttempts.length}` : ""}${task.modelRouting ? ` modelRouting=${task.modelRouting.requested ? `${task.modelRouting.requested}->` : ""}${task.modelRouting.resolved}${task.modelRouting.usedAttempt ? ` attempt=${task.modelRouting.usedAttempt + 1}` : ""}` : ""}${task.agentProgress?.activityState ? ` activityState=${task.agentProgress.activityState}` : ""}${(() => { const t = extractCommandTrace(task.agentProgress?.recentTools); return t.summary ? ` ${t.summary}` : ""; })()}${attentionByTask.get(task.id)?.data?.reason ? ` attention=${String(attentionByTask.get(task.id)?.data?.reason)}` : ""}${task.jsonEvents !== undefined ? ` jsonEvents=${task.jsonEvents}` : ""}${task.usage ? ` usage=${JSON.stringify(task.usage)}` : ""}${task.resultArtifact ? ` result=${task.resultArtifact.path}` : ""}${task.transcriptArtifact ? ` transcript=${task.transcriptArtifact.path}` : ""}${task.worktree ? ` worktree=${task.worktree.path}` : ""}${task.error ? ` error=${task.error}` : ""}`) : ["- (none)"]),
+		...(tasks.length
+			? tasks.map(
+					(task) =>
+						`- ${task.id} [${task.status}] ${task.role} -> ${task.agent}${task.taskPacket ? ` scope=${task.taskPacket.scope}` : ""}${task.verification ? ` green=${task.verification.observedGreenLevel}/${task.verification.requiredGreenLevel}` : ""}${task.modelAttempts?.length ? ` attempts=${task.modelAttempts.length}` : ""}${task.modelRouting ? ` modelRouting=${task.modelRouting.requested ? `${task.modelRouting.requested}->` : ""}${task.modelRouting.resolved}${task.modelRouting.usedAttempt ? ` attempt=${task.modelRouting.usedAttempt + 1}` : ""}` : ""}${task.agentProgress?.activityState ? ` activityState=${task.agentProgress.activityState}` : ""}${(() => {
+							const t = extractCommandTrace(task.agentProgress?.recentTools);
+							return t.summary ? ` ${t.summary}` : "";
+						})()}${attentionByTask.get(task.id)?.data?.reason ? ` attention=${String(attentionByTask.get(task.id)?.data?.reason)}` : ""}${task.jsonEvents !== undefined ? ` jsonEvents=${task.jsonEvents}` : ""}${task.usage ? ` usage=${JSON.stringify(task.usage)}` : ""}${task.resultArtifact ? ` result=${task.resultArtifact.path}` : ""}${task.transcriptArtifact ? ` transcript=${task.transcriptArtifact.path}` : ""}${task.worktree ? ` worktree=${task.worktree.path}` : ""}${task.error ? ` error=${task.error}` : ""}`,
+				)
+			: ["- (none)"]),
 		`Task counts: ${[...counts.entries()].map(([status, count]) => `${status}=${count}`).join(", ") || "none"}`,
 		"Effectiveness:",
 		`- observable=${effectiveness.observable}/${Math.max(1, effectiveness.completed)} completed tasks`,
@@ -97,18 +157,28 @@ export function handleStatus(params: TeamToolParamsValue, ctx: TeamContext): PiT
 		`- noObservedWork=${effectiveness.noObservedWorkTaskIds.length ? effectiveness.noObservedWorkTaskIds.join(",") : "none"}`,
 		`- needsAttention=${effectiveness.needsAttentionTaskIds.length ? effectiveness.needsAttentionTaskIds.join(",") : "none"}`,
 		"Completion verification",
-		...(tasks.filter((t) => t.status === "completed").length ? tasks.filter((t) => t.status === "completed").map((t) => {
-			const guard = verifyTaskCompletion(t, manifest);
-			return `- ${t.id} green=${guard.greenLevel}/3${guard.warnings.length ? ` warnings=[${guard.warnings.join(", ")}]` : ""}`;
-		}) : ["- (no completed tasks)"]),
+		...(tasks.filter((t) => t.status === "completed").length
+			? tasks
+					.filter((t) => t.status === "completed")
+					.map((t) => {
+						const guard = verifyTaskCompletion(t, manifest);
+						return `- ${t.id} green=${guard.greenLevel}/3${guard.warnings.length ? ` warnings=[${guard.warnings.join(", ")}]` : ""}`;
+					})
+			: ["- (no completed tasks)"]),
 		"Active agents:",
 		...(activeAgents.length ? activeAgents.map(agentLine) : ["- (none)"]),
 		"Waiting tasks:",
-		...(waitingTasks.length ? waitingTasks.map((task) => `- ${task.id} [queued] ${task.role} -> ${task.agent} ${waitingReason(task, tasks) ?? "waiting"}`) : ["- (none)"]),
+		...(waitingTasks.length
+			? waitingTasks.map((task) => `- ${task.id} [queued] ${task.role} -> ${task.agent} ${waitingReason(task, tasks) ?? "waiting"}`)
+			: ["- (none)"]),
 		"Completed agents:",
 		...(completedAgents.length ? completedAgents.map(agentLine) : ["- (none)"]),
 		"Policy decisions:",
-		...(manifest.policyDecisions?.length ? manifest.policyDecisions.map((item) => `- ${item.action} (${item.reason})${item.taskId ? ` ${item.taskId}` : ""}: ${item.message}`) : ["- (none)"]),
+		...(manifest.policyDecisions?.length
+			? manifest.policyDecisions.map(
+					(item) => `- ${item.action} (${item.reason})${item.taskId ? ` ${item.taskId}` : ""}: ${item.message}`,
+				)
+			: ["- (none)"]),
 		`Total usage: ${formatUsage(totalUsage)}`,
 		"Group joins:",
 		...(groupJoinLines.length ? groupJoinLines : ["- (none)"]),
@@ -117,15 +187,29 @@ export function handleStatus(params: TeamToolParamsValue, ctx: TeamContext): PiT
 		...(artifactLines.length ? artifactLines : ["- (none)"]),
 		"",
 		"Recent events:",
-		...(events.length ? events.map((event) => `- ${event.time} ${event.type}${event.taskId ? ` ${event.taskId}` : ""}${event.message ? `: ${event.message}` : ""}`) : ["- (none)"]),
+		...(events.length
+			? events.map(
+					(event) =>
+						`- ${event.time} ${event.type}${event.taskId ? ` ${event.taskId}` : ""}${event.message ? `: ${event.message}` : ""}`,
+				)
+			: ["- (none)"]),
 	];
 	if (!fullDetails) {
-		return result(
-			buildCompactStatus(manifest, tasks, counts, asyncLivenessLine, phaseProgress).join("\n"),
-			{ action: "status", status: "ok", runId: manifest.runId, artifactsRoot: manifest.artifactsRoot, intent: `status ${manifest.runId}: ${manifest.status} (compact)` },
-		);
+		return result(buildCompactStatus(manifest, tasks, counts, asyncLivenessLine, phaseProgress).join("\n"), {
+			action: "status",
+			status: "ok",
+			runId: manifest.runId,
+			artifactsRoot: manifest.artifactsRoot,
+			intent: `status ${manifest.runId}: ${manifest.status} (compact)`,
+		});
 	}
-	return result(lines.join("\n"), { action: "status", status: "ok", runId: manifest.runId, artifactsRoot: manifest.artifactsRoot, intent: `status ${manifest.runId}: ${manifest.status}` });
+	return result(lines.join("\n"), {
+		action: "status",
+		status: "ok",
+		runId: manifest.runId,
+		artifactsRoot: manifest.artifactsRoot,
+		intent: `status ${manifest.runId}: ${manifest.status}`,
+	});
 }
 
 /**
@@ -136,18 +220,26 @@ export function handleStatus(params: TeamToolParamsValue, ctx: TeamContext): PiT
  * Exported for unit testing.
  */
 export function buildCompactStatus(
-	manifest: { runId: string; team: string; workflow?: string; status: string; goal: string; workspaceMode?: string },
-	tasks: Array<{ id: string; status: string; role: string; agent: string; error?: string }>,
+	manifest: {
+		runId: string;
+		team: string;
+		workflow?: string;
+		status: string;
+		goal: string;
+		workspaceMode?: string;
+	},
+	tasks: Array<{
+		id: string;
+		status: string;
+		role: string;
+		agent: string;
+		error?: string;
+	}>,
 	counts: Map<string, number>,
 	asyncLivenessLine?: string,
 	progress?: { overallPercentage: number; estimatedRemainingMs: number },
 ): string[] {
-	const failedOrAttention = tasks.filter(
-		(t) =>
-			t.status === "failed" ||
-			t.status === "needs_attention" ||
-			t.status === "cancelled",
-	);
+	const failedOrAttention = tasks.filter((t) => t.status === "failed" || t.status === "needs_attention" || t.status === "cancelled");
 	const lines = [
 		`Run: ${manifest.runId}`,
 		`Team: ${manifest.team}${manifest.workflow ? ` (${manifest.workflow})` : ""}`,

package/src/extension/team-tool/workflow-manage.ts

@@ -14,24 +14,20 @@
  *   - workflow-delete : remove a dynamic workflow file (confirm-gated).
  */
 
-import { readFileSync, writeFileSync, existsSync, rmSync } from "node:fs";
-import { dirname, join, basename } from "node:path";
-import { result, type TeamContext } from "./context.ts";
+import { existsSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { basename, dirname, join } from "node:path";
+import type { TeamToolParamsValue } from "../../schema/team-tool-schema.ts";
+import { logInternalError } from "../../utils/internal-error.ts";
+import { packageRoot, projectCrewRoot, userPiRoot } from "../../utils/paths.ts";
 import { assertSafePathId, resolveRealContainedPath } from "../../utils/safe-paths.ts";
-import { projectCrewRoot, userPiRoot, packageRoot } from "../../utils/paths.ts";
 import { allWorkflows, discoverWorkflows } from "../../workflows/discover-workflows.ts";
-import { logInternalError } from "../../utils/internal-error.ts";
-import type { TeamToolParamsValue } from "../../schema/team-tool-schema.ts";
+import { result, type TeamContext } from "./context.ts";
 
 /** The 3 allowed bases for dynamic-workflow scripts (§0c C5). */
 function allowedWorkflowDirs(cwd: string): string[] {
 	// Fix round-6: align with discoverWorkflows (which reads userPiRoot/workflows, NOT
 	// userCrewRoot/workflows). The old userCrewRoot path silently orphaned user-scope workflows.
-	return [
-		join(projectCrewRoot(cwd), "workflows"),
-		join(userPiRoot(), "workflows"),
-		join(packageRoot(), "workflows"),
-	];
+	return [join(projectCrewRoot(cwd), "workflows"), join(userPiRoot(), "workflows"), join(packageRoot(), "workflows")];
 }
 
 /** Best-effort ADVISORY content check (review H-3): trivially bypassable
@@ -70,12 +66,20 @@ export function handleWorkflowCreate(params: TeamToolParamsValue, ctx: TeamConte
 	// runs (the run is blocked at the tool_call layer if confirm is missing). We re-check here
 	// as defense-in-depth in case the gate is bypassed.
 	if (params.confirm !== true) {
-		return result("workflow-create is a new arbitrary-code-execution surface and requires confirm:true. Add the action to DESTRUCTIVE_TEAM_ACTIONS (destructive-gate.ts) so the runtime gate enforces this.", { action: "workflow-create", status: "error" }, true);
+		return result(
+			"workflow-create is a new arbitrary-code-execution surface and requires confirm:true. Add the action to DESTRUCTIVE_TEAM_ACTIONS (destructive-gate.ts) so the runtime gate enforces this.",
+			{ action: "workflow-create", status: "error" },
+			true,
+		);
 	}
 	const name = params.config?.name as string | undefined;
 	const script = params.config?.script as string | undefined;
 	if (!name || typeof name !== "string") {
-		return result("workflow-create requires config.name (the workflow name, path-safe).", { action: "workflow-create", status: "error" }, true);
+		return result(
+			"workflow-create requires config.name (the workflow name, path-safe).",
+			{ action: "workflow-create", status: "error" },
+			true,
+		);
 	}
 	if (!script || typeof script !== "string") {
 		return result("workflow-create requires config.script (the .dwf.ts source).", { action: "workflow-create", status: "error" }, true);
@@ -88,7 +92,15 @@ export function handleWorkflowCreate(params: TeamToolParamsValue, ctx: TeamConte
 		const scope = (params.scope === "user" ? "user" : "project") as "user" | "project";
 		const filePath = resolveWorkflowWritePath(ctx.cwd, name, scope);
 		writeFileSync(filePath, script, "utf-8");
-		return result(`Dynamic workflow '${name}' created at ${filePath}.\n\nIt is now runnable via: team action='run' workflow='${name}' goal='...'\n/scripts are commit-reviewed (postinstall-equivalent trust — see docs/dynamic-workflows.md).`, { action: "workflow-create", status: "ok", data: { name, filePath, scope } }, false);
+		return result(
+			`Dynamic workflow '${name}' created at ${filePath}.\n\nIt is now runnable via: team action='run' workflow='${name}' goal='...'\n/scripts are commit-reviewed (postinstall-equivalent trust — see docs/dynamic-workflows.md).`,
+			{
+				action: "workflow-create",
+				status: "ok",
+				data: { name, filePath, scope },
+			},
+			false,
+		);
 	} catch (error) {
 		const message = error instanceof Error ? error.message : String(error);
 		return result(`workflow-create failed: ${message}`, { action: "workflow-create", status: "error" }, true);
@@ -121,8 +133,18 @@ export function handleWorkflowGet(params: TeamToolParamsValue, ctx: TeamContext)
 			isDynamic ? "```" : "",
 			isDynamic ? source : "",
 			isDynamic ? "```" : "",
-		].filter(Boolean).join("\n"),
-		{ action: "workflow-get", status: "ok", data: { name: wf.name, runtime: wf.runtime ?? "static", filePath: wf.filePath } },
+		]
+			.filter(Boolean)
+			.join("\n"),
+		{
+			action: "workflow-get",
+			status: "ok",
+			data: {
+				name: wf.name,
+				runtime: wf.runtime ?? "static",
+				filePath: wf.filePath,
+			},
+		},
 		false,
 	);
 }
@@ -132,29 +154,52 @@ export function handleWorkflowList(params: TeamToolParamsValue, ctx: TeamContext
 	if (workflows.length === 0) return result("No workflows found.", { action: "workflow-list", status: "ok" }, false);
 	const lines = workflows.map((w) => {
 		const tag = w.runtime === "dynamic" ? "[dynamic]" : "[static] ";
-		const detail = w.runtime === "dynamic" ? w.dynamicScript ?? w.filePath : `${w.steps.length} steps`;
+		const detail = w.runtime === "dynamic" ? (w.dynamicScript ?? w.filePath) : `${w.steps.length} steps`;
 		return `  ${tag} ${w.name.padEnd(20)} ${detail}`;
 	});
-	return result(`Workflows (${workflows.length}):\n${lines.join("\n")}`, { action: "workflow-list", status: "ok", data: { count: workflows.length, workflows: workflows.map((w) => ({ name: w.name, runtime: w.runtime ?? "static" })) } }, false);
+	return result(
+		`Workflows (${workflows.length}):\n${lines.join("\n")}`,
+		{
+			action: "workflow-list",
+			status: "ok",
+			data: {
+				count: workflows.length,
+				workflows: workflows.map((w) => ({
+					name: w.name,
+					runtime: w.runtime ?? "static",
+				})),
+			},
+		},
+		false,
+	);
 }
 
 export function handleWorkflowSave(params: TeamToolParamsValue, ctx: TeamContext): ReturnType<typeof result> {
 	// H-1 (review): workflow-save writes an arbitrary .dwf.ts (ACE-equivalent) — gate it
 	// via destructive-gate.ts confirm:true (now in DESTRUCTIVE_TEAM_ACTIONS) + re-check here.
 	if (params.confirm !== true) {
-		return result("workflow-save writes an executable .dwf.ts and requires confirm:true (gated by destructive-gate.ts).", { action: "workflow-save", status: "error" }, true);
+		return result(
+			"workflow-save writes an executable .dwf.ts and requires confirm:true (gated by destructive-gate.ts).",
+			{ action: "workflow-save", status: "error" },
+			true,
+		);
 	}
 	// workflow-save: persist an ephemeral run's script as a named reusable workflow.
 	// Reads the source from config.script (the caller provides what to save).
 	const name = params.config?.name as string | undefined;
 	const script = params.config?.script as string | undefined;
-	if (!name || !script) return result("workflow-save requires config.name + config.script.", { action: "workflow-save", status: "error" }, true);
+	if (!name || !script)
+		return result("workflow-save requires config.name + config.script.", { action: "workflow-save", status: "error" }, true);
 	const validationError = validateScriptContent(script);
 	if (validationError) return result(`workflow-save rejected: ${validationError}`, { action: "workflow-save", status: "error" }, true);
 	try {
 		const filePath = resolveWorkflowWritePath(ctx.cwd, name, "project");
 		writeFileSync(filePath, script, "utf-8");
-		return result(`Saved dynamic workflow '${name}' → ${filePath}.`, { action: "workflow-save", status: "ok", data: { name, filePath } }, false);
+		return result(
+			`Saved dynamic workflow '${name}' → ${filePath}.`,
+			{ action: "workflow-save", status: "ok", data: { name, filePath } },
+			false,
+		);
 	} catch (error) {
 		const message = error instanceof Error ? error.message : String(error);
 		return result(`workflow-save failed: ${message}`, { action: "workflow-save", status: "error" }, true);
@@ -164,13 +209,22 @@ export function handleWorkflowSave(params: TeamToolParamsValue, ctx: TeamContext
 export function handleWorkflowDelete(params: TeamToolParamsValue, ctx: TeamContext): ReturnType<typeof result> {
 	// workflow-delete is destructive (removes a file) — gated by destructive-gate.ts confirm:true.
 	if (params.confirm !== true) {
-		return result("workflow-delete requires confirm:true (gated by destructive-gate.ts).", { action: "workflow-delete", status: "error" }, true);
+		return result(
+			"workflow-delete requires confirm:true (gated by destructive-gate.ts).",
+			{ action: "workflow-delete", status: "error" },
+			true,
+		);
 	}
 	const name = (params.config?.name as string | undefined) ?? params.workflow;
 	if (!name) return result("workflow-delete requires config.name.", { action: "workflow-delete", status: "error" }, true);
 	const wf = allWorkflows(discoverWorkflows(ctx.cwd)).find((w) => w.name === name);
 	if (!wf) return result(`Workflow '${name}' not found.`, { action: "workflow-delete", status: "error" }, true);
-	if (wf.runtime !== "dynamic") return result(`Workflow '${name}' is not a dynamic workflow (only .dwf.ts files can be deleted via this action).`, { action: "workflow-delete", status: "error" }, true);
+	if (wf.runtime !== "dynamic")
+		return result(
+			`Workflow '${name}' is not a dynamic workflow (only .dwf.ts files can be deleted via this action).`,
+			{ action: "workflow-delete", status: "error" },
+			true,
+		);
 	try {
 		assertSafePathId("workflowName", name);
 		// Verify the file is inside an allowed dir before deleting.
@@ -182,9 +236,22 @@ export function handleWorkflowDelete(params: TeamToolParamsValue, ctx: TeamConte
 				return false;
 			}
 		});
-		if (!contained) return result(`Refusing to delete '${wf.filePath}': not inside an allowed workflows directory.`, { action: "workflow-delete", status: "error" }, true);
+		if (!contained)
+			return result(
+				`Refusing to delete '${wf.filePath}': not inside an allowed workflows directory.`,
+				{ action: "workflow-delete", status: "error" },
+				true,
+			);
 		rmSync(wf.filePath, { force: true });
-		return result(`Deleted dynamic workflow '${name}' (${wf.filePath}).`, { action: "workflow-delete", status: "ok", data: { name, filePath: wf.filePath } }, false);
+		return result(
+			`Deleted dynamic workflow '${name}' (${wf.filePath}).`,
+			{
+				action: "workflow-delete",
+				status: "ok",
+				data: { name, filePath: wf.filePath },
+			},
+			false,
+		);
 	} catch (error) {
 		const message = error instanceof Error ? error.message : String(error);
 		return result(`workflow-delete failed: ${message}`, { action: "workflow-delete", status: "error" }, true);

package/src/extension/team-tool-types.ts

@@ -13,7 +13,14 @@ export interface TeamToolDetails {
 	/** Resource scope affected by the action (e.g. cleanup: "project"). */
 	scope?: string;
 	/** Run metrics for compact display in TUI tool result rendering. */
-	metrics?: { taskCount?: number; completedCount?: number; totalTokens?: number; totalCost?: number; durationMs?: number; consistencyScore?: number };
+	metrics?: {
+		taskCount?: number;
+		completedCount?: number;
+		totalTokens?: number;
+		totalCost?: number;
+		durationMs?: number;
+		consistencyScore?: number;
+	};
 	/** Structured data for programmatic consumption (e.g. TUI widgets). */
 	data?: Record<string, unknown>;
 }