pi-crew 0.9.12 → 0.9.14

package/src/schema/team-tool-schema.ts

@@ -114,6 +114,12 @@ export const TeamToolParams = Type.Object({
 	goal: Type.Optional(
 		Type.String({ description: "High-level objective for a team run." }),
 	),
+	chain: Type.Optional(
+		Type.String({
+			description:
+				'Chain expression: "step1 -> step2 -> step3". Runs each step as a sequential team run, passing handoff context forward via the goal text. Supports inline goals ("...") and @team references. e.g. chain=\'"Research X" -> "Analyze" -> "Write report"\'.',
+		}),
+	),
 	task: Type.Optional(
 		Type.String({
 			description: "Concrete task text for direct role/agent execution.",
@@ -370,6 +376,9 @@ export interface TeamToolParamsValue {
 	role?: string;
 	agent?: string;
 	goal?: string;
+	/** Chain expression: "step1 -> step2 -> step3". Runs each step as a sequential
+	 *  team run with handoff context passed forward via the goal. */
+	chain?: string;
 	task?: string;
 	singleAgent?: boolean;
 	runId?: string;

package/src/state/types.ts

@@ -201,6 +201,9 @@ export interface TeamRunManifest {
 	args?: unknown;
 	summary?: string;
 	policyDecisions?: PolicyDecision[];
+	/** #2 (assessment): goal-achievement verdict — kills the silent false-green. */
+	goalAchieved?: boolean | "unknown";
+	goalAchievementNote?: string;
 }
 
 export interface UsageState {

package/src/ui/widget/index.ts

@@ -42,7 +42,7 @@ export function getRenderWidth(width?: number): number {
 	if (Number.isFinite(stdoutCols) && stdoutCols! > 0) return Math.floor(stdoutCols!);
 	return DEFAULT_WIDGET_WIDTH;
 }
-export { notificationBadge } from "./widget-formatters.ts";
+export { notificationBadge, NOTIFICATION_BADGE_CAP } from "./widget-formatters.ts";
 
 // ── Constants ─────────────────────────────────────────────────────────
 

package/src/ui/widget/widget-formatters.ts

@@ -144,9 +144,22 @@ export function agentStats(agent: CrewAgentRecord, liveHandle?: LiveAgentHandle)
 
 // ── Notification badge ────────────────────────────────────────────────
 
+// Bug 021: the bell glyph 🔔 was misread as "queued messages" — users saw
+// `🔔227` and concluded there were 227 pending items, when the value is a
+// CUMULATIVE warning/error/critical count with zero actual queue behind it.
+// Fix: relabel to an explicit "alerts" segment (no bell) and cap the display
+// at 99+ (standard badge practice). The cumulative count stays accurate
+// internally (widgetState.notificationCount) and remains fully logged in
+// .crew/state/notifications/YYYY-MM-DD.jsonl — this bounds presentation only.
+// Deeper fixes (decay window, owner-scope, auto-reset on all-runs-terminal,
+// full deprecation) are product decisions documented in
+// docs/bugs/bug-021-notification-badge-counter-misleading.md.
+export const NOTIFICATION_BADGE_CAP = 99;
+
 export function notificationBadge(count: number | undefined, env: NodeJS.ProcessEnv = process.env): string {
 	if (!count || count <= 0) return "";
 	const term = `${env.TERM ?? ""} ${env.WT_SESSION ?? ""} ${env.TERM_PROGRAM ?? ""}`.toLowerCase();
 	const supportsEmoji = !term.includes("dumb") && env.NO_COLOR !== "1";
-	return supportsEmoji ? ` 🔔${count}` : ` [!${count}]`;
+	const label = count > NOTIFICATION_BADGE_CAP ? `${NOTIFICATION_BADGE_CAP}+ alerts` : `${count} alerts`;
+	return supportsEmoji ? ` · ${label}` : ` [${label}]`;
 }

package/src/ui/widget/widget-renderer.ts

@@ -15,6 +15,7 @@ import { computeLiveDurationMs } from "../live-duration.ts";
 import { getTaskUsage } from "../../runtime/usage-tracker.ts";
 import { agentActivity, agentStats, elapsed, formatTokensCompact, notificationBadge } from "./widget-formatters.ts";
 import { activeWidgetRuns, shortRunLabel } from "./widget-model.ts";
+import { isFinishedRunStatus } from "../../runtime/process-status.ts";
 import type { WidgetRun } from "./widget-types.ts";
 
 const MAX_AGENTS_DISPLAY = 3;
@@ -69,6 +70,7 @@ export function buildWidgetLines(cwd: string, frame = 0, maxLines = 8, providedR
 		});
 		const completed = agents.filter((a) => a.status === "completed").length;
 		const runGlyph = iconForStatus(run.status, { runningGlyph });
+		const isTerminal = isFinishedRunStatus(run.status);
 		// Run progress line. v1–v3 flickered on snapshot.tasks state, v4 was
 		// too minimal (`0/1 agents` only), v5 duplicated the worker activity
 		// line (tools/tokens/duration already shown one row below). v6 (this)
@@ -81,10 +83,19 @@ export function buildWidgetLines(cwd: string, frame = 0, maxLines = 8, providedR
 		// for a healthy run), and `run.createdAt` is immutable. The format
 		// shape `"X/Y agents · Ns"` is therefore truly invariant: same number
 		// of `·`-separated fields, same field meanings, every render tick.
+		//
+		// Bug 022 (timer-fix + label): for TERMINAL runs (failed/cancelled/
+		// completed) the elapsed counter previously kept ticking up forever
+		// from createdAt (a failed run showed `2028s` and climbing, read as
+		// "still running"). Now it FREEZES at updatedAt (when the run
+		// reached its terminal status). The status label is also surfaced
+		// explicitly so the row cannot be misread as an active run.
 		const agentCountText = `${completed}/${agents.length} agents`;
-		const runElapsedMs = Math.max(0, Date.now() - new Date(run.createdAt).getTime());
+		const runEndMs = isTerminal ? new Date(run.updatedAt).getTime() : Date.now();
+		const runElapsedMs = Math.max(0, Number.isFinite(runEndMs) ? runEndMs - new Date(run.createdAt).getTime() : 0);
 		const runElapsedText = `${Math.floor(runElapsedMs / 1000)}s`;
-		const progressPart = `${agentCountText} · ${runElapsedText}`;
+		const statusLabel = isTerminal ? ` · ${run.status}` : "";
+		const progressPart = `${agentCountText} · ${runElapsedText}${statusLabel}`;
 		lines.push(truncate(`├─ ${runGlyph} ${shortRunLabel(run)} · ${progressPart} · ${run.runId.slice(-8)}`, width));
 
 		const liveForRun = listLiveAgents().filter((a) => a.runId === run.runId);

package/src/utils/redaction.ts

@@ -19,6 +19,24 @@ export const PEM_PRIVATE_KEY_PATTERN = /-----BEGIN [A-Z ]+PRIVATE KEY-----[\s\S]
 // Full mitigation ladder: (1) redaction here + at artifact-write; (2) Phase 1.5
 // sanitized-env verification; (3) sandbox (deferred).
 
+// Exclusion list: LLM usage-count key names that contain "token" but are
+// observable metrics, NOT credentials. These must NEVER be redacted so that
+// token-usage observability in events.jsonl is preserved. The isSecretKey()
+// keyword-scan matches '_token' in 'prompt_tokens' (underscore + "token"),
+// falsely classifying usage counts as secrets. See performance/quality
+// assessment fix #5.
+const TOKEN_COUNT_KEYS = new Set([
+	"prompt_tokens",
+	"completion_tokens",
+	"total_tokens",
+	"cached_tokens",
+	"reasoning_tokens",
+	"cached_read_tokens",
+	"cached_write_tokens",
+	"input_tokens",
+	"output_tokens",
+]);
+
 // JWT — three base64url segments separated by dots, distinctive "eyJ" headers.
 // Linear: single + on [A-Za-z0-9_-] per segment, no nesting.
 export const JWT_PATTERN = /(?<![A-Za-z0-9_-])eyJ[A-Za-z0-9_-]+\.eyJ[A-Za-z0-9_-]+\.[A-Za-z0-9_-]+/g;
@@ -43,6 +61,8 @@ export const STRIPE_KEY_PATTERN = /(?<![A-Za-z0-9_])sk_live_[0-9a-zA-Z]{24}(?![0
 // a more complex regex, catastrophic backtracking (ReDoS) could result.
 // Any modifications must preserve O(n) complexity where n = keyName.length.
 export function isSecretKey(keyName: string): boolean {
+	// Fast path: known token-count keys are never secrets.
+	if (TOKEN_COUNT_KEYS.has(keyName.toLowerCase())) return false;
 	// Fast path: common secret key names (safe anchored regex, no backtracking)
 	const lower = keyName.toLowerCase();
 	if (/^(token|apikey|api_key|password|secret|credential|authorization|privatekey|private_key)$/.test(lower)) {